* Revert "Moved subscribe and filter into network controller (#16693)"
This reverts commit 6f6984fa58. That
commit was an RPC middleware refactor intended to move the subscribe
and filter middleware into the network controller, to simplify the
process of sharing this middleware between clients.
This refactor resulted in `eth_subscribe` notifications being sent on
the wrong connections, causing the UI to break in some cases (the UI
`provider` connection does not support notifications). This happened
because the `setupProviderEngine` function runs per-connection,
whereas the engine setup inside the network controller is global. The
global network client cannot support notifications because it has no
way to route them; they'll need to stay in the per-connection provider
engine.
Closes#17467
* Add e2e test
An e2e test has been added that confirms subscriptions are only
broadcast to the site that registered them. This test fails on
`develop`.
* added the rest of the sev1 warnings to getSnapInstallWarnings
* added and updated translations
* Updated getSnapInstallWarnings to include warnings for all weight-1 permissions
* Updated snap install warning and css according to designs
* fix snaps tests
* fixed alignment/spacing
* updated e2e tests to click through the newly displayed public key access warning
* lint fix
* fixed update snap test
* refactored getSnapInstallWarnings, moved logic to PERMISSION_DESCRIPTIONS
* fix logic to account for objects & arrays
* update function description
* add missing properties to ethereum provider description
* moved id and message to baseDescription to fix error
* add optional chaining to fix undefined error
* more optional chaining
* more optional chaining
* Ensure that NonInfuraDefaultNetworks are only selected in the dropdown if they are the currently selected network
* Ensure Linea Goerli network appears in network settings tab if added manually
* Ensure that NonInfuraDefaultNetworks are only selected in the dropdown if they are the currently selected network
* Ensure Linea Goerli network appears in network settings tab if added manually
* add header base component
* fix resizing issue
* add center
* add demo
* header base using flexbox
* fix button issue
* header base clean up
* update tests
* add readme description
* add docs
* update snapshot
* add more to readme
* convert to TS
* fix file name
* fix types and colors
* fix classname error
* fix boxprops import
* fix boxprops
* prop fix
* fix errors
* Update ui/components/component-library/header-base/header-base.stories.tsx
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/component-library/header-base/header-base.types.ts
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/component-library/header-base/header-base.types.ts
Co-authored-by: George Marshall <george.marshall@consensys.net>
* headerbase fixes
* fix export
* remove Math.max
* change order for index on storybook to prep build
* revert back to order
* remove type from export
* add type to export
* change export of headerbase function
* export update
* revert back to normal
* add type to export
* Removing interface export from index
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
