1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00
Commit Graph

7091 Commits

Author SHA1 Message Date
Albert Olivé
68f5c578a2
Fixed issue generating the pipeline (#20231) 2023-07-27 14:36:19 +02:00
David Walsh
f584f56d9c
UX: Allow quick Add Account name based on default name (#20168)
* UX: Allow quick Add Account name

* do not allow account names with just spaces

---------

Co-authored-by: Howard Braham <howrad@gmail.com>
2023-07-26 18:03:30 -07:00
legobeat
41f66271db
Dedupe bn.js (#20199)
* force latest version of dependency bn.js to @5.2.1
* test - fix broken standin data given to bn.js
---------

Co-authored-by: kumavis <aaron@kumavis.me>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-07-27 07:01:31 +09:00
Binij Shrestha
6e5ab2a945
Migrate AvatarIcon (#19107)
Migrate AvatarIcon to TS


---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-26 14:18:36 -07:00
David Walsh
bfe0323bd7
UX: Ensure currently selected account displays when Account Menu opens (#20166)
* UX: Ensure currently selected account displays when Account Menu opens

* Jest tests
2023-07-26 14:38:19 -05:00
David Walsh
c1a7f46e8f
UX: Show Checksum Addresses in Account Menu (#20135)
* UX: Show Checksum Addresses in Account Menu

* Checksum the account details -> export private key address copy button

* Update tests
2023-07-26 14:37:33 -05:00
Ujwal Kumar
4b2c777862
Replacing deprecated components and code for import tokens (#19559)
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-26 08:48:31 -07:00
Daniel
0f582af3e3
Remove console errors (#20209) 2023-07-26 17:32:15 +02:00
Binij Shrestha
d3c9d4a55a
Fix/18885 migrate avatar token (#19080)
* Migrate AvatarToken
---------

Co-authored-by: garrettbear <gwhisten@gmail.com>
2023-07-26 07:50:53 -07:00
Brad Decker
e28db07a1b
Set sentry autoTrackSessions default (#20132)
* Set sentry autoTrackSessions default

* endSession....

* fixup

* updated comment

* prevent breaking devmode

* remove changes to beforeSend

* remove additional usage of sinon
2023-07-26 07:13:28 -05:00
Albert Olivé
9797d9a634
[MMI] Fix element UI in MMI (#20176)
* Added support for dark mode in metafox logo and removed unused compliance images

* Fixed text elements with wrong alignment and color

* Changed needHelp in mmi

* Updated code

* Improved code

* Updated copies

* Changed logic to fix code fences issues

* Renamed component
2023-07-26 11:51:11 +02:00
ryanml
d262acb3a4
Fixing Dapp link on NFT import screen (#19799) 2023-07-26 13:58:16 +05:30
Garrett Bear
d6cb724323
ButtonBase linting error from IconProps (#20187) 2023-07-25 20:09:52 -02:30
Pritam Dhara
a942459b36
replaced actionablemessage in Import-Token.js (#20147)
* replaced actionablemessage in Import-Token.js

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>

* Use single controller method to add transactions (#20007)

* fix: remove unused useMethodData code (#20146)

* Remove Snaps execution environment override (#20173)

* Used Box from component-library

---------

Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
2023-07-25 15:11:23 -07:00
Dhruv
a10fb75f35
replacing deprecated components and consts (#19563)
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-25 13:22:26 -07:00
David Walsh
bab1670432
Restructure CurrencyDisplay to use Design System (#19171)
* Restructure CurrencyDisplay to use Design System

* Add storybook, remove CSS

* Update ui/components/ui/currency-display/currency-display.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/ui/currency-display/currency-display.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/ui/currency-display/currency-display.stories.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/ui/currency-display/currency-display.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/ui/currency-display/currency-display.stories.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/ui/currency-display/currency-display.stories.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Remove deprecated imports, import EtherDenomination

* Update jest

* Use TextVariant: Inherit to keep correct font-size

* Snapshots

* Switch from boxProps to props

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-07-25 14:32:21 -05:00
David Walsh
9310a95499
UX: Ensure block explorer link is for desired account (#20144) 2023-07-25 11:59:22 -05:00
George Marshall
25247d0300
Updating Icon types and component to use TS Box component (#19990) 2023-07-25 09:05:37 -07:00
Garrett Bear
3f27d018c4
Fix/buttonbase ts update (#20060)
* Migrate ButtonBase to TS

---------

Co-authored-by: Binij Shrestha <shresthabinij@gmail.com>
2023-07-25 09:05:15 -07:00
ryanml
85465f53a7
Fixing 'View on Opensea' link for main and testnet NFTs (#19797) 2023-07-25 21:14:40 +05:30
vthomas13
3e6f1c3288
Adding Metametrics for Activity Screen (#20077)
* adding activity metrics and tests

* removing unnecessary stopPropagation
2023-07-25 09:06:11 -04:00
Pedro Figueiredo
83a5090c48
fix: remove unused useMethodData code (#20146) 2023-07-25 10:49:45 +01:00
Matthew Walsh
fdc3558988
Use single controller method to add transactions (#20007) 2023-07-25 09:50:55 +01:00
António Regadas
4b9a4d330c
[MMI] Allows the mmi build to be generated using the dist command (#20148)
* adds listeners for signatureControll and adds the handleSigningEvents method

* clean up

* updates signature request containers files

* adds necessary methods

* wip

* signing flow with core methods

* yarn lint

* updates logic to fit latest signatureCOntroller

* updates mmi extension package

* updates signature-controller and message-manager packages

* checkout develop lock file and run yarn

* checkout develop lock file and package.json to test circleci

* test fix

* adds signature-controller new version

* updates mmi extension package

* tx-list update and runs lavamoat auto

* lint fix

* runs lavamoat auto

* resets lavamoat/build-system/policy.jsono to develop

* Update LavaMoat policies

* adds back the dispatch

* lint

* changes needed to generate a mmi build

* adds metametricsId in url param

* adds necessary fence

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-25 10:31:52 +02:00
Dhruv
5693d1945a
Migrate component to TS: Input (#20094)
* Migrating Input component

* Adjusting types and fixing design system import

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-24 21:13:17 -07:00
Harsh Shukla
84ff66c373
Part of #17670 for ui\components\app\transaction-detail-item\transaction-detail-item.component.js (#19980)
* Part of #17670 for ui\components\app\transaction-detail-item\transaction-detail-item.component.js

* Update transaction-detail-item.component.js

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-24 21:09:56 -07:00
David Walsh
d1bc22a4e2
Fix #20140 - Ensure only one network displays as selected in the network picker when chain IDs collide (#20152) 2023-07-24 19:06:37 -05:00
Garrett Bear
02b8edc8c2
Fix hover on account menu (#20153)
* Fix hover on account menu

* remove excessive color prop
2023-07-24 15:26:22 -07:00
Dhruv
edbc728014
Migrate component to TS: Tag (#20086)
* migrating Tag to TS
---------

Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-07-24 13:42:10 -07:00
Harsh Shukla
a01e4fa00a
Updating SignatureRequestData components (#19994)
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-24 13:40:41 -07:00
Harsh Shukla
ab1b4c3a31
Part of #17670 for: accreditation.component.js (#20057)
* Part of #17670 for: accreditation.component.js

* Update checkbox.test.tsx.snap

* Update ui/components/app/transaction-decoding/components/ui/accreditation/accreditation.component.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update accreditation.component.js

* Update ui/components/app/transaction-decoding/components/ui/accreditation/accreditation.component.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Updating component to use component library components and removing unused CSS

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-24 13:38:17 -07:00
Harsh Shukla
24c9db5883
Part of #18714 for 2 files in ui\components\component-library\avatar-icon (#20038) 2023-07-24 14:58:30 -05:00
David Walsh
d5dbdfa912
UX: Fix TextColor value casing (#20133)
* UX: Fix TextColor value casing

* Fix snapshot
2023-07-24 13:59:45 -05:00
Binij Shrestha
ceadfacb21
Fix/18884 migrate avatar network (#19079)
* Migrate AvatarNetwokr

fixing error

fix textAlign

added AvatarNetworkSize

NetworkProps extends BaseProps instead of Boxprops

omitted children from base, made name required

replace deprecated and fix lint

* update AvatarNetwork TS

* add AvatarNetworkSize test

* remove unused size import

* Update ui/components/component-library/avatar-network/avatar-network.types.ts

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* fix readme

* update to latest box component

---------

Co-authored-by: garrettbear <gwhisten@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-07-24 11:15:33 -07:00
Danica Shen
74a645e957
feat(874): add tooltip to connect hardwallet and style refactor (#20121) 2023-07-24 19:00:34 +01:00
Gabriel Méndez
9b0f8d457b
Migrate Label component to TS (#19146)
* Migrating Label component to TS

* label TS updates

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: garrettbear <gwhisten@gmail.com>
2023-07-24 10:54:34 -07:00
David Walsh
23c30d9ae1
UX: Fix display block value (#20131) 2023-07-24 10:36:03 -05:00
David Walsh
9575075dc1
UX: Remove height from loading block, use modern components (#20134)
* UX: Remove height from loading block, use modern components

* Fix lint
2023-07-24 10:35:37 -05:00
youngje (heka)
660ed410ce
fix: where text wraps even though there is enough space to display it. (#19914)
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-07-24 18:51:29 +05:30
Albert Olivé
270f74c209
[MMI] Connect MMI flow in one step less (#20143)
* First approach to fix the issue that we are displaying one extra step

* Fixed issues
2023-07-24 15:14:56 +02:00
Ariella Vu
737173ed5a
New BlockaidBannerAlert component (#20051) 2023-07-24 12:24:17 +05:30
George Marshall
e030f28ba0
Removing none from sizes (#20130)
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-07-22 16:32:53 +09:00
Harsh Shukla
02b45aa648
Part of #18896 for file ui\components\app\create-new-vault\create-new-vault.js (#20025)
* Part of #18896 for file ui\components\app\create-new-vault\create-new-vault.js

* Update create-new-vault.js

* Adding submit attribute

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-21 15:14:26 -07:00
Garrett Bear
e923110092
Fix/helptext to ts (#20108)
* migrate help-text to TS

delete story with js format

Update ui/components/component-library/help-text/help-text.types.ts

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

add forwardRef

add ref in forwardRef

final updates to HelpText to TS

update HelpText props

* form text field

* Removing some unused example code

---------

Co-authored-by: taeslee <64485716+taeslee@users.noreply.github.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-21 10:11:35 -07:00
António Regadas
8ee733c0d5
[MMI] Handle personal sign and sign typed operations (#20087)
* adds listeners for signatureControll and adds the handleSigningEvents method

* clean up

* updates signature request containers files

* adds necessary methods

* wip

* signing flow with core methods

* yarn lint

* updates logic to fit latest signatureCOntroller

* updates mmi extension package

* updates signature-controller and message-manager packages

* checkout develop lock file and run yarn

* checkout develop lock file and package.json to test circleci

* test fix

* adds signature-controller new version

* updates mmi extension package

* tx-list update and runs lavamoat auto

* lint fix

* runs lavamoat auto

* resets lavamoat/build-system/policy.jsono to develop

* Update LavaMoat policies

* adds back the dispatch

* lint

* clean up

* clean up

* applies patch for signature controller

* clean patch file

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-21 16:52:47 +01:00
George Marshall
c9ce85bd85
Removing unused deprecated Text component (#20119) 2023-07-21 08:44:57 -07:00
jiexi
4c881f70fe
Update "NFT Added" events (#19796)
* Update NFT events

* remove uneeded toString()

* source_connection_method to source for TokenAdded events

* redelete add-nft

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2023-07-21 10:17:56 -05:00
Frederik Bolding
ba001b597c
[FLASK] Unblock personal_sign for snaps (#19998)
* Add snap legacy authorship header

* Add legacy snap header to personal_sign

* Disable SIWE for snaps

* Add comment
2023-07-21 11:28:54 +02:00
Ariella Vu
59102e37b8
New SecurityProviderBannerAlert component (#19825) 2023-07-21 11:04:51 +02:00
David Walsh
112511542f
UX: Use classNames in ConnectedSitesMenu (#20067)
* UX: Use classNames in ConnectedSitesMenu

* Update snapshots
2023-07-20 18:29:24 -05:00
Garrett Bear
26d7520a84
fix Box ts spread props issue (#20107) 2023-07-20 15:06:28 -07:00
George Marshall
733391a964
Update Text import paths: /pages (#20117)
* Updating remaining Text import paths

* Updating snapshots
2023-07-20 12:49:35 -07:00
Niranjana Binoy
0c203d0518
Signature-Request refactor (#19104)
* refactoring signature-request and adding test coverage

* adding storybook and removing the reduntant files:

* adding new components from

* replacing <SiteOrigin/> with <TagUrl/>

* updating review comments from Jyoti and George

* adding the hook

* refactoring in the changes from #18770 MMI PR

* adding new hook for the MMISign changes

* updating lavamoat

* updating lavamoat

* removing a commeted line

* updating the sign check with accountType conditional

* fixing build issues

* updating the review comments on the hooks

* updating signatureRequestHeader

* lint fix

* fixing test failure

* lint fix

* updating review comments

* adding the renamed hook

* updating the origin url

* fixing test failure

* migrating changes from #19184

* updating snapshot

* fixing e2e failure

* fixing e2e failure

* addressing review comments from Joao

* migrating chnages from #19892

* moving shallowEqual inside of mmi build

* migrating changes from #19881

* fixing build failure

* migrating changes from #19949

* migrating changes from #19468

* updating snapshot

* updating snapshot

* updating QA review comments

* fixing full screen height issue from develop

* migrating changes from #20083

* fixing snapshot
2023-07-20 18:51:38 +01:00
Jyoti Puri
6ce80fe997
Adding experimental flag for blockaid (#19819) 2023-07-20 21:17:01 +05:30
Albert Olivé
e8deec28bb
Added back trackEvents to whats-new-popup (#20110)
* Added back trackEvents to whats-new-popup

* Renamed constants

* Fixed code fences issue
2023-07-20 16:29:16 +02:00
Albert Olivé
26225aabe0
[MMI] Removed compliance feature from the codebase (#20088) 2023-07-20 10:11:14 +02:00
George Marshall
88cb8ce0f5
Component library readme update (#20105)
* initial commit

* Edit

* Updating Box link

* Updating TS issues link
2023-07-19 22:10:45 -07:00
George Marshall
bf61322ee1
Update Text import paths: /app (#20083)
* Updating import paths

* Updating snapshots

* Fixing lint issues

* Updating snapshots
2023-07-19 15:32:35 -07:00
Danica Shen
cc3ef534ad
feat(882): Ensure user's IP address is not leaked to third parties before opting-out (#20101) 2023-07-19 20:56:31 +01:00
George Marshall
f9649a27f8
Update Text import paths: /ui (#20076)
* Updating Text import paths in ui folder

* Updating snapshot
2023-07-19 10:55:38 -07:00
George Marshall
b4bc033b72
Updating network list item hover (#20063)
* Updating network list item hover

* Updating e2e test

* Updating e2e test

* Updating e2e test

* Updating more e2e tests

* Updating more e2e tests
2023-07-19 10:12:24 -07:00
Frederik Bolding
56481dd875
[FLASK] snaps@0.37.1-flask.1 (#20069)
* snaps@0.37.0-flask.1

* Update LavaMoat policies

* Add support for disabling markdown

* Update execution env URL

* Bump patch version
2023-07-19 14:16:51 +02:00
Dhruv
674bb131b2
Part of #18714: Replacing deprecated constants (#20003)
* replacing deprecated constants

* updating Box in player.js

* created story for Player.js
2023-07-19 15:08:06 +05:30
Dhruv
821888effd
replacing deprecated constants and components (#20070) 2023-07-19 15:06:21 +05:30
David Walsh
8f8613a4e1
UX: Increase network name threshold before showing tooltip (#20009) 2023-07-18 17:09:26 -05:00
David Walsh
46b2290822
Fix #20006 - Add Address Details and View on Explorer to Global Menu (#20013)
* Fix #20006 - Add Address Details and View on Explorer to Global Menu

* Fix tests
2023-07-18 17:01:07 -05:00
David Walsh
be469db9a0
UX: Fix Display Property in NFTs (#20066) 2023-07-18 10:47:27 -07:00
George Marshall
e75535ddfb
Update Text import paths: /institutional (#20064)
* Updating Text import paths and deprecated consts

* Update to button
2023-07-18 08:15:25 -07:00
Albert Olivé
a8716db694
[MMI] Fix wrong custody logo location (#20072)
* Added missing styles

* updated snapshots

* fixed snapshot

* updated snapshot
2023-07-18 15:58:33 +02:00
António Regadas
f8bfb6cff5
[MMI] adds segment events to Metametrics constants (#19468)
* adds metametrics enums

* prettier

* adds necessary code fence

* edits events names and title cases them

* edits events names

* updates events according to segment-schema
2023-07-18 15:55:37 +02:00
Nidhi Kumari
e105a6030e
added background color of testnet to activity screen (#20068) 2023-07-18 08:32:00 -05:00
David Walsh
19d5cdb014
UX: Remove unwanted async callback (#20065) 2023-07-18 08:31:02 -05:00
Harsh Shukla
1277c6225d
Part of #18714 in ui\components\app\custom-spending-cap (#20039)
* Part of #18714 in ui\components\app\custom-spending-cap

* Update checkbox.test.tsx.snap
2023-07-17 22:03:46 -07:00
George Marshall
36be38e979
Update Text import paths: /multichain (#20061)
* Updating import paths for Text component

* Updating snapshots

* Adding story for TokenCell

* Updating banner in account details

* Fixing lint issue by removing unused import
2023-07-17 22:02:02 -07:00
David Walsh
3f3ee63b17
UX: Make 'Done' button a block in Account Details (#20059) 2023-07-17 21:37:29 -05:00
George Marshall
5d17f86e02
Update Text import paths: component library/ (#19987)
* Updating component-librar import paths

* Updating snapshots

* Updates to AvatarBase story

* Updates to avatar and checkbox

* Updating last of the deprecated import paths

* Updating component-library snapshots from button-base

* Updating snapshots from rest of codebase to do with button-base

* Removing unneeded CSS

* Updating snapshots
2023-07-17 14:00:16 -07:00
David Walsh
343cde9091
UX: Avoid Popover Footer when No Connected Sites (#20036)
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-17 13:12:45 -05:00
vthomas13
4dcde1e216
Multichain Activity Screen (#19557)
* layout wip

* Icon changes, add badgewrapped icons to smart tx

* grouping by date wip

* typo fix

* group txs by date, button styling

* removing queue/history division, adding datestamp for pending tx, minor styling changes

* adding tests, updating snap

* font size fix

* e2e fixes

* Remove unnecessary tabIndex and keypress handler

* Fix typo for fontWeight

* Fix nesting warning by removing unnecessary Text

* Fix tests

* Fix import and exports

* Remove unused verbiage

* Update E2E selectors

* More E2E

* More E2Es

* More test fixes

* awaiting find instead of click

* adding regularDelayMs to flaky test

* removing delay

* increasing delay outside of wait

* adding back first-child to selector

* test fixes

* using datatestid for primary currency

* sorting date txgroups

* wip alignment for big numbers

* alignment issues fix

* lintfix

* adding tabindex, cursor pointer, updating snap

* unit test fix

* storybook additions

* snaphot update

* update snap

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-07-17 13:48:15 -04:00
Albert Olivé
ea589a6e5c
[MMI] Update Modals (#20054) 2023-07-17 19:34:32 +02:00
Nidhi Kumari
8e361b391a
UX Multichain: Added background color of test networks (#20032)
* added background color to token list item

* updated badge color for nft-item

* updated nft-item tests
2023-07-17 22:13:26 +05:30
Nidhi Kumari
ce771bee66
Direct users to testnet toggle on dapp requests (#20048)
* auto switch test network when dapp requests

* fixed memory leakage issue
2023-07-17 22:12:58 +05:30
Nidhi Kumari
bdbaa03aca
UX: Updated nfts detection notice to use Banner (#20053)
* updated nfts detection notice to use banner

* removed unused css file

* updated global css file
2023-07-17 21:28:36 +05:30
Albert Olivé
0309858917
[MMI] Fixed remove custodian token (#20021) 2023-07-17 12:11:38 +02:00
George Marshall
805cc31e63
Updating BadgeWrapper to use TS Box (#19769) 2023-07-14 13:05:00 -07:00
Garrett Bear
c028bba8fd
Update ButtonLink hover underline (#19992)
* Update ButtonLink hover underline

* update buttonlink to use text decoration

* update buttonlink to use text decoration

* fix lint
2023-07-14 12:25:46 -07:00
Garrett Bear
775ca0dc31
Feat/15438/create ds checkbox component (#19808)
* add ds checkbox

---------

Co-authored-by: Garrett Bear <gwhisten@gmail.com>

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-07-14 11:50:47 -07:00
Daniel
1295474dc3
Show a balance for the Token To, update position of the MM fee, removes a link (#20030) 2023-07-14 20:48:46 +02:00
George Marshall
74cc312cb1
Updating Text and import paths (#19949) 2023-07-14 10:59:30 -07:00
Nidhi Kumari
5bc0ba7f3a
Move "Import NFTs" to Modal (#19806)
* moved import nft to modal

* fixed modal state

* updated port-nft-popup

* updated onChange for import nft modal

* updated tests

* updated tests

* updated tests

* added story and updated spec file

* updated spec file

* updated spec file

* updated spec file for import-nft

* added focus to form field

* added autofocus to tokenId
2023-07-14 21:48:41 +05:30
Nidhi Kumari
7bdd76a4ad
updated hardware wallet text (#20026) 2023-07-14 21:12:01 +05:30
David Walsh
45b7b0ca76
UX: Network Menu: Disable testnet toggle when on testnet (#19951) 2023-07-14 08:21:53 -05:00
Howard Braham
3ef2faf41c
fix(clipboard): Increase DEFAULT copy to clipboard time (#20008) 2023-07-13 13:49:13 -07:00
Ariella Vu
0917b7c52f
Add alternative summary UI with arrow icon to the Disclosure component (#19770)
* disclosure: add isArrowSummary option w/ UI

* disclosure.scss: add missing trailing semicolon

* Disclosure: replace isArrowSummary -> type prop

* Disclosure: alphabetize props

* Disclosure: add cursor: pointer

* storybook: add Disclosure - Type Arrow

* Disclosure: margin-left: 0 arrow type content

* Disclosure: fix margin-left: 0 arrow type

* Disclosure: support Text media query for Arrow

* Disclosure: clean rn type -> variant

* Disclosure: use size prop for arrow summary text

* Disclosure: update rest of type -> variant

* Disclosure: 1 more type -> variant

* Disclosure: TypeArrow -> VariantArrow
2023-07-13 22:38:42 +02:00
Garrett Bear
090476d9a2
ButtonIcon background & ButtonBase disabled update (#19976)
* button background hover updates

* add buttonlink underline

* update button base disabled

* fix size auto

* Update ui/components/component-library/button-link/button-link.stories.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* remove underline

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-07-13 13:22:40 -07:00
David Walsh
719d8a499b
Fix #19941 - Correctly show network name and selection when chainIds collide (#19947) 2023-07-13 13:29:53 -05:00
Nidhi Kumari
f17a841677
fixed button in wallet-overview (#19920)
* fixed button in wallet-overview

* lint fix

* updated selector css with class
2023-07-13 15:31:10 -02:30
David Walsh
0ba409662e
UX: Remove Portfolio from Token Overview Page (#19988)
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-13 12:52:27 -05:00
Albert Olivé
47fe542273
[MMI] Review interactive replacement token flow (#19974)
* Sending showCustodyConfirmLink as a prop and fixing other issues

* Upgraded MMI extension monrepo and trying to fix the issue

* prevents deeplink from closing

* Fixed styles of Custody view and changed the place of it

* Fixed CI issues

* fixing eslint issues

* Update LavaMoat policies

* fixing tests

* Fixed test

* updated snapshots

* Improving IRT flow

* Fixing everything

* Finish fixing all issues

* Fixed institutional entity done page styles

* Fixing boxes

* Fixed issue with checkbox

* Fixed tests and styles

* Removed duplicated lodash

* updated snapshot

* Fixing tests

* Removed unused test

* Fixed snapshot

* Fixed snapshot

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-13 18:27:49 +02:00
Dan J Miller
16481268cc
Fix memory based performance problem caused by use of lodash memoize in box component (#19993) 2023-07-13 12:23:10 -02:30
Danica Shen
2f03c0d62a
feat(19726): fix flaky test in Dapp interactions caused by home-container rerender (#19997) 2023-07-13 13:02:06 +01:00
Frederik Bolding
30a77d0483
[FLASK] Fix overflow on snaps connect screen (#19995) 2023-07-13 13:40:58 +02:00
Albert Olivé
b5ece42ca1
[MMI] Fix Connect MMI and Deep link Flows (#19881)
* Sending showCustodyConfirmLink as a prop and fixing other issues

* Upgraded MMI extension monrepo and trying to fix the issue

* prevents deeplink from closing

* Fixed styles of Custody view and changed the place of it

* Fixed CI issues

* fixing eslint issues

* Update LavaMoat policies

* fixing tests

* Fixed test

* updated snapshots

* reorder, otherwise it won't make sense

* adds necessary methods

* removes duplicated key value

* updated snapshot

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-07-13 10:42:08 +02:00
Mark Stacey
d1d39ee1cd
Fix unit test failures (#19983)
* Fix unit test failures

Fix unit test failures by updating Jest snapshots

* Update additional outdated snapshot
2023-07-12 14:40:01 -07:00
Vladimir Saric
36eaaa19ed
Added customize tx nonce on ERC20 approve screen when feature is enabled (#17945) 2023-07-12 14:32:46 -04:00
Jase Balderrama
c7782563c8
Fix misaligned icons in 'Connected sites' modal (#19944)
* Replace <SiteIcon> w/ <AvatarFavicon>

* Use constant values for borderColor & size

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-12 23:17:15 +05:30
Nidhi Kumari
beffc0611f
UX Multichain: Replace badge icon with current network image (#19964)
* updated network with current network

* Update snapshot

* fixed stories

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-07-12 22:57:39 +05:30
Dhruv
c86cbf5df2
Replacing deprecated constants (#19858) 2023-07-12 09:42:24 -07:00
jainex
23c3e8f32d
Replacing deprecated constants with enums (#19860) 2023-07-12 09:40:12 -07:00
David Walsh
e329818dab
Fix #19548 - Increase address copy to clipboard time (#19948) 2023-07-12 11:05:41 -05:00
Garrett Bear
c206200918
Update ButtonBase text variant and fix font smoothing (#19883)
* Update ButtonBase text variant

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-12 07:37:33 -07:00
Nidhi Kumari
1ea934165b
Show product tour only on home page (#19938)
* show product tour only on home page

* updated variable name

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-07-12 17:03:58 +05:30
Vinicius Stevam
5736e670f7
Approval flow adding success and error pages (#19778) 2023-07-12 09:29:54 +01:00
David Walsh
a8ad19da32
UX: Use System Theme for tooltip (#19954) 2023-07-11 13:23:07 -05:00
David Walsh
145280374d
Fix #19393 - Add indicator for Refresh list on tokens screen (#19952) 2023-07-11 10:43:39 -05:00
Niranjana Binoy
129f6f3f64
Token allowance flow update (#19666) 2023-07-11 10:57:59 -04:00
David Walsh
f9b1514914
UX: Ensure NFT Options Menu is Same Size as Tokens (#19953) 2023-07-11 09:11:31 -05:00
ryanml
8e55e9541c
Fixing scroll references for Advanced and Security settings (#19771) 2023-07-11 11:35:58 +05:30
David Walsh
4b38a2f054
UX: Multichain: Convert Networks Menu to Modal (#19803)
* UX: Multichain: Convert Networks Menu to Modal

* Fix padding

* Remove dead CSS

* moved show network to bottom

* updated snapshot

---------

Co-authored-by: NidhiKJha <menidhikjha@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-07 19:38:24 +05:30
David Walsh
64813fb660
UX: Multichain: Use Modal for AccountListMenu (#19809)
* UX: Multichain: Use Modal for AccountListMenu

* Update ui/components/multichain/account-list-menu/account-list-menu.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-07 19:18:26 +05:30
Nidhi Kumari
a2730d46fb
updated background color (#19891) 2023-07-07 18:52:23 +05:30
Frederik Bolding
4918aa4c34
[FLASK] Fix Snaps UI divider (#19919) 2023-07-07 15:10:58 +02:00
Matthew Walsh
4e63991cb7
Provide missing history property (#19896) 2023-07-07 09:05:58 +01:00
Frederik Bolding
f829f0069d
[FLASK] Allow Snaps to use eth_accounts as a revokable permission (#19306)
* Add support for snap authorship component at the top of PermissionConnect

* Add PermissionCellOptions

* Add details popover

* Add action for revoking dynamic permissions

* Improve UI and revoke logic

* Better eth_accounts screen support

* Fix tests

* Fix lint

* More linting fixes

* Fix missing fence

* Add another fence

* Unnest permission page to fix weird CSS issues

* Hide footer on permissions connect when using a snap
2023-07-06 22:54:27 +02:00
Dan J Miller
e8bd57fd13
Fix flaky test by stop estimating gas when starting a draft transaction in the send flow (#19897)
* Stop estimating gas when starting a draft transaction in the send flow, because other estimates will happen later

* fix: test fixing overlay dom issue

* Stop estimating gas when starting a draft transaction in the send flow, because other estimates will happen later

* fix: remove extra await delays

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-07-06 20:57:02 +01:00
António Regadas
2c22e85947
[MMI] personal sign and sign typed logic (#19892)
* adds missing logic

* lint fixes
2023-07-06 16:10:03 +01:00
Frederik Bolding
5d3690aa24
Fix a recent code-fencing issue with keyring snaps (#19874) 2023-07-06 11:15:14 +02:00
David Walsh
1247e03a33
Fix #19856 - Don't autoclose Modals when Popover items are clicked (#19857) 2023-07-05 10:11:49 -07:00
David Walsh
945508c895
UX: Multichain: Convert AccountDetails Popover to Modal (#19811)
* UX: Multichain: Convert AccountDetails Popover to Modal

* Fix E2E

* updated spec file

---------

Co-authored-by: NidhiKJha <menidhikjha@gmail.com>
2023-07-05 18:27:02 +05:30
David Walsh
fdac94e361
Fix #19832 - UX: Multichain: Move location of test networks (#19812)
* UX: Multichain: Move location of test networks

* Re-add Linea
2023-07-05 15:31:45 +05:30
António Regadas
ecea2d7506
[MMI] fix note to trader (#19868)
* update styles

* updates snapshot

* prettier

* clean up
2023-07-05 11:00:15 +01:00
David Walsh
98c571e90d
UX: Multichain: Use new Box component (#19794)
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-04 20:47:05 +05:30
Nidhi Kumari
fa84aa8b0a
Render correct image in the asset dropdown while sending an NFT (#19787)
* show native token image for native token in asset dropdown list

* remove console statements
2023-07-04 18:30:11 +05:30
David Walsh
aa95fe838a
Fix #19764 - Move Token Options Menu (#19765) 2023-07-04 18:06:58 +05:30
David Walsh
e05aec8502
Fix #19830 - UX: Multichain test linting (#19792)
* Fix address-copy-button.test.js

* Fix connected-site-menu.js

* Fix app-header.test.js

* Fix product-tour-popover.test.js
2023-07-04 17:30:09 +05:30
George Marshall
7c014896e8
Fix hold to reveal button on mobile browsers (#19847)
* Replacing MouseDown/Up events with PointerDown/Up so works on mobile browsers

* More test updates

* More test updates
2023-06-30 14:11:29 -07:00
Garrett Bear
a41219ceb8
Update Design Tokens & Add New Text Variants (#19853)
* update button font weight to medium

* update design-tokens and add new Text medium

* undo button base weight change

* fix unused import

* update snapshot

* fix yarn dedupe

* update readme
2023-06-30 11:35:43 -07:00
Albert Olivé
17c5964735
[MMI] Removed institutional portfolio dashboard (#19842)
* Removed institutional portfolio dashboard

* Fixed eslint

* Removed unused key
2023-06-30 15:19:59 +02:00
Albert Olivé
5545e5e581
Added code fence to remove backup notice (#19840) 2023-06-30 14:03:47 +02:00
Albert Olivé
59980f1b27
Fixing connect custody flow (#19802)
* Fixing connect custody flow

* Finished fixing mmi connect flow

* Fixed test

* updated snapshot

* Finished fixing tests
2023-06-30 12:41:28 +02:00
Dan J Miller
6bb5e6941d
Disable the opensea provider and NFT feature What's New notifications (#19828) 2023-06-29 13:51:58 -02:30
Bernardo Garces Chapero
a2dfe8d113
Approval flow for add & switch network (#19656) 2023-06-29 16:51:56 +01:00
António Regadas
48465432d6
[MMI] connect custodial with incorrect styles (#19820)
* updates the custody-keyring package and sorts the order of custodians

* updates the styles

* snapshots update

* lint

* run dedupe

* clean up
2023-06-29 15:42:37 +01:00
Monte Lai
af2c87d777
[FLASK] Add Snaps Keyring (#19710)
* flask - add restricted snap_manageAccounts

* snap keyring: use local snap keyring instead of package

* mvp snap-keyring

* fixed the easier lint errors

* fix missing permission text

* add removal function

* update snap keyring

* update dep

* update git link

* update messages and remove snap keyring from lib

* set snapprovider as soon as possible

* chore: update snap keyring dependency

* chore: pass SnapController to SnapKeyring constructor

* chore: update deps and comment line (wip)

* fix latest update for snaps and remove setController

* update yarn lock

* add routes

* add messages

* add message

* add snap account detail page

* add snap account card

* add snap account page

* update route

* add background

* use css grid

* update snap text styling

* fix lint

* remove unused import

* change manage link to go to snap

* add types for react-router-dom

* add link to settings

* add breadcrumb to header

* add popover

* add prop types

* add link to propTypes

* fix icon in header and tag

* update popover

* update yarn.lock

* add link to account list menu

* update from deprecated

* add add-snap-popup

* use popoverheader

* fix lint

* update to use modal instead of popup

* add install snap

* remove export of DeferredPromise

* change snap keyring to its own enum

* update imports and fences

* fix snapId and route

* fix header and button for snapCard

* hide app header on AddSnapAccountPage

* update icon

* match path to SnapAccountDetail

* set getting started button to close modal

* fix key prop warning

* add By Metamask message

* fix label

* add fence to snapkeyringtype

* update yarn.lock

* refactor removeAccount and static snap list

* update removeSnap

* feat: remove associated accounts when snap is removed

* add get snaps installed to snaps page

* fix updateAvailable

* add tests to ui components

* update test

* update scss

* udpate config snap popup style

* fixed https://www.notion.so/Show-pop-up-only-once-c6aa8494486a4ece8a5c5e35fea56ab5

* update accountListMenu click to open tab or push depending on environment

* update yark.lock

* remove unused uuid

* update lock

* update eth-snap-keyring

* udpate install from snap page

* update to install to use popup

* use release versino of eth-snap-keyring

* chore: bump snaps-utils version to `0.34.1-flask.1`

* update configure snap

* chore: update eth-snap-keyring

* chore: update policies

* fix: remove unused

* fix: fix snap-account-detail-page test

* fix: fix styles

* chore: remove swappable-obj-proxy

* fix: fix duplicate entry

* fix: disable export private key for snaps account

* feat: shuffle snap lists on every reload

* fix: configure not popping up

* refactor: snapsAddSnapAccountModalDismissal into action and selector

* fix: E2BIG when running prettier

* fix: lint default export or add-snap-account-modal

* fix: lint, remove vendor prefix

* fix: fix snapCreatedByMetamask to snapCreatedByMetaMask

* Add `manageAccounts` RPC method (#19724)

* Update dependencies

* Remove snap-keyring-permissions

* Update dependencies

* Update dependencies

* Update imports

* removed portfolio link from wallet view (#19716)

* removed portfolio link from wallet view

* removed unused code

* updated test

* updated spec file

* updated test

* Validate LavaMoat policies on each PR (#19703)

* Validate LavaMoat policies on each PR

The LavaMoat policies are now validated on every PR. This makes it
easier to validate policy changes, as they should always correspond
with the changes made in the PR (unlike today, when they could be due
to a change in platform or a previous PR).

Closes #19680

* Update LavaMoat policies

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>

* fix(action): add required permissions to remove labels (#19728)

* Fix dependencies

* signature approved metrics e2e test (#19628)

* Update dependencies

* Integrate Snow with LavaMoat scuttling protection (#17969)

* Update lavamoat policies

* Security Provider cleanup (#19694)

* security-prov: isFlaggedSecurityProviderResponse

* security-prov: create shared/modules/util

* security prov: rn isFlagged -> isSuspcious
- util fn returns true if response is not verified and flagged

* security prov: add util test
and support undefined param

* security prov: reorg util fn
- no logic changes

* Update LavaMoat policies (#19744)

Update LavaMoat policies to match what CI expects.

* Replacing deprecated constants & creating stories (#19686)

* Replacing deprecated constants & creating stories

* updating snapshot

* fix: fix imports

* chore: update policy.json

* fix: move SmartTransactionController out of snaps code fence

* fix: yarn.lock dedupe

* fix: lavamoat policy

* fix: update test

* fix: remove snapshot, the list of snaps are always randomized.

* fix: resole snaps-controller to use flask

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: weizman <weizmangal@gmail.com>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Dhruv <79097544+dhruvv173@users.noreply.github.com>
Co-authored-by: Monte Lai <monte.lai@consensys.net>

* Update LavaMoat policies

* chore: fix webapp policy.json

* feat: add snap label test

* feat: test to disable export private key for snap accounts

* feat: add snap account link test in account-list-menu

* fix: add fence for setSnapsAddSnapAccountModalDismissed

* fix: remove comments

* fix: move routes into snaps fence

* feat: use snap registry

* fix: account snap identification

* chore: add `keyring-snaps` feature flag

* fix: remove unneeded spread

* Disable warn logs in content-script (#19754)

* Use Yarn caching in GitHub Actions (#19662)

GitHub actions that install dependencies will now also cache those
dependencies using the standard strategy for Yarn (which is to hash the
lockfile).

This matches the module template (see https://github.com/MetaMask/metamask-module-template/pull/145
for details).

This should have no functional impact except that this action will run
faster when dependencies are unchanged.

* Fixing misspelling in 10.28.0 changelog notes (#19756)

* Add `tokenId` type validation in `wallet_watchAsset` middleware (#19738)

* Remove unused GitHub Action workflow (#19660)

This GitHub action workflow was disabled, but was still running setup
steps. It has now been removed entirely. We can re-introduce it again
later once the problem that led to it being disabled has been fixed.

The associated npm script and JavaScript module have been removed as
well.

* Fix #847 - Don't show account address on token pages (#19740)

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Deprecating FormField and fixing console error (#19739)

* Deprecating FormField and fixing console error

* Updating snapshots

* updated linea image for token and badge (#19717)

* updated linea image for token and badge

* replaced hardcoded string with constant

* UI updates for contacts Page (#19646)

* updated contacts flow update

* json file updates

* updated contacts edit and view list

* keep contacts tab selected

* lint fix

* replaced hardcoded strings with constant

* updated padding in box

* Replacing deprecated components and fixing prop errors (#19745)

* Use `snaps@0.35.2-flask.1` and `snaps@1.0.0-prerelease.1` (#19734)

* snaps@0.35.0-flask.1

* Update LavaMoat policies

* Update stable snaps packages to 1.0.0-prerelease.1

* Update LavaMoat policies

* Fix lint

* snaps@0.35.2

* Exclude snap_manageAccounts

* Code fencing

* Revert removing endowment:keyring exclusion

* Bump iframe URLs

* UX: Ensure multichain native token name is always shown (#19705)

* UX: Ensure multichain native token name is always shown

* Fix lint

* UX Multichain: fixed padding for edit screen (#19707)

* fixed padding for edit screen

* Use network picker for header trigger

* Fix swaps display

* updated snapshot

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>

* Bump @metamask/providers to v11.1.0 (#19762)

* Bump @metamask/providers to v11.1.0

---------

Co-authored-by: Alex <adonesky@gmail.com>

* Fix fallback gas estimation (#19746)

* Fix fallback gas estimation

Our fallback gas estimation was failing due to a bug in the
`@metamask/controller-utils` package. This was causing gas estimation
to fail completely on certain networks (those not supported by our gas
estimation APIs and non EIP-1559 compatibile), and it was causing the
fallback gas estimation operation (in case our API was down) to fail
across all networks.

Fixes https://github.com/MetaMask/metamask-extension/issues/19735

* Add e2e tests

E2E tests have been added to capture gas estimation. Cases are added
for our API, for the fallback estimate, and for non-EIP-1559 estimates.

As part of this work, the legacy gas API had to be disabled. This was
being used in e2e tests but was dead code in production. It needed to
be disabled to ensure the code under test was reachable.

* Fix gas API referenced in e2e test

* Update unit test snapshots

* Update Label component font weight from bold to medium (#19731)

* Update Label component font weight from bold to medium

* update snapshot

* fix snapshots

* fix snapshots 2

* Removeing deprecated constants for enums

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

* Part of #17670: Replace Typography with Text component in CancelSpeedupPopover (#18638)

* create story

* replace Typography with Text component

* review changes

* replace CSS with props styling
* use `Button` from `component-library`
* tooltip HTML refactor with `component-library` components
* remove whitespace in story

* strong tag support within Text component

* addresses #18651
* taken from #18752 as suggested in https://github.com/MetaMask/metamask-extension/pull/18638#discussion_r1176334805

* replace `strong` with new `Text as="strong"`

* remove unneccessary css from fa564e3f036f1439f9f220cca23595b508760614

* add text variant definition

* Updating text variant of button

* restrore proper spacing between elements

* Quick fix for test

* Adding key

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>

* Issue 17670 replace typography with text (#19433)

* Replace Typograph with Text component in numeric-input-component.js

* Replace Typography with Text component in signature-request-message.js

* Replace Typography with Text component in signature-request.component.js

* Replacing deprecating constants and fixing some signature story warnings

* Updating snapshot

* Fixing import

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>

* Part of #18714: Replacing deprecated constants in `confirm-subtitle` folder (#19699)

* repalcing deprecated constants

* resolve issue

* lint fixes

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

* Part of #17670: Replace Typography with Text component in: callout.js (#18912)

* Part of #17670: Replace Typography with Text component in: callout.js

* Update ui/components/ui/callout/callout.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update callout.js

* Updating snapshot and deprecating component

* Updating snapshot and deprecating component

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>

* [MMI] Added code fences in whats new popup (#19581)

* added code fences in whats new popup

* Improved code

* Added missing prop

* Update LavaMoat policies

* updated functions by using an options object for the rendering functions in order to bypass possible typsecript issues

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>

* Updated action list in token, NFTs and activity view (#19702)

* updated ui for nft import button

* updated no nft image found in the center

* updated footer for all screens in tabs

* removed no nft state from nft tab

* updated snapshot

* lint fix

* fixed e2e tests

* fixed prep build error

* removed no nfts yet test

* updated tabs

* fixed prod error

* updated no nft screen

* changed button size to md

* fix: change 'M' to '?'

* fix: update fence to keyring-snaps

* chore: rename folder

* fix: typo

* chore: remove logs

* feat: add metamask developer constant

* fix: sass keyring-snap path

* chore: update yarn.lock

* fix: remove alias

* feat: add KEYRING_SNAPS_REGISTRY_URL env

* fix: nested fence

* feat: add snap manageAccount e2e (#19777)

* feat: add snap manageAccount e2e

* feat: update link

* fix: lint

* fix: get values of restrictedMethodPermissionBuilders

* fix: add fence to perferences

* fix: stop shuffle

* fix: remove KEYRING_SNAPS_REGISTRY_URL from metamaskRc

* fix: use permissions to determine account snaps

* fix: remove shuffle

* fix: add comments to fences in excluded snap permission.

* chore: fix policy.json

* fix: fix snap-account-detail test

* fix: lint

* fix: snap accoutn detail page test

* Update LavaMoat policies

* Update ui/pages/keyring-snaps/snap-account-detail-page/snap-account-detail-page.test.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/pages/keyring-snaps/snap-account-detail-page/snap-account-detail-page.test.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* fix: remove fence from isAbleToExportAccount

* chore: remove comment line

* fix: dismiss snap modal

* fix: try catch for scroll

* fix: icon for manageAccount

* fix: update `handleSnapRequest` to make `params` optional and add `id`

* fix: lint for uuid

* fix: remove arg in saveSnapKeyring

* fix: add fence for uuidV4

* chore: bump dep

* fix: permission_manageAccounts message and icon

* chore: update registry link

* chore: convert address to lowercase

* fix: change icon

* chore: bump eth-snap-keyring

* chore: update webapp policy.json

* Update ui/pages/keyring-snaps/new-snap-account-page/new-snap-account-page.test.tsx

Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>

* fix: update fences

* fix: nested fence

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/components/multichain/account-details/account-details-display.js

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/pages/keyring-snaps/snap-account-detail-page/header.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/pages/keyring-snaps/snap-account-detail-page/snap-account-detail-page.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* fix: rename and added jsdoc

* fix: add fence to snap label

* fix: remove comment

* fix: change pixel to int and remove unused class

* fix: lint

* fix: create two tests for main and flask restricted methods

* fix: remove fence in test

* fix: lint header

* feat: allow `metamask.github.io` in manifest

* fix: remove comment

* fix: rename isAbleToExportAccount

* chore: use a more restrictive registry URL

* fix: change to && not ||

* fix: remove unused

* fix: move keyring snaps URL to Flask's base manifest

* fix: use fetch instead of fetchWithCache

* fix: lint

---------

Co-authored-by: kumavis <aaron@kumavis.me>
Co-authored-by: Howard Braham <howrad@gmail.com>
Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: weizman <weizmangal@gmail.com>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Dhruv <79097544+dhruvv173@users.noreply.github.com>
Co-authored-by: ryanml <ryanlanese@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: jiexi <jiexiluan@gmail.com>
Co-authored-by: jainex <jainexp017@gmail.com>
Co-authored-by: Matthias Kretschmann <m@kretschmann.io>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
Co-authored-by: Ujwal Kumar <ujwalkumar95@gmail.com>
Co-authored-by: rohit kerkar <129620973+rohiiittttt@users.noreply.github.com>
Co-authored-by: Harsh Shukla <125105825+PrgrmrHarshShukla@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Albert Olivé <albertolivecorbella@gmail.com>
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
2023-06-29 09:24:08 -04:00
Alex Donesky
230c0c6fa1
fix issue where non-standard NFT watchAsset requests result in notification with home screen view (#19788) 2023-06-28 13:01:38 -05:00
Nidhi Kumari
b9bca5feca
removed margin for popup view (#19804) 2023-06-28 20:41:19 +05:30
David Walsh
7e7b4f018c
UX: Multichain: Update deprecated variables (#19795) 2023-06-28 10:03:50 -05:00
David Walsh
fd20f48e2c
UX: Multichain: Make imports consistent (#19793) 2023-06-28 08:37:03 -05:00
Frederik Bolding
c8f26d8c24
Fix design inconsistencies in the connect flow (#19800) 2023-06-28 14:36:20 +02:00
Albert Olivé
9271cfd7bf
[MMI] The add custody token view needs a styles tweak (#19779)
* fixing styles

* Fixing styles and snapshots

* fixed eslint rule

* Removed unnecessary test
2023-06-27 15:49:15 +02:00
Nidhi Kumari
af56e34d5f
Updated action list in token, NFTs and activity view (#19702)
* updated ui for nft import button

* updated no nft image found in the center

* updated footer for all screens in tabs

* removed no nft state from nft tab

* updated snapshot

* lint fix

* fixed e2e tests

* fixed prep build error

* removed no nfts yet test

* updated tabs

* fixed prod error

* updated no nft screen

* changed button size to md
2023-06-27 12:05:31 +05:30
Albert Olivé
1e56fdbf66
[MMI] Added code fences in whats new popup (#19581)
* added code fences in whats new popup

* Improved code

* Added missing prop

* Update LavaMoat policies

* updated functions by using an options object for the rendering functions in order to bypass possible typsecript issues

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-06-27 08:30:42 +02:00
Harsh Shukla
ec4c4050e6
Part of #17670: Replace Typography with Text component in: callout.js (#18912)
* Part of #17670: Replace Typography with Text component in: callout.js

* Update ui/components/ui/callout/callout.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update callout.js

* Updating snapshot and deprecating component

* Updating snapshot and deprecating component

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-06-26 19:36:01 -07:00
rohit kerkar
deabc3ed5f
Part of #18714: Replacing deprecated constants in confirm-subtitle folder (#19699)
* repalcing deprecated constants

* resolve issue

* lint fixes

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-06-26 19:35:45 -07:00
Ujwal Kumar
04839a250d
Issue 17670 replace typography with text (#19433)
* Replace Typograph with Text component in numeric-input-component.js

* Replace Typography with Text component in signature-request-message.js

* Replace Typography with Text component in signature-request.component.js

* Replacing deprecating constants and fixing some signature story warnings

* Updating snapshot

* Fixing import

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-06-26 15:50:08 -07:00
113fdc189c
Part of #17670: Replace Typography with Text component in CancelSpeedupPopover (#18638)
* create story

* replace Typography with Text component

* review changes

* replace CSS with props styling
* use `Button` from `component-library`
* tooltip HTML refactor with `component-library` components
* remove whitespace in story

* strong tag support within Text component

* addresses #18651
* taken from #18752 as suggested in https://github.com/MetaMask/metamask-extension/pull/18638#discussion_r1176334805

* replace `strong` with new `Text as="strong"`

* remove unneccessary css from fa564e3f036f1439f9f220cca23595b508760614

* add text variant definition

* Updating text variant of button

* restrore proper spacing between elements

* Quick fix for test

* Adding key

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-06-26 13:52:54 -07:00
jainex
c1c6c8237a
Update Label component font weight from bold to medium (#19731)
* Update Label component font weight from bold to medium

* update snapshot

* fix snapshots

* fix snapshots 2

* Removeing deprecated constants for enums

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-06-27 01:29:04 +05:30
Mark Stacey
ec7e7fdf6d
Fix fallback gas estimation (#19746)
* Fix fallback gas estimation

Our fallback gas estimation was failing due to a bug in the
`@metamask/controller-utils` package. This was causing gas estimation
to fail completely on certain networks (those not supported by our gas
estimation APIs and non EIP-1559 compatibile), and it was causing the
fallback gas estimation operation (in case our API was down) to fail
across all networks.

Fixes https://github.com/MetaMask/metamask-extension/issues/19735

* Add e2e tests

E2E tests have been added to capture gas estimation. Cases are added
for our API, for the fallback estimate, and for non-EIP-1559 estimates.

As part of this work, the legacy gas API had to be disabled. This was
being used in e2e tests but was dead code in production. It needed to
be disabled to ensure the code under test was reachable.

* Fix gas API referenced in e2e test

* Update unit test snapshots
2023-06-26 16:13:16 -02:30
Nidhi Kumari
eb506a5694
UX Multichain: fixed padding for edit screen (#19707)
* fixed padding for edit screen

* Use network picker for header trigger

* Fix swaps display

* updated snapshot

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-06-26 23:27:56 +05:30
David Walsh
9a9625d96c
UX: Ensure multichain native token name is always shown (#19705)
* UX: Ensure multichain native token name is always shown

* Fix lint
2023-06-26 12:54:32 -05:00
Frederik Bolding
3df690b852
Use snaps@0.35.2-flask.1 and snaps@1.0.0-prerelease.1 (#19734)
* snaps@0.35.0-flask.1

* Update LavaMoat policies

* Update stable snaps packages to 1.0.0-prerelease.1

* Update LavaMoat policies

* Fix lint

* snaps@0.35.2

* Exclude snap_manageAccounts

* Code fencing

* Revert removing endowment:keyring exclusion

* Bump iframe URLs
2023-06-26 19:41:59 +02:00
George Marshall
f2d039f6cb
Replacing deprecated components and fixing prop errors (#19745) 2023-06-26 10:29:02 -07:00
Nidhi Kumari
1cc78fa0b1
UI updates for contacts Page (#19646)
* updated contacts flow update

* json file updates

* updated contacts edit and view list

* keep contacts tab selected

* lint fix

* replaced hardcoded strings with constant

* updated padding in box
2023-06-26 22:38:42 +05:30
Nidhi Kumari
e9423be894
updated linea image for token and badge (#19717)
* updated linea image for token and badge

* replaced hardcoded string with constant
2023-06-26 22:07:20 +05:30
George Marshall
48f61dcf61
Deprecating FormField and fixing console error (#19739)
* Deprecating FormField and fixing console error

* Updating snapshots
2023-06-26 09:29:33 -07:00
David Walsh
e37e570b2e
Fix #847 - Don't show account address on token pages (#19740)
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-06-26 11:13:26 -05:00
Dhruv
1c7c89abcb
Replacing deprecated constants & creating stories (#19686)
* Replacing deprecated constants & creating stories

* updating snapshot
2023-06-23 14:38:40 -07:00
Ariella Vu
34375a57e5
Security Provider cleanup (#19694)
* security-prov: isFlaggedSecurityProviderResponse

* security-prov: create shared/modules/util

* security prov: rn isFlagged -> isSuspcious
- util fn returns true if response is not verified and flagged

* security prov: add util test
and support undefined param

* security prov: reorg util fn
- no logic changes
2023-06-23 20:08:22 +02:00
Nidhi Kumari
dfb830e862
removed portfolio link from wallet view (#19716)
* removed portfolio link from wallet view

* removed unused code

* updated test

* updated spec file

* updated test
2023-06-23 17:28:41 +05:30
António Regadas
80bfb5b501
[MMI] rearrange mmi account menu options (#19635)
* adds the portfolio dashboard option and compliance to the global menu

* undo change
2023-06-23 11:55:31 +02:00
António Regadas
93704a8479
fixes the stake a portfolio icons not showing (#19633) 2023-06-23 11:54:59 +02:00
António Regadas
adc02dd534
adds MMI blue fox svg (#19632) 2023-06-23 11:54:04 +02:00
Elliot Winkler
bd12ea733a
Fix autolock field to accept decimals in Firefox (#19653)
The autolock field on the Settings screen — the field that allows users
to set the duration that MetaMask will wait for until automatically
locking — does not always accept decimal numbers. This breaks the e2e
test for this feature as it attempts to set this field to "0.1".

More specifically, the React component responsible for this field passes
whatever the user inputs through the `Number` function immediately and
then uses this to repopulate the input. Therefore, if the user enters
"3" followed by a ".", `Number("3.")` will be called. This evaluates to
the number 3, and "3" becomes the new value of the field. As a result,
the "." can never be typed.

Curiously, this behavior only happens in Firefox; Chrome seems to
keep the "." in the input field when it's typed. This happens because
`onChange` event doesn't seem to get fired until a number is typed
*after* the ".". This may be due to underlying differences in the DOM
between Chrome and Firefox.

Regardless, always passing the input through `Number` creates other odd
behavior, such as the fact that the input can never be cleared (because
`Number("")` evaluates to 0).

This commit solves these problems by saving the "raw" version of the
user's input as well as the normalized version. The raw version is
always used to populate the input, whereas the normalized version is
saved in state.
2023-06-22 10:29:24 -06:00
David Walsh
329e4b75ed
Fix #19608 - Make account name validation more strict (#19616) 2023-06-22 09:07:56 -05:00
David Walsh
7949ec9cd4
Fix #18423 - Ensure token details stay within dropdown (#19626)
* Fix #18423 - Ensure token details stay within dropdown

* Ellipsize the token id

* Add tooltip, fix tests
2023-06-21 16:28:53 -05:00
Nidhi Kumari
76cafe0a83
added extra margin for unlocked state in full view in header (#19701)
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-06-21 19:32:25 +05:30
Dhruv
bc1a15a0a3
Creating stories for LoadingHeartBeat and LoadingIndicator (#19495)
* Creating stories

* lint fix

* Updating LoadingHeartbeat story

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-06-20 15:16:19 -07:00
Dhruv
ab0374d48a
Part of #18714: Replacing deprecated constants with enums (#19516)
* replacing deprecated constants with enums

* Removing redundant properties
2023-06-20 15:14:45 -07:00
Ujwal Kumar
84135f5d4c
Replace deprecated Display constant with enum in slippage-buttons.js (#19560) 2023-06-20 13:56:05 -07:00
rohit kerkar
639de748fb
Adding story for CancelButton (#19566)
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-06-20 13:44:54 -07:00
rohit kerkar
4a8a4aa01b
creating story for multilayer-fee-message & nft-options (#19567)
* creating story for multilayer fee message

* add story for nftoptions

* lint fixed

* suggestion

* Updating function props to actions in storybook

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-06-20 13:43:27 -07:00
Howard Braham
9acd4b4ea1
feat(srp): add a quiz to the SRP reveal (#19283)
* feat(srp): add a quiz to the SRP reveal

* fixed the popover header centering

* lint fixes

* converted from `ui/components/ui/popover` to `ui/components/component-library/modal`

* responded to @darkwing review

* added unit tests

* renamed the folder to 'srp-quiz-modal'

* responded to Monte's review

* using i18n-helper in the test suite

* small improvement to JSXDict comments

* wrote a new webdriver.holdMouseDownOnElement() to assist with testing the "Hold to reveal SRP" button

* Updating layout and some storybook naming and migrating to tsx

* Apply suggestions from @georgewrmarshall

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Unit test searches by data-testid instead of by text

* new layout and copy for the Settings->Security page

* now with 100% test coverage for /ui/pages/settings/security-tab
fixes #16871
fixes #18140

* e2e tests to reveal SRP after quiz

* e2e- Fix lint, remove unneeded extras

* @coreyjanssen and @georgewrmarshall compromise

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Corey Janssen <corey.janssen@consensys.net>

* trying isRequired again

* transparent background on PNG

* [e2e] moving functions to helpers and adding testid for SRP reveal quiz (#19481)

* moving functions to helpers and adding testid

* fix lint error

* took out the IPFS gateway fixes

* lint fix

* translations of SRP Reveal Quiz

* new Spanish translation from Guto

* Update describe for e2e tests

* Apply suggestion from @georgewrmarshall

Co-authored-by: George Marshall <george.marshall@consensys.net>

* fixed the Tab key problem

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Plasma Corral <32695229+plasmacorral@users.noreply.github.com>
Co-authored-by: Corey Janssen <corey.janssen@consensys.net>
2023-06-20 14:27:10 -04:00
Daniel
3e79a742c4
Only show a Swaps notification on a supported chain (#19673) 2023-06-20 18:57:14 +02:00
David Walsh
ba3f86400c
Fix #19609 - Prevent rounded corners in account menu (#19615) 2023-06-20 08:38:24 -05:00
OGPoyraz
39089e0f4c
Accept SignController approval request from frontend (#19184) 2023-06-20 15:37:09 +02:00
Matthew Walsh
b247f272ba
Support translation in background code (#19650) 2023-06-20 13:44:11 +01:00
jainex
6bc6cba6d5
remove Unused CSS (#19602)
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-06-19 23:29:52 +05:30
Victorien Gauch
e4923399a9
feat: add new linea mainnet network (#19326)
* feat: add new linea mainnet network

* fix: removed unused condition + lint code

* fix: update tests + fix network tab issue

* feat: add feature toggle for linea mainnet

* fix: add feature toggle for linea mainnet

* feat: add linea mainnet logo

* update @metamask/eth-json-rpc-infura package to support linea networks

* update linea mainnet block explorer url

* fix: refactor linea mainnet feature toggle

* fix: update linea mainnet chain id and rpc url

* fix: update settings-search unit test

* fix: update linea mainnet feature flag

* fix: remove useless async function keyword for linea mainnet feature flag
2023-06-16 14:05:33 -02:30
Garrett Bear
70d86ee67c
Feat/19274/ds popover update account list menu (#19534)
* update account list menu to use ds popover and fix accessibility issue

* close popover if user continues to tab to next items

* remove disable logic not doing anything

* add stylesheet

* add refs to track last menuitem

* cleaned up ref version for MenuItems

* fix test

* add click away option and fix test

* fix e2e test

* undo e2e test

* add account e2e

* fix click outside component

* remove additional line break

* remove commented out code

* add isOpen to story

* set width to 225px
2023-06-16 09:25:13 -07:00
Nidhi Kumari
a8a61ebc33
Updated contacts Title and copy changes in Send Flow (#19618)
* updated snapshot

* updated spacing for edit and delete in full screen

* updated ui

* reverted changes for contacts

* updated json
2023-06-16 21:36:27 +05:30
David Walsh
bc2a5aaf96
Fix #19619 - Submit the account creation form when pressing enter (#19620) 2023-06-16 08:13:08 -05:00
Daniel
1aae94fedc
Fix searchable item list height (#19634) 2023-06-16 15:06:25 +02:00
Alex Donesky
c16b35c029
Extend wallet_watchAsset to support ERC721 and ERC1155 tokens (#19454)
* Extend wallet_watchAsset to support ERC721 and ERC1155 tokens
2023-06-15 15:18:12 -05:00
Daniel
8b3e3c8a58
Swaps UI update (#19169) 2023-06-15 20:17:21 +02:00
António Regadas
1520f57b77
MMI start script and fixes a bug preventing it to run (#19594)
* adds MMI start script and fixes a bug preventing it to run

* lint fix
2023-06-15 17:57:35 +01:00
David Walsh
d2f0b2f785
UX: Ensure 'Connect Hardware' route is functioning properly (#19612)
* UX: Ensure 'Connect Hardware' route is functioning properly

* restore create-account page

---------

Co-authored-by: Bernardo Garces Chapero <bernardo.chapero@consensys.net>
2023-06-15 11:55:23 -05:00
Olusegun Akintayo
a0e6737848
Fix unknown processing time not showing in warning color (#19527) 2023-06-15 10:52:08 -05:00
David Walsh
276d9c74c6
Fix #19437 - Prevent Connected Sites global menu item from being clicked during confirmation (#19598)
* Fix #19437 - Prevent Connected Sites global menu item from being clicked during confirmation

* Add tests
2023-06-15 08:36:28 -05:00
David Walsh
b6f42bacf7
UX: Add portfolio button in overview (#19601) 2023-06-15 08:17:29 -05:00
Victorien Gauch
1fca9255c1
fix: refactor linea goerli testnet implementation (#19321)
* fix: refactor linea goerli testnet implementation

* fix: rename linea goerli network

* feat: add linea testnet logo

* update linea goerli block explorer url

* update @metamask/eth-json-rpc-infura package to version 8.1.0

* fix: refactor ticker map object in shared/constants/networks.ts files
2023-06-15 09:08:07 -02:30
David Walsh
875bad125f
Fix #19439 - Allow Account Picker during Send flow (#19522)
* Fix #19439 - Allow Account Picker during Send flow

* Disable any network change with confirmations pending

* Disable the settings menu during an unconfirmed transaction
2023-06-14 13:49:14 -05:00