Adnan Sahovic
fbbc1df853
Display large and small numbers as decimals instead of scientific notation on token allowance confirmation screens ( #16676 )
...
Co-authored-by: VSaric <vladimir.saric@consensys.net>
Co-authored-by: Vladimir Saric <92527393+VSaric@users.noreply.github.com>
2023-01-05 08:58:16 -06:00
Filip Sekulic
e6038d542a
Update UI for transaction security check in settings ( #16830 )
2023-01-04 15:59:48 -06:00
HowardBraham
b9d9112b97
Prevent account name collisions ( #16752 )
...
* dealt with most of the problems in the Create Account dialog
* Fixed "newAccountNumberName" localizations
* In another language, don't allow accounts named, for instance, Cuenta 3
* Editing an account name later now follows the same rules
* Fixing lint errors
* Responding to the review by @adonesky1
* Worked with @montelaidev to alter the RegExp, in order to catch spaces before and after the account name
* Fixed line breaks for eslint
2022-12-22 11:27:31 -06:00
Daniel
2832f8a97e
Update quote selection for Optimism ( #16998 )
2022-12-21 20:59:34 +01:00
Alex Donesky
1a842aabb6
Replace eth-optimism/contracts package with local snippet of gas price ABI and address ( #16891 )
2022-12-20 14:05:07 -06:00
Guillaume Roux
85f260c22d
[FLASK] Use custom UI for dialogs ( #16973 )
...
* update dialog templates to use custom UI
* add TODO comments
* Fix showDialog hook and destructuring
* Regen LavaMoat policies
* Re-add legacy snap confirmation for now
* Fix circular dependency issue
* Revert change to token-util
* Fix lint
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-12-20 11:44:22 +01:00
Olusegun Akintayo
13de51e748
Security and Privacy Settings Re-org ( #16756 )
2022-12-19 18:46:36 +01:00
Dan J Miller
22fc60a341
Show user the general contract interaction screen for token approvals, when the asset standard is undefined ( #16765 )
...
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
2022-12-19 13:38:28 -03:30
legobeat
204f39ef12
ui: make settings search regex range explicit ( #16903 )
...
* ui: make settings search regex range explicit
- Addresses CodeQL advisory #31
- Removes `][^ as valid characters
* ui: settings-search: ignore leading/trailing whitespace
2022-12-17 05:28:13 +09:00
dragana8
d2f8083d64
Fix insufficient currency buy or receive error message ( #16979 )
2022-12-16 10:17:01 -06:00
George Marshall
09d29ef00d
Renaming broken stories to clean up console ( #16905 )
...
* Renaming broken stories. Fixing deprecated default arg syntax for stories using defaultValue
* Fixing imports
2022-12-15 14:46:30 -08:00
legobeat
1acb1b2e5d
Refactor password validation ( #16902 )
...
* ui: add common constant PASSWORD_MIN_LENGTH=8
* ui: simplify password validation logic
* ui: getPasswordStrengthLabel using t from context
Co-authored-by: Alex Donesky <adonesky@gmail.com>
2022-12-15 20:56:27 +00:00
David Walsh
43adc60956
Onboarding: Set SeedPhraseBackedUp when appropriate ( #16875 )
...
* Onboarding: Set SeedPhraseBackedUp when appropriate
* Dispatch setSeedPhraseBackedUp
* Fix test
* Make call async
* Fix test
* Fix test
* enhance test
Co-authored-by: Alex <adonesky@gmail.com>
2022-12-15 08:38:15 -06:00
Alex Donesky
9dd30a0ac6
add back error when password is too short ( #16876 )
2022-12-14 19:20:55 -06:00
Alex Donesky
c76453d6cb
fix issue where final onboarding pages are not show ( #16943 )
2022-12-14 12:19:52 +05:30
Jyoti Puri
929dfbfd21
Fix onboarding V2 Install complete page ( #16941 )
2022-12-13 15:44:08 -06:00
Alex Donesky
6a23dcc68a
remove the ability to navigate back into the onboarding flow after completing onboarding ( #16916 )
...
* fix issue when navigating back into the onboarding flow after completing onboarding
* disable navigating back into the onboarding flow
* lint
* fix test
* lint
2022-12-13 12:08:28 -06:00
Daniel
a6da5fd4c3
Add Optimism's L1 fee for an approval tx into total L1 fee in Swaps ( #16929 )
2022-12-13 18:28:05 +01:00
Vladimir Saric
11f24deef6
Added reject transactions modal to be present in the footer of the approve screen ( #16832 )
...
* Added reject transactions modal in the footer
* Use Button component for multiple unapproved tx
2022-12-13 13:33:35 +01:00
Jyoti Puri
9a4739c813
User should be able to search setting to batch account balance request ( #16887 )
2022-12-12 20:35:21 +05:30
David Walsh
dcffa4c7bc
Fix #16804 - Onboarding - Prevent odd behavior with clicks and show/hide password ( #16878 )
2022-12-12 08:36:02 -06:00
Frederik Bolding
5cca4b9b44
[FLASK] Fix a crash that occurred after a snap confirmation had been approved ( #16864 )
...
* Fix a crash that occurred after a snap confirmation had been approved
* Fix lint
* Move code below early return
2022-12-12 12:32:31 +01:00
David Walsh
7a1f75d17f
Fix #16852 - Update support link for BETA ( #16853 )
2022-12-09 08:01:40 -06:00
Jyoti Puri
8125473dc5
Removing flag for EIP1559 V2 support ( #16446 )
2022-12-09 00:07:06 +05:30
David Walsh
7d3b1d08da
NFTs: Update COLLECTIBLES_V1 to NFTS_V1 ( #16851 )
2022-12-08 11:37:47 -06:00
David Walsh
43c278d813
Privacy - Show default selected network after a custom network has been added during onboarding ( #16789 )
...
* Privacy - Allow users to set a custom RPC from the onboarding process (#16767 )
* Privacy - Allow adding custom IPFS from onboarding (#16782 )
* Privacy - Show default selected network after a custom network has been added during onboarding
* WIP: Show dropdown list of networks
* Add network switcher to the onboarding advanced privacy screen
* Fix duplicate imports
* Provide default for networks
* Update ui/helpers/utils/ipfs.js
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
* Fix lint
* Remove unwanted changes
* Fix lint
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2022-12-08 10:42:23 -06:00
Pedro Figueiredo
3a456a45fc
fix locales for advance config ( #16849 )
2022-12-08 14:20:59 +00:00
ryanml
a759d427f0
Remove new address alert ( #14811 )
...
* Removing new address alert
* remove unused copy
* fix broken e2e test
* rework layout nesting
* satisfy lint
* change layout to fix firefox tests
* change selector specificity on e2e test
* revert test change after fix has been merged from develop
* fix linting
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2022-12-08 14:20:24 +00:00
David Walsh
ead5076b86
Privacy - Update metametrics copy during onboarding ( #16825 )
2022-12-07 12:56:57 -06:00
amerkadicE
8885c54f13
NFT setApprovalForAll warning popover ( #16195 )
...
* NFT setApprovalForAll warning popover
2022-12-06 14:24:07 -06:00
Thomas Huang
8fde322907
Continue converting tests from enzyme to @testing-library/react ( #16753 )
2022-12-06 10:49:08 -06:00
Daniel
7f50febfcd
Ensure 0% slippage on Arbitrum for wrapping / unwrapping ( #16778 )
...
* Contract addresses to lowercase
* Use case insensitive checks in the shouldEnableDirectWrapping fn
* Remove duplicated functions, move unit tests into the right location
2022-12-06 10:44:09 -06:00
Filip Sekulic
c3f329cc80
Transaction security provider feature flag ( #16776 )
2022-12-06 11:43:53 -03:00
Vladimir Saric
9ede85c9ac
Updated secondary copy and removed the address component from SetApprovalForAll and NFT Approve screens ( #16292 )
2022-12-05 10:59:15 -06:00
Brad Decker
f7014a79fc
remove network name from analytics ( #16781 )
2022-12-03 09:57:48 -06:00
Alex Donesky
f162c58f5a
Allow adding networks with the same chainId as a preloaded/default network via wallet_AddEthereumChain API ( #16733 )
...
* allow adding networks with the same chainId as an existing network via API
Co-authored-by: Kurush Dubash <kurush@alchemyapi.io>
2022-12-02 21:14:27 -06:00
Pedro Figueiredo
d096560d85
Give the user ability to opt out of get balance batch request for all loaded accounts ( #16746 )
2022-12-01 21:16:04 +00:00
Erik Marks
a861cc6dae
[FLASK] Add snap alerts and prompts via snap_dialog RPC method ( #16048 )
...
Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-12-01 16:46:06 +01:00
Frederik Bolding
025ee2cb48
[FLASK] Expose transaction origin to transaction insight snaps ( #16671 )
...
* Expose transaction origin to transaction insight snaps
* Support multiple icons for each label for a permission
* Add transaction insight origin permission
* Fix fencing
* Fix import and permission crash
* Use function properly for connected accounts
2022-12-01 14:38:56 +01:00
Brad Decker
b3895b6840
remove rpc urls from metrics ( #16710 )
2022-11-30 09:52:25 -06:00
Thomas Huang
119219b5d2
Continue converting tests from enzyme to @testing-library/react ( #16458 )
...
* Add transaction activity log component
* Remove duplicate tx activity log snapshot.
* Convert Advanced Tab to tlr.
* Lint fix
* Convert Settings Tab test to tlr.
* Convert Send Amount Row test to tlr.
* Convert Send Row Error Message test to tlr.
* Add Mock Send State json file.
* Lint fix
* Use proper testid for jazz icon for settings e2e
* Update Send Amount Row snapshot
2022-11-29 07:42:59 -08:00
dragana8
2680340e27
Unable to proceed with tx bc of inaccurate/overly aggressive "Insufficient funds for gas" warning #13087 ( #14634 )
...
Co-authored-by: VSaric <vladimir.saric@consensys.net>
2022-11-28 10:41:42 -06:00
Adnan Sahovic
6f21c4837d
Token allowance i18n interpolation system ( #16347 )
...
* added i18n interpolation system to token-allowance screen
* modified revokeSpendingCap
* Fixed minor type error
* resolved conflicts
2022-11-25 06:56:29 -03:30
Elliot Winkler
51cffa15dd
Migrate to new controller packages ( #16547 )
...
* Migrate to new controller packages
`@metamask/controllers` is deprecated, and most of the controllers that
lived here are now located in their own package ([1]). This commit
replaces `@metamask/controllers` in `package.json` with references to
these packages and updates `import` lines to match.
[1]: https://github.com/MetaMask/controllers/pull/831
* Support GitHub registry for draft PRs (#16549 )
* Add additional allowed host to lockfile linter
* Update LavaMoat policies
* Add policy exception for nanoid
* Add additional nanoid overrides
* Update LavaMoat policies again
* Bump controller packages
* Update lavamoat
* Bump controller packages
* Update packages to v1.0.0
* Expand gitignore comment
* Unpin controller dependencies, using ^ range instead
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2022-11-24 16:29:07 -03:30
Niranjana Binoy
5666d0a71c
Resetting spending cap value to empty when a token allowance request is rejected. ( #16659 )
2022-11-24 14:14:41 -05:00
Adnan Sahovic
1bdfb952bd
Disabled save button on add contact form if input fields are empty ( #16233 )
2022-11-23 10:17:08 -06:00
Frederik Bolding
ed52a4c227
[FLASK] Fix a crash that happens after snap install ( #16526 )
2022-11-22 13:08:57 +01:00
Frederik Bolding
de955f3faa
[FLASK] snaps-monorepo@0.24.1 ( #16525 )
...
* snaps-monorepo@0.24.0
* Fix imports and regen LavaMoat policies
* Bump iframe-execution-environment
* Fix tests
* Add permissions
* Bump patch
* Bump test-snaps
* [FLASK] Fix update e2e test to catch snaps with caveats (#16546 )
* changed snap to update to bip32
* small changes to test
* Fix lint
* Fix E2E
* Update copy
* Update icon
Co-authored-by: Bowen Sanders <bowensanders@gmail.com>
2022-11-22 13:07:08 +01:00
Ben Behrman
086003555c
Make ENS named elements domain generic ( #16166 )
...
Co-authored-by: Olaf Tomalka <olaf.tomalka@gmail.com>
Co-authored-by: Vincent Shadbolt <vince.shadbolt@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Brad Decker <git@braddecker.dev>
2022-11-21 09:19:11 -06:00
David Walsh
9530797a7a
Create constants for all keyring types ( #16575 )
2022-11-21 08:23:35 -06:00
