1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00
Commit Graph

5665 Commits

Author SHA1 Message Date
Frederik Bolding
4048feeaac
Increase likelyhood of valid method signatures being returned by getMethodData (#14937)
* Increase likelyhood of valid method signatures being returned by getMethodData

* Update coverage

* Update coverage

* Update coverage

* add a migration to clear knownMethodData

* Small typo changes

Co-authored-by: Alex <adonesky@gmail.com>
2022-06-17 23:11:09 +02:00
ricky
3d74d06f93
Add missing subtitles for secret recovery phrase (#14943)
* add missing subtitles

* Update subtitles map

* update subtitle map in onboarding v2 flow

Co-authored-by: Alex <adonesky@gmail.com>
2022-06-17 14:55:04 -04:00
白宦成
adbd1c79be
fix EditGasDisplay (#13980)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-17 13:04:59 -05:00
George Marshall
fdf3e9d2d7
Fix/14856 network settings page (#14857)
* Removing other features code

* Improving acccessibility of check icon

* Fixing add network button footer in popover view

* Fixing unit tests
2022-06-15 13:16:53 -07:00
Ariella Vu
73488766b6
SB:EditGasDisplay: fix error (#14946) 2022-06-15 14:55:04 -05:00
Daniel
ebf967562b
Remove experimental gas editing for Swaps (#14942) 2022-06-15 21:08:13 +02:00
Ariella Vu
1771ed4925
ErrorMessage: add @deprecated (#14945) 2022-06-15 13:45:54 -05:00
David Walsh
ea49b40d33
Make the accounts menu accessible (#14936) 2022-06-15 12:49:18 -05:00
Jordon
f5c6d0054f
Convert knobs and actions to controls/args for MainQuoteSummary (#14758)
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-06-15 10:43:26 -05:00
Ariella Vu
ede801e143
MetaMetrics: fix onCancel trackEvent (#14935)
should mirror first-time-flow/metametrics-opt-in logic
2022-06-14 11:00:11 -05:00
Soralit
804db7f1dc
fix animated qr in dark mode (#14900) 2022-06-13 16:07:51 -05:00
VSaric
f9edbf50ce
Empty balance while switching network (#14354) 2022-06-13 14:39:48 -05:00
VSaric
136218893b
Fix contact address pet name (#14613)
* The contact pet name isn't replaced by the recipients address

* Create getEnsResolutionByAddress selector and use it in the codebase

* Modified the getRecipient selector such that it returns an ens resolution as the nickname if a nickname isn't present but a ens resolution is.

* Update ui/ducks/send/send.js

Co-authored-by: Brad Decker <bhdecker84@gmail.com>

* Checked if ens resolution is present in the getRecipient selector

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-06-13 11:18:33 -05:00
Alex Donesky
b170211700
Fix to infinite loading on approve screen (#14756) 2022-06-11 12:55:35 -05:00
ryanml
496d9d81c3
Fix Enhanced Gas Fee toggle setting metrics event (#14874) 2022-06-10 16:05:25 -07:00
Zachary Belford
7dc6a5feaa
Merge pull request #14837 from MetaMask/prop-type-fixups
Prop type fixups
2022-06-10 12:36:31 -07:00
ryanml
54e83d659d
Fix padding issue in Edit Nickname screen (#14842)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-08 15:56:14 -07:00
Zachary Belford
d882835cae
Added PR feedback changes 2022-06-08 14:24:50 -07:00
Zachary Belford
8b09f84502
Linting fixups 2022-06-08 14:24:50 -07:00
Zachary Belford
93ee67eb01
Update pr based on review feedback 2022-06-08 14:24:50 -07:00
Zachary Belford
0f7bb16b9b
Update ui/pages/settings/settings.component.js
Remove the extra route

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2022-06-08 14:24:50 -07:00
Zachary Belford
5e049aabff
Remove junk from previous ticket 2022-06-08 14:24:49 -07:00
Zachary Belford
9c8b22a20b
Changed to address to optional for TransactionDecoding component 2022-06-08 14:24:36 -07:00
Zachary Belford
c2d5bd01c4
Changed networks tab to explicitly pass in false and fix implicit type casting 2022-06-08 14:24:36 -07:00
Zachary Belford
b76943ea18
Changed custom nonce min to a number from a string 2022-06-08 14:24:36 -07:00
Zachary Belford
9ec652d0da
Changed transaction decoding component to put keys on data items 2022-06-08 14:24:35 -07:00
Zachary Belford
29d87343fa
Changed update nickname popover to remove proptype errors 2022-06-08 14:24:35 -07:00
Zachary Belford
3665c3718d
Changed seedPhraseBackedUp to always a boolean 2022-06-08 14:24:35 -07:00
Zachary Belford
5c93ca44da
Changed asset option prop type requirements 2022-06-08 14:24:34 -07:00
Daniel
b0557daa05
Handle an RPC provider delay in Swaps (#14821)
* Return an estimated amount for a completed swap if an RPC provider has a delay

* Create a recursive function for updating post tx balance

* Add a few tests for the "getSwapsTokensReceivedFromTxMeta" fn

* Trigger Build
2022-06-08 16:32:04 +02:00
Olusegun Akintayo
4fa4930c8a
Add friendly error handling when background throws an error before listening for connection (#14461)
* When background port closes, UI should display a user friendly error.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Remove console.log

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

A couple of fixes
    1. Use timeout in metaRPCClientFactory to check if UI can't
       communicate with bg
    2. Refactor locale setup
    3. Fixed wording/capitalization
    4. Fix locales usage so that linting works
    5. Refactor CSS

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

do not simulate errorwq

Refactor loading css

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Remove the onDisconnect event handler in ui as this is handled in
metarpcclientfactory

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not throw in bg

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Fix PR comments

Remove unused message 'failedToLoadMessage'

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Move usage of locales to shared/** so that linter can see it.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not simulate error.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

metarpc can handle multiple requests, responseHandled should be a map.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

reload metamask button on critical error

Use metamask state (if available) to the locale, else read locale files
manually.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

use constant and numeric separator

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

refactor error utils

remove error simulation

Memoize setupLocale function

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

test cases

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not simulate error

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

1. store should be metamask state
2. code refactorings.
Tests: mock setupLocale

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Mock fetchLocale instead
Test setup locale

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

UI/CSS changes.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not simulate failure

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* spell MetaMask correctly

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Rename state to mockStore

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* we should clean up this.responseHandled[id] in the error case.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Fixed PR comments.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* clean up response handled.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2022-06-08 00:37:15 +04:00
Daniel
9705531671
Reduce the default slippage from 3% to 2% (#14863) 2022-06-07 18:28:59 +02:00
Daniel
bd5d47993d
Make content changes for the STX status page, remove old content (#14805) 2022-06-07 15:42:25 +02:00
Thomas Huang
18e4af7690
Unit test proptype (#14868)
* Add missing props to advanced tab component test.

* Add icon size prop to site icon test

* Add hardwareWalletRequiresConnection prop to signature request test as a boolean

* Add setShowDetectedTokens prop to detect token test

* Set Setting description prop to be either object or string.
2022-06-06 19:30:07 -07:00
VSaric
914cdd5fa5
Fix switching between ETH and USD (#13827) 2022-06-06 08:11:14 -05:00
ryanml
250b3d5499
Fixing add recipient flow issue with contact list/recent recipients (#14771) 2022-06-03 15:41:05 -07:00
George Marshall
c18c3b078e
Updating icon color (#14835) 2022-06-03 12:45:03 -07:00
Victor Korzunin
0166575405
fix: keep lock button text inside button boundaries (#14335)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-03 12:16:44 -07:00
Ariella Vu
e60af93f2a
Storybook: add TransactionListItem component page (#14786)
* TransactionListItem: add storybook page

* SB:TransactionListItem: update retry status

* SB:TranslationListItem: exclude CANCEL & RETRY

* TransactionListItem: exclude SIGNED status

* TransactionListItem: fix mock transactions

* SB:TransactionListItem: add isEarliestNonce param

* SB:TransactionListItem: fix args

* SB:TransactionListItem: add "Speed Up" params

* SB: add nonce to mock transactions
2022-06-03 12:50:23 -05:00
$tocker
ba7a177f5c
fix design breaks on the Settings Navbar when Internationalization (#14012)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-06-03 12:33:59 -05:00
Frederik Bolding
239f5f7fa6
Include snap version in pill (#14803)
* Include snap version in pill

* snaps authorship styling

* styling

* Fix linting

* Fix linting

Co-authored-by: eriknson <eriks@mail.se>
2022-06-02 11:38:39 +02:00
Soralit
efdc3149aa
fix: keystone transaction qrcode has no white spacing (#14798) 2022-06-01 12:32:24 -05:00
Guillaume Roux
b599035a12
Snap notifications integration (#14605)
* begin controller implentation

* add NotificationController

* create selectors and actions

* update actions tu use forceUpdateMetamaskState

* Basic notification UI

* fix typo and remove console.log

* lint

* more css

* add notifications scroll

* add translations and fix some css

* Fix rebase and edit colors

* add flask tags

* add flask tag to routes component

* add missing flask tags

* add tests

* fix tests

* store notification expiration delay in constant

* address requested changes

* rename to unreadNotificationsCount

* add missing flask tag
2022-06-01 19:09:13 +02:00
Thomas Huang
db6998c66a
Fix proptype errors in network dropdown, tx list item details, and account details modal tests (#14747) 2022-05-31 09:46:38 -07:00
Dan J Miller
8961ea5d1b
Ensure transaction type is correctly updated on edit (#14721)
* updated state on edit

* Update transaction type in updateEditableParams method instead of in the send duck

* Fix unit test

* Fix unit tests

* Fix and improve unit tests

Co-authored-by: dragana8 <dragana.simic@consensys.net>
2022-05-27 14:01:31 -02:30
benlwyre
f6643e853c
Add fiat onboarding for AVAX and MATIC through Wyre (#14683) 2022-05-27 11:04:26 -05:00
Ariella Vu
b6ade44bc9
Slight cleanup of constants/transactions, useTransactionDisplayData, and TransactionIcon (#14784)
* TransactionIcon: alphabetize categories

* useTransactionDisplayData: rm repetitive comment

* useTransactionDisplayData: mv signatureTypes

* useTxDisplayData: import transactionGroup @typedef

* userTxDisplayData: just vertical line spacing
2022-05-26 16:26:45 -05:00
Daniel
6dbb2c4ded
Migrate the "estimateGas" API call to "getFees" for STX (#14767) 2022-05-26 19:56:28 +02:00
Brad Decker
51986a4724
Add types to send state (#14740) 2022-05-25 15:54:05 -05:00
Frederik Bolding
5b8a69c721
Remove site origin on snap install (#14752)
* Remove site origin on snap install

* Fix linting + storybook

* Update local snap icon

* Fix storybook build
2022-05-25 18:19:02 +02:00
George Marshall
8fcbebc546
Update design tokens library from 1.5 to 1.6 WIP (#14732)
* Updating account menu icon color

* Updating design-tokens and making appropriate updates to extension styles

* Adding more deprecated tags to colors

* Adding spinner and removing todo comment

* Remove comment

* Updates

* Updating snapshots

* More color and ui updates

* reverting transition change
2022-05-25 08:35:36 -07:00
Ariella Vu
70bdd9729f
Enables the "Safe Transaction From" copy for safeTransferFrom transactions (#14769)
* useTransactionDisplayData:support safetransferfrom

* useTransactionDisplayData: update test
2022-05-25 10:13:15 -05:00
Brad Decker
3177c6abbb
remove draft transaction (#14701) 2022-05-24 16:05:27 -05:00
VSaric
623fd91d65
Fix currency conversion rate (#14713) 2022-05-24 15:16:11 -05:00
Daniel
f6576801d4
Fix an edge case with missing top assets in Swaps (#14688)
* If there is no array of top assets in a response, use an empty array

* Set a default empty array for 2 functions, remove an unnecessary condition

* Redirect a user from Swaps to the homepage if they switch to a chain that is not supported in Swaps

* Fix errors in the UI Console when it's not a swaps chain
2022-05-24 18:30:46 +02:00
Frederik Bolding
c833e41eee
Restore SiteOrigin chip on permission screen (#14768)
* Restore SiteOrigin chip on permission screen

* Fix linting
2022-05-24 18:04:07 +02:00
VSaric
e7d1476522
Sign button is enabled after scrolling all the way to the bottom (#14745) 2022-05-24 10:28:40 -05:00
Ariella Vu
e06e5599bb
EditGasFeeBtn: Insufficient number of substitutions for key "dappSuggestedTooltip" (#14734)
* EditGasFeeBtn: support missing origin dappSuggest

* EditGasFeeButton: add tooltip min-width

* EditGasFeeButton: tooltip min-width needs extra px

* EditGasFeeBtb: tooltip min-width add a bit more px
2022-05-23 15:04:54 -05:00
Alex Donesky
634cf70a71
Enhance reusable SiteOrigin component (#14720)
* extend and reuse SiteOrigin component
2022-05-20 09:35:18 -05:00
Thomas Huang
11831c6ae5
Add hideEstimatedGasFee prop to sort-list and select-quote-popover tests (#14725) 2022-05-19 10:43:31 -07:00
VSaric
a5e07b0f18
Chain ID field use the same color pattern as the currency symbol field warning message below (#14644) 2022-05-19 10:52:17 -05:00
Frederik Bolding
66c049bb35
snaps-skunkworks@0.14.0 (#14700)
* snaps-skunkworks@0.13.0

* snaps-skunkworks@0.14.0

* Fix test

* Add long-running permission copy and icon

* Run linting

* Fix typo

* Bump E2E version
2022-05-18 13:49:26 +02:00
Ariella Vu
9d058007cc
NetworksTab: make footer buttons nowrap (#14733) 2022-05-17 19:44:32 -05:00
Dan J Miller
944c22262f
Ensure send logs use current chain currency symbol (#14726) 2022-05-17 14:27:23 -02:30
Ariella Vu
7cfa454570
Storybook: add SignatureRequestOriginal (#14707)
* SB: add SignatureRequestOriginal

* SB:SignatureRequestOriginal: add reusable Template

* SB:SignatureRequestOriginal: add args
missing isRequired args

* SB:SignatureRequestOriginal: add eth_signTypedData

* SB:SignatureRequestOriginal: update README.mdx

* SB:README: update description

* SignatureRequestOriginal: destruct mock value
2022-05-16 17:28:20 -05:00
Ariella Vu
1464ab724f
Storybook: Fix SignatureRequest component (#14706)
* SB:SignatureRequest: fix control type

* SB:SignatureRequest: fix args
expected by sanitizeMessage

* SignatureRequests: cleanup
2022-05-16 17:24:08 -05:00
Thomas Huang
dbe89049bd
Unit test proptype (#14564)
* Change import file to root index

* Properly set showFiat proptype to bool
2022-05-16 13:53:47 -07:00
dragana8
d01a2ad7e5
Overall CSS #13441 (#13902)
* styling updates

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-05-16 13:38:04 -05:00
dragana8
a0c4febfce
"Cancel/reject all" for signature requests #13201 (#13786) 2022-05-16 13:36:19 -05:00
Lachlan Tweedie
eee4cc3100
Add Coinbase Pay as fiat onramp option (#14648) 2022-05-12 18:27:49 -05:00
Daniel
d305dcba9d
Change styles for the high price impact notification in Swaps (#14697) 2022-05-12 19:57:05 +02:00
Alex Donesky
5e55cf2cf2
add case in useTransactionDisplayData to handle transaction type safeTransferFrom (#14678)
* add case in useTransactionDisplayData to handle transaction type safeTransferFrom

* add test
2022-05-12 10:02:08 -05:00
Niranjana Binoy
6c757ab5e0
Event tracking for Token Detection V2 (#14441) 2022-05-11 16:27:58 -04:00
Erik Marks
4b2cd0ef7a
Fix Snaps view search (#14693)
Closes #14687

Snap IDs were not properly encoded (and decoded) as URI components in the Snaps view search implementation. This ensures that they are.
2022-05-11 13:14:53 -07:00
Daniel
9a153d2388
Remove gas editing in Swaps (#14673)
* Remove gas editing in Swaps

* Remove "extraApprovalGas"
2022-05-11 20:30:03 +02:00
ryanml
54292f6c81
Fix eth_sign 'Learn more' dialog link (#14667) 2022-05-10 17:25:36 -07:00
George Marshall
23f4b58dca
Updating alert text color (#14674) 2022-05-10 10:28:30 -07:00
PeterYinusa
f47d02b72a
Auto lock e2e (#14624)
* add auto lock e2e test

* fix console errors
2022-05-10 17:57:11 +01:00
Ariella Vu
98c7515344
TransactionListItem: fix save/cancel rounded btn (#14659) 2022-05-09 13:11:25 -05:00
Niranjana Binoy
0a10b425ea
Add New Tokens Found page (#14366) 2022-05-09 13:47:06 -04:00
Daniel
2bd7127433
Swaps / STX improvements (#14622) 2022-05-09 18:48:14 +02:00
Frederik Bolding
9e401b14bf
Simplify removeSnap functionality after snaps-skunkworks update (#14646) 2022-05-09 18:19:34 +02:00
ryanml
a2ea1cacc8
Fixing Speed up/Cancel information text (#14551)
* Fixing Speed up/Cancel information text

* Adding tests
2022-05-09 08:37:31 -07:00
Frederik Bolding
fa9d703aa0
Fix SRP paste duplication (#14625)
* Fix SRP paste duplication

* Remove else-case for paste event

* Add E2E test that would catch this issue in the future

* Fix linting
2022-05-09 14:46:20 +02:00
Brad Decker
564ad2f81b
Track send flow history on txMeta (#14510) 2022-05-04 11:54:46 -05:00
David Walsh
8a71f0f008
Add search information for Theme dropdown (#14476) 2022-05-04 09:57:01 -05:00
Daniel
9daab6aa59
Disable STX if a regular tx is in progress (#14554)
* Disable STX if a regular tx is in progress

* disableStxIfRegularTxInProgress : early return

* Fix UTs

* Trigger Build
2022-05-03 17:55:41 +02:00
Frederik Bolding
3b3a680682
Stop using 4bytes for contract deployment (#14598) 2022-05-02 16:49:01 -05:00
Alex Donesky
12a088e638
Fix browser.tab.get call (#14550)
* update to expect promise from browser api polyfill rather than pass callback
2022-04-29 09:21:06 -05:00
Thomas Huang
d139e69545
Unit test proptype (#14509)
* Confirm page container content currentTransaction proptype change string to object

* Add title prop
2022-04-28 15:14:53 -07:00
George Marshall
ad1abaaef4
Updating text/muted to text/alternative for select text on home screen (#14553) 2022-04-28 06:03:12 -07:00
Guillaume Roux
6309d53650
Dark Mode : Add OS option in theme selection dropdown (#14379) 2022-04-28 14:36:28 +02:00
Hennadii Ivtushok
72d2977e72
Warn about multiple MetaMask instances running (#13836)
* Add text warning on startup page

* Try to detect extensions with browser API

* Setup messaging between different versions of extension

* Cleanup

* Cleanup

* Simplify check for multiple instances running

* Fix a doc string + use webextension-polyfill

* Fix test

* Mock webextension-polyfill

* Mock correctly

* Catch error and show warning in both extensions

* Mock as promise

* Address comments

* Rename build ids

* Run detection code only if Chrome

* Add Firefox warnings

* Cleanup imports

* Update connection ids

* Run detection code for Firefox

* Add test

* Add missing await

* Update tests

* Cleanup

* Cleanup

* Improve testing

* Improve tests

* Log errors from sendMessage

* Cleanup

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-04-27 20:14:10 +02:00
Frederik Bolding
27ad7279cd
Rename NotificationController to AnnouncementController (#14389)
* Rename NotificationController to AnnouncementController

* Fix test

* Add test for missing NotificationController state

* Bump controllers

* Move test to correct file

* Rename config key

* Add migration 71 to list of migrations

* Fix selector after migration
2022-04-27 10:36:32 +02:00
Guillaume Roux
7a9662b88e
Add token standard to custom token details (#14506)
* use getTokenStandardAndDetails to get token standard

* remove console.log and fix test

* remove console.log
2022-04-26 12:08:14 -07:00
ryanml
0c49bc14d4
Fixing 'Learn more' casing on import token screen (#14529) 2022-04-26 10:25:07 -07:00
Brad Decker
193c22588e
call controller methods directly in send duck (#14465) 2022-04-26 12:07:39 -05:00
Alex Donesky
cf2c6a3164
show token approval details on confirm approve screen by default (#14523) 2022-04-26 10:21:52 -05:00
Brad Decker
f567a3fe86
Do not show failed off-chain transactions details when grouped with another valid transaction of same nonce (#14497)
* fix failed off chain tx mismatch with next confirmed transaction

* dont drop failed txs when tx in confirmed

* add comment for reassigning logic

* resolve change requests
2022-04-25 14:39:34 -05:00
amerkadicE
ef6fb86f50
Update for a new Add network page (#13866) 2022-04-25 13:30:46 -05:00