Jyoti Puri
9fa099f5fc
Fix issue with requests with empty data being forwarded to opensea ( #18598 )
2023-04-19 07:50:36 -02:30
OGPoyraz
6e40a0eb7e
feat: use siwe detection from @metamask/controller-utils ( #18409 )
2023-04-04 17:25:57 +02:00
Elliot Winkler
1304ec7af5
Convert shared/constants/metametrics to TS ( #18353 )
...
We want to convert NetworkController to TypeScript in order to be able
to compare differences in the controller between in this repo and the
core repo. To do this, however, we need to convert the dependencies of
the controller to TypeScript.
As a part of this effort, this commit converts
`shared/constants/metametrics` to TypeScript. Note that simple objects
have been largely replaced with enums. There are some cases where I even
split up some of these objects into multiple enums.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-04-03 09:31:04 -06:00
Ariella Vu
058c571fab
Fix Sign-in With Ethereum (SIWE) metametric, add tests, and clean RPC method middleware event logic ( #18008 )
...
* rpc middleware: update comment
* rpc middleware: use errorCodes const
* rpc middleware: only create event props once
* rpc middleware: rn properties -> eventProperties
* rpc middleware: use TransactionStatus const
* rpc middleware: use const for ui_customizations
* rpc middleware: no need to push null eventProp
- also removes === null check which makes this logic a bit more robust
* rpc middleware: rn METRIC..OPTIONS -> METRIC..OPT
* clean: add consistency
* rpc middleware: refactor let msgParams
* lint: rm unused METAMETRIC_KEY
* fix test: do not pass ui_customizations: null
* rpc middleware test: consolidate tests
* rpc middleware: fix siwe event
.push returns length of mutated array
* rpc middleware test: add siwe test
* rpc middleware test: rm redudant set
2023-03-29 15:25:01 -03:00
Filip Sekulic
0351309227
OpenSea security provider metrics ( #17688 )
...
* Added metrics for the OpenSea security provider
* Fixed tests
* Fixed a test
* Fixed metrics
* Code refactor
* Lint fixed
* Removed unnecessary code
* Fix build
* Fix e2e
* Cleanup
* Fix e2e
* Code refactor
* Removed unnecessary code
* rpc middleware: catch securityProviderCheck errors
to not block dapp rpc requests
* Fixed an issue
* Added aditional test
* Applied some changes
* Fixed a test
* Fixed a test
* Code refactor
* Covered more code with tests
* Updated a test
* Fixed an issue
---------
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-03-23 14:01:51 -03:00
Ariella Vu
5468c2c142
Fix disabled 'eth_sign' event & add 'Request Disabled' event type ( #18007 )
...
* Fix #17974 / add REQUEST_DISABLED event
* RPCMiddleware: add eth_sign REQUEST_DISABLED test
* don't call Signature Request for disabled eth_sign
* clean: alphabetize
* clean: rn isDisabledRequest -> isDisabledRPCMethod
* fix test
* rpc middeware: add eth_sign comment
* fix eth_sign events and re-add Signature Request
* send 'Signature Failed' for disabled eth_sigh
2023-03-14 11:31:19 -07:00
Sam Gbafa
7aad1c9650
remove siwe feature flag ( #17690 )
...
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-10 02:05:16 +07:00
Sam Gbafa
53205b6bff
Detect and track UI customizations on Personal Sign Requests ( #16222 )
...
* detect and track ui customizations on personal sign requests
* add feature flag check to metrics
* clean up comments
* get data only if it exists
* updated with PR feedback
* moved constants
* lint
* Apply suggestions from code review
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
---------
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-08 22:16:17 +07:00
Mark Stacey
25fae8d32e
Increase provider rate limited to 5 minutes ( #16308 )
...
The metric event for provider methods has been increased from 1 minute
to 5 minutes. This will reduce the event rate, ensuring a maximum of
one event is tracked for each method call every five minutes.
2022-10-31 15:24:01 -02:30
Brad Decker
df646a03eb
Fix Provider Tracking Metrics ( #15082 )
2022-07-20 08:25:04 -05:00
Ariella Vu
78f4684b2a
MetaMetrics: Add EVENT.CATEGORIES const ( #14474 )
...
* MetaMetrics: add EVENT.CATEGORIES const
* MetaMetrics: add EVENT.CATEGORIES.INPAGE_PROVIDER
* MetaMetrics: add EVENT.CATEGORIES.AUTH
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 1
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 2
confirm we want to use 'Accounts' instead of 'Account'
* MetaMetrics: add EVENT.CATEGORIES.MESSAGES
* MetaMetrics: add EVENT.CATEGORIES.RETENTION const
* MetaMetrics: add EVENT.CATEGORIES.SETTINGS
* MetaMask: add missing EVENT.CATEGORIES.SNAPS
* MetaMetrics: add EVENT.CATEGORIES.WALLET const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING
& EVENT.CATEGORIES.TRANSACTIONS consts
* MetaMetrics: use EVENT.CATEGORIES
* ducks/swaps: revert slice name
* MetaMetrics: add missing EVENT.CATEGORIES.NETWORK
2022-04-22 13:09:10 -03:00
Brad Decker
d6df3700f7
track rpc method usage ( #14269 )
2022-04-04 14:26:13 -05:00
