legobeat
567fd93377
deps/security: vm2@3.9.15->3.9.16 ( #18555 )
...
CVE-2023-29199 / GHSA-xj72-wvfv-8985
2023-04-20 13:48:02 -02:30
Dan J Miller
9e127f01ce
Merge remote-tracking branch 'origin/master' into Version-v10.29.0
2023-04-20 13:47:31 -02:30
Filip Sekulic
6f29c96c2e
Replace contract with third party within the token allowance flow ( #18101 )
2023-04-20 13:42:02 -02:30
Dan J Miller
aaee8ec466
Rename migration 83 to 84 and rename migration 84 to 83 ( #18655 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-20 13:41:42 -02:30
Thomas Huang
928bd1c5bb
Import srp onboarding unit tests ( #18255 )
2023-04-20 09:06:36 -07:00
Thomas Huang
735076b584
Add Network Modal onboarding tests ( #18258 )
2023-04-20 07:00:27 -07:00
Thomas Huang
9b724d1032
Create New Vault test improvements ( #18259 )
...
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-04-20 06:36:03 -07:00
Monte Lai
f9a3bc8070
18566 firefox ledger u2f message ( #18570 )
...
* check for user agent
* fix regex
* fix lint
* update link
* add test
* update message
* update coverage
* fix test names
* update text
* add whats new notification for firefox and ledger users
* update action button link
* update notification text
* update viewed notification
* update coverage
* update coverage
2023-04-20 07:44:43 -02:30
George Marshall
e96c0b6963
Update to component-library readme ( #18501 )
...
* Update to component-library readme
* Update ui/components/component-library/README.md
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 19:30:29 -07:00
Mark Stacey
8e52ed3fac
Make upsertNetworkConfiguration async ( #18606 )
...
The network controller method `upsertNetworkConfiguration` has been
made async. It makes one async call internally, which is the optional
step of setting the given network as the active network.
If the `setActive` option is set to `true`, this function will not
resolve until after the network switch has completed. If the
`setActive` option is `false`, this change will not have any functional
impact.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-19 20:24:50 -02:30
Monte Lai
fa6e26744d
18566 firefox ledger u2f message ( #18570 )
...
* check for user agent
* fix regex
* fix lint
* update link
* add test
* update message
* update coverage
* fix test names
* update text
* add whats new notification for firefox and ledger users
* update action button link
* update notification text
* update viewed notification
* update coverage
* update coverage
2023-04-19 19:23:07 -02:30
Garrett Bear
34c1e5a2a1
Fix/18492/update icon ts app folder ( #18645 )
2023-04-19 14:16:49 -07:00
Dan J Miller
baf0ad5c21
Fix swaps controller: update provider after networkIdStore state update ( #18670 )
...
* Fix swaps controller: update provider after networkIdStore state update
* Listen for changes on networkController.store, instead of networkController.networkIdStore, in the swaps controller
* Fix unit tests
2023-04-19 18:17:23 -02:30
Dan J Miller
7ca9383785
Fix swaps controller: update provider after networkIdStore state update ( #18670 )
...
* Fix swaps controller: update provider after networkIdStore state update
* Listen for changes on networkController.store, instead of networkController.networkIdStore, in the swaps controller
* Fix unit tests
2023-04-19 18:15:26 -02:30
Mark Stacey
cffce88e32
Fix Sentry console logs ( #18539 )
...
Sentry console logs were failing with the error "Error: TypeError:
Cannot read properties of undefined (reading 'log')". This error has
been fixed; now Sentry can log errors to the console.
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 16:58:49 -02:30
Danica Shen
5e95e8140f
fix(18574): fix new BigNumber() not a number: undefined for setApprovalForAll method ( #18660 )
2023-04-19 16:58:35 -02:30
Dan J Miller
5bb87978ac
Merge pull request #18656 from MetaMask/master-sync
...
Master sync following v10.28.2 and v10.28.3
2023-04-19 16:49:37 -02:30
Guillaume Roux
21e07ae6ba
use history.replace() instead of history.push() ( #18663 )
2023-04-19 20:38:27 +02:00
Garrett Bear
4e1a96b4ef
Feat/18308/ds popover header component ( #18489 )
...
* add popover component
popperjs init
popperjs hook init
popper arrow styles
fix popover story
add popover positions constant
story testing
popover structure
popper placement
make forwardref
fix popover with TS updates
modifiers
createPortal
add useClickAway hook
newer popover component build
simplifed popperjs with toggle to show/hide
toggle popover
modal version
popover progress 65%
add hover functionality
hide folder
storybook demo
add close button props
working popover with arrow
title prop breaking
popover TS conversion
TS updates
update test
add test
add arrow test
add stories
remove unused hook
fix docs
add popoverheader
types fix
Fix typo: detetcted-tokens-link -> detected-tokens-link (#18408 )
Typography to text (#18382 )
* Typography to text
* Update README.md
* Update README.md
* minor changes in custom file
* minor change
* Resolved Conflict issues
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
fix: Pass correct optimism chain id to gas estimation (#18478 )
removes unnecessary images (#18484 )
Fix firsttimeloaded logic (#18344 )
* use session storage, instead of chrome.runtime.onStartup and globalThis, for firstTimeLoaded architecture
* Ensure account tracker accounts remain defined upon service worker restart
* lint fix
* Simplify code
* Only call browser.storage.session in mv3
* Only call browser.storage.session.set after resetStates in mv3
* fix metamask controller reset states unit tests
* fix test
* fix test
* Actually fix tests
* lint fix
[FLASK] More Snaps E2E Optimization and Delay Reductions (#18245 )
* bip32 delay reduction
* asserts changed to waitFors in 32/44
* scrollTo change
* replaced delay for firefox flake
* more reduced delays
* more delay reductions and changes
* raise paralellism to 4 for snaps tests
* additional delay changes
* fixed update code
* removed comment
* removed another comment
Fix switch-ethereum-chain handler by passing configuration id to setA… (#18483 )
* Fix switch-ethereum-chain handler by passing configuration id to setActiveNetwork
* fix e2e test
* Fix e2e tests
* Update test/e2e/tests/switch-custom-network.spec.js
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
* Revert "Update test/e2e/tests/switch-custom-network.spec.js"
This reverts commit be533ff7f25e1fd42e951d9b817b8438035ae256.
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Bumping notification id's to 18 & 19 (#18460 )
* Popover header update with TS ButtonIcon
* update PopoverHeader types
* update using new Text enums
* readme fix
* direct file import
* remove forwardRef and add action argtypes
* remove console.logs
* add arg types and fix TS on HeaderBase
* george nits
* popover header snapshot update
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 10:36:01 -07:00
Danica Shen
1e5f481a51
fix(18574): fix new BigNumber() not a number: undefined for setApprovalForAll method ( #18660 )
2023-04-19 19:20:18 +02:00
Mark Stacey
ac64cc9e38
Fix Sentry console logs ( #18539 )
...
Sentry console logs were failing with the error "Error: TypeError:
Cannot read properties of undefined (reading 'log')". This error has
been fixed; now Sentry can log errors to the console.
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 14:27:02 -02:30
Nidhi Kumari
cb6223b75f
removed portfolio icon from eth overview ( #18662 )
2023-04-19 22:22:53 +05:30
David Drazic
525d5ff54e
[FLASK] Revert changes made to stable permission display (UI design) ( #18470 )
...
* Revert changes made to stable permission display (UI design)
* Add test for new component
* Update paddings for install flow
* Fix missing icons on snap installation flow
* Update storybook path
* Add targetSubjectMetadata param
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-04-19 14:09:09 -02:30
Dan J Miller
53faf7966c
Merge remote-tracking branch 'origin/develop' into master-sync
2023-04-19 13:44:02 -02:30
Elliot Winkler
a876eaba23
removeNetworkConfiguration validates given ID ( #18650 )
...
In the `core` version of NetworkController, `removeNetworkConfiguration`
throws an error if the given network configuration ID doesn't match an
existing network configuration. This commits adds the same check for
consistency. It also makes some minor changes to the implementation and
tests for `removeNetworkConfiguration` for consistency as well.
2023-04-19 09:47:33 -06:00
vthomas13
b7518c0810
adding notification 18 title ( #18526 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 13:07:33 -02:30
Nidhi Kumari
d362dbfacb
UX Multichain: updated ethereum logo icon ( #18528 )
...
* updated ethereum logo icon
* Updating eth logo (#18631 )
* Updating eth logo
* Removing border from eth logo identicon
* Removing old eth logo
* updated snapshot and lint errors
* updated eth logo from svg to png
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-04-19 20:55:19 +05:30
PeterYinusa
aef27db737
update policies
2023-04-19 16:24:47 +01:00
Peter
02e8e9c679
Avoid resetting the mock server ( #18661 )
2023-04-19 15:36:23 +01:00
Dan J Miller
7bc13e90f8
Rename migration 83 to 84 and rename migration 84 to 83 ( #18655 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 11:38:16 -02:30
Dan J Miller
bffbfe1fad
Fix merge conflict introduced by cherry-picking ad11352 without also having 3577d3545f on the branch
2023-04-19 11:31:30 -02:30
Peter
1cc709af41
wait for gas estimate to update ( #18658 )
2023-04-19 13:36:24 +01:00
Jyoti Puri
e091e77674
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-19 07:50:37 -02:30
Brad Decker
ad11352199
use network did change instead of state update for assetsContractController ( #18629 )
2023-04-19 07:50:37 -02:30
Jyoti Puri
600909418c
Fix approve all warning modal ( #18613 )
...
* Fix approve all warning modal
* fix
* fix
* fix
2023-04-19 07:50:37 -02:30
Dan J Miller
3cc82898a6
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-19 07:50:37 -02:30
Dan J Miller
a97383d62e
Pass correct params to fetchEstimatedL1Fee in the swaps controller ( #18634 )
2023-04-19 07:50:37 -02:30
Jyoti Puri
b69e662ba5
Fix error in console on rejecting signature request ( #18614 )
2023-04-19 07:50:37 -02:30
Danica Shen
f8f1abf53c
fix/18577: Add title back for approving ERC20 token ( #18617 )
...
* fix/18577: Add title back for approving ERC20 token
* Apply suggestions from code review
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-19 07:50:36 -02:30
Jyoti Puri
9fa099f5fc
Fix issue with requests with empty data being forwarded to opensea ( #18598 )
2023-04-19 07:50:36 -02:30
Ariella Vu
7e14686ec7
siwe: add ledger instructions ( #18589 )
2023-04-19 07:50:36 -02:30
Matthew Walsh
58ed6af3a4
Disable rate limiting for signature approval requests ( #18594 )
2023-04-19 07:50:32 -02:30
George Marshall
2575fe1da8
Fix hold to reveal button ( #18496 )
2023-04-19 07:46:56 -02:30
Jyoti Puri
ca7f61126c
Improvement on approval pages ( #18545 )
2023-04-19 07:46:56 -02:30
sumit shinde ( Roni )
52e91058a0
knob to control ( #18635 )
...
* knob to control
* Update confirm-add-suggested-token.stories.js
* fix eslint
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update confirm-add-suggested-token.stories.js
* updaes
* Updating to use redux provider
* lint fix
---------
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-04-19 14:33:29 +05:30
Jyoti Puri
5892acab81
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-18 20:53:45 -02:30
Dan J Miller
39f6042e65
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-18 17:19:49 -02:30
Jyoti Puri
599bef9dc5
Adding documentation for confirmation code cleanup ( #17975 )
2023-04-18 22:31:45 +05:30
Garrett Bear
13f4295287
update Icon to TS version in UI Folder ( #18551 )
...
* update Icon to TS version and using proper Enums
* Update ui/components/ui/menu/menu.stories.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Update ui/components/ui/nickname-popover/nickname-popover.component.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-18 09:48:34 -07:00
Brad Decker
7fa7c05586
use network did change instead of state update for assetsContractController ( #18629 )
2023-04-18 14:03:12 -02:30
