Brad Decker
e0953d9f68
Update send and confirm state management, and tx controller gas defaults, for EIP1559 ( #11549 )
...
wip
Documentation improvements for send slice support of EIP1559
Remove console.log in send duck
Property lookup safety improvement in selectors/confirm-transaction
Add code accidentally removed in rebase
Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks (#11615 )
* Fix typo
Remove console.log in send duck
* Update addTxGasDefaults and _getDefaultGasFees to work correctly with all new gas fee estimate types
* Don't show gas timing support when not on eip1559 compatible network
* Hide gas timing component on transaction screen when on a non-1559 network
* Improve comments, tests and edge case handling
* Ensure eip1559 fees are applied and updated correctly when eip1559 estimate api fails
* Lint fix
Co-authored-by: Brad Decker <git@braddecker.dev>
Remove console.log
Handle possible gasEstimateType undefined
Remove unnecessary nonce field position change in confirm-page-container-content__details
2021-07-30 22:15:18 -02:30
Dan J Miller
f1140087b7
Adds insufficient gas error to edit-gas-display ( #11524 )
2021-07-30 20:16:31 -02:30
Dan J Miller
a1f8a65519
Ensure correct conversion of data before calling getGasFeeTimeEstimate ( #11697 )
2021-07-30 19:41:55 -02:30
Daniel
fa703173a0
Fix Jest unit tests ( #11687 )
...
* Fix Jest unit tests
* Provider correct getGasFeeTimeEstimate call to Gas Timing
* Fix tests for correct getGasFeeTimeEstimate method name
* Rename instances to getGasFeeTimeEstimate
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-07-30 15:10:41 -02:30
Daniel
24f5cc009b
Pass "maxFeePerGas" to the <GasTiming> component from Swaps ( #11684 )
2021-07-30 15:19:30 +02:00
David Walsh
e283c03c4e
EIP-1559 - Improve gas timing logic to show more accurate verbiage ( #11668 )
2021-07-30 08:00:02 -05:00
Daniel
714170c7b8
EIP-1559 and Rinkeby Testnet support in Swaps ( #11635 )
2021-07-30 13:35:30 +02:00
David Walsh
cbfde8a080
EIP-1559 - Fix duplicated networkSupports1559 variables ( #11679 )
2021-07-30 05:11:27 -05:00
Alex Donesky
583c115663
remove estimation appearance from edit-gas-popover on non-1559 networks ( #11673 )
2021-07-29 18:29:36 -05:00
Dan J Miller
b4722ff81d
Fix to having radio buttons in advanced gas inputs pre-selected ( #11669 )
...
* Ensure fees match in use gas inputs
* Lint fix
2021-07-29 16:00:21 -02:30
David Walsh
990a278177
EIP-1559 - Only show radio group and gas timing when network supports 1559 ( #11659 )
2021-07-29 13:13:14 -05:00
David Walsh
15cbe4e9a0
EIP-1559 - Allow decimals for maxFeePerGas and maxPriorityFeePerGas ( #11664 )
2021-07-29 10:59:14 -05:00
David Walsh
0849738003
EIP-1559 - Don't hide advanced form when radio button is chosen ( #11643 )
2021-07-29 10:14:48 -05:00
David Walsh
6d1fb911dc
EIP-1559 - Fix education links ( #11650 )
2021-07-29 09:18:13 -05:00
Dan J Miller
aaa15cbe03
Add support for EIP1559 transactions to transaction breakdown ( #11622 )
...
* Add support for EIP1559 transactions to transaction breakdown
* Use userPreferencedCurrencyDisplay for effective gas price in transaction breakdown
* Hide eip1559 gas properties in transaction breakdown on non-1559 networks
* Add comment explaining gasPrice and effectiveGasPrice usage in transaction breakdown container.
2021-07-28 15:00:34 -02:30
ryanml
52bac60a22
Fixing confirmation layout when dapp has suggested a price (EIP-1559) ( #11634 )
2021-07-28 11:29:55 -05:00
Dan J Miller
9a81b826c5
Only show dapp suggested gas fee warning if user has not edited the fee ( #11621 )
2021-07-27 20:01:53 -02:30
David Walsh
604524f94d
EIP-1559 - Restore custom values in Edit Gas Popover ( #11589 )
...
* EIP-1559 - Restore custom values in Edit Gas Popover
* Provide method to tell which radio button the user may have selected
* Use lodash's findKey
* Add case for legacy gas
* Use gas instead of gasLimit
* Remove unnecessary deletion and todo
2021-07-27 17:12:56 +02:00
ryanml
813eef6080
Trimming whitespace in ENSInput ( #11631 )
2021-07-27 07:53:13 -07:00
Daniel
709369dc14
Fix default tooltip color ( #11633 )
2021-07-27 15:20:01 +02:00
Dan J Miller
f4d294714a
Ensure origin shows in gas popover dapp suggested gas fee warning ( #11618 )
2021-07-26 21:13:05 -02:30
David Walsh
fab9cfde03
EIP-1559 - Provide data wiring for Gas Timing component ( #11462 )
2021-07-26 10:35:51 -05:00
David Walsh
a2be02dfeb
EIP-1559 - Show gas estimate updating animation in transaction detail ( #11566 )
2021-07-26 10:24:44 -05:00
David Walsh
6986e76adc
EIP-1559 - Show advanced form controls by default when user has selected custom values or there are gas warnings/errors ( #11590 )
2021-07-26 09:17:23 -05:00
ryanml
d092e4bdbe
Fixing type issue with auto-filled custom token decimals value ( #11604 )
2021-07-26 07:08:10 -07:00
ryanml
d03dc311ee
Adding hex address guard to input validation for token sends ( #11608 )
2021-07-26 07:07:57 -07:00
Dan J Miller
02318df48c
Ensure that the send flow state recipient nickname gets set if recipient address is in addressBook ( #11610 )
2021-07-26 07:03:05 -07:00
Daniel
868d932165
Check for the "fromToken" existance before checking decimals ( #11606 )
2021-07-26 10:15:13 +02:00
David Walsh
5d92836c8c
EIP-1559 - Provide the nonce field in the new transaction display ( #11598 )
2021-07-25 09:56:24 -05:00
David Walsh
cd4521fb12
EIP-1559 - Allow wrapping for dapp suggested origin ( #11602 )
2021-07-24 15:40:51 -05:00
Dan J Miller
2ac7b27876
Fix sending maximum of an ERC20 token ( #11594 )
...
* Fix sending maximum of an ERC20 token
* Always update gas limit when send amount updates
2021-07-23 17:40:40 -07:00
David Walsh
4e87069af3
EIP-1559 - Prevent Max Fee and Max Amount from wrapping on confirmation screen ( #11591 )
2021-07-23 08:39:10 -05:00
ryanml
8cb1557f1c
Adding method to capture one-time Sentry exceptions ( #11553 )
2021-07-22 16:13:40 -07:00
ryanml
a96af9e5fc
No longer deconstructing account menu ref if it isn't rendered ( #11585 )
2021-07-22 11:42:44 -07:00
ryanml
68c852f7c9
Validating seed phrase in restoration flow ( #11586 )
2021-07-22 10:34:53 -07:00
Daniel
a17c4462b4
Add token decimals validation in Swaps ( #11587 )
...
* Add token decimals validation in Swaps
* Use camelCase
2021-07-22 19:29:31 +02:00
David Walsh
c1d96676b5
EIP-1559 - Implement new verbiage for transaction detail subtext ( #11569 )
2021-07-22 11:33:34 -05:00
David Walsh
286fd397f8
EIP-1559 - Maintain changed form values and unselect radio buttons when user customizes form value ( #11577 )
2021-07-22 11:32:59 -05:00
Dan J Miller
ac15b3b465
Ensure send slice gas loading state is set to false upon gas estimation error ( #11581 )
2021-07-21 16:00:00 -02:30
David Walsh
859a82d428
EIP-1559 - Ony show orange confirmation heading when fee is Dapp suggested ( #11570 )
2021-07-21 07:54:32 -05:00
David Walsh
6d92759853
EIP-1559 - Implement form validation for EIP-1559 ( #11540 )
...
* Restructure advanced gas form errors
* Use shared constant for gas errors
* Add validation for fields too low
* Add warnings for high max fee and max priority fee
* Fix lint
* Fix priority fee high warning string
2021-07-20 14:34:32 -05:00
Daniel
594025a198
Add support for Polygon ( #11545 )
...
* Fix a check for EIP presense
* Add support for Polygon
* Update default Polygon URL
* Trigger Build
* Use a more user-friendly error message for disabled Swaps API calls
2021-07-20 19:17:15 +02:00
Etienne Dusseault
96b0730a89
add confirm-encryption-public-key component to Storybook ( #11364 )
...
* confirm-encryption-public-key
* lintfix
* lintfix
2021-07-20 09:29:38 -07:00
David Walsh
e0ba3eb6fc
Fix actionable message icon size ( #11547 )
2021-07-16 21:36:35 -05:00
ryanml
e60e371105
Improve handling for block explorer url host extraction ( #11543 )
2021-07-16 11:52:41 -07:00
Dan J Miller
6f0e54aa26
Implement modern design for error messages ( #11521 )
2021-07-16 13:06:48 -05:00
David Walsh
493448c96e
EIP-1559 - Don't show submit button when in education mode, don't duplicate title ( #11541 )
2021-07-16 11:19:09 -05:00
Brad Decker
dc25a24de3
rely upon gas fee controller for gas price estimates ( #11511 )
2021-07-16 11:06:32 -05:00
David Walsh
d8984d3cf3
EIP-1559 - Provide Updated UI for Dapp-Suggested Gas fees ( #11523 )
2021-07-16 10:00:03 -05:00
Niranjana Binoy
d33b841fb8
Adding TokenListController to Metamask-Controller ( #11515 )
2021-07-15 19:08:16 -04:00
ryanml
b21b139653
Handling non-numeric input for chain id in network form ( #11537 )
2021-07-15 14:11:43 -07:00
Brad Decker
4aab4887d5
add MODIFY_IN_PLACE as mode prop on edit-gas-popover ( #11527 )
...
This is necessary for the submit method to call the right background process
2021-07-15 12:31:51 -05:00
David Walsh
8e5ebfb05a
EIP-1559 - Disable gas form submission if estimates are loading state ( #11525 )
2021-07-15 12:24:03 -05:00
David Walsh
1665617378
Create different label for Gas Price with GWEI included ( #11526 )
2021-07-15 12:23:54 -05:00
David Walsh
c241d3150c
EIP-1559 - Provide tooltip text for all advanced gas controls ( #11529 )
2021-07-15 12:23:37 -05:00
David Walsh
c1064e0c50
EIP-1559 - Only show education link if on 1559-compatible network ( #11535 )
2021-07-15 12:22:55 -05:00
David Walsh
a294f02b1d
EIP-1559 - Elevate gas properties to the Popover, disable submission if errors ( #11510 )
2021-07-14 11:45:37 -05:00
David Walsh
91e744a705
EIP-1559 - Provide edit button for transaction screens to update gas ( #11516 )
2021-07-14 08:42:10 -05:00
ryanml
bbef49158d
Various UI fixes ( #11512 )
2021-07-13 19:06:12 -07:00
David Walsh
90180627cb
Using translation for edit text ( #11514 )
2021-07-13 14:22:33 -05:00
David Walsh
97d9cdff80
Provide EIP 1559 fields in transaction history ( #11464 )
2021-07-13 08:42:36 -05:00
Brad Decker
9416d1ca71
provide skeleton for submitting gas form ( #11496 )
2021-07-12 14:35:54 -05:00
ryanml
f15a68b923
Fixing invalid prop type in ConfirmPageContainerHeader ( #11500 )
2021-07-12 10:13:09 -07:00
David Walsh
1da7beed13
Provide Estimate Data to EditGasDisplay ( #11433 )
2021-07-12 11:16:03 -05:00
Brad Decker
c3e6514c35
add useGasInputs hook ( #11480 )
2021-07-09 13:26:54 -05:00
Dan J Miller
809b93dd77
Ensure simple send gas estimation happens after the recipient is iden… ( #11485 )
...
* Ensure simple send gas estimation happens after the recipient is identified
* Update ui/ducks/send/send.test.js
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* Improve test name
* Lint fix
Co-authored-by: Alex Donesky <adonesky@gmail.com>
2021-07-09 15:39:43 -02:30
Brad Decker
36ab817858
add edit button support to transaction-detail-item ( #11481 )
2021-07-09 13:08:15 -05:00
Daniel
d438439661
Swaps: Add conditional routing to new APIs based on a feature flag ( #11470 )
2021-07-09 10:24:00 -05:00
Brad Decker
f51a8451b8
add useGasEstimates hook ( #11479 )
2021-07-09 10:23:45 -05:00
Alex Donesky
2cb807dc20
fix up ens/hex address validation error handling ( #11477 )
...
* fix up ens/hex address validation error handling
* fix lint/tests
2021-07-09 09:17:02 -05:00
Brad Decker
68dfc98f40
wire up gasFeeController ( #11421 )
2021-07-08 15:23:00 -05:00
Brad Decker
64adfe7b11
update speedup and cancel to make room for EIP-1559 ( #11407 )
...
* prepare for EIP1559 gas fields in speedup/cancel
* Update ui/components/app/gas-customization/gas-modal-page-container/gas-modal-page-container.container.js
2021-07-08 13:48:23 -05:00
Alex Donesky
0ca0f1784e
Add recovery-phrase views for new onboarding flow ( #11434 )
...
* add recovery-phrase views for new onboarding flow
* black => ui-black
* minor syntax improvement
2021-07-07 19:10:12 -05:00
Alex Donesky
b1e2005a73
Add form-field component and new account view ( #11450 )
...
* add generic form-field component
* swap in new form-field component for advanced-gas-controls-row
* add new create password view for redesigned onboarding flow
* make text additions translatable
2021-07-06 17:19:11 -05:00
ryanml
68ad9c619f
Adding copy icon to home screen account address ( #11460 )
...
* Adding copy icon to home screen account address
Fixes MetaMask/metamask-extension#10145
* Using margin-inline-start
2021-07-06 11:17:13 -07:00
Brad Decker
da9fb4636b
move conversion utils to shared folder ( #11451 )
2021-07-06 12:48:49 -05:00
ryanml
a835f00ba6
Fixing leading zero when amount input is focused ( #11459 )
...
Fixes MetaMask/metamask-extension#11146
2021-07-06 10:44:46 -07:00
David Walsh
6fa3cce7ab
Create Gas Timing component for EIP-1559 ( #11405 )
2021-07-02 14:12:13 -05:00
David Walsh
afe06adb7a
Add icon to actionable message component ( #11409 )
2021-07-02 14:07:56 -05:00
David Walsh
e097a02607
Provide tooltip for 1559 Gas Price field ( #11436 )
2021-07-02 14:07:34 -05:00
Daniel
8ca0d24f82
Increase Jest unit test coverage for the Swaps feature to ~60% ( #11343 )
2021-07-02 08:48:34 -05:00
Dan J Miller
bda4d0cbca
Add list of custom networks with special gas limit buffers ( #11435 )
2021-07-01 19:18:30 -02:30
David Walsh
310531eeb6
EIP 1559 - Provide a GWEI label for advanced gas control fields ( #11419 )
2021-07-01 09:37:00 -05:00
David Walsh
64644ad380
Implement Dapp Acknowledgement screen for editing gas ( #11424 )
2021-07-01 09:36:48 -05:00
ryanml
43b7eab46a
Fixing invalid minimumGasLimit prop (AdvancedGasInputs) ( #11412 )
2021-06-30 23:41:39 -07:00
Dan J Miller
a60301686c
Ensure that eth_estimateGas is called to estimate gas limit for simple sends on custom networks ( #11418 )
...
* Ensure that eth_estimateGas is called to estimate gas limit for simple sends on custom networks
* getIsNonStandardEthChain returns false when in test
* Add comment explaining gas limit buffer multipliers in estimateGasLimitForSend
2021-06-30 23:24:47 -02:30
Dan J Miller
18464793f5
Fix gas-modal-page-container.container check for custom gas price safety ( #11426 )
...
* Fix gas-modal-page-container.container check for custom gas price safety
* Ensure gas price has been fetch before checking for price safety on testnets
2021-06-30 15:56:34 -02:30
Alex Donesky
ad6715511e
make network-display component only clickable when passed a function for onClick ( #11379 )
2021-06-30 13:21:48 -05:00
Alex Donesky
433cf6339d
refix the instance of unsafe destructuring I had introduced and fixed and then reintroduced ( #11428 )
2021-06-30 13:20:13 -05:00
David Walsh
36d3770b42
EIP-1559 - Implement TransactionDetail for confirmations ( #11404 )
2021-06-30 11:58:18 -05:00
sooyoung
9e86a03afa
add scroll function to jump to the top of screen ( #11386 )
...
* add scroll function to jump to the top of screen
* moved the scroll function from transaction-list.js to asset.js
2021-06-29 15:08:31 -05:00
Brad Decker
844a021fcd
remove ui lookup of lastGasPrice field ( #11411 )
2021-06-29 11:02:00 -05:00
Alex Donesky
352102438f
add ChipWithInput component ( #11392 )
2021-06-28 16:09:48 -05:00
David Walsh
d68f8f27c6
Implements the new EIP1559 UI components ( #11384 )
2021-06-28 09:45:08 -05:00
Brad Decker
23a859826f
add method to detect EIP 1559 support ( #11369 )
2021-06-25 11:24:00 -05:00
Daniel
a1d7271ed7
Call Wyre’s API via our backend to generate Wyre’s Checkout URL ( #11387 )
...
* Call Wyre’s API via our backend to generate Wyre’s Checkout URL
* Add back paymentMethod=debit-card, use a fallback URL if no url is returned from BE
* Fix a lint issue
* Refactor how to return Wyre’s Checkout URL
* Add 2 constants into a test file, refactoring
2021-06-25 09:52:29 -05:00
Daniel
ba3f51d6ed
Add support for fiat on-ramp via Transak ( #11376 )
2021-06-25 08:10:24 -05:00
ryanml
a69ed05141
Removing obsolete client-side transaction metrics events ( #11329 )
...
* Removing metametrics send count tracking
* Removing client side Transaction Completed and Canceled events
2021-06-24 15:37:44 -07:00
Dan J Miller
87166afb6b
Use eth_gasPrice result for setting too low warning on custom networks ( #11370 )
...
* Use eth_gasPrice result for setting too low warning on custom networks
* Assume CustomPriceSafeForCustomNetwork when there is no custom price set (it will default to recommended)
2021-06-24 14:29:47 -02:30
Alex Donesky
a6e16f458e
Adding edit navigation button flow back to send token flow ( #11335 )
2021-06-23 18:50:24 -05:00