1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-13 05:07:12 +01:00
Commit Graph

16318 Commits

Author SHA1 Message Date
David Walsh
7a29d896ad
Fix #17328 - Move NFT settings to Experimental (#17400)
* Fix #17328 - Move NFT settings to Experimental

* Don't indent second NFT setting

* Fix jest test
2023-01-31 12:50:53 -06:00
David Walsh
145cf1ec01
UX - Update all copy icons (#17445) 2023-01-31 11:00:26 -06:00
Vladimir Saric
8aa3263b82
Added navigation between multiple sign prompts and reject all sign prompts (#17093)
* Fixed navigation through multiple unapproved transactions for ERC20 tokens

* Fixed tx details activity-log currency

* Fixed e2e test failure

* Added navigation between multiple sign prompts and reject all sign prompts

* Resolving conflicts

* Creating SignatureRequestNavigation component and extracting the UI rendering part into a single component

* Fixing e2e tests and updating snapshot

* Using single component for navigation which shows both messages and transactions requests

* Fixing test-unit-jest-main

* Added more unit tests

* Fixing test-storybook

* Fixing test-storybook

---------

Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
2023-01-31 16:29:23 +01:00
David Walsh
6439d03075
Fix #17439 - Prevent event error when user presses enter key during onboarding (#17497) 2023-01-31 08:47:55 -06:00
David Walsh
18a1beb3dd
Update overview icons for buy, send, and swap (#17492) 2023-01-31 08:47:43 -06:00
David Walsh
d057410762
New Icons: Replace instance of fa-qr-code icon (#17474)
* New Icons: Replace instance of fa-qr-code icon

* Update ui/pages/send/send-content/add-recipient/domain-input.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-01-31 08:47:23 -06:00
David Walsh
edb2c9ea00
Fix #17441 - Update all MenuItem instances to use new icons (#17468) 2023-01-31 08:47:00 -06:00
David Walsh
ff843c1b10
Fix #17393 - Fix NFT collection header image (#17394) 2023-01-31 08:46:40 -06:00
chloeYue
812b57dcaf
Add e2e test: add custome network during onboarding (#17436)
* e2e test add custome network during onboarding
2023-01-31 13:58:39 +01:00
Danica Shen
2958d68af8
feat(mme-17214): migrate L33 files to typescript (#17372) 2023-01-31 12:01:10 +00:00
ryanml
8a7c897a1c
Update copy when revoking setApprovalForAll (#17500) 2023-01-31 04:27:41 -07:00
ryanml
25728563c8
Merge pull request #17504 from MetaMask/master-sync
master sync following v10.24.2
2023-01-31 03:49:46 -07:00
Dan Miller
ce9bc2236d Merge remote-tracking branch 'origin/develop' into master-sync 2023-01-30 21:58:52 -03:30
Dan J Miller
fdeb1e9dc9
Merge pull request #17472 from MetaMask/Version-v10.24.2
Version v10.24.2 RC
2023-01-30 17:21:16 -08:00
David Walsh
acafe7c4c5
Update home portfolio dapp icon to new icon (#17471)
* Update home portfolio dapp icon to new icon

* Using ButtonLink component so onClick isn't used on a div

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-01-30 12:33:08 -06:00
Mark Stacey
55d8ec0572
Document displayWarning as deprecated (#17465)
The `displayWarning` action creator will show the error in various
different places in the UI. This is confusing for users, we should stop
doing this.

Instead we can consider each error case separately. If there is a
scenario where it's appropriate to tell a user about an error, we
should build that case into the relevant UI and use localized error
messages.
2023-01-30 09:37:04 -03:30
Mark Stacey
e58800952c
Ignore storybook-build lint errors (#17373)
The `storybook-build` directory is the Storybook build output. These
are generated files that we do not need to lint.
2023-01-30 09:36:52 -03:30
Guillaume Roux
82f2ba15e6
remove snap notifications when uninstalled (#17487) 2023-01-30 13:43:47 +01:00
Dan J Miller
665f22d236 Update changelog for v10.24.2: adding entry for #17432 2023-01-30 08:55:31 -03:30
Dan J Miller
a31eccd01e Fix unit tests that were removed on develop in #16862, but broken in master with #17450 2023-01-30 06:23:59 -03:30
Jyoti Puri
58b5332b67 Improving getMemoizedMetadataContractName selector (#17432) 2023-01-27 12:33:02 -07:00
Peter Yinusa
245c32a99e
Nft build for e2e tests (#17430) 2023-01-27 12:45:35 -06:00
Danica Shen
c23bd4925b
feature: convert level 32 files to typescript (#17390) 2023-01-27 18:28:03 +00:00
ryanml
62bca62273 Updating changelog 2023-01-27 11:09:23 -07:00
Dan J Miller
5f5b75832f Fix cookiejar dependency vulnerability (#17355) 2023-01-27 11:06:43 -07:00
MetaMask Bot
76ebc3318c Version v10.24.2 2023-01-27 17:40:38 +00:00
Dan J Miller
c9acbfb973 Use network provider state, instead of CurrencyRateController state, to select 'nativeCurrency' (#17450)
* Use network provider state, instead of CurrencyRateController state, select 'nativeCurrency'

* Fix unit tests

* Lint fix

* Only use the network provider ticket for the native currency when useCurrencyRateCheck is false

* Fix unit test

* Fix tests for real
2023-01-27 10:37:38 -07:00
Dan J Miller
7a77c82514
Use network provider state, instead of CurrencyRateController state, to select 'nativeCurrency' (#17450)
* Use network provider state, instead of CurrencyRateController state, select 'nativeCurrency'

* Fix unit tests

* Lint fix

* Only use the network provider ticket for the native currency when useCurrencyRateCheck is false

* Fix unit test

* Fix tests for real
2023-01-27 13:47:47 -03:30
dzfjz
abb2532a3b
[e2e]Add e2e test for deleting custom network (#17254)
* add test for deleting added custom network

* update code because of failing on firefox browser

* changing steps for adding custom network

* chage code for custom network
2023-01-27 16:50:08 +00:00
David Walsh
6ee2d07706
Fix #17362 - Ensure NFT icons are correct (#17440)
* Fix #17362 - Ensure NFT icons are correct

* Update trash icon
2023-01-27 08:32:03 -06:00
David Walsh
b21e0df4fa
Fix #17385 - Provide autohide callback for ActionMessage (#17392)
* Fix #17385 - Provide autohide callback for ActionMessage

* Add autohide to the removeal message
2023-01-27 08:31:43 -06:00
Garrett Bear
30520a3352
button link housekeeping (#16885)
* button link housekeeping

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-01-26 10:32:11 -08:00
weizman
e33b8976cd
Bump lavapack version to 5 (#17431)
* Update package.json

* update
2023-01-26 14:34:13 -03:30
Danica Shen
787add7c70
feature: convert shared/modules/contract-utils.test.js to typescript (#17435) 2023-01-26 17:59:49 +00:00
amerkadicE
ab329e5186
Refactor confirm page container component from class to functional component (#16907) 2023-01-26 11:07:17 -06:00
Mark Stacey
001ea4c951
Test parameter change cache miss (#17346)
Tests have been added to ensure that our middleware will not return a
cached response to a request with unique parameters. Each parameter
supported by each method is tested independently.

Closes #17003
2023-01-26 12:27:46 -03:30
Mark Stacey
506ee16648
Document callback-style background calls as deprecated (#17376)
We've been migrating from callback-based to async background calls for
a number of years now. The async calls are easier to read, and less
likely to be misused (especially when it comes to error handling).

The `callBackgroundMethod` method, used to make a callback-based
background call, has been marked as deprecated. Hopefully this will
discourage further use.
2023-01-26 12:27:15 -03:30
Jyoti Puri
5a493fb38e
Improving getMemoizedMetadataContractName selector (#17432) 2023-01-26 21:09:13 +05:30
Alex Miller
3e3abcafc2
[GridPlus] Bumps gridplus-sdk to v2.4.1 (#16847)
The only change relevant to MetaMask users is a fix on an ABI
decoding util that addresses an edge case that was failing to decode.
Full changes: https://github.com/GridPlus/gridplus-sdk/compare/v2.2.9...v2.4.1
2023-01-25 18:57:33 -03:30
Olusegun Akintayo
16ea4a8046
Put hardware wallets behind an HARDWARE_WALLETS_MV3 flag (#17354)
* Put hardware wallets behind an HARDWARE_WALLETS_MV3 flag
Disable Hardware connect buttons if the flag is set.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

update to metamask/eth-keyring-controller

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

revert to eth-keyring-controller v8

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

LAvamost after rebase

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

lock file.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Added toaster for removed NFTs (#17297)

* added notification for remove nfts

* reverted names for tabs

* updated default key

* updated snapshot

* updated remove nft toast to danger

Setup network controller mocks per-test (#17250)

The network controller unit test network mocks are now setup for each
test. This makes modifying network behavior on a per-test basis easier,
and makes it more clear which test relies upon which mocks.

Security provider check (OpenSea) (#16584)

chore: copy update for metamask fee on swaps (#17133)

* linter fix

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* setLedgerTransportPreference in the metamask-controller should not be called, or should return immediately, if canUseHardwareWallets() is false

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
2023-01-25 17:42:08 -03:30
Nidhi Kumari
1d1b751f62
Consolidated all component import paths (#17368) 2023-01-25 11:54:08 -08:00
Nidhi Kumari
709d0267f8
updated new links for the stories (#17369) 2023-01-25 11:51:25 -08:00
David Walsh
29d4799f46
Fix #17388 - Remove dismiss button from NFT notification (#17389) 2023-01-25 13:28:15 -06:00
Daniel
a4f968b423
Remove a notification for falling back from STX to regular swaps (#17374) 2023-01-25 20:01:10 +01:00
Garrett Bear
ed75dabe57
Feat/15086/add banner severities component (#17307)
* add banner component

* update banner styles and tests

* fix padding and update snapshot

* banner stories id removal

* update readme

* Update ui/components/component-library/banner/banner.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/banner/README.mdx

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/component-library/banner/README.mdx

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* banner updates

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-01-25 10:39:49 -08:00
Garrett Bear
23133a2735
fix icon names (#17391) 2023-01-25 23:41:13 +05:30
Mark Stacey
d2331c0e0b
Fix Playwright install step (#17415)
The Playwright install step run in the `test-storybook` job has been
updated to ensure that we are running the correct install command.
Previously we were using `yarn dlx`, which would use the latest version
of `Playwright` rather than the one currently installed. Instead now we
are using `yarn exec`, which will invoke the `playwright` binary from
the locally installed package. This binary has an `install` command
that completes the necessary setup, which is to install custom patched
browsers for Playwright to run.
2023-01-25 14:22:04 -03:30
Alex Donesky
3d87f65d9b
Fix broken NFT import and auto-detect flows (#17384)
* Fix broken NFT import and auto-detect flows
2023-01-25 10:33:06 -06:00
Brad Decker
073718d965
Convert ui/helpers/constants/common to typescript (#17348) 2023-01-25 09:47:02 -06:00
Niranjana Binoy
129a06cc12
Copy update on Transaction breakdown for ApproveToken (#17296) 2023-01-25 10:15:58 -05:00