1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 11:22:43 +02:00
Commit Graph

6405 Commits

Author SHA1 Message Date
HowardBraham
694773f17a
Upgrading the Import Account modal (#17763)
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: NidhiKJha <nidhi.kumari@consensys.net>
Co-authored-by: montelaidev <monte.lai@consensys.net>
2023-03-06 09:48:28 -08:00
Danica Shen
47d9964a89
fix(17857): show correctly converted account balance in sign&encrypt windows (#17973)
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-03-04 12:14:20 +00:00
David Walsh
5018329cd8
UX: Icon: Restore missing back chevron in settings (#17916)
* UX: Icon: Restore missing back chevron in settings

* Update ui/pages/settings/settings.component.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Fixing size and alignment

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-03-03 15:11:20 -06:00
Olusegun Akintayo
e8c92c3d5a
Edit Token Transfer displays mixed info with regular Send Tx (ETH) (#17507) 2023-03-03 10:52:32 -06:00
Vinicius Stevam
e07ec9dcf3
identify desktop is paired in the metrics event (#17892) 2023-03-02 14:55:27 -06:00
António Regadas
f9f215f20d
[MMI] Adds the MMI support link and the mmi_website link as well (#17853) 2023-03-02 10:19:20 -06:00
ryanml
6b15d0bae7
Fix incorrect balance in signature request header (#17829)
* Fix incorrect balance in signature request header

* Fix unit tests

* Fix tests and increase unit test coverage

* actually fix unit tests

---------

Co-authored-by: Dan Miller <danjm.com@gmail.com>
2023-03-02 05:40:07 -07:00
António Regadas
56cba09749
[MMI] Adds mmi build type + manifest files and images (#17842)
* MMI adds all mmi images, build type and manifest files

* build-for-all-custodians

* fix remove-fenced-code test

* no need for axios

* runs prettier

* linter

* MMI moving file out of codebase

* MMI adds locale appNameMmi

* MMI adds locale appNameMmi to verify-locale-strings
2023-03-01 09:38:15 +00:00
Alaa Hadad
5998ae21aa
Buy crypto by redirecting to onramp experience on pdapp instead of deposit popover (#17689)
* feat: disable deposit popover and replace it with global redirect to onramp on pdapp

* feat: remove legacy code for hardcoded onramp providers

* fix: remove unused visuals and components related to legacy code of deposit popover

* fix: remove unused messages

* feat: use a custom hook for all onramps related methods and variables

* fix: modify the custom hook implementation to include test networks

* fix: remove deprecated file buy-url

* fix: remove references for deleted deposit logos

* fix: network-controller failing unit test

* fix: snapshot loading-swaps-quotes-stories-metadata.test.js.snap

* fix: storybook tests

* fix: remove unused constatns related to buyable onramp chains

* fix: remove unused variables and fix eslint

* adding unit test for useRamps custom hook

* feat: add comment on the proper usage of useRamps within confirm-page-container component

* fix: add unit tests for buy button in token-overview page

* fix: add unit test for open the buy crypto URL for a buyable chain ID in token page

* feat: add unit test coverage for eth-overview page

* fix: update locales
2023-03-01 12:45:27 +04:00
Filip Sekulic
426e3c37a4
Fixed accounts auto scrolling (#17075)
* Fixed a bug

* Fixed additional bug
2023-02-28 08:23:24 -06:00
Nidhi Kumari
878bb4ab25
Ux: Icon: Update fa-eye with ICON_NAMES.EYE (#17800)
* updated fa-eye

* Fix build error

* resolved lint error

* lint error fix

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-02-28 12:55:58 +05:30
David Walsh
eb380f92ef
UX: Icon: Remove unwanted aria label (#17903) 2023-02-27 10:43:06 -06:00
David Walsh
5561987fed
UX: Icon: Stop using fa-times (#17811) 2023-02-27 10:42:02 -06:00
Frederik Bolding
63cbcc7147
Selector performance improvements (#17410)
* Stop checksumming addresses unnecesarily

* Fix lint
2023-02-27 17:33:21 +01:00
Frederik Bolding
64bfe6f307
Fix a bug where non-address types would be rendered as addresses in EIP-712 (#17846)
* Fix EIP-712 rendering logic

* Fix tests

* Fix tests and story

* Fix lint

* Fix import

* Fix stories
2023-02-27 17:32:51 +01:00
Filip Sekulic
932282e638
What's new - OpenSea security provider (#16831) 2023-02-27 10:20:22 -06:00
David Walsh
e20c70efd5
UX: Update Settings Icon (#17561)
* UX: Update Settings Icon

* Remove font-awesome usage

* Remove from files to convert

* Fix lint
2023-02-26 20:42:03 -06:00
Niranjana Binoy
bc19856d5d
Transaction-list-item-details pop up to display the correct token information on token approve item (#17422) 2023-02-24 14:21:55 -05:00
Ariella Vu
60f257fd62
ConfirmDecryptMessage: avoid mutation of state in decryptMsg/completedTx action (#17895)
* fix ConfirmEncryptionPublicKey txData

* encrypt/decrypt: fix missing txData state

* rm console.log

* ConfirmDecryptMessage: cloneDeep to avoid mutation
2023-02-25 02:02:02 +07:00
Ariella Vu
bdf3b8486b
Fix GetEncryptionKey TypeError Cannot destructure property 'msgParams' of 'txData' (#17808)
* fix ConfirmEncryptionPublicKey txData

* encrypt/decrypt: fix missing txData state

* rm console.log
2023-02-25 01:58:42 +07:00
Nidhi Kumari
9f17e2f94b
UX Icon: updated fa-exclamation-circle (#17879) 2023-02-24 12:52:11 -06:00
Jyoti Puri
1c0ff8a6e8
Fix state in confirm transaction (#17838) 2023-02-24 22:37:26 +05:30
witmicko
d7adbb6f41
window open noopener (#17882)
* window open noopener
2023-02-24 15:27:38 +00:00
David Walsh
e3380ba3ae
UX: Icon: Remove fa-exclamation-triangle usages (#17691)
* UX: Icon: WIP: Remove fa-exclamation-triangle usages

* Swap the rest of the icons

* Fix color import

* Update ui/pages/onboarding-flow/secure-your-wallet/skip-srp-backup-popover.stories.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/pages/onboarding-flow/secure-your-wallet/skip-srp-backup-popover.stories.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/pages/onboarding-flow/secure-your-wallet/skip-srp-backup-popover.stories.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/pages/onboarding-flow/secure-your-wallet/skip-srp-backup-popover.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/app/add-network/add-network.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/ui/review-spending-cap/review-spending-cap.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Fix lint

* Fix alignment and sizes

* Use IconColor

* Update ui/components/app/custom-spending-cap/custom-spending-cap-tooltip.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/app/confirmation-warning-modal/confirmation-warning-modal.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update ui/components/app/signature-request-original/signature-request-original-warning/signature-request-original-warning.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update ui/components/ui/review-spending-cap/review-spending-cap.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update ui/pages/onboarding-flow/secure-your-wallet/skip-srp-backup-popover.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Fix imports

* Use IconColor

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-02-23 15:20:07 -06:00
David Walsh
09a170bfe2
UX: Icons: Remove icon-import (#17816)
* UX: Icons: Remove icon-import

* Add new icon
2023-02-23 15:19:23 -06:00
David Walsh
6cc46454c2
UX: Remove legacy metametrics modal (#17817)
* UX: Remove legacy metametrics modal

* Remove old localizations

* Remove dead image
2023-02-23 13:58:09 -06:00
Brad Decker
df0ca5a43f
avoid mutation of state in signTransaction action (#17772)
Co-authored-by: ryanml <ryanlanese@gmail.com>
2023-02-23 12:16:55 -06:00
João Tavares
bde74756d3
Add extension desktop UI (#17748)
* feat: add desktop enable button component

This component will be added
to the experimental page. Users
will then be able to initialize
a desktop connection

* feat: add desktop pairing page

* feat: add desktop deep-linking shared lib

* test: add initial entries to render helper

Allow specifying initialEntries for
MemoryRouter. This change will allow
testing pages that use the useParam
hook.

* feat: add desktop error page

Error page for any desktop pairing
related issue

* feat: add desktop routes to route component

* feat: add enable desktop button to experimental tab

* feat: add desktop icon when paired in dev mode

* feat: disable ledger live control when desktop enabled

* feat: register desktop error actions on ui init

* fix: add missing code fencing

* chore: remove enable desktop rpc middleware

Now that we are adding the UI
there's no need for this rpc middleware
(as it was used to test desktop background
code)

* fix: display experimental tab for desktop
2023-02-23 16:39:48 +00:00
amerkadicE
505f1f5445
Token allowance unit tests (#17019)
* Token allowance unit tests

Fix lint

Fix test

Fix token allowance unit tests

Add txData in state for token allowance unit test

Treshold bumped

Run pipeline

Treshold bumped

Treshold bumped

Treshold bumped

* Update tests

* Update tests
2023-02-23 16:57:12 +01:00
Vladimir Saric
4c598b330e
Display the address icon for the contract requesting spending cap instead of the dapp/url icon (#17858) 2023-02-23 15:54:04 +01:00
David Walsh
09c60e2038
UX: Icons: Remove IconCheck and fa-check (#17787)
* UX: Icons: Remove IconCheck and fa-check

* update jest snapshots

* Update story

* Remove dead CSS

* Update ui/components/app/account-menu/account-menu.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/app/dropdowns/network-dropdown.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/app/modals/metametrics-opt-in-modal/metametrics-opt-in-modal.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/pages/settings/networks-tab/networks-list-item/networks-list-item.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/pages/settings/networks-tab/networks-list-item/networks-list-item.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/pages/permissions-connect/redirect/permissions-redirect.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/pages/send/send-content/add-recipient/domain-input.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/pages/onboarding-flow/metametrics/metametrics.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/app/modals/transaction-confirmed/transaction-confirmed.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/app/modals/metametrics-opt-in-modal/metametrics-opt-in-modal.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Fix jest snapshots

* Update sizes of network andd account menu checks

* Fix ICON_SIZES in account menu

* Improvements

* Use IconColor

* Use IconColor

* Lint

* Update snapshots

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-02-23 07:19:28 -06:00
Filip Sekulic
2acd51af2e
Open sea security provider warning message (#17662)
* Warning message for the OpenSea security provider

* Updated snapshots

* Removed flask usage

* Covered more test cases

* Code refactor

* Fixed errors

* Code refactor

* Fixed few issues

* Covered more code with tests
2023-02-23 08:38:09 -03:00
Nidhi Kumari
6892ab2bff
updated Proptypes for IconButton (#17797) 2023-02-22 16:55:32 -06:00
Nidhi Kumari
3437d7161f
UX Icon: updated fas-question icon (#17828)
* updated fas-question icon

* removed as property from Box

* fallback prop for heading
2023-02-22 16:45:07 -06:00
George Marshall
72af5626de
Updating Icon html element to span (#17790) 2023-02-22 14:42:50 -08:00
Garrett Bear
d22522ed5d
update to add end icon support (#17776) 2023-02-22 09:42:06 -08:00
Garrett Bear
9df5f910a7
set default html elements (#17762) 2023-02-22 09:41:46 -08:00
David Walsh
eba4275467
Fix #17825 - Prevent timing conflict with NFT toast messages (#17861) 2023-02-22 11:14:47 -06:00
George Marshall
ae3cd97690
Fixing focus outline (#17863) 2023-02-22 09:14:40 -08:00
David Walsh
f57d10d857
UX: Icons: Remove unused overview icons (#17671)
* UX: Icons: Remove unused overview icons

* Add args
2023-02-22 11:13:48 -06:00
George Marshall
527387bbfe
Adding Input component and updating TextFieldBase (#17664)
* Adding Input component and updating TextField

* Exporting from index, removing as prop and updating snapshot
2023-02-21 10:35:28 -08:00
David Walsh
1b382e9f2d
Remove CancelTransaction modal (#17819)
* Remove CancelTransaction modal

* Remove old locales

* Remove dead test
2023-02-21 11:19:37 -06:00
David Walsh
1e5f9da592
MenuItem: Fix layout of menu item with subtitle (#17650) 2023-02-21 09:50:54 -06:00
David Walsh
1f9b5a2293
UX: Icons: Stop using FA in TransactionActivityLog (#17667) 2023-02-21 09:49:31 -06:00
David Walsh
2cfd0f9bbd
Ux: Icon: Improve alignment of asset list chevron (#17791)
* Ux: Icon: Improve alignment of asset list chevron

* Update jest snapshot
2023-02-21 09:49:16 -06:00
David Walsh
c312f6c2b2
UX: Icons: Remove IconWithLabel (#17815) 2023-02-21 09:45:12 -06:00
David Walsh
24e0a9030b
UX: Move Portfolio link to its own button (#17722) 2023-02-21 09:32:08 -06:00
Nidhi Kumari
123098d77a
UX Icon: Replace fa-user (#17809)
* updated fa-user

* updated color
2023-02-21 18:59:19 +05:30
ryanml
3bb36e8142
Fix currency symbol in insufficient balance warning (#17820) 2023-02-21 06:08:47 -07:00
ryanml
b7bb0f03d7
Do not display experiment settings tab when there are no settings to show (#17765) 2023-02-20 18:29:50 -07:00
David Walsh
3fa167e673
UX: Icons: Fix alignment of settings icons in full screen (#17783) 2023-02-17 09:17:34 -06:00
Ariella Vu
7d1dc7f177
Cleanup: clearTimeout on useEffect for gas estimation and prevent state update on unmounted ConfirmTransactionBase (#17804) 2023-02-17 22:11:50 +07:00
George Marshall
30bc9a923e
Part of 17670: Replace Typography with Text approve-content-card (#17753)
* Updating Typography to Text approve-content-card

* Adding h6 tags

* Update ui/components/app/approve-content-card/approve-content-card.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-02-16 18:33:35 -08:00
David Walsh
1a330dd8c6
UX: Icons: Remove lock icon (#17739)
* UX: Icons: Remove lock icon

* set icon to auto for improved alignment

* remove unused import

---------

Co-authored-by: garrettbear <gwhisten@gmail.com>
2023-02-16 15:56:26 -08:00
George Marshall
cf487b8f97
Update HelpText component (#17705)
* Updating HelpText component

* Updating logic for html element depending on children

* Adding span to story to reflect docs

* Updating reveal seed instance
2023-02-16 12:42:15 -08:00
Nidhi Kumari
33cc8d587a
NFT: Replaced all the instances of collectibles with NFTs (#17741)
* replaced all the instances of collectibles with nfts

* updated actions

* updated e2e seeder

* updated confirm Approve test

* updated test dapp change

* updated test dapp change

* nit fix

* nit fix

* updated casing and snapshots

* updated casinG

* added migrations

* updated ,igration

* updated 078.test

* updated tests for 078 migration

* updated migration

* updated 078 index.js
2023-02-17 00:53:29 +05:30
David Walsh
cf49761d71
Fix #17669 - Revise old metrics schema for Onboarding v2 (#17769) 2023-02-16 10:06:56 -06:00
Jyoti Puri
9979020252
Confirm transaction test (#17780) 2023-02-16 20:23:15 +05:30
David Walsh
74ef8e4fa4
UX: Icon: Remove Plus icon (#17666) 2023-02-16 07:26:26 -06:00
David Walsh
4dcb639652
UX: Icons: Remove usage of chevron fa- icons (#17668) 2023-02-16 07:26:14 -06:00
David Walsh
8c233b2a82
UX: Icons: Stop using fa-address-book (#17761)
* UX: Icons: Stop using fa-address-book

* Remove locale string

* Fix positioning
2023-02-16 07:26:00 -06:00
Maarten Zuidhoorn
f20d5db1e4
[FLASK] Temporarily disable JSON-RPC snap e2e test (#17778)
* Temporarily disable JSON-RPC snap e2e test

* Update outdated snapshot
2023-02-16 10:35:11 +01:00
George Marshall
f6ee35b6e3
Updating TextField component (#17732)
* Removing TextFieldBase and updating TextField and TextFieldSearch

* Removing autoFocus from MDX so it's not annoying
2023-02-15 15:43:51 -08:00
Monte Lai
cdc1bce688
SRP hold to reveal (#17232)
* refactor class to functional component

* update messages

* fix: use classnames

* feat: add hold to reveal modal

* feat: add new zendesk url for secret recovery phrase and noncustodial wallet

* update: clipboard to clear copied text after delay

* fix: remove save to csv

* feat: update styles for reveal seed page

* fix: update reveal seed snapshot

* add test to check for modal

* fix: lint

* fix: unused messages locale

* fix: use new banner component

* fix: use new button from design system

* fix: update snapshot

* fix: lint

* revert text

* fix: lint

* fix: remove --copy-only

* fix: marginBottom prop value

* fix: iconName and prop error

* --made the QR code slightly smaller so it's less likely to have a scrollbar
--updated the snapshots

* fix: error message not displaying

* SRP hold to reveal using more DS components (#17583)

* Updating to add DS components and remove CSS

* Fixing rendered html and removing some unneeded props

* fix: set block to true

---------

Co-authored-by: Monte <monte.lai@consensys.net>

* fix: add descriptions to messages

* Update ui/components/ui/export-text-container/export-text-container.component.js

fix: lint

Co-authored-by: HowardBraham <HowardBraham@users.noreply.github.com>

* fix: remove using displayWarning in requestRevealSeedWords

* fix: update test to remove displayError

* fix: update design system enums

* fix: messages descriptions

* fix: banner to banneralert

* fix: update preview

* add additional tests

* fix: use jest instead of sinon

* add test if long press isn't completed

* add test if password is wrong

---------

Co-authored-by: Howard Braham <howrad@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-02-15 10:07:33 -08:00
David Walsh
9e9f9126cc
UX: Icons: Use proper send icon on wallet and token overview pages (#17720) 2023-02-15 10:26:21 -06:00
David Walsh
fca2a3f97f
UX: Update three-dot icon for settings (#17558) 2023-02-15 08:39:46 -06:00
George Marshall
a4f33ec0ad
Updating Label component (#17731) 2023-02-15 08:29:26 -06:00
Ayush
caef0735fd
Fix #17447 (#17679) 2023-02-15 11:34:11 +07:00
George Marshall
aee1971496
Fixing prop type errors in components and tests (#17704) 2023-02-14 11:34:19 -06:00
Garrett Bear
ec870cebc6
fix broken stories and readme from TS update (#17703) 2023-02-14 11:33:04 -06:00
Ariella Vu
5752742459
Clean ConfirmTranscationPage component (#17546)
* ConfirmTransaction: rm unused metricEvent context

* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id

* ConfirmTransaction: convert to FC

* ConfirmTransaction: use const ORIGIN_METAMASK

* ConfirmTransaction: rm mapStateToProps

* ConfirmTransaction: mv confirm-transaction ducks

* ConfirmTransaction: mv getContractMethodData duck

* ConfirmTransaction: rm container file

* ConfirmTransaction: use ORIGIN_METAMASK const

* clean: rn totalUnapprovedCount -> totalUnapproved

* clean: reorder ConfirmTransaction & alphabetize

* clean: rn validTransactionId> isValidTransactionId

* clean: rn unconfirmedTransactions > unconfirmedTxs

* ConfirmationTransaction: add tests

* ConfirmTransaction: mv const

* ConfirmTransaction: update jest mock after merge

* ConfirmTransaction: fix from merge fault

* tests: update snapshot after mock-state updates
2023-02-11 22:17:12 +07:00
David Walsh
7774ee6e2f
UX: Replace all fa-bell instances with Notification icon (#17524)
* UX: Replace all fa-bell instances with Notification icon

* Fix flask comment fencing

* Fix import error
2023-02-10 19:33:11 -06:00
David Walsh
d79374189c
UX: Update fa-search icon (#17527) 2023-02-10 19:33:02 -06:00
David Walsh
c61576e33c
UX: Icons: Remove legacy connect icon (#17673) 2023-02-10 19:32:52 -06:00
David Walsh
e723de3208
UX: Icons: Remove usage of pencil icon (#17676) 2023-02-10 19:32:44 -06:00
amerkadicE
1ecf241a9f
Rename reset account settings (#17457)
* Rename reset account settings

Fix snapshot

Update snapshots

Fix e2e tests

Fix e2e tests

* Rename reset-account e2e test to clear-activity e2e test
2023-02-10 22:50:12 +01:00
Nidhi Kumari
9b0e71f27f
Updated messages/strings to replace Collectibles with NFTs (#17659)
* updated json files to use NFT

* Update locale strings

* fixed lint errors

* updated json files

* updated removeCollectibleMessage and newNftAddedMessage

* updated test for nfts
2023-02-10 21:06:58 +05:30
Dan J Miller
c3100d8fe4
Ensure simulation failure warning is shown on all networks and accounts (#17458)
* Ensure simulation failure warning is shown on all networks and accounts

* Add e2e test to cover failure warning behaviour on non-eip-1559 network

* Fix new e2e test
2023-02-10 11:45:54 -03:30
amerkadicE
208ea3013c
Make username mandatory in the edit contact screen (#17425) 2023-02-10 19:57:13 +05:30
David Walsh
50937dcfde
NFTs: Hide detail when no thumbnail available (#17693) 2023-02-10 08:05:51 -06:00
George Marshall
e269790ff4
Removing TEXT_VARIANTS in favour of TextVariant (#17674) 2023-02-09 16:09:33 -08:00
George Marshall
a5b908ccf3
Deprecating Typography component (#17672)
* Deprecating Typography component

* Fixing lint issue
2023-02-09 12:17:25 -08:00
Sam Gbafa
7aad1c9650
remove siwe feature flag (#17690)
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-10 02:05:16 +07:00
amerkadicE
0c2af508ef
Fix recent recipient order (#16346) 2023-02-09 23:15:52 +05:30
David Walsh
10be6fcfeb
UX: Update block explorer icon (#17562)
* UX: Update block explorer icon

* Removing unneeded CSS and some HTML bloat

* Removing unneeded className

* Removing unneeded CSS and reducing HTML bloat for ContractTokenValues

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-02-09 10:21:51 -06:00
EresDev
58cd3deed5
fix test of useTransactionDisplayData for different timezone (#17063)
Co-authored-by: ryanml <ryanlanese@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Fixes https://github.com/MetaMask/metamask-extension/issues/17062
2023-02-08 17:13:39 -06:00
Jyoti Puri
61a7850afc
Sanitising string on signature request pages (#17571) 2023-02-09 04:35:52 +05:30
Nidhi Kumari
3be1fc6d0c
converted collectibles files to nfts (#17658)
* converted collectibles files to nfts

* updated relative import for scss

* updated scss for pages
2023-02-08 20:04:56 +05:30
Maarten Zuidhoorn
ff85b040cb
Sort permissions based on weight (#17660) 2023-02-08 15:28:48 +01:00
Ariella Vu
b5c1de900d
Refactor ConfirmTransaction to Functional Component (#17473)
* ConfirmTransaction: rm unused metricEvent context

* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id

* ConfirmTransaction: convert to FC

* ConfirmTransaction: use const ORIGIN_METAMASK

* ConfirmTransaction: rm mapStateToProps

* ConfirmTransaction: mv confirm-transaction ducks

* ConfirmTransaction: mv getContractMethodData duck

* ConfirmTransaction: rm container file

* ConfirmTransaction: use ORIGIN_METAMASK const

* ConfirmationTransaction: add tests

* ConfirmTransaction: update jest mock after merge

* tests: update snapshot after mock-state updates
2023-02-08 18:00:25 +07:00
Matthew Walsh
92367dff79
Add desktop build type (#17592)
Implement build type inheritance.
Add CircleCI jobs for desktop build type.
2023-02-08 09:24:01 +00:00
George Marshall
b55f955243
Adding docs for layout and spacing for Icon component (#17612)
* Adding docs for layout and spacing for Icon component

* Adding close bracket
2023-02-07 10:07:50 -08:00
Thomas Huang
14efbf1eea
Collectible Unit Tests (#17632)
* Add ipfs gateway and collectible state to mock-state.json

* Add collectible-default-image test with snapshot and testids

* Add Collectible Details test, snapshot, and test-ids

* Add Collectible Options tests and test-ids

* Add Collectible Items test and test-ids.

* Add more tests to Add Collectible component

* Update Security Tab snapshot with ipfs gateway state value

* Add data-testid to Menu component for menu background

* Lint

* Bump coverage targets

* Remove commented import

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-02-07 12:06:37 -06:00
Garrett Bear
fd53de6af5
Update BannerAlert component (#17586)
* update button alert component

* update test

* rename Banner to BannerAlert

* remove old banner snapshot

* fix banner alert border left
2023-02-07 09:32:35 -08:00
Monte Lai
31afc76f9b
fix: update ledger logo (#17616) 2023-02-07 05:10:21 +08:00
Maarten Zuidhoorn
1d5030af97
Add hardcoded list of human-readable snap derivation paths (#17627)
* Add hardcoded list of human-readable snap derivation paths

* Fix formatting

* Update policies
2023-02-06 21:49:56 +01:00
Harry
b4ecc4c3f5
Disable eth_sign by default, allow users to toggle it back on (#17308)
* Added translation for eth sign toggle

* Disabled the ability to call eth_sign by default. Added ability within advanced settings to renable support for eth_sign

* Add test case for eth_sign being enabled and disabled

* Modified copy

* Moved rpc method preference to its own object within store

* Complete work on moving rpc method preference into its own object within store

* Fix with prettier

* Fix lint

* Fix a unit test

* Fix test

* Renamed function and object keys to be more intuitive

* Fix e2e test

* Enabled eth_sign through preferences fixture

* Fix lint

* Fix e2e test

Wait for the notification popup to close, leaving 2 window handles the extension and the test dapp

* Fix e2e test

* Fix unit test

Enable eth_sign method

* Lint fix

---------

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-02-06 13:17:50 -03:30
David Walsh
02d608d20c
UX: Fix token image not displaying in asset listing (#17575) 2023-02-06 08:31:19 -06:00
David Walsh
4b8aebbd5d
Prevent lint warning in ActionableMessage (#17598) 2023-02-06 08:30:02 -06:00
Maarten Zuidhoorn
8cda817f5c
Add hardcoded list of human-readable snap names (#17595)
* Add hardcoded list of human-readable snap names

* Make the text properly bold

* Small style fixes to approval screen

* Run yarn lint:fix

* Update snapshots
2023-02-06 11:05:57 +01:00
David Walsh
68ea3a7298
NFTs: Update event name for Detect NFT settings (#17597) 2023-02-03 19:19:07 -06:00
David Walsh
678ad6397b
Change COLORS reference to Color (#17599)
* Change COLORS reference to Color

* Fix lint
2023-02-03 17:47:45 -06:00
David Walsh
330cba61de
UX: Remove the IconCopy and IconCopied Components and their usages (#17530) 2023-02-03 16:06:14 -06:00
David Walsh
710b1a3fbf
UX: Update support icon (#17560) 2023-02-03 16:05:51 -06:00
Brad Decker
31897b542d
Convert actions.js to typescript (#17446) 2023-02-03 11:56:44 -06:00
Niranjana Binoy
769efc9fe3
Disable fiat conversion in Approve Screen when Show balance and token price checker is OFF (#17443) 2023-02-03 12:13:19 -05:00
Dan J Miller
0c24448037
Ensure the advanced gas modal displays a zero priority fee if that is how it is set in the transaction (#17559)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-03 12:30:49 -03:30
Danica Shen
6b076fa346
feature: convert ui/ducks/app/app.ts to typescript (#17454)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-03 08:59:07 -06:00
Dan J Miller
8fa45c5454
Fix speed up of 0 max priority fee transactions (#17547)
* Fix speed up of 0 max priority fee transactions

* Update ui/hooks/gasFeeInput/useTransactionFunction.test.js

Co-authored-by: Brad Decker <bhdecker84@gmail.com>

* Use bignumber for comparison to zero

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-03 07:57:32 -03:30
Garrett Bear
0465263d3e
update banner base component (#17582)
* update banner base component

* add description to story controls
2023-02-03 13:42:53 +05:30
Nidhi Kumari
41d3dcc8a3
updated tag icon (#17540) 2023-02-02 17:13:49 -08:00
Brad Decker
02b2d7fa42
Dead and redundant code removal (#17512) 2023-02-02 16:00:05 -06:00
Brad Decker
3fc26521d4
initialize currentLocale in the locale slice upon app start (#17579) 2023-02-02 15:24:48 -06:00
Danica Shen
f3c00c65d0
fix: fix non-critical warning in tests (#17567) 2023-02-02 20:37:53 +00:00
Danica Shen
794f3039f1
feature: migrate design-system.ts (#17518) 2023-02-02 20:15:26 +00:00
Brad Decker
deb9343ff0
Convert store.js to typescript and redux toolkit (#17508) 2023-02-02 13:32:44 -06:00
Brad Decker
85a52d49db
Convert action-queue to TypeScript (#17509) 2023-02-02 13:14:56 -06:00
vthomas13
532a10f9f5
Adding browser outdated notification (#17027)
* Adding browser outdated notification

* updating dependency

* adding unit tests for util function

* adding unit tests for selectors, lintfix

* Added Tests, refactored notification delay logic

* lint:fix

* adding test coverage for method parameter

* Update app/scripts/controllers/app-state.js

adding documentation details

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* moving declaration into test

* Update app/scripts/controllers/app-state.test.js

spacing in test file

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update jest.config.js

removing duplicate entries

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* using async submitRequestToBackground method

* removing unused import

* removing unnecessary link syntax in notification

* adding opera and edge and associated tests

* handling the undefined case in bowser.satisfies

* setOutdatedBrowserWarningLastShown try/catch

* lint:fix

* Removing try/catch and letting errors bubble up

Removing deprecated displayWarning method

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* taking out forceMetamaskUpdateState call

* excludint app-state test from mocha test suite

* Added note: Jest files should match Mocha excluded

* syntax error, lint:fix

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-02-02 13:56:41 -05:00
Brad Decker
aededb1c71
Convert confirm-tx.utils.js to typescript (#17349) 2023-02-02 12:35:05 -06:00
Nidhi Kumari
b123458a26
updated CollectibleDetail Storybook Coverage (#17351)
* updated CollectibleDetail Storybook Coverage

* updated tooltip for collectible details

* updated color of icon

* fixed lint error

* fix lint error
2023-02-02 23:56:36 +05:30
vthomas13
7ef3fa08ff
adding textfix on experimental tab (#17306) 2023-02-02 13:18:25 -05:00
Brad Decker
3f50243cef
Allow background to handle forgotten password flow (#17501) 2023-02-02 10:46:22 -06:00
Ariella Vu
33ee1e4f8c
GasDisplay: fix z-index for Confirm Approve warning (#17470)
* GasDisplay: fix z-index for warning

* GasDisplay: update z-index comment
2023-02-02 23:31:34 +07:00
Jyoti Puri
db09719e45
Move confirm-transaction/conf-tx.js to confirm-signature-request (#17408) 2023-02-02 20:22:11 +05:30
Nidhi Kumari
493ab6cbd9
remove nft toaster on first autohide (#17536) 2023-02-02 16:42:52 +05:30
ryanml
7f9977b7d2
Convert ui/store/actionConstants.js -> Typescript (#17442) 2023-02-01 22:16:59 -07:00
Vladimir Saric
308151cd49
Display a warning and gas fee component for token allowance and NFT flow when transaction is expected to fail (#17437)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-02-01 17:14:09 -06:00
Garrett Bear
b0ed6be77a
remove unused banner base proptype (#17531) 2023-02-01 13:44:57 -08:00
Brad Decker
0885c6cd1f
prefer locale slice for locale state (#17499) 2023-02-01 11:53:35 -06:00
David Walsh
03d8ee5eae
Onboarding V2: Remove old onboarding flow (#17081) 2023-02-01 09:28:09 -06:00
Jyoti Puri
8fd65a698e
Fix build (#17538) 2023-02-01 19:07:15 +05:30
Garrett Bear
db0492e042
fix button text props (#17478)
* fix button text props

* fix textProps size from being overriden

* Update ui/components/component-library/button-link/button-link.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-02-01 13:25:46 +05:30
Jyoti Puri
26222a9b27
Refactoring confirm-transaction-base component (#17484) 2023-02-01 11:24:41 +05:30
Jyoti Puri
80fb59f0a0
Refactor conf-tx.js (#17380) 2023-02-01 11:24:18 +05:30
ryanml
83a3ce1aa0
Fix RPC Url editing issue of existing network (#17451) 2023-01-31 18:22:47 -07:00
ryanml
5e863a297f
Adjust 'Confirm' button color on setApprovalForAll revocations (#17506) 2023-01-31 18:22:33 -07:00
Brad Decker
6e7f5c3e21
Move THEME_TYPE to new preferences.ts file (#17515) 2023-01-31 17:49:00 -06:00
David Walsh
7a29d896ad
Fix #17328 - Move NFT settings to Experimental (#17400)
* Fix #17328 - Move NFT settings to Experimental

* Don't indent second NFT setting

* Fix jest test
2023-01-31 12:50:53 -06:00
David Walsh
145cf1ec01
UX - Update all copy icons (#17445) 2023-01-31 11:00:26 -06:00
Vladimir Saric
8aa3263b82
Added navigation between multiple sign prompts and reject all sign prompts (#17093)
* Fixed navigation through multiple unapproved transactions for ERC20 tokens

* Fixed tx details activity-log currency

* Fixed e2e test failure

* Added navigation between multiple sign prompts and reject all sign prompts

* Resolving conflicts

* Creating SignatureRequestNavigation component and extracting the UI rendering part into a single component

* Fixing e2e tests and updating snapshot

* Using single component for navigation which shows both messages and transactions requests

* Fixing test-unit-jest-main

* Added more unit tests

* Fixing test-storybook

* Fixing test-storybook

---------

Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
2023-01-31 16:29:23 +01:00
David Walsh
6439d03075
Fix #17439 - Prevent event error when user presses enter key during onboarding (#17497) 2023-01-31 08:47:55 -06:00
David Walsh
18a1beb3dd
Update overview icons for buy, send, and swap (#17492) 2023-01-31 08:47:43 -06:00
David Walsh
d057410762
New Icons: Replace instance of fa-qr-code icon (#17474)
* New Icons: Replace instance of fa-qr-code icon

* Update ui/pages/send/send-content/add-recipient/domain-input.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-01-31 08:47:23 -06:00
David Walsh
edb2c9ea00
Fix #17441 - Update all MenuItem instances to use new icons (#17468) 2023-01-31 08:47:00 -06:00
David Walsh
ff843c1b10
Fix #17393 - Fix NFT collection header image (#17394) 2023-01-31 08:46:40 -06:00
Danica Shen
2958d68af8
feat(mme-17214): migrate L33 files to typescript (#17372) 2023-01-31 12:01:10 +00:00
ryanml
8a7c897a1c
Update copy when revoking setApprovalForAll (#17500) 2023-01-31 04:27:41 -07:00
David Walsh
acafe7c4c5
Update home portfolio dapp icon to new icon (#17471)
* Update home portfolio dapp icon to new icon

* Using ButtonLink component so onClick isn't used on a div

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-01-30 12:33:08 -06:00
Mark Stacey
55d8ec0572
Document displayWarning as deprecated (#17465)
The `displayWarning` action creator will show the error in various
different places in the UI. This is confusing for users, we should stop
doing this.

Instead we can consider each error case separately. If there is a
scenario where it's appropriate to tell a user about an error, we
should build that case into the relevant UI and use localized error
messages.
2023-01-30 09:37:04 -03:30
Danica Shen
c23bd4925b
feature: convert level 32 files to typescript (#17390) 2023-01-27 18:28:03 +00:00