1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 01:39:44 +01:00
Commit Graph

17764 Commits

Author SHA1 Message Date
Dan J Miller
442181de94 Log before and after each migration run (#20424)
* Log before and after each migration run

* Use loglevel
2023-08-16 14:38:30 -02:30
Dan Miller
72d20c92d6 Version v10.34.5 2023-08-16 14:29:17 -02:30
Mark Stacey
c0fd7700c8
Fix Sentry error e2e tests (#20479)
The state fixtures in the Sentry e2e tests became invalid in #20458
due to a conflict with that change (the new state properties were
missing). The state fixtures have been updated.
2023-08-16 13:34:12 -02:30
Dan J Miller
9bbabd4868
Capture app and migration version (#20458)
* Add AppMetadataController so current and previous application and migration version can be captured in sentry

* Add currentAppVersion, previousAppVersion, previousMigrationVersion, currentMigrationVersion to SENTRY_OBJECT

* Update app/scripts/controllers/app-metadata.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/controllers/app-metadata.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/controllers/app-metadata.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Fix types

* Add tests for app-metadata.test.ts

* Lint fixes

* Modify loadStateFromPersistence to return the whole versionData object, so that the migration version can be passed to the metamask-controller on instantiation

* Remove reference to implementation details in test descriptions in app/scripts/controllers/app-metadata.test.ts

* Reset all mocks afterEach in AppMetadataController

* Refactor AppMetadataController to be passed version instead of calling platform.version directly (for ease of unit testing the MetaMask Controller)

* Make maybeUpdateAppVersion and maybeUpdateMigrationVersion private, and remove unit tests of those specific functions

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-16 12:22:38 -02:30
Mark Stacey
a6ef7bb244
Add additional Sentry E2E tests (#20425)
* Reorganize Sentry error e2e tests

The tests have been reorganized into different describe blocks. Each
describe block is for either before or after initialization, and either
with or without opting into metrics.

This was done to simplify later test additions. The conditions for each
test are now in the describe block, letting us test additional things
in each of these conditions. The conditions were flattened to a single
level to avoid excessive indentation.

* Add error e2e test for background and UI errors

The Sentry e2e tests before initialization only tested background
errors, and the after initialization tests only tested UI errors. Now
both types of errors are tested in both scenarios.

* Add error e2e tests for Sentry error state

E2E tests have been added to test the state object sent along with each
Sentry error.

At the moment this object is empty in some circumstances, but this will
change in later PRs.

* Rename throw test error function

* Only setup debug/test state hooks in dev/test builds

The state hooks used for debugging and testing are now only included in
dev or test builds. The function name was updated and given a JSDoc
description to explain this more clearly as well.

* Add state snapshot assertions

State snapshot assertions have been added to the e2e error tests. These
snapshots will be very useful in reviewing a few PRs that will follow
this one.

We might decide to remove these snapshots after this set of Sentry
refactors, as they might be more work to maintain than they're worth.
But they will be useful at least in the short-term.

The login step has been removed from a few tests because it introduced
indeterminacy (the login process continued asynchronously after the
login, and sometimes was not finished when the error was triggered).

* Ensure login page has rendered during setup

This fixes an intermittent failure on Firefox

* Format snapshots with prettier before writing them

* Use defined set of date fields rather than infering from name

* Remove waits for error screen

The error screen only appears after a long timeout, and it doesn't
affect the next test steps at all.
2023-08-16 11:52:25 -02:30
Mark Stacey
9e302ea84e
Update protobufjs (#20469)
Update `protobufjs` to the latest version. This resolves a security
advisory for this package. The advisory is concerning prototype
pollution, so it likely never affected us due to LavaMoat protections.
2023-08-16 08:33:18 -02:30
Michele Esposito
42d05ef9cd
Use addNewAccount from core KeyringController (#19814)
* refactor: use addNewAccount from core KeyringController

* refactor: replace missed interaction

* refactor: select account only when is new

* refactor: use getAccounts to check if account is new
2023-08-16 11:19:41 +02:00
Bowen Sanders
fed047f88b
[FLASK] Create new E2E test for snaps lifecycle-hooks (#20352) 2023-08-16 11:18:41 +02:00
Pritam Dhara
6512cacec8
Replaced ActionableMessage in confirm-page-container-content (#20417)
* Replaced ActionableMessage in confirm-page-container-content

* Updated Snapshot of confirm-transaction-base

* Updated BannerAlert className

* Using component API and replacing ErrorMessage

* Update snapshot

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-15 14:59:29 -07:00
jainex
cde910faec
Replacing deprecated components in ConfirmationWarningModal (#20416)
* Replacing deprecated components in ConfirmationWarningModal

* Layout and semantic html updates to align with design system conventions

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-15 14:57:34 -07:00
Dan J Miller
d368f517e2
Log before and after each migration run (#20424)
* Log before and after each migration run

* Use loglevel
2023-08-15 19:19:48 -02:30
Dhruv
73add90685
fix/AvatarFavicon to TS (#20430)
* AvatarFavicon to TS

* documentation updates

* fix types import

* Some doc updates

---------

Co-authored-by: Garrett Bear <gwhisten@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-15 14:35:18 -07:00
Harsh Shukla
b8475f85d4
Part of #17670 for: privacy-settings.js (#20288)
* Update privacy-settings.js

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update privacy-settings.js

* Update index.scss

* Update to html nesting and semantic fix

* lint fix

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-15 14:05:04 -07:00
George Marshall
19de95dba3
Updating props to optional and providing defaults (#20448) 2023-08-15 09:38:36 -07:00
Bhavya gor
b0fcb12b99
Update BannerAlert icon to match Figma Issue#20355 (#20407)
* changed warning --> danger

* snapshot updates

* Adding comment

* Updating snapshot

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-15 08:20:02 -07:00
Dan J Miller
0ca4a3c457
Fix bad changelog entry for v10.34.1 (#20445) 2023-08-15 07:16:13 -02:30
Frederik Bolding
260962402b
snaps@1.0.0 (#20450) 2023-08-15 09:38:38 +02:00
Dhruv
63d67f3d2f
replacing deprecated Box component and updating story (#20301)
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-08-14 16:07:45 -07:00
Dhruv
7c2f7671b0
ButtonSecondary to TS (#20411)
* ButtonSecondary to TS

* updating components and addressing errors

* lint and snapshot updates

* using Boolean conversion for className

* removing ValidButtonTag type

* fix text color when link

---------

Co-authored-by: garrettbear <gwhisten@gmail.com>
2023-08-14 15:13:15 -07:00
Dhruv
e31c933869
updating SnapSettingsCard (#20296)
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-14 13:25:41 -07:00
Frederik Bolding
e0a6435f62
Bump SES to fix audit failure (#20434)
* Bump SES to fix audit failure

* Freeze Symbol
2023-08-14 16:30:34 -02:30
David Walsh
712a62ed74
UX: Remove unwanted extra spacing on home screen (#20441)
Co-authored-by: Victor Thomas <10986371+vthomas13@users.noreply.github.com>
2023-08-14 11:53:11 -05:00
Ariella Vu
136ede5d4c
Add Blockaid / PPOM Failed Request Security Alert (#20362)
* WIP blockaid: add request failed UI
- proposed to update reason value. planning to update upon update

* alphabetize

* BlockaidBannerAlert: update tkeys based on reason

* SecurityProviderBannerAlert: fix footer alignment

* BlockaidBannerAlert: rm footer w failed resultType

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
2023-08-14 18:38:03 +02:00
Dan J Miller
e9fbf8591f
Merge pull request #20403 from MetaMask/master-sync
Master sync PR following v10.34.3 and v10.34.4
2023-08-14 14:00:46 -02:30
Dan J Miller
f8187c2538
Fix opening of speedup popover in activity list (in the popup view) (#20205)
* Set height of activity-list-item rightContent to Blocksize.min, so that the element doesn't overlap buttons

* Fix unit test

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-08-14 13:55:41 -02:30
Jyoti Puri
2550eaa9ac
PPOM dependency updates (#20342) 2023-08-14 21:48:40 +05:30
David Walsh
ee4bf2d264
Fix #19829: UX: Multichain: Move "Import Tokens" to Modal (#19553)
* Move Import Tokens to Modal

* Better dimensions for long token name

* Add padding above tabs
2023-08-14 11:08:59 -05:00
Michele Esposito
d6eecf8584
Use createNewVaultAndRestore from core KeyringController (#19816)
* refactor: use createNewVaultAndRestore from core kc

* test: use createNewVaultAndRestore from core

* refactor: apply @mcmire suggestion

* fix: mnemonic conversion
2023-08-14 17:23:28 +02:00
Danyal Prout
d28f699c57
Specify that Base is a multilayer network (#20097) 2023-08-14 12:22:02 -03:00
Dan J Miller
bd37b30cda Merge origin/develop into master-sync 2023-08-14 12:34:43 -02:30
David Walsh
f69180c174
UX: Remove unwanted spacing from last NFT collection (#20442) 2023-08-14 09:52:52 -05:00
David Walsh
ae76364c17
Create What's New storybook item (#20392)
* Create What's New storybook item

* Remove unnecessary button type attribute

* Remove unneccessary provider from story
2023-08-14 08:27:12 -05:00
Dan J Miller
14486a8a80
Merge pull request #20418 from MetaMask/Version-v10.34.4
v10.34.4
2023-08-07 10:18:12 -02:30
Dan J Miller
0c8bd0ce4a
Update CHANGELOG.md
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-08-07 09:38:47 -02:30
Dan J Miller
ce0fd8069e Update changelog for v10.34.4 2023-08-07 09:34:56 -02:30
Frederik Bolding
9fdf2f0076 [FLASK] snaps@0.38.1-flask.1 (#20420) 2023-08-07 09:22:56 -02:30
Frederik Bolding
e02f5972be
[FLASK] snaps@0.38.1-flask.1 (#20420) 2023-08-07 13:46:05 +02:00
Dan Miller
15bf697538 Version v10.34.4 2023-08-06 20:42:30 -02:30
David Walsh
8c953d2d5b
Fix #20184 - Prevent overflow within the activity list (#20188)
* Fix #20184 - Prevent overflow within the activity list

* removing inline style, updating snap

---------

Co-authored-by: Victor Thomas <10986371+vthomas13@users.noreply.github.com>
2023-08-05 12:11:27 -04:00
Garrett Bear
70a13296c9
Feat/18889/update buttonlink ts (#20372)
* fix buttonlink alignment

* ButtonLink TS migration

* fix lint

* remove ButtonBase loading error feat

* move padding 0 to ButtonBase

* fix color issue

* fix test file

* fix snapshot

* Update ui/components/component-library/button-link/README.mdx

Co-authored-by: George Marshall <george.marshall@consensys.net>

* readme fix

* Update ui/components/component-library/button-link/button-link.stories.tsx

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-04 14:00:05 -07:00
David Walsh
91f6545c09
UX: Remove the 'Source' and 'Link' URLs from NFT detail (#20248) 2023-08-04 13:28:34 -05:00
Dominik Rudzki
29ad914dc9
Fix #19882 - MetaMask support link alignment v2 (#20354)
* Fix support link alignment

* Fix lint issues

* Fix workflows

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-08-04 13:26:50 -05:00
jainex
798a9b0e60
migration of Popover to use TS Box version (#20279)
* migration of Popover to use TS Box version

* fix lint error

* Updating docs

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-04 11:11:32 -07:00
Garrett Bear
3915482edb
ButtonPrimary to TS (#20390)
* ButtonPrimary to TS

* button primary to ts updates

* fixes
2023-08-04 10:45:55 -07:00
Nidhi Kumari
90adb4617b
UX Multichain: Fixed fiat and eth value in Account List Menu (#20334)
* swapped fiat and eth valu

* updated e2e test for account list and token value

* updated fixture
2023-08-04 13:29:23 -04:00
Victor Thomas
2ff289e271
Add Opt-out Settings toggle for 4byte contract method names resolution (#20098)
* Adding 4byte toggle to settings UI and preferences

* Adding 4byte toggle to advanced settings tab

* adding use4ByteResolution privacy logic to getContractMethodData & getMethodDataAsync, removing unused useMethodData hook, adding clearKnownMethodData

* add 4byte setting to onboarding advanced option

* more test changes

* adding e2e for 4byte setting toggle

* test and copy changes, snap updates

* removing 4byte from advanced section

* adding settings constant and fixing refs

* removing clearKnownMethodData, adding flag to selector, test fixes

* e2e refactor, selectors refactor

* adding tests

* Fix jest tests, remove unwanted forceUpdateMetamaskState

* Fix jest tests

* lint:fix

* settingsRefs fixes

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-08-04 13:28:37 -04:00
Dhruv
658ceb90d1
Fix-Migrate Picker-Network to TS (#20365)
* migrating PickerNetwork to TS

* deleting js file

* deleting js snapshot

* fixing e2e tests and updating snapshot

* updating snapshot

* Some small updates to docs and types

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-08-04 10:11:55 -07:00
Pritam Dhara
8c2e85bb8e
Replaced ActionableMessage component in srp-input (#20111)
* Replaced ActionableMessage component in srp-input

* Modified value of Severity in srp-input/BannerAler

* fixed lint error

* Updateddata-testid in banner and test/e2e/helpers.js

* Updated className with prefix

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-04 08:42:28 -07:00
David Walsh
fee1606fad
Fix #20305 - Show the network name in Delete Network modal (#20309)
* Fix #20305 - Show the network name in Delete Network modal

* Update app/_locales/en/messages.json

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Add unit test

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-04 09:48:12 -05:00
Danica Shen
a85a4cf97e
feat(878): add new incomingTxn component and change styles of settings (#20374)
* feat(878): add new incomingTxn component and change styles of settings

* feat(878): relocate openSea tab from rebase regression

* feat(878): make UI and test modifications

* feat(878): transfer to ts

* feat(878): rename network-toggle.tsx
2023-08-04 12:33:47 +01:00