Akintayo A. Olusegun
df69d2e5a8
Merge pull request #12019 from MetaMask/dev-olu-11148
...
Fix for: Confirmation screen should show local nicknames even when invoking a contract method
2021-09-08 20:45:04 +04:00
jpuri
ec9b94ccfe
Fix padding at bottom of custom network form in popup view
2021-09-08 21:10:15 +05:30
Etienne Dusseault
09e79f273a
fix state problems with Storybook ( #11984 )
...
* fix state problems with Storybook
* lint
* lint
* Cleanup
Co-authored-by: ryanml <ryanlanese@gmail.com>
2021-09-07 13:51:41 -10:00
Akintayo A. Olusegun
0339a8715b
Refactor contact name code using ternary operator.
...
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2021-09-08 02:52:42 +04:00
Akintayo A. Olusegun
1ad80f0ae8
Use variable to check if should display dialog and display dialog
...
inline.
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2021-09-08 02:40:47 +04:00
ryanml
17fe978c82
Adding usage instructions for Ledger Live users to confirmation screen ( #12020 )
...
* Adding usage instructions for Ledger Live users to confirmation screen
* Using design system components
* Hiding first step on Firefox
2021-09-07 14:46:15 -07:00
Akintayo A. Olusegun
409bb00748
Separate container from component as per https://github.com/MetaMask/metamask-extension/pull/12019#discussion_r703804969
...
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2021-09-08 01:12:56 +04:00
ryanml
449da1d095
Improving warning text for eth_sign ( #12013 )
...
* Improving warning text for eth_sign
* Copy update
2021-09-06 10:28:34 -07:00
Akintayo A. Olusegun
d78855cb3d
Fix for: Confirmation screen should show local nicknames even when invoking a contract method #11148
...
1. Display the new address detected dialog if the contract is not in the address book
2. Use the address book if exists, else use the default.
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2021-09-05 16:16:18 +00:00
Elliot Winkler
49e1abc374
Sort contacts alphabetically ( #11982 )
...
* Sort contacts alphabetically
Contacts are grouped together by letter, and the groups are listed
alphabetically, but the contacts in each group are not sorted
alphabetically themselves.
Fixes #10318 .
* Improve tests to be less brittle
* Remove this matcher
* Revert this file
* Also don't need this change anymore
* Don't need this data attribute either
2021-09-03 12:31:12 -07:00
Alex Donesky
7a8f65d642
fix import account page layout ( #11944 )
...
* fix import account page layout
* cleanup
2021-09-03 10:56:43 -05:00
Alex Donesky
dcebf49032
fix contact settings layout issues ( #11967 )
2021-09-03 10:54:20 -05:00
Alex Donesky
3358ac2c1f
send user to account page upon adding a custom network ( #11945 )
2021-09-03 10:52:37 -05:00
Alex Donesky
e8ab578ed0
bump @metamask/controllers to v15.0.2 and remove AbortController workaround in e2e tests ( #11988 )
...
* bump @metamask/controllers to v15.0.1 and remove AbortController workaround in e2e tests
* remove old abortcontroller polyfill
* bump @metamask/controllers to v15.0.2
2021-09-03 09:34:21 -05:00
ryanml
cce623f5b6
Fixing horizontal line for gas recommendations ( #11890 )
...
* Fixing horizontal line for gas recommendations
* Unify browser differences between Chrome and FF
* Remove duplicate style
* Remove browser hacks
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
2021-09-02 10:12:47 -07:00
Akintayo A. Olusegun
aba396870a
Update copy in dapp suggested gas fee tooltip to: "Edit to use MetaMask's recommended gas fee based on the latest block." #11952 ( #11986 )
...
* Change the [domain] suggested gas fee (i) to Estimated gas fee (i)
Change that line's color from orange to black
Under that line, add Site suggested in italics in gray.
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
* liinter fixes.
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2021-09-01 11:02:01 -07:00
Dan J Miller
a4c0133bc5
1559 ledger ( #11951 )
...
* EIP-1559 - Provide support for Ledger
* Update ui/selectors/selectors.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Add shared constants for hw types
* bump eth-ledger-bridge-keyring to v0.7.0
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Alex <adonesky@gmail.com>
2021-09-01 11:25:06 -05:00
Etienne Dusseault
48c5c07ded
send-content ( #11962 )
2021-08-30 13:05:02 -10:00
Etienne Dusseault
9f0f729c5b
token-placeholder ( #11961 )
2021-08-30 13:04:24 -10:00
Etienne Dusseault
8875e9a49c
token-search ( #11960 )
2021-08-30 13:04:05 -10:00
Etienne Dusseault
1a0276fc6e
gas-fee-display ( #11959 )
2021-08-30 13:03:47 -10:00
Etienne Dusseault
1c2d9e5c9c
add-token ( #11957 )
2021-08-30 13:02:55 -10:00
Etienne Dusseault
616016a1f6
account-list-item ( #11956 )
2021-08-30 13:02:39 -10:00
Etienne Dusseault
4426104fc7
unlock-page ( #11955 )
2021-08-30 13:02:23 -10:00
Etienne Dusseault
9f10fe8c97
swaps-gas-customization ( #11938 )
2021-08-30 13:01:59 -10:00
Etienne Dusseault
8d22dc4470
import token ( #11657 )
2021-08-30 13:00:47 -10:00
Etienne Dusseault
28708e3a2e
Add first time flow components to Storybook ( #11655 )
...
* end of first time flow
* metametrics first time flow
* select-action
* welcome
2021-08-30 12:59:56 -10:00
Etienne Dusseault
0a472a440a
create-password ( #11646 )
2021-08-30 12:59:20 -10:00
Etienne Dusseault
2de9628865
Add mobile-sync component to Storybook ( #11645 )
...
* mobile sync
* lintfix
2021-08-30 12:58:58 -10:00
Etienne Dusseault
57a5e4528b
Add permissions-connect component to Storybook ( #11644 )
...
* add metadata
* fix image path for storybook
* fix lint
* separate components
2021-08-30 12:58:21 -10:00
Etienne Dusseault
2ca7f066e3
Add new-account component to Storybook ( #11638 )
...
* add action
* lintfix
2021-08-30 12:57:39 -10:00
Etienne Dusseault
7d0d6013af
Add connected-accounts component to Storybook ( #11637 )
...
* name change
* add actions
* lintfix
2021-08-30 12:56:34 -10:00
Etienne Dusseault
7b4aac7755
Add connected-sites component to Storybook ( #11415 )
...
* connectd-sites
* fix image path for storybook
* lintfixd, namechange
2021-08-30 12:56:03 -10:00
Etienne Dusseault
2996163770
Add confirm-send-token component to Storybook ( #11399 )
...
* fix image path for storybook
* confirm-send-token-component
* lintfix
2021-08-30 12:55:08 -10:00
Etienne Dusseault
cd3447995b
confirm-transaction-base ( #11396 )
...
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
2021-08-30 12:54:21 -10:00
Etienne Dusseault
a77368be34
Add confirm-send-ether component to Storybook ( #11395 )
...
* confirm-send-ether
* fix conflict
* lintfix
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
2021-08-30 12:53:41 -10:00
Austin Akers
6875d15e5f
disabled spell-check on ens input
2021-08-28 19:16:19 -07:00
Austin Akers
a690cd618c
fixed scrolling issue with many accounts
2021-08-28 17:46:00 -07:00
ryanml
58f9299df2
Guarding against null keyring (Hardware Wallet Selectors) ( #11893 )
2021-08-27 08:46:56 -07:00
Alex Donesky
9b6acb7370
Use higher gasfees when attempting to speedup or cancel a transaction ( #11936 )
2021-08-25 16:04:18 -07:00
ryanml
9c675ec033
Temporarily Disabling Mobile Sync ( #11931 )
2021-08-25 11:54:23 -07:00
ryanml
b20a77b255
Updating decimal precision to 9 (getRoundedGasPrice) ( #11930 )
2021-08-25 11:09:39 -07:00
ryanml
b021c35f7b
Fixing error handling for publish() (MobileSync) ( #11909 )
2021-08-25 09:16:12 -07:00
ryanml
dc3e74a66a
Localize import account warning messages ( #11910 )
2021-08-25 09:14:42 -07:00
ryanml
472cf17bda
Adding UI helpers for URL parsing ( #11899 )
2021-08-24 15:28:16 -07:00
Elliot Winkler
0d63aa0402
Update header on Send page to be more accurate ( #11895 )
...
Change "Add Recipient" to "Send to".
2021-08-20 09:44:41 -06:00
ryanml
a4360e7201
Adding subtitles for additional languages (SRP Video) ( #11849 )
...
Adding support for: Spanish, Hindi, Indonesian, Japanese, Korean, Portuguese, Russian, Tagalog, and Vietnamese
2021-08-18 09:09:11 -07:00
Dan J Miller
05fa7961f1
Dont default gas limit in gas popover when non is available on transaction params ( #11872 )
...
* Dont default gas limit when non is available on transaction params
* Fix unit tests
2021-08-18 02:54:53 -07:00
ryanml
d1d6f0531e
Fix content cutoff issue (Mobile Sync View ( #11871 )
2021-08-18 02:12:07 -07:00
Dan Finlay
932474127e
Increase saliency of mobile sync warning ( #11862 )
...
* Increase warning saliency of qr sync
* Remove duplciate locale entries
* Revise wording per Antonela feedback
* Avoid all caps
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
2021-08-17 18:19:09 -07:00
Dan J Miller
29487ef277
Allow submission of transactions with dapp suggested gas fees, while estimates are loading ( #11858 )
...
* Allow submission of transactions with dapp suggested gas fees, while estimates are loading
* Allow editing of transactions with dapp suggested feeds, while estimates are still loading
* Ensure that advanced gas is always editible inline when gas is loading
* Ensure that insufficient balance error is shown when gas is loading if the user has customized the gas
* Only set gas price insufficient errors if the current network is non-eip-1559, or the txparams actually have a gas price
* Remove unnecessary param
* lint fix
* ensure insufficient balance warning is showing when loading
* Ensure that eip1559 network transactions do not combined eip1559 and non-eip1559 gas fee properties
* Lint fix
2021-08-17 17:38:13 -02:30
Dan J Miller
84036aacb6
Allow advanced inline gas editing when there is an estimates unavailable error ( #11859 )
2021-08-17 16:55:26 -02:30
Etienne Dusseault
46c4cc1966
Add confirm-add-suggested-token & confirm-add-token components to Storybook ( #11175 )
...
* add suggessted token
* lintfix
* lintfix
* silence use effect warning
* download token icons and use paths to avoid web urls
* lintifx
* Add confirm-add-token component to Storyboard (#11195 )
* create story for add token
* change code
* add confirm add token story
* lintfix
* Update confirm-add-token.component.js
* Update confirm-add-token.component.js
* different token list for confirm add token
* lintfix
* Update confirm-add-suggested-token.component.js
* remove bnb png
* remove redundant images and fix storybook image path
2021-08-17 00:33:46 -05:00
Etienne Dusseault
71a9fe2ed1
Add confirm-token-transaction-base component to Storybook ( #11414 )
...
* confirm-token-transaction-base
* Update ui/pages/confirm-token-transaction-base/confirm-token-transaction-base.stories.js
Co-authored-by: Brad Decker <git@braddecker.dev>
Co-authored-by: Brad Decker <git@braddecker.dev>
2021-08-17 00:33:32 -05:00
Etienne Dusseault
435b663f5f
awaiting signature ( #11656 )
2021-08-17 00:30:58 -05:00
Dan J Miller
ae247ea14a
Improve flashing behaviour for loading gas estimates (on confirm screen) ( #11852 )
...
* Improve flashing behaviour for loading gas estimates
* Fix typo
* renderHeartBeatIfInTest
2021-08-16 20:18:24 -02:30
Dan J Miller
b919884c6e
Allow editing custom gas while estimate is loading ( #11853 )
2021-08-16 20:15:55 -02:30
David Walsh
01fd2a609e
Gas Timing with Negative attitude should be bold with tooltip ( #11772 )
2021-08-14 17:46:55 -05:00
David Walsh
b5baa6c1d1
EIP-1559 - Update tooltip text for gas fees ( #11805 )
2021-08-13 19:13:21 -05:00
David Walsh
df84a6efa6
Keep radio group contained and equal width ( #11771 )
2021-08-13 19:13:10 -05:00
ryanml
1837397202
Fixing persisting error message from MobileSyncPage ( #11835 )
2021-08-13 12:59:06 -07:00
Alex Donesky
a073e0bb7e
Add low/medium/high gas recommendations to the speedup/cancel gas popovers ( #11818 )
2021-08-13 11:36:45 -05:00
Daniel
410c4aec9a
Fix Insufficient number of substitutions for key "swapYourTokenBalance" ( #11833 )
...
* Fix Insufficient number of substitutions for key "swapYourTokenBalance"
* Use an empty string if there is no default symbol
* Add ? after SWAPS_CHAINID_DEFAULT_TOKEN_MAP[chainId]
2021-08-13 08:26:42 -07:00
ryanml
38b581cdfa
Return an empty string when date is not provided [Date display utils] ( #11831 )
2021-08-13 08:22:12 -07:00
ryanml
428b86fcf3
Hardening clipboardData handling in EnsInput ( #11822 )
2021-08-12 15:30:07 -07:00
David Walsh
e0692db7ba
Remove unwanted console.log from codebase ( #11820 )
2021-08-12 08:13:51 -05:00
ryanml
e57a2da647
Adjusting Max Fee label in EditGasDisplay per designs ( #11796 )
2021-08-10 15:36:35 -07:00
David Walsh
00572f5910
Correct the vertical margins on the RadioGroup component ( #11769 )
2021-08-10 16:56:16 -05:00
David Walsh
da79ac382e
Autofocus the unit fiend in send screen ( #11795 )
2021-08-10 16:56:07 -05:00
ryanml
504e74fbed
Fixing EditGasDisplay console errors ( #11797 )
2021-08-10 13:45:09 -07:00
David Walsh
2bb1c1a61d
Selected radio group label should be black ( #11770 )
2021-08-10 09:25:07 -05:00
Dan J Miller
e6543a83ef
Ensure transaction activity log supports EIP-1559 ( #11794 )
...
* Ensure transaction activity log supports EIP-1559
* unit test fix
* Add estimated base fee to swaps txMeta
* fix lint and tests
* Improve activity log copy
2021-08-06 19:48:53 -02:30
Alex Donesky
1216dc95c0
Hide gasTiming on edit-gas-popover when form is in error ( #11792 )
...
* Hide gasTiming on edit-gas-popover when form is in error
* Show unknown processing error if maxFeePerGas is too low for network conditions
* remove unnecessary change
* remove unnecessary function wrapper
2021-08-06 16:37:18 -05:00
Dan J Miller
bfde5a1d77
Fixes updates on the confirm screen. ( #11788 )
...
* Fixes updates on the confirm screen.
* Better handling of internal send transactions
* maxFee -> maxFeePerGas property name fix
* Remove redundant setEstimateToUse call in onManualChange
* Fix unit tests
* rebase error fix
* Fixes to speedup loading and transaction breakdown priority fee
* Fix lint and unit tests
* Ensure gas price based transaction that have been customized (e.g. speed up and retry) are properly initialized in useGasFeeInputs
* Clean up
* Link fix
2021-08-06 14:31:30 -05:00
David Walsh
1b1d039310
EIP-1559 - Ensure form always displays when there are errors ( #11787 )
2021-08-05 20:25:23 -05:00
Alex Donesky
751534e665
fix confirm transaction details to match spec ( #11779 )
2021-08-05 20:07:04 -05:00
David Walsh
a0bd496d56
Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly ( #11781 )
2021-08-05 18:59:58 -05:00
Alex Donesky
804fefcd36
Separate out non blocking gas errors ( #11783 )
2021-08-05 17:53:48 -05:00
Alex Donesky
f9378b3aa2
Add fee level education button to swaps edit gas popover ( #11785 )
2021-08-05 17:10:04 -05:00
David Walsh
d5033249a2
Fix NumericInput proptype error ( #11773 )
2021-08-05 16:52:45 -05:00
Dan J Miller
e9ef3b168a
Allow max fee to be equal to max priority fee ( #11778 )
2021-08-05 14:15:02 -02:30
Dan J Miller
0cf5019486
Use bignumber for number comparisons in useGasFeeInput ( #11776 )
...
* Use bignumber for number comparisons in useGasFeeInput
* fix
2021-08-05 13:52:56 -02:30
Dan J Miller
01262d33a4
Ensure that gas fee inputs fallback to tx params values if api is down ( #11775 )
...
* Ensure that gas fee inputs fallback to tx params values if down
* ensure getGasFeeEstimate fallback is a string
2021-08-05 08:33:49 -02:30
Dan J Miller
9fcd93191b
Ensure that gas fee minimum errors show when api is down ( #11767 )
...
* Fix legacy unapproved tx handling
* clean up
2021-08-04 20:14:20 -02:30
Dan J Miller
818dc13019
Fix legacy unapproved tx handling ( #11766 )
2021-08-04 19:53:15 -02:30
Alex Donesky
4245dac8d9
tiny lost code change from 9.8.4 RC ( #11764 )
2021-08-04 17:10:29 -05:00
David Walsh
e1de6e19af
EIP-1559 - Fix mislabeled MaxPriority fee key ( #11758 )
2021-08-04 17:07:17 -05:00
Alex Donesky
d359429f04
Stop GasFeeController polling when pop closes ( #11746 )
...
* Stop GasFeeController polling when pop closes
* Stop estimate gas polling on window unload
* lint + comments
* Improve client closed logic
* lint
* Add back _beforeUnload on unmount in gas-modal-page-container
* Add full check and call onClientClosed method for notifcation environment
* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type
* remove unused method
* move controller manipulation logic from background.js to metamask-controller, disaggregate methods
* add beforeunload handling to reset gas polling tokens from root of send page
* cleanup, lint and address feedback
* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller
* mock new methods to fix tests
* final bit of cleanup + comments
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 16:53:13 -05:00
David Walsh
96a13dddb5
Provide pointer cursor for radio group buttons ( #11763 )
2021-08-04 16:37:16 -05:00
Dan J Miller
a950111a19
Show advanced options, and hide radio buttons, for advanced gas settings users ( #11751 )
...
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on
* Improve naming and copy
* lint fix
* Lint fix
2021-08-04 19:04:42 -02:30
David Walsh
aa3d1f2341
EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate ( #11759 )
2021-08-04 16:17:20 -05:00
David Walsh
f0daa28fac
EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail ( #11762 )
2021-08-04 16:16:18 -05:00
David Walsh
a3c7bae345
EIP-1559 - Remove unncessary props from AdvancedFormControls ( #11757 )
2021-08-04 16:00:46 -05:00
Dan J Miller
3f4c988018
Ensure gas fees update in popover on poll for new values ( #11760 )
2021-08-04 18:27:14 -02:30
Alex Donesky
4552a53724
remove unnecessary conversion call ( #11742 )
...
* remove unnecessary conversion call
* Pass args to GasTiming as decGwei
* lint
2021-08-04 10:54:40 -02:30
ryanml
7902e62d8f
Fixing errors in EditGasDisplay ( #11748 )
2021-08-04 10:54:07 -02:30
Dan J Miller
b9fb495c7b
Allow max priority fee to be below 1, and only require it to be greater than 0 ( #11749 )
2021-08-04 10:53:52 -02:30
Dan J Miller
61b965a8a2
Allows users to set a max priority fee below suggested, just showing a warning in that case ( #11750 )
2021-08-04 10:53:19 -02:30
Dan J Miller
1acbb39dff
Rename effective gas price field to total gas fee ( #11754 )
2021-08-04 10:52:54 -02:30
Alex Donesky
615380b76d
Remove estimate detail above advanced gas controls in non-1559 network ( #11744 )
...
* Remove estimate detail above advanced gas controls in non-1559 network
* lint
* remove gasEstimate localization text
2021-08-03 14:34:24 -05:00
