Whymarrh Whitby
b6ccd22d6c
Update ESLint shared config to v3 ( #9274 )
...
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-08-19 13:57:05 -02:30
Whymarrh Whitby
4357cda7b8
Fix no-shadow issues ( #9246 )
...
See [`no-shadow`](https://eslint.org/docs/rules/no-shadow ) for more information.
This change enables `no-shadow` and fixes the issues raised by the rule.
2020-08-18 14:06:45 -02:30
Whymarrh Whitby
bf6578c6b8
Enable guard-for-in rule ( #9000 )
2020-07-21 18:40:45 -02:30
Whymarrh Whitby
2ae4720443
Fix words ( #9038 )
2020-07-20 14:32:49 -02:30
Thomas Huang
7b2218ac6e
Clear unapprovedTxs on createNewVaultAndRestore ( #9026 )
...
Clear unapproved transactions from txStateManager.transactions on createNewVaultAndRestore
2020-07-16 18:37:56 -07:00
Whymarrh Whitby
c7fad8f400
Limit number of transactions passed outside of TransactionController ( #9010 )
...
Refs #8572
Refs #8991
This change limits the number of transactions (`txMeta`s) that are passed
outside of the `TransactionController`, resulting in shorter serialization and
deserialization times when state is moved between the background and UI
contexts.
`TransactionController#_updateMemstore`
---------------------------------------
The `currentNetworkTxList` state of the `TransactionController` is used
externally (i.e. outside of the controller) as the canonical source for
the full transaction history. Prior to this change, the method would iterate
the full transaction history and possibly return all of it.
This change limits it to `MAX_MEMSTORE_TX_LIST_SIZE` to make sure that:
1. Calls to `_updateMemstore` are fast(er)
2. Passing `currentNetworkTxList` around is fast(er)
(Shown in #8377 , `_updateMemstore`, is called _frequently_ when a transaction
is pending.)
The list is iterated backwards because it is possible that new transactions are
at the end of the list. [1]
Results
-------
In profiles before this change, with ~3k transactions locally,
`PortDuplexStream._onMessage` took up to ~4.5s to complete when the set of
transactions is included. [2]
In profiles after this change, `PortDuplexStream._onMessage` took ~90ms to
complete. [3]
Before vs. after profile screenshots:
![Profile 1][2]
![Profile 2][3]
[1]:5a3ae85b72/app/scripts/controllers/transactions/tx-state-manager.js (L172-L174)https://user-images.githubusercontent.com/1623628/87613203-36f51d80-c6e7-11ea-89bc-11a1cc2f3b1e.png
[3]:https://user-images.githubusercontent.com/1623628/87613215-3bb9d180-c6e7-11ea-8d85-aff3acbd0374.png
[8337]:https://github.com/MetaMask/metamask-extension/issues/8377
[8572]:https://github.com/MetaMask/metamask-extension/issues/8572
[8991]:https://github.com/MetaMask/metamask-extension/issues/8991
2020-07-16 17:52:41 -02:30
Erik Marks
652db3fd36
Use string network and chain IDs ( #8628 )
...
* convert network id enums to string
* stringify appropriate chain/network ids in tests
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-07-08 14:05:09 -07:00
Whymarrh Whitby
f2f70342e2
Skip adding history entry for empty txMeta diffs ( #8379 )
2020-04-22 11:09:16 +08:00
Whymarrh Whitby
18eaae2721
Update tx status tests to assert cb called ( #8371 )
2020-04-20 13:26:50 -02:30
Whymarrh Whitby
164923acd1
Export individual fns from tx-state-history-helpers ( #8370 )
2020-04-20 13:00:51 -02:30
Whymarrh Whitby
e05db747f5
Tidy up transaction-related unit tests ( #8362 )
...
Co-Authored-By: Erik Marks <25517051+rekmarks@users.noreply.github.com>
2020-04-20 12:31:00 -02:30
Whymarrh Whitby
4f3fc95d50
Update ESLint rules for test suite ( #8023 )
...
* Use @metamask/eslint-config@1.1.0
* Use eslint-plugin-mocha@6.2.2
* Mark root ESLint config as root
* Update Mocha ESLint rules with shared ESLint config
2020-02-11 13:21:13 -03:30
Whymarrh Whitby
4257858fb5
Remove extraneous console output from TransactionStateManager tests ( #7838 )
2020-01-16 08:32:02 -08:00
Whymarrh Whitby
92971d3c87
Migrate codebase to use ESM ( #7730 )
...
* Update eslint-plugin-import version
* Convert JS files to use ESM
* Update ESLint rules to check imports
* Fix test:unit:global command env
* Cleanup mock-dev script
2020-01-09 00:04:58 -03:30
Whymarrh Whitby
274a9ecf53
yarn lint --fix
2019-12-03 17:20:55 -03:30
Frankie
f6d25357db
transactions:tx-state-manager - optionally take a function as a search param ( #7078 )
2019-08-29 14:57:28 +02:00
Whymarrh Whitby
4d88e1cf86
Enable indent linting via ESLint ( #6936 )
...
* Enable indent linting via ESLint
* yarn run lint:fix
2019-07-31 10:17:11 -10:00
Akshit Kr Nagpal
d16d6f483c
Validate txParams in TransactionStateManager.addTx ( #6713 )
...
* Normalize and Validate txParams in TransactionStateManager.addTx too
* Added Tests
* Updated normalizeAndValidateParams to return the new txParams
2019-06-29 00:51:51 +02:00
Whymarrh Whitby
094e4cf555
Check for unused function arguments ( #6583 )
...
* eslint: Check for unused function arguments
* eslint: Ignore unused '_' in argument list
Also allow any number of '_' e.g., '__' or '___' which is to be used sparingly
* Remove and rename unused arguments
2019-05-08 15:51:33 -04:00
frankiebee
b30499886f
test - check that #setTxStatusRejected removes transaction from history
2018-07-10 15:35:27 -07:00
frankiebee
28c509914b
Merge branch 'develop' of https://github.com/MetaMask/metamask-extension into i#3896
2018-07-10 11:32:05 -07:00
brunobar79
4b398701c1
fix unit tests
2018-07-02 21:03:34 -04:00
brunobar79
c734e486a0
fix tests
2018-07-02 20:21:27 -04:00
brunobar79
0da41263ac
fix warning for unit tests
2018-07-02 20:12:50 -04:00
brunobar79
a8f745f9fe
eslint --fix .
2018-07-02 18:49:33 -04:00
frankiebee
94a4f99115
tests - fix cancle transaction test to better fit new behavior
2018-06-26 12:21:50 -07:00
frankiebee
7b1f57e05d
woops - remove .only
...
Co-authored-by: @jennypollack
2018-06-25 15:18:01 -07:00
frankiebee
9b92ba4c47
trandsactions - remove rejected transactions from history
2018-06-25 15:07:54 -07:00
tmashuang
13ebb0b455
Moved loose some loose test files to sub folders
2018-05-21 05:59:26 -07:00
