* origin/develop: (333 commits)
Subscribe to event fired by KeyringController on account removal (#20478)
Updating padding for 'import-token__custom-token-form' to match 'import-token__search-token' in Import Token Modal (#20661)
[MMI] Adding missing logic to handle custodian approval in token allowance (#20662)
style: fix Settings pages padding (#20674)
Fix#20648 - Show Linea ETH fiat value by default (#20672)
Fix: UnitInput too narrow for small and trailing zeroed numbers (#20666)
fix(20314): fix window.left negative value causing polifll warning (#20653)
UX: Create selector for blockie preference (#20577)
style: update Desktop App settings styles (#20676)
UX: Nit: Avoid AccountPicker props error (#20645)
Bump test-dapp to v7.1.0 (#20665)
use @blockaid/ppom_release vs @blockaid/ppom (#20669)
Use getEncryptionPublicKey from Core KeyringController (#20646)
fix/BannerTip to TS (#20538)
Declared <IconWithFallback/> as deprecated (#20656)
Bump @metamask/post-message-stream and extension-port-stream core libs (#20659)
Fix Blockaid and OpenSea BannerAlert placement for Token Allowance, Confirm Pages, SIWE, and Signature V3/V4 pages (#20530)
Use `verifySeedPhrase` from `KeyringController` (#19817)
Update network.ts (#20617)
Declared <TextField/> as deprecated (#20640)
...
* origin/develop: (302 commits)
Added deprecatation comment to menu.js file and Add deprecation notice to storybook (#20622)
deprecating NetworkDisplay in favour of PickerNetwork (#20619)
deprecating ConfirmPageContainerWarning in favour of BannerAlert (#20621)
deprecating Dialog in favour of BannerAlert (#20623)
Fixing linting issue caused by bad merge of HoldToRevealModal and the Button component library component TS migration (#20634)
Feat/18890/button ts update (#20492)
20488: Declare <Chip/> as deprecated (#20579)
fix: Remove obsolete network controller state properties (#20586)
Fix Sentry source maps (#20616)
Track snap uninstalls (#20624)
split advancedGasFee by network and erase previous options (#20576)
Part of #20163 for file ui\components\app\detected-token\detected-token-values\detected-token-values.js (#20537)
Fix account selectors when balances are missing (#20385)
fix:fix error of balance fetching when add/import an account (#20612)
fix:remove extra $ after variale in french locale (#20606)
Multichain v1 App Footer component (#20550)
Updating watch NFT page header (#20569)
Always show connected accounts permissions if they exist (#20600)
Update snaps-related copy (#20601)
Added missing bindings (#20602)
...
* fix(settings): fixed two IPFS gateway issues
- adds back in two bugfixes that were originally in #19283
- fixes#16871
- fixes#18140
- achieves 100% code coverage for /ui/pages/settings/security-tab
- removes the npm package `valid-url`, which has not been updated in 10 years
* changes after #20172 was merged
* improved URL validation (specifically spaces)
* better Jest coverage
* response to legobeat review
* fixing lint and Jest
* feat(action): github action to create bug report issue at RC cut
* feat(action): github action to close bug report issue once release is ready
* fix(action): replace main by master
* fix(action): create event does not support branch filter
* fix(action): indentation
* fix(action): actionlint erors
* fix(action): actionlint erors 2
* fix(action): actionlint erors 3
* fix(action): replace npm by yarn for consistency
* Enable Snaps feature flag in stable
* Run snaps E2Es in stable
* Fix CI config indentation
* Fix CI paths
* Update LavaMoat policies
* Update iframe URL
* Exclude some tests from running in stable e2e
* Disable another test on stable
* Bump to 1.0.1
* Fix config.yml issue due to staleness
* Stop running newly added test
* Update snapshots used for E2E
* Use shallow-git-clone
* fixed connect mmi button several issues
* Fixed snapshot
* Improved multiple things
* running yarn dedupe
* Update LavaMoat policies
* For some reason, this.mmiConfigurationController.store.mmiConfiguration?.portfolio sometimes is undefined, added [] if null.
Moved the || {} outside the find method
* minor improvements
---------
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
* Remove fallback phishing warning configuration
The package `@metamask/phishing-controller` has been updated from v4
v6. The only breaking changes are a minimum Node.js version bump, and
the removal of the fallback phishing configuration.
The fallback phishing configuration was resulting in MetaMask being
incorrectly flagged as malware, and the stale config was causing
problems for sites that had been blocked in the past but have since
been unblocked. This should substantially reduce the bundle size as
well.
* Update LavaMoat policies
* Update test state to include example blocked site
---------
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
* Remove fallback phishing warning configuration
The package `@metamask/phishing-controller` has been updated from v4
v6. The only breaking changes are a minimum Node.js version bump, and
the removal of the fallback phishing configuration.
The fallback phishing configuration was resulting in MetaMask being
incorrectly flagged as malware, and the stale config was causing
problems for sites that had been blocked in the past but have since
been unblocked. This should substantially reduce the bundle size as
well.
* Update LavaMoat policies
* Update test state to include example blocked site
---------
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
* Update phishing controller to v4.0.0
* Move phishing e2e test utilities into its own helper.js
* Update phishing detection e2e test
* Update MetaMask Controller test mocks
* Update mv3 phishing tests
* Fix test for 500 error on warning page
* Allow for directories in test folder
* Update migration number
* Linting fixes
* Remove fail on console error
* Separate mocks from helpers
* Have migration delete PhishingController state entirely
* Remove phishing detection directory
* Only delete the listState in migration
* Bump migration version
* Update phishing controller to v4.0.0
* Move phishing e2e test utilities into its own helper.js
* Update phishing detection e2e test
* Update MetaMask Controller test mocks
* Update mv3 phishing tests
* Fix test for 500 error on warning page
* Allow for directories in test folder
* Update migration number
* Linting fixes
* Remove fail on console error
* Separate mocks from helpers
* Have migration delete PhishingController state entirely
* Remove phishing detection directory
* Only delete the listState in migration
* Bump migration version
* eth_call test
* eth_chainId test
* run json rpc tests
* add ci job
* remove query string param from url
* eth_sendTransaction test
* eth_sendTransaction test
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
* devDeps: @lavamoat/allow-scripts@2.0.3->2.3.1
Note: As of right now, this causes depcheck script to fail under yarn due to a server error in NPM registry triggered by https://github.com/yarnpkg/berry/issues/4117. As can be seen in that issue, the results from this script have already been invalid since the upgrade from yarnv1 to yarnv3 and a change of package manager version or dependency-auditing script will have to be made.
* force latest version of dependency bn.js to @5.2.1
* test - fix broken standin data given to bn.js
---------
Co-authored-by: kumavis <aaron@kumavis.me>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
