Brad Decker
38fe75b7d9
prefer chainId when building block explorer urls ( #10587 )
2021-03-09 15:37:19 -06:00
Erik Marks
76a2a9bb8b
@metamask/eslint config@5.0.0 ( #10358 )
...
* @metamask/eslint-config@5.0.0
* Update eslintrc and prettierrc
* yarn lint:fix
2021-02-04 10:15:23 -08:00
David Walsh
42fd8b0ff0
Use strict equality in unit tests ( #9966 )
2020-12-03 09:46:22 -06:00
Brad Decker
a49a4a066c
expand transaction constants coverage ( #9790 )
...
* expand transaction constants coverage
* touchups
* dont import inside of e2e
* Update app/scripts/controllers/transactions/tx-state-manager.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Update test/unit/app/controllers/transactions/tx-controller-test.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-11-07 01:38:12 -06:00
Brad Decker
2ebf8756a4
[RFC] add prettier to eslint ( #8595 )
2020-11-02 17:41:28 -06:00
Erik Marks
3aaa41ef44
Replace abi-decoder with ethers ( #9290 )
...
* replace abi-decoder with ethers
* handle transaction parsing errors
* update token param getter function names
* add docstrings
2020-08-21 19:29:19 -07:00
Whymarrh Whitby
c1e3c229bc
Fix import/order issues ( #9239 )
...
See [`import/order`](https://eslint.org/docs/rules/import/order ) for more information.
This change enables `import/order` and fixes the issues raised by the rule.
2020-08-18 16:48:25 -02:30
Erik Marks
652db3fd36
Use string network and chain IDs ( #8628 )
...
* convert network id enums to string
* stringify appropriate chain/network ids in tests
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-07-08 14:05:09 -07:00
bguiz
96929d99c0
fix: handle trailing / in block explorer URLs
...
What
- modify `ui/app/helpers/utils/transactions.util.js` and
`ui/lib/account-link.js` to strip trailing slashes
if they are present.
- added relevant tests not just for the new scenario,
but also the general scenarios for these functions,
as there previously was no test coverage for these
two functions.
Why
- Current behaviour, when user enters a block explorer URL
when configuring a custom RPC, and that block explorer URL
contains a trailing `/`.
- e.g. `https://block.explorer/ `
- this results in a double-slash (`//`) in the transaction
and account URLs generated by MetaMask.
- e.g. `https://block.explorer/tx/0xabcd ...`,
`https://block.explorer/account/0xabcd ...`
- This needs to be handled using a router redirect
on the server of the block explorer,
and this changes would avoid that requirement.
2020-05-14 17:15:17 +08:00
Whymarrh Whitby
4f3fc95d50
Update ESLint rules for test suite ( #8023 )
...
* Use @metamask/eslint-config@1.1.0
* Use eslint-plugin-mocha@6.2.2
* Mark root ESLint config as root
* Update Mocha ESLint rules with shared ESLint config
2020-02-11 13:21:13 -03:30
Chi Kei Chan
31175625b4
Folder restructure ( #6304 )
...
* Remove ui/app/keychains/
* Remove ui/app/img/ (unused images)
* Move conversion-util to helpers/utils/
* Move token-util to helpers/utils/
* Move /helpers/*.js inside /helpers/utils/
* Move util tests inside /helpers/utils/
* Renameand move confirm-transaction/util.js to helpers/utils/
* Move higher-order-components to helpers/higher-order-components/
* Move infura-conversion.json to helpers/constants/
* Move all utility functions to helpers/utils/
* Move pages directory to top-level
* Move all constants to helpers/constants/
* Move metametrics inside helpers/
* Move app and root inside pages/
* Move routes inside helpers/
* Re-organize ducks/
* Move reducers to ducks/
* Move selectors inside selectors/
* Move test out of test folder
* Move action, reducer, store inside store/
* Move ui components inside ui/
* Move UI components inside ui/
* Move connected components inside components/app/
* Move i18n-helper inside helpers/
* Fix unit tests
* Fix unit test
* Move pages components
* Rename routes component
* Move reducers to ducks/index
* Fix bad path in unit test
2019-03-21 20:33:30 -02:30
