1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
Commit Graph

5857 Commits

Author SHA1 Message Date
Dan J Miller
6602e4a013
Ensure smart contract interactions are properly represented on the confirm screen (#15446)
* Ensure smart contract interactions are properly represented on the confirm screen

* Fix unit tests

* Code cleanup

* Cleanup

* Code cleanup

* Fix test
2022-08-03 17:05:34 -02:30
Brad Decker
cfe5f3a99a
add safegaurd for missing account in action (#15450)
* add safegaurd for missing account in action

* add test to cover case
2022-08-03 13:14:23 -05:00
Dan J Miller
71cc3397bf
Ensure that if max is selected in send flow, the correct value is set after network switch (#15444) 2022-08-03 14:24:35 -02:30
Hassan Malik
a7179a6b88
[FLASK] Add update snap UI (#15143)
* added snap-update folder

* addded update route, snap update component, updated permissions connect components

* added actions and selectors

* updated permissions selectors and updated permissions connect container to have update snap logic

* updated translations, added selector, updated request object

* updated translations, added update snap permission list component

* more fixes

* added CSS, redid some HTML

* lint fixes

* Add missing grantPermissions action

* updated button padding

* fixes

* removed prop type

* fix Update & Install wrapping

* made changes for forthcoming snap controller PR

* removed ununsed imports

* updated css

* re-added padding rule and removed unused translation messages

* addressed comments

* add subtext for new permissions

* lint fix

* removed unused translations

* some more changes

* fix e2e tests

* lint fix

* added in delay for e2e tests

* Revert "added in delay for e2e tests"

This reverts commit 095962a2c0c9de0b0b343d3134bb0787044dd8ce.

* fixed routing logic

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
2022-08-03 12:02:44 -04:00
ryanml
97b10f96e0
Opening Network Forms in full screen from the popup view (#15442) 2022-08-03 13:07:16 -02:30
Sam Gbafa
5802805597
Add Sign-In with Ethereum (#14438)
Co-authored-by: Gregório Granado Magalhães <greg.magalhaes@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: brad-decker <bhdecker84@gmail.com>
2022-08-03 09:56:11 -05:00
George Marshall
2e6aea412a
Moving incorrectly ordered page component to correct pages category (#15426) 2022-08-03 08:56:32 -05:00
Alex Donesky
713399cb88
add access protection to the getNativeCurrencyImage selector in case it is the source of a mysterious bug on firefox (#15425) 2022-08-02 20:06:11 -05:00
Brad Decker
ddadc79f60
remove unnecessary usage of renderableGasButton logic (#15422) 2022-08-02 16:56:35 -05:00
Filip Sekulic
ea247d4e4a
Fix 'block link explorer on custom networks' (#13870)
* Created a logic for the 'Add a block explorer URL'

Removed unused message

Message logic rollback

Modified history push operation

WIP: Pushing before rebasing

Applied requested changes

Removed unintenionally added code

* Lint fix

* Metrics fixed
2022-08-02 16:56:02 -05:00
Brad Decker
f425e482e4
fix issues relating to race conditions where draftTx does not exist (#15420)
* fix issues relating to race conditions where draftTx does not exist

* add another fail safe for inflight initializations
2022-08-02 13:52:09 -05:00
Alex Donesky
fb191c865b
Enhance approval screen title logic (#15406) 2022-08-02 13:38:15 -05:00
Dan J Miller
d484f107c0
Fix optimism send flow (#15419) 2022-08-02 15:54:24 -02:30
Guillaume Roux
9ce4a8f987
[FLASK] Fix key management permission copy (#14849) 2022-08-02 11:29:40 +02:00
Alex Donesky
fc304680d4
Fix error that occurs when attempting to display transaction value for an approval transaction with no value argument in the transaction data (#15398) 2022-08-01 11:42:58 -05:00
Jyoti Puri
bca9a61d6b
MV3: Re-activate service worker and reconnect UI streams (#14781) 2022-08-01 18:53:21 +05:30
Nidhi Kumari
194f7c8dd8
added AvatarBase Component (#15307)
* added AvatarBase Component

* added README file to storybook

* converted avatar-base to base-avatar

* props for snapshot testing

* replaced snapshot testing

* Updates to stories and component

* used arrow function for component

* fixed merge conflicts

* removed box stories

* changed import order for scss files

* replaced base-avatar import with component scss file

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2022-08-01 15:14:33 +05:30
Brad Decker
c72199a1a6
update prettier (#15360) 2022-07-31 13:26:40 -05:00
kumavis
9e7c75d06d
Bundle optimazation 0 (#14782)
* optimism/contracts - import minimal subset

* ui helpers - dont import whole of mm controllers

* lint fix
2022-07-30 03:07:29 -02:30
George Marshall
8185175968
Adding readme for component-library folder (#15381)
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-07-29 16:24:32 -05:00
Brad Decker
8e9df0457b
cast chainId to hex for metrics (#15332)
* cast chainId to hex for metrics

* Update ui/pages/settings/networks-tab/networks-form/networks-form.js

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2022-07-29 10:37:48 -05:00
Daniel
f31bac9fbf
Performance improvements for Swaps (#15359) 2022-07-28 15:56:15 +02:00
Dan J Miller
aea5c5824f
Clean up of code introduced with 43f7a44 (#15158) 2022-07-27 15:19:05 -05:00
George Marshall
6075e86838
Adjusting the height of account menu nav items to expand scroll area (#15302)
* Adjusting the height of account menu nav items to expand scroll area

* reducing font size

* Adding back max height media query
2022-07-27 12:35:52 -07:00
Brad Decker
693a6dfc0c
Remove unnecessary file extensions (#15352) 2022-07-27 14:32:17 -05:00
ryanml
c677edc51d
[FLASK] disable "Mark all as read button" when there are no notifications (#15333)
* [Flask] disable "Mark all as read button" when there are no notifications

* Adding test case

* Addressing feedback
2022-07-27 09:49:34 -07:00
Nidhi Kumari
e12d0a94e8
Updates to stories and component (#15357)
* Updates to stories and component

* removed SECONDARY color options

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2022-07-27 09:46:13 -07:00
Nidhi Kumari
2cf7cd40d0
added tx details popup to cancelled Swap (#15273)
* added tx details popup to cancelled Swap

* removed unnecessary console statements
2022-07-27 20:41:48 +05:30
Brad Decker
652d631cda
remove exclusions for mismatched object jsdoc type casing (#15351) 2022-07-27 08:28:05 -05:00
Nidhi Kumari
7424e98416
Updated all instances of "Component API" to "Props" in storybook documentation (#15324)
* replaced Component API with Props

* replaced Component API with Props in DOCUMENTATION.stories.mdx

* removed base avatar component
2022-07-27 00:22:40 +05:30
Brad Decker
1db0ee87ec
Update Eslint and deps (#15293) 2022-07-26 13:10:51 -05:00
Alex Donesky
b82d357a0d
Remove decentralized 4byte function signature registry since it contains incorrect signatures and we can't algorithmically check for best option when 4byte.directory is down (#15300)
* remove decentralized 4byte function signature registry since it is griefed and we can't algorithmically check for best option when 4byte is down

* add migration

* remove nock of on chain registry call in getMethodDataAsync test
2022-07-26 12:01:14 -05:00
Alex Donesky
8536c86ed5
Improve tokenId parsing and clean up useAssetDetails hook (#15304) 2022-07-23 09:37:31 -05:00
Hassan Malik
1f943a7d69
[FLASK] Fix snaps authorship pill (#15190)
* add truncation

* add title to show complete package name

* Remove hardcoded max-width

* truncation

* reduced max-width

* final changes

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: eriknson <eriks@mail.se>
2022-07-23 00:58:46 -04:00
Dan J Miller
101fe0b27a
Metrics adjustments (#15313)
* Don't send errors to sentry if users have not opted-in to participate in metametrics

* Don't capture opt-out metrics

* Move the metrics-opt in screen to immediately after the welcome screen

* Ensure that global.getSentryState is set in the background

* Fix e2e tests after rearranging onboardin flow

* Fix unit tests

* More e2e test fixes

* Remove unnecessary wrappers around capture exception
2022-07-22 18:09:48 -02:30
Nidhi Kumari
132c1818df
added storybook controls for confirm send ether component (#15235)
* added storybook controls for confirm send ether component

* fixed lint errors

* corrected the argTypes for send-ether-storybook component
2022-07-22 10:58:37 -07:00
VSaric
f1ca3e56e7
Modify transaction type and add contract method data to metrics (#15175) 2022-07-22 12:45:04 -05:00
Nidhi Kumari
2e6f579ee5
Converted BuildQuote story to use controls and action argType (#15234)
* added build quote component

* fixed updated test-data to use Rinkeby instead of ropsten
2022-07-22 12:14:35 +05:30
George Marshall
5592687df1
Updating design tokens package and shadow values with new tokens (#15264)
* Updating design tokens v1.8 and shadows

* Adding missing stories

* Some fixes and updates to css and stories

* removing unneeded story

* Fixing story order
2022-07-21 15:43:31 -07:00
Nidhi Kumari
c85af877bd
added storybook controls for confirm deploy contract component (#15236)
* added storybook controls for confirm deploy contract component

* fixed args in confirm-deploy-contract-storybook

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-07-21 14:34:13 -07:00
Ernesto García
e6931e3f5d
Fix: Actionable Message on Confirm Transaction view is over Tabs (#15272)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-07-21 16:09:18 -05:00
Alex Donesky
b2fde5114a
fix blockExplorer link on setApprovalForAll confirmation screen (#15312) 2022-07-21 14:39:55 -05:00
Dan J Miller
a0c9738924
Ensure that editing a tx from a transfer to a simple send resets data and updates type (#15248)
* Ensure that editing a transaction from a transfer to a simple send properly resets data and updates type

* Handle case where there are no unapproved txes

* Improve comment in updateSendAsset

* Remove unnecessary code in send transaction edit function

* Fix

* Ensure hex data is properly reset when changing from a safe transfer from tx to native send
2022-07-20 20:33:23 -02:30
Frederik Bolding
9e1814952f
Fix stringified object on NFT approve screen (#15287) 2022-07-20 18:24:50 -02:30
George Marshall
05a20bb721
Add responsive props to Box component (#15106)
* Adding responsive props to Box component

* Updating margin array prop instances

* Updating padding array prop instances

* Updates to docs, tests and margin, padding instances

* Optimizing class name object

* Simplifying single value logic

* replacing for loop with switch statement

* Memoizing generateClassNames function
2022-07-20 13:47:51 -07:00
Dor Wiser
98fc0060f3
DefinitionList story: convert knobs and actions to controls / args (#15185)
* tabs story changes

* removed knobs and implemented controls

* object to select control typography

* added argtypes only for relevant stories + fixes
2022-07-20 11:58:14 -07:00
Alex Donesky
78b32153f5
show asset name instead of symbol for setApprovalForAll calls on NFT contracts where possible (#15296) 2022-07-20 13:42:57 -05:00
David Walsh
95adbc245c
Set default getFetchWithTimeout default timeout value (#14218) 2022-07-19 11:13:45 -05:00
Filip Sekulic
7d321c48e0
Removed ui related code from shared directory (#15252) 2022-07-19 11:07:13 -05:00
Nidhi Kumari
fe76317eef
added storybook files to alert and breadcrumbs component (#15156)
* added storyblok files to alert and breadcrumbs component

* formatted the files

* added confusable, i18n, export, hextToDecimal stories

* replaced alert class component to functional component

* removed i18n story files

* added storyblok files to alert and breadcrumbs component

* formatted the files

* added confusable, i18n, export, hextToDecimal stories

* replaced alert class component to functional component

* removed i18n story files

* added README files to storybook elements and fixed lint issues

* added readme files

* updated README file for confusable

* fixed linting errors in test

* removed unwanted tests
2022-07-19 21:10:04 +05:30
Nidhi Kumari
7a3ff7e436
added storybook component for send-content-stories (#15210)
* added storybook component for send-content-stories

* added draftTransactions to storybook
2022-07-19 14:05:45 +05:30
Niranjana Binoy
2223e81c67
Disable Seedphrase import button if any of the characters is in uppercase (#15186) 2022-07-18 20:17:43 -04:00
ryanml
e38cc863a4
Remove dark mode and transaction insights announcements (#15279) 2022-07-18 16:41:10 -07:00
Alex Donesky
3ddebf818b
Preserve send amount when editing an ERC20 transaction (#15275)
* preserve amount when editing an ERC20 transaction

* fix tests
2022-07-18 12:20:02 -05:00
Brad Decker
751c119d10
enable direct routing to the send page (#15259) 2022-07-18 12:01:10 -05:00
Alex Donesky
d92936475a
Fix default currency symbol for wallet_addEthereumChain + improve warnings for data that doesn't match our validation expectations (#15201)
* set more appropriate default for ticker symbol when wallet_addEthereumChain is called

* throw error to dapp when site suggests network with same chainId but different ticker symbol from already added network, instead of showing error and disabled notification to user
2022-07-18 10:59:38 -05:00
George Marshall
81a876f979
Adding media query sass vars, mixins and docs (#15053)
* Adding media query sass vars, mixins and docs

* Updates to docs and fixing page order in storybook
2022-07-18 08:23:27 -07:00
Alex Donesky
09164dcabb
Bump controllers v30.0.2 (#14906)
* bump @metamask/controllers to v30.0.2 and adapt
2022-07-18 09:43:30 -05:00
Daniel
2744eaf760
Update the "results" state if "initialResultsState" array length is different (#15270) 2022-07-18 16:30:36 +02:00
Alex Donesky
4993d28a8f
Only send the rpc origin to segment when calling trackevent for newly added custom networks (#15227) 2022-07-15 12:08:44 -05:00
Alex Donesky
cbda923c61
small approve confirmation ui fixes (#15239) 2022-07-14 13:22:12 -05:00
ryanml
9e63a9a449
Adding "What's New" Notification for Add Popular networks (#15121)
* Adding "What's New" Notification for Add Popular networks

* Adding action text to notification

* Addressing review feedback

* Flag removal
2022-07-14 11:08:32 -07:00
ryanml
959a376347
Remove 'ADD_POPULAR_NETWORKS' feature flag (#15229) 2022-07-14 08:58:34 -07:00
Filip Sekulic
6b4fa46908
Removed the Infura v3 key from rpcUrl display (#15193)
* Removed infura v3 key from rpcUrl display

* Code refactor

* Fixed error

* Prevent submission of form when editing an featured rpc and there is a chainId error

* Add optional chaining to rpcurls to prevent type errors

Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2022-07-14 07:13:56 -02:30
Dan J Miller
0c163dd8aa
Show users a warning when they are sending directly to a token contract (#13588)
* Fix warning dialog when sending tokens to a known token contract address

Fixing after rebase

Covering missed cases

Rebased and ran yarn setup

Rebased

Fix checkContractAddress condition

Lint fix

Applied requested changes

Fix unit tests

Applying requested changes

Applied requested changes

Refactor and update

Lint fix

Use V2 of ActionableMessage component

Adding Learn More Link

Updating warning copy

Addressing review feedback

Fix up copy changes

Simplify validation of pasted addresses

Improve detection of whether this is a token contract

Refactor to leave updateRecipient unchanged, and to prevent the double calling of update recipient

Update tests

fix

* Fix unit tests

* Fix e2e tests

* Ensure next button is disabled while recipient type is loading

* Add optional chaining and a fallback to getRecipientWarningAcknowledgement

* Fix lint

* Don't reset recipient warning on asset change, because we should show recipient warnings regardless of asset

* Update unit tests

* Update unit tests

Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
2022-07-13 19:45:38 -02:30
Daniel
75ac87e487
Show a block explorer URL hostname, hide token import if block explorer URL is not available (#15198) 2022-07-13 18:42:50 +02:00
Filip Sekulic
7246058797
Added metrics for adding a new network (#15176)
* Added metrics for adding a new network

* Applied requested changes

* Added missed changes
2022-07-13 11:47:13 -02:30
Dan J Miller
f785f77959
Improve confirm screen tests (#15163)
* Improve confirm screen tests

* Fix transaction controller unit test

* Fix unit test fixtures

* Fix e2e test
2022-07-12 14:50:20 -02:30
Makoto Inoue
fdd8646ce8
Support for ENS wildcard and offchain resolution (#14675) 2022-07-12 09:30:31 -05:00
Nidhi Kumari
0fd37cd5ff
removed i18nValue component (#15179)
* removed i18nValue component

* fixed bracket issue
2022-07-12 19:29:38 +05:30
VSaric
baeaf763d7
Handling invalid prop loading console warning (#15177) 2022-07-12 08:44:49 -05:00
Alex Donesky
4f0115fcdc
Add setApprovalForAll confirmation view (#15010)
* enhance setApprovalForAll confirmation flow

* cleanup

* address feedback
2022-07-11 18:32:55 -05:00
Justin Léger
2a73dea54d
Update confirmation screen styling (#15136)
* Added 8px of margin to the top of the network display as it was touching the edge of the view
* Removed the SiteIcon component and passed the icon url to the SiteOrigin to display the icon next to the origin.

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-07-11 16:08:43 -07:00
Dor Wiser
5ca8651fe1
NicknamePopover story: convert knobs and actions to controls / args (#15167)
* tabs story changes

* nickname popover implemented controls and actions

* fixed lint error
2022-07-11 14:09:30 -07:00
Dor Wiser
8ccd235a27
tabs story changes (#15147) 2022-07-11 09:01:02 -07:00
Daniel
8cbfa2ea9e
Show a tx link and the "create a new swap" link for STX (#14995) 2022-07-11 17:53:07 +02:00
Niranjana Binoy
bafc235928
Disable Seedphrase import button after switching seedphrase length (#15139) 2022-07-07 11:37:21 -04:00
Dan J Miller
e8ea973f0f
Add feature flag to prevent add popular networks from being available on prod (#15117) 2022-07-04 12:20:37 -02:30
PeterYinusa
79d0a2c8ba
Update wallet-overview.js (#15125) 2022-07-01 12:35:40 -02:30
Brad Decker
94967072f7
Remove global transaction state from send flow (#14777)
* remove global transaction state from send slice

* fixup new test
2022-07-01 08:58:35 -05:00
Dan J Miller
f4b25d7ea5
Ensure native asset icon does not display incorrectly when switching networks and balance is loading (#15116) 2022-07-01 10:38:42 -02:30
Filip Sekulic
43f7a44c25
Adding popular custom network integration (#14557)
* Initial push

* Refactored the code

* Additional code

* Removed the unused message

* Added a tooltip

* Fixed tests

* Lint fix

* Added style to a tooltip

* Fix e2e test failure

* Lint fix and code revert

* Fix e2e test

* Fixed paddings

* Fixed paddings

* CSS fix

* Minified svg files

* Applied requested changes

* Fixed theme issue

* Code revert

* Added back overridden code

* Icon problem fixed

* Lint fix

* Replaced H3 with H4

* Added unit test

* Added breadcrumbs

* Added const props for networks

* Lint fix

* Lint fix

* Added toggle button for showing the custom network list and resolved few issues

* Fixed routes

* Refactored a piece of code

* Enabled searching for the newly created option

* Fixed unit test

* Updated theme
2022-06-30 13:49:07 -02:30
Alex Donesky
3a31326199
Add fallback image/card for NFTs when image was not fetched correctly or does not exist (#15034)
* add fallback image/card for collectibles when image was not fetched correctly or does not exist

* UI and storybook updates (#15071)

* UI and storybook updates

* Adding break so token id is displayed

* subtle border fix

* Updating content

* Removing unused image

* Adding proptype descriptions

* Lint fix

Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-06-30 08:46:38 -07:00
Dan J Miller
c3623ab729
Remove change from cb77f94 that breaks ens inputs in send flow (#15069) 2022-06-28 17:06:55 -02:30
Dan J Miller
cb77f94bc5
Ensure that addresses are properly hex-prefixed in the generate ERC token transfer functions (#15064)
* Ensure that addresses are properly hex-prefixed in the generate ERC token transfer functions

* Ensure hex-prefixed addresses in send input

* Update unit tests

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-06-28 14:21:09 -02:30
Alex Donesky
5290402181
Fix tokenIds larger than MAX_SAFE_INTEGER converted to scientific notation and failing to import (#15016)
* fix tokenIds larger than MAX_SAFE_INTEGER breaking

* add tests
2022-06-27 19:31:25 -05:00
Daniel
5fa88bebce
Show how much a cancellation of a smart transaction will cost (#15011) 2022-06-22 18:58:51 +02:00
David Walsh
6ffd0ce063
Fix 14802 - Prevent children error in page container (#14809) 2022-06-21 18:38:39 -05:00
George Marshall
051254dffd
Fixing tooltip theming by enforcing default theme (#14992)
* Fixing tooltip theming by enforcing background color

* Removing wide prop
2022-06-21 09:50:44 -07:00
daniba
085126d275
Move search icon and add to storybook (#14940)
* move search icon || update imports || add to story

* Optimized svg path, updated icon api and updating colors

* update other icons

* update snapshot

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2022-06-21 10:18:35 -05:00
Zachary Belford
5a1bc94aa4
Changed accounts fuzzy search threshhold to match all (#14914)
* Changed accounts fuzzy search threshhold to match all

* Changed account search only when there is at least 2 terms

* Fixed linting issue

* Lint fix account menu component
2022-06-20 15:35:07 -07:00
Guillaume Roux
25739a5fc1
[FLASK] Fix notifications icon color (#14941) 2022-06-20 23:23:51 +02:00
Frederik Bolding
4048feeaac
Increase likelyhood of valid method signatures being returned by getMethodData (#14937)
* Increase likelyhood of valid method signatures being returned by getMethodData

* Update coverage

* Update coverage

* Update coverage

* add a migration to clear knownMethodData

* Small typo changes

Co-authored-by: Alex <adonesky@gmail.com>
2022-06-17 23:11:09 +02:00
ricky
3d74d06f93
Add missing subtitles for secret recovery phrase (#14943)
* add missing subtitles

* Update subtitles map

* update subtitle map in onboarding v2 flow

Co-authored-by: Alex <adonesky@gmail.com>
2022-06-17 14:55:04 -04:00
白宦成
adbd1c79be
fix EditGasDisplay (#13980)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-17 13:04:59 -05:00
George Marshall
fdf3e9d2d7
Fix/14856 network settings page (#14857)
* Removing other features code

* Improving acccessibility of check icon

* Fixing add network button footer in popover view

* Fixing unit tests
2022-06-15 13:16:53 -07:00
Ariella Vu
73488766b6
SB:EditGasDisplay: fix error (#14946) 2022-06-15 14:55:04 -05:00
Daniel
ebf967562b
Remove experimental gas editing for Swaps (#14942) 2022-06-15 21:08:13 +02:00
Ariella Vu
1771ed4925
ErrorMessage: add @deprecated (#14945) 2022-06-15 13:45:54 -05:00
David Walsh
ea49b40d33
Make the accounts menu accessible (#14936) 2022-06-15 12:49:18 -05:00
Jordon
f5c6d0054f
Convert knobs and actions to controls/args for MainQuoteSummary (#14758)
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-06-15 10:43:26 -05:00
Ariella Vu
ede801e143
MetaMetrics: fix onCancel trackEvent (#14935)
should mirror first-time-flow/metametrics-opt-in logic
2022-06-14 11:00:11 -05:00
Soralit
804db7f1dc
fix animated qr in dark mode (#14900) 2022-06-13 16:07:51 -05:00
VSaric
f9edbf50ce
Empty balance while switching network (#14354) 2022-06-13 14:39:48 -05:00
VSaric
136218893b
Fix contact address pet name (#14613)
* The contact pet name isn't replaced by the recipients address

* Create getEnsResolutionByAddress selector and use it in the codebase

* Modified the getRecipient selector such that it returns an ens resolution as the nickname if a nickname isn't present but a ens resolution is.

* Update ui/ducks/send/send.js

Co-authored-by: Brad Decker <bhdecker84@gmail.com>

* Checked if ens resolution is present in the getRecipient selector

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-06-13 11:18:33 -05:00
Alex Donesky
b170211700
Fix to infinite loading on approve screen (#14756) 2022-06-11 12:55:35 -05:00
ryanml
496d9d81c3
Fix Enhanced Gas Fee toggle setting metrics event (#14874) 2022-06-10 16:05:25 -07:00
Zachary Belford
7dc6a5feaa
Merge pull request #14837 from MetaMask/prop-type-fixups
Prop type fixups
2022-06-10 12:36:31 -07:00
ryanml
54e83d659d
Fix padding issue in Edit Nickname screen (#14842)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-08 15:56:14 -07:00
Zachary Belford
d882835cae
Added PR feedback changes 2022-06-08 14:24:50 -07:00
Zachary Belford
8b09f84502
Linting fixups 2022-06-08 14:24:50 -07:00
Zachary Belford
93ee67eb01
Update pr based on review feedback 2022-06-08 14:24:50 -07:00
Zachary Belford
0f7bb16b9b
Update ui/pages/settings/settings.component.js
Remove the extra route

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2022-06-08 14:24:50 -07:00
Zachary Belford
5e049aabff
Remove junk from previous ticket 2022-06-08 14:24:49 -07:00
Zachary Belford
9c8b22a20b
Changed to address to optional for TransactionDecoding component 2022-06-08 14:24:36 -07:00
Zachary Belford
c2d5bd01c4
Changed networks tab to explicitly pass in false and fix implicit type casting 2022-06-08 14:24:36 -07:00
Zachary Belford
b76943ea18
Changed custom nonce min to a number from a string 2022-06-08 14:24:36 -07:00
Zachary Belford
9ec652d0da
Changed transaction decoding component to put keys on data items 2022-06-08 14:24:35 -07:00
Zachary Belford
29d87343fa
Changed update nickname popover to remove proptype errors 2022-06-08 14:24:35 -07:00
Zachary Belford
3665c3718d
Changed seedPhraseBackedUp to always a boolean 2022-06-08 14:24:35 -07:00
Zachary Belford
5c93ca44da
Changed asset option prop type requirements 2022-06-08 14:24:34 -07:00
Daniel
b0557daa05
Handle an RPC provider delay in Swaps (#14821)
* Return an estimated amount for a completed swap if an RPC provider has a delay

* Create a recursive function for updating post tx balance

* Add a few tests for the "getSwapsTokensReceivedFromTxMeta" fn

* Trigger Build
2022-06-08 16:32:04 +02:00
Olusegun Akintayo
4fa4930c8a
Add friendly error handling when background throws an error before listening for connection (#14461)
* When background port closes, UI should display a user friendly error.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Remove console.log

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

A couple of fixes
    1. Use timeout in metaRPCClientFactory to check if UI can't
       communicate with bg
    2. Refactor locale setup
    3. Fixed wording/capitalization
    4. Fix locales usage so that linting works
    5. Refactor CSS

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

do not simulate errorwq

Refactor loading css

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Remove the onDisconnect event handler in ui as this is handled in
metarpcclientfactory

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not throw in bg

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Fix PR comments

Remove unused message 'failedToLoadMessage'

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Move usage of locales to shared/** so that linter can see it.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not simulate error.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

metarpc can handle multiple requests, responseHandled should be a map.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

reload metamask button on critical error

Use metamask state (if available) to the locale, else read locale files
manually.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

use constant and numeric separator

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

refactor error utils

remove error simulation

Memoize setupLocale function

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

test cases

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not simulate error

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

1. store should be metamask state
2. code refactorings.
Tests: mock setupLocale

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Mock fetchLocale instead
Test setup locale

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

UI/CSS changes.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Do not simulate failure

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* spell MetaMask correctly

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Rename state to mockStore

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* we should clean up this.responseHandled[id] in the error case.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Fixed PR comments.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* clean up response handled.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2022-06-08 00:37:15 +04:00
Daniel
9705531671
Reduce the default slippage from 3% to 2% (#14863) 2022-06-07 18:28:59 +02:00
Daniel
bd5d47993d
Make content changes for the STX status page, remove old content (#14805) 2022-06-07 15:42:25 +02:00
Thomas Huang
18e4af7690
Unit test proptype (#14868)
* Add missing props to advanced tab component test.

* Add icon size prop to site icon test

* Add hardwareWalletRequiresConnection prop to signature request test as a boolean

* Add setShowDetectedTokens prop to detect token test

* Set Setting description prop to be either object or string.
2022-06-06 19:30:07 -07:00
VSaric
914cdd5fa5
Fix switching between ETH and USD (#13827) 2022-06-06 08:11:14 -05:00
ryanml
250b3d5499
Fixing add recipient flow issue with contact list/recent recipients (#14771) 2022-06-03 15:41:05 -07:00
George Marshall
c18c3b078e
Updating icon color (#14835) 2022-06-03 12:45:03 -07:00
Victor Korzunin
0166575405
fix: keep lock button text inside button boundaries (#14335)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-03 12:16:44 -07:00
Ariella Vu
e60af93f2a
Storybook: add TransactionListItem component page (#14786)
* TransactionListItem: add storybook page

* SB:TransactionListItem: update retry status

* SB:TranslationListItem: exclude CANCEL & RETRY

* TransactionListItem: exclude SIGNED status

* TransactionListItem: fix mock transactions

* SB:TransactionListItem: add isEarliestNonce param

* SB:TransactionListItem: fix args

* SB:TransactionListItem: add "Speed Up" params

* SB: add nonce to mock transactions
2022-06-03 12:50:23 -05:00
$tocker
ba7a177f5c
fix design breaks on the Settings Navbar when Internationalization (#14012)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-06-03 12:33:59 -05:00
Frederik Bolding
239f5f7fa6
Include snap version in pill (#14803)
* Include snap version in pill

* snaps authorship styling

* styling

* Fix linting

* Fix linting

Co-authored-by: eriknson <eriks@mail.se>
2022-06-02 11:38:39 +02:00
Soralit
efdc3149aa
fix: keystone transaction qrcode has no white spacing (#14798) 2022-06-01 12:32:24 -05:00
Guillaume Roux
b599035a12
Snap notifications integration (#14605)
* begin controller implentation

* add NotificationController

* create selectors and actions

* update actions tu use forceUpdateMetamaskState

* Basic notification UI

* fix typo and remove console.log

* lint

* more css

* add notifications scroll

* add translations and fix some css

* Fix rebase and edit colors

* add flask tags

* add flask tag to routes component

* add missing flask tags

* add tests

* fix tests

* store notification expiration delay in constant

* address requested changes

* rename to unreadNotificationsCount

* add missing flask tag
2022-06-01 19:09:13 +02:00
Thomas Huang
db6998c66a
Fix proptype errors in network dropdown, tx list item details, and account details modal tests (#14747) 2022-05-31 09:46:38 -07:00
Dan J Miller
8961ea5d1b
Ensure transaction type is correctly updated on edit (#14721)
* updated state on edit

* Update transaction type in updateEditableParams method instead of in the send duck

* Fix unit test

* Fix unit tests

* Fix and improve unit tests

Co-authored-by: dragana8 <dragana.simic@consensys.net>
2022-05-27 14:01:31 -02:30
benlwyre
f6643e853c
Add fiat onboarding for AVAX and MATIC through Wyre (#14683) 2022-05-27 11:04:26 -05:00
Ariella Vu
b6ade44bc9
Slight cleanup of constants/transactions, useTransactionDisplayData, and TransactionIcon (#14784)
* TransactionIcon: alphabetize categories

* useTransactionDisplayData: rm repetitive comment

* useTransactionDisplayData: mv signatureTypes

* useTxDisplayData: import transactionGroup @typedef

* userTxDisplayData: just vertical line spacing
2022-05-26 16:26:45 -05:00
Daniel
6dbb2c4ded
Migrate the "estimateGas" API call to "getFees" for STX (#14767) 2022-05-26 19:56:28 +02:00
Brad Decker
51986a4724
Add types to send state (#14740) 2022-05-25 15:54:05 -05:00
Frederik Bolding
5b8a69c721
Remove site origin on snap install (#14752)
* Remove site origin on snap install

* Fix linting + storybook

* Update local snap icon

* Fix storybook build
2022-05-25 18:19:02 +02:00
George Marshall
8fcbebc546
Update design tokens library from 1.5 to 1.6 WIP (#14732)
* Updating account menu icon color

* Updating design-tokens and making appropriate updates to extension styles

* Adding more deprecated tags to colors

* Adding spinner and removing todo comment

* Remove comment

* Updates

* Updating snapshots

* More color and ui updates

* reverting transition change
2022-05-25 08:35:36 -07:00
Ariella Vu
70bdd9729f
Enables the "Safe Transaction From" copy for safeTransferFrom transactions (#14769)
* useTransactionDisplayData:support safetransferfrom

* useTransactionDisplayData: update test
2022-05-25 10:13:15 -05:00
Brad Decker
3177c6abbb
remove draft transaction (#14701) 2022-05-24 16:05:27 -05:00
VSaric
623fd91d65
Fix currency conversion rate (#14713) 2022-05-24 15:16:11 -05:00
Daniel
f6576801d4
Fix an edge case with missing top assets in Swaps (#14688)
* If there is no array of top assets in a response, use an empty array

* Set a default empty array for 2 functions, remove an unnecessary condition

* Redirect a user from Swaps to the homepage if they switch to a chain that is not supported in Swaps

* Fix errors in the UI Console when it's not a swaps chain
2022-05-24 18:30:46 +02:00
Frederik Bolding
c833e41eee
Restore SiteOrigin chip on permission screen (#14768)
* Restore SiteOrigin chip on permission screen

* Fix linting
2022-05-24 18:04:07 +02:00
VSaric
e7d1476522
Sign button is enabled after scrolling all the way to the bottom (#14745) 2022-05-24 10:28:40 -05:00
Ariella Vu
e06e5599bb
EditGasFeeBtn: Insufficient number of substitutions for key "dappSuggestedTooltip" (#14734)
* EditGasFeeBtn: support missing origin dappSuggest

* EditGasFeeButton: add tooltip min-width

* EditGasFeeButton: tooltip min-width needs extra px

* EditGasFeeBtb: tooltip min-width add a bit more px
2022-05-23 15:04:54 -05:00
Alex Donesky
634cf70a71
Enhance reusable SiteOrigin component (#14720)
* extend and reuse SiteOrigin component
2022-05-20 09:35:18 -05:00
Thomas Huang
11831c6ae5
Add hideEstimatedGasFee prop to sort-list and select-quote-popover tests (#14725) 2022-05-19 10:43:31 -07:00
VSaric
a5e07b0f18
Chain ID field use the same color pattern as the currency symbol field warning message below (#14644) 2022-05-19 10:52:17 -05:00
Frederik Bolding
66c049bb35
snaps-skunkworks@0.14.0 (#14700)
* snaps-skunkworks@0.13.0

* snaps-skunkworks@0.14.0

* Fix test

* Add long-running permission copy and icon

* Run linting

* Fix typo

* Bump E2E version
2022-05-18 13:49:26 +02:00
Ariella Vu
9d058007cc
NetworksTab: make footer buttons nowrap (#14733) 2022-05-17 19:44:32 -05:00
Dan J Miller
944c22262f
Ensure send logs use current chain currency symbol (#14726) 2022-05-17 14:27:23 -02:30
Ariella Vu
7cfa454570
Storybook: add SignatureRequestOriginal (#14707)
* SB: add SignatureRequestOriginal

* SB:SignatureRequestOriginal: add reusable Template

* SB:SignatureRequestOriginal: add args
missing isRequired args

* SB:SignatureRequestOriginal: add eth_signTypedData

* SB:SignatureRequestOriginal: update README.mdx

* SB:README: update description

* SignatureRequestOriginal: destruct mock value
2022-05-16 17:28:20 -05:00
Ariella Vu
1464ab724f
Storybook: Fix SignatureRequest component (#14706)
* SB:SignatureRequest: fix control type

* SB:SignatureRequest: fix args
expected by sanitizeMessage

* SignatureRequests: cleanup
2022-05-16 17:24:08 -05:00
Thomas Huang
dbe89049bd
Unit test proptype (#14564)
* Change import file to root index

* Properly set showFiat proptype to bool
2022-05-16 13:53:47 -07:00
dragana8
d01a2ad7e5
Overall CSS #13441 (#13902)
* styling updates

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-05-16 13:38:04 -05:00
dragana8
a0c4febfce
"Cancel/reject all" for signature requests #13201 (#13786) 2022-05-16 13:36:19 -05:00
Lachlan Tweedie
eee4cc3100
Add Coinbase Pay as fiat onramp option (#14648) 2022-05-12 18:27:49 -05:00
Daniel
d305dcba9d
Change styles for the high price impact notification in Swaps (#14697) 2022-05-12 19:57:05 +02:00
Alex Donesky
5e55cf2cf2
add case in useTransactionDisplayData to handle transaction type safeTransferFrom (#14678)
* add case in useTransactionDisplayData to handle transaction type safeTransferFrom

* add test
2022-05-12 10:02:08 -05:00
Niranjana Binoy
6c757ab5e0
Event tracking for Token Detection V2 (#14441) 2022-05-11 16:27:58 -04:00
Erik Marks
4b2cd0ef7a
Fix Snaps view search (#14693)
Closes #14687

Snap IDs were not properly encoded (and decoded) as URI components in the Snaps view search implementation. This ensures that they are.
2022-05-11 13:14:53 -07:00
Daniel
9a153d2388
Remove gas editing in Swaps (#14673)
* Remove gas editing in Swaps

* Remove "extraApprovalGas"
2022-05-11 20:30:03 +02:00
ryanml
54292f6c81
Fix eth_sign 'Learn more' dialog link (#14667) 2022-05-10 17:25:36 -07:00
George Marshall
23f4b58dca
Updating alert text color (#14674) 2022-05-10 10:28:30 -07:00
PeterYinusa
f47d02b72a
Auto lock e2e (#14624)
* add auto lock e2e test

* fix console errors
2022-05-10 17:57:11 +01:00
Ariella Vu
98c7515344
TransactionListItem: fix save/cancel rounded btn (#14659) 2022-05-09 13:11:25 -05:00
Niranjana Binoy
0a10b425ea
Add New Tokens Found page (#14366) 2022-05-09 13:47:06 -04:00
Daniel
2bd7127433
Swaps / STX improvements (#14622) 2022-05-09 18:48:14 +02:00
Frederik Bolding
9e401b14bf
Simplify removeSnap functionality after snaps-skunkworks update (#14646) 2022-05-09 18:19:34 +02:00
ryanml
a2ea1cacc8
Fixing Speed up/Cancel information text (#14551)
* Fixing Speed up/Cancel information text

* Adding tests
2022-05-09 08:37:31 -07:00
Frederik Bolding
fa9d703aa0
Fix SRP paste duplication (#14625)
* Fix SRP paste duplication

* Remove else-case for paste event

* Add E2E test that would catch this issue in the future

* Fix linting
2022-05-09 14:46:20 +02:00
Brad Decker
564ad2f81b
Track send flow history on txMeta (#14510) 2022-05-04 11:54:46 -05:00
David Walsh
8a71f0f008
Add search information for Theme dropdown (#14476) 2022-05-04 09:57:01 -05:00
Daniel
9daab6aa59
Disable STX if a regular tx is in progress (#14554)
* Disable STX if a regular tx is in progress

* disableStxIfRegularTxInProgress : early return

* Fix UTs

* Trigger Build
2022-05-03 17:55:41 +02:00
Frederik Bolding
3b3a680682
Stop using 4bytes for contract deployment (#14598) 2022-05-02 16:49:01 -05:00
Alex Donesky
12a088e638
Fix browser.tab.get call (#14550)
* update to expect promise from browser api polyfill rather than pass callback
2022-04-29 09:21:06 -05:00
Thomas Huang
d139e69545
Unit test proptype (#14509)
* Confirm page container content currentTransaction proptype change string to object

* Add title prop
2022-04-28 15:14:53 -07:00
George Marshall
ad1abaaef4
Updating text/muted to text/alternative for select text on home screen (#14553) 2022-04-28 06:03:12 -07:00
Guillaume Roux
6309d53650
Dark Mode : Add OS option in theme selection dropdown (#14379) 2022-04-28 14:36:28 +02:00
Hennadii Ivtushok
72d2977e72
Warn about multiple MetaMask instances running (#13836)
* Add text warning on startup page

* Try to detect extensions with browser API

* Setup messaging between different versions of extension

* Cleanup

* Cleanup

* Simplify check for multiple instances running

* Fix a doc string + use webextension-polyfill

* Fix test

* Mock webextension-polyfill

* Mock correctly

* Catch error and show warning in both extensions

* Mock as promise

* Address comments

* Rename build ids

* Run detection code only if Chrome

* Add Firefox warnings

* Cleanup imports

* Update connection ids

* Run detection code for Firefox

* Add test

* Add missing await

* Update tests

* Cleanup

* Cleanup

* Improve testing

* Improve tests

* Log errors from sendMessage

* Cleanup

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-04-27 20:14:10 +02:00
Frederik Bolding
27ad7279cd
Rename NotificationController to AnnouncementController (#14389)
* Rename NotificationController to AnnouncementController

* Fix test

* Add test for missing NotificationController state

* Bump controllers

* Move test to correct file

* Rename config key

* Add migration 71 to list of migrations

* Fix selector after migration
2022-04-27 10:36:32 +02:00
Guillaume Roux
7a9662b88e
Add token standard to custom token details (#14506)
* use getTokenStandardAndDetails to get token standard

* remove console.log and fix test

* remove console.log
2022-04-26 12:08:14 -07:00
ryanml
0c49bc14d4
Fixing 'Learn more' casing on import token screen (#14529) 2022-04-26 10:25:07 -07:00
Brad Decker
193c22588e
call controller methods directly in send duck (#14465) 2022-04-26 12:07:39 -05:00
Alex Donesky
cf2c6a3164
show token approval details on confirm approve screen by default (#14523) 2022-04-26 10:21:52 -05:00
Brad Decker
f567a3fe86
Do not show failed off-chain transactions details when grouped with another valid transaction of same nonce (#14497)
* fix failed off chain tx mismatch with next confirmed transaction

* dont drop failed txs when tx in confirmed

* add comment for reassigning logic

* resolve change requests
2022-04-25 14:39:34 -05:00
amerkadicE
ef6fb86f50
Update for a new Add network page (#13866) 2022-04-25 13:30:46 -05:00
amerkadicE
8fef9fd8df
Update display of switching current network (#13450)
Co-authored-by: Amer Kadic <amerkadic@Amers-MacBook-Pro.local>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-04-25 13:28:52 -05:00
Dan J Miller
284bab1cbc
Ensure network name in confirm page container is defined (#14520) 2022-04-25 15:04:44 -02:30
Ariella Vu
78f4684b2a
MetaMetrics: Add EVENT.CATEGORIES const (#14474)
* MetaMetrics: add EVENT.CATEGORIES const

* MetaMetrics: add EVENT.CATEGORIES.INPAGE_PROVIDER

* MetaMetrics: add EVENT.CATEGORIES.AUTH

* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 1

* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 2
confirm we want to use 'Accounts' instead of 'Account'

* MetaMetrics: add EVENT.CATEGORIES.MESSAGES

* MetaMetrics: add EVENT.CATEGORIES.RETENTION const

* MetaMetrics: add EVENT.CATEGORIES.SETTINGS

* MetaMask: add missing EVENT.CATEGORIES.SNAPS

* MetaMetrics: add EVENT.CATEGORIES.WALLET const

* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING const

* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING
& EVENT.CATEGORIES.TRANSACTIONS consts

* MetaMetrics: use EVENT.CATEGORIES

* ducks/swaps: revert slice name

* MetaMetrics: add missing EVENT.CATEGORIES.NETWORK
2022-04-22 13:09:10 -03:00
Alex Donesky
fbeae57247
Add testnet name as prefix for native currency of preloaded testnets (#14454)
* add testnet name as prefix for native currency of preloaded testnets
2022-04-21 14:09:41 -05:00
Olusegun Akintayo
095cc94ed0
Add new token added event (duplicating the existing event structure) when collectible is manually added (#14279)
* Add new token added event (duplicating the existing event structure) when auto detection occurs for NFTs
Set source property to detected on the new token added event,
2022-04-21 13:29:39 -05:00
Brad Decker
8f47c19b9d
increase test coverage of nonce sorted transaction selector (#14486) 2022-04-21 12:33:44 -05:00
Dan J Miller
3ecc04e42d
Fix the alerts toggles in settings (#14498) 2022-04-21 09:48:03 -07:00
Dan J Miller
b1df04c253
Disable swaps whenever the environment is not development or testing, so that behaviour follows production for QA purposes (#14499) 2022-04-21 09:19:34 -07:00