1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Commit Graph

15911 Commits

Author SHA1 Message Date
Ariella Vu
462e5faab5
Fix token balance precision on confirm token approval page from soon-to-be-deprecated token allowance flow (#16934)
* ConfirmToken: fix token balance onboarding v1
this UI/UX should be deprecated following PR#16740, maybe v10.25

* TokenApproval: use precision for token balance

* EditApproval: calc utilizing existing util
2022-12-16 22:20:05 +07:00
Dan J Miller
3ab450131a
Fix the ganache:start command by making the 'yarn bin' usage compatible with yarn3 (#16983) 2022-12-16 11:43:06 -03:30
seaona
6cebc854fd
Merge branch 'develop' into master-sync 2022-12-16 13:05:36 +01:00
David Walsh
6439a0e934 Onboarding: Set SeedPhraseBackedUp when appropriate (#16875)
* Onboarding: Set SeedPhraseBackedUp when appropriate

* Dispatch setSeedPhraseBackedUp

* Fix test

* Make call async

* Fix test

* Fix test

* enhance test

Co-authored-by: Alex <adonesky@gmail.com>
2022-12-16 12:57:51 +01:00
Dan J Miller
34f83a8435
Merge pull request #16975 from MetaMask/Version-v10.23.1
Version v10.23.1
2022-12-15 20:20:26 -03:30
George Marshall
09d29ef00d
Renaming broken stories to clean up console (#16905)
* Renaming broken stories. Fixing deprecated default arg syntax for stories using defaultValue

* Fixing imports
2022-12-15 14:46:30 -08:00
legobeat
1acb1b2e5d
Refactor password validation (#16902)
* ui: add common constant PASSWORD_MIN_LENGTH=8

* ui: simplify password validation logic

* ui: getPasswordStrengthLabel using t from context

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2022-12-15 20:56:27 +00:00
seaona
9d6ab1bcb2 Fix lint by removing un-used variable getAccountsWithLabels 2022-12-15 20:20:58 +01:00
Garrett Bear
4ba081a096
add text directions (#16901)
* add text directions

* add text direction test

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2022-12-15 10:49:47 -08:00
seaona
56b89e7c9f Changelog entry for hotfix 2022-12-15 19:07:27 +01:00
MetaMask Bot
bc073a771c Version v10.23.1 2022-12-15 17:46:22 +00:00
Dan J Miller
bb562ea29c Recipient name passed to confirm-page-container component should be u… (#16961)
* Recipient name passed to confirm-page-container component should be used if pet name exists for the to address

* Ensure recipient edit/add popup is shown for non-owned accounts

* Ensure contract name is rendered if it exists for recipient address

* Ensure that shortened address is last fallback after account, addressbook, token and ens names
2022-12-15 18:42:21 +01:00
Nidhi Kumari
88af4b3c36
Avatar Token HouseKeeping (#16662)
* Avatar Token HouseKeeping

* updated props

* fixed indentation and avatar size

* fixed lint issues

* updated sizes

* fixed alignment of avatar token halo stories

* updated story for src

* updated avatar token

* updated README

* updated Readme
2022-12-15 22:59:24 +05:30
Nidhi Kumari
4fcbaae32f
housekeeping for avatar network (#16663)
* added housekeeping for avatar network

* fixed alt

* updated story in Readme

* fixed indentation and added network src

* updated SIZES for avatar network

* updated snapshot

* updated docs and props

* updated name of avatar

* removed comments

* updated avatar network component

* updated readme

* updated story for badge

* added constants to the root
2022-12-15 22:58:42 +05:30
Nidhi Kumari
df73d1887d
added goerli and sepolia inverse colors (#16928)
* added goerli and sepolia inverse colors

* updated story

* removed duplication of args

* updated colors in root
2022-12-15 22:58:30 +05:30
Dan J Miller
0792e4ebbc
Recipient name passed to confirm-page-container component should be u… (#16961)
* Recipient name passed to confirm-page-container component should be used if pet name exists for the to address

* Ensure recipient edit/add popup is shown for non-owned accounts

* Ensure contract name is rendered if it exists for recipient address

* Ensure that shortened address is last fallback after account, addressbook, token and ens names
2022-12-15 13:03:59 -03:30
David Walsh
43adc60956
Onboarding: Set SeedPhraseBackedUp when appropriate (#16875)
* Onboarding: Set SeedPhraseBackedUp when appropriate

* Dispatch setSeedPhraseBackedUp

* Fix test

* Make call async

* Fix test

* Fix test

* enhance test

Co-authored-by: Alex <adonesky@gmail.com>
2022-12-15 08:38:15 -06:00
Alex Donesky
5accaf88b9 add back error when password is too short (#16876) 2022-12-15 11:03:15 +01:00
seaona
3859c25cac
Changelog for 10.24.0 (#16888)
* Changelog for 10.24.0

* Update FLASK snaps-monorepo entry

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Flask entries

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Small fixes on changelog entries

* Updated Flask entries classification

* Add new cherry-picked entries

* Small fix for reject tx entry

* Update CHANGELOG.md [FLASK] Fix usage of wrong `ethereum` global for `ethereum` endowment

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-12-15 09:49:54 +01:00
Alex Donesky
9dd30a0ac6
add back error when password is too short (#16876) 2022-12-14 19:20:55 -06:00
Dan J Miller
b3dbf62860
Add lavamoat policy override for react-responsive-carousel (#16955) 2022-12-14 14:35:28 -06:00
Frederik Bolding
13e4d3054b
[FLASK] Fix race condition with transaction insights (#16956)
* Fix race condition with transaction insights

* Rename variable
2022-12-14 19:50:23 +01:00
Alex Donesky
bcfe67a132 fix issue where final onboarding pages are not show (#16943) 2022-12-14 18:00:12 +01:00
David Walsh
b40fd429fb Fix #16804 - Onboarding - Prevent odd behavior with clicks and show/hide password (#16878) 2022-12-14 16:38:45 +01:00
Jyoti Puri
4e272beb26 User should be able to search setting to batch account balance request (#16887) 2022-12-14 16:34:58 +01:00
Ariella Vu
c4f9dcc3a5 onboardingV2: fix privacy policy in spanish (#16918) 2022-12-14 16:33:36 +01:00
Jyoti Puri
6bc01a1e97 Fix onboarding V2 Install complete page (#16941) 2022-12-14 16:27:59 +01:00
Alex Donesky
fde7cb5e17 remove the ability to navigate back into the onboarding flow after completing onboarding (#16916)
* fix issue when navigating back into the onboarding flow after completing onboarding

* disable navigating back into the onboarding flow

* lint

* fix test

* lint
2022-12-14 15:06:46 +01:00
Jyoti Puri
8d8fcdcf0e ButtonIcon: fix react component proptype (#16942) 2022-12-14 15:04:15 +01:00
Frederik Bolding
1e156ebb94 [FLASK] Bump snaps iframe-execution-environment (#16932) 2022-12-14 12:37:39 +01:00
Frederik Bolding
0511d6f0b1
[FLASK] Bump snaps iframe-execution-environment (#16932) 2022-12-14 11:48:50 +01:00
Vladimir Saric
219e3129dc Added reject transactions modal to be present in the footer of the approve screen (#16832)
* Added reject transactions modal in the footer

* Use Button component for multiple unapproved tx
2022-12-14 11:15:25 +01:00
Alex Donesky
5d285f7be5
fix cached detected token results (#16866) 2022-12-14 12:26:08 +05:30
Alex Donesky
c76453d6cb
fix issue where final onboarding pages are not show (#16943) 2022-12-14 12:19:52 +05:30
Jyoti Puri
929dfbfd21
Fix onboarding V2 Install complete page (#16941) 2022-12-13 15:44:08 -06:00
Jyoti Puri
dc5a9f967d
ButtonIcon: fix react component proptype (#16942) 2022-12-13 15:23:39 -06:00
Brad Decker
e83111cc7e
Nock some endpoints to improve test perf (#16940) 2022-12-13 14:20:24 -06:00
Elliot Winkler
dd59792392
Remove if to expose more network client tests (#16906)
This commit affects the network client tests, which were added in a
previous PR to test the behavior of `createInfuraClient`, a function
called that sets up a portion of the middleware stack in the JSON-RPC
layer.

An `if` statement appears in the tests which limits the execution of
certain tests. However, this seems to have been added for debugging
purposes and is not actually needed.

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-12-13 12:49:58 -07:00
Mark Stacey
5857b85225
Add e2e debugging logs (#16937)
A `debug` flag has been added to our e2e test runner scripts, enabling
e2e debug logs. When this flag is enabled, all driver interactions will
be logged to the console. This is extremely useful when debugging e2e
tests, because it lets you known how far the test had progressed before
failing.

This flag should work with all existing e2e test scripts, including
both `test:e2e:single` and all of the test commands that run entire
test suites.

The README has been updated to reference this flag in the section
regarding how to run a single e2e test. To ensure this wasn't totally
missed for the other scripts, I added a line suggesting that users use
`--help` to see all supported options.
2022-12-13 16:00:47 -03:30
Mark Stacey
69e5d6da4a
Make certain network controller methods private (#16883)
Five network controller methods have been renamed to start with an
underscore:
* `getLatestBlock`
* `setNetworkState`
* `setNetworkEIPSupport`
* `clearNetworkDetails`
* `setProviderConfig`

All of these methods were used solely within the network controller.
The leading underscore now documents these methods as being private.

A few tests required updates as well because they were stubbing out one
of these methods.

This should include zero functional changes.

This relates to https://github.com/MetaMask/controllers/issues/971
2022-12-13 15:43:54 -03:30
Mark Stacey
06d87fb98b
Refactor how network state is passed to transaction controller (#16922)
The network state is now passed to the TransactionController via a
getter function and a subscription function, instead of passing one of
the network controller stores directly.

This way of passing the state makes further refactoring easier, as we
don't have to change the input when the store is changed or replaced.
It's also more aligned with our conventions today.

This change was made as part of a larger refactor of the network
controller, as part of the effort to merge the mobile and extension
network controllers.
2022-12-13 15:43:12 -03:30
Ariella Vu
be6edb4bc8
scripts/ui: add tabs.query promise error handler (#16915) 2022-12-14 01:21:32 +07:00
Alex Donesky
6a23dcc68a
remove the ability to navigate back into the onboarding flow after completing onboarding (#16916)
* fix issue when navigating back into the onboarding flow after completing onboarding

* disable navigating back into the onboarding flow

* lint

* fix test

* lint
2022-12-13 12:08:28 -06:00
Daniel
a6da5fd4c3
Add Optimism's L1 fee for an approval tx into total L1 fee in Swaps (#16929) 2022-12-13 18:28:05 +01:00
Mark Stacey
75177c5998
Make setProviderType synchronous (#16879)
The network controller method `setProviderType` was marked as `async`
despite doing nothing async internally. The `async` has been dropped.

This should have zero functional impact.

This relates to https://github.com/MetaMask/controllers/issues/971
2022-12-13 13:57:48 -03:30
Mark Stacey
5df6f653af
Remove unused verifyNetwork method (#16882)
The network controller method `verifyNetwork` has been deleted. It was
unused.

This relates to https://github.com/MetaMask/controllers/issues/971
2022-12-13 13:57:28 -03:30
Ariella Vu
e4e69d86b2
onboardingV2: fix privacy policy in spanish (#16918) 2022-12-14 00:16:10 +07:00
Mark Stacey
add2d2e1d8
Disable LavaMoat for start:test command (#16919)
The `start:test` command no longer uses LavaMoat to run the build
process. `start:test` is meant for local development, so it should have
the same behavior as `start` in this respect, and `start` also does not
use LavaMoat.

This significantly improves build times for local e2e development.
2022-12-13 12:32:09 -03:30
Mark Stacey
6d64951938
Move infuraProjectId to network controller constructor (#16884)
The network controller `setInfuraProjectId` method has been deleted.
The Infura project ID is only ever set upon construction, so it is now
passed in as a constructor parameter instead.

Rather than adding this as a second parameter, the network controller
now uses an "options bag" for constructor parameters. The initial state
was the first parameter, but it's now passed in as the `state` option
instead.

These changes make the API more similar to the mobile network
controller API.

This should have zero functional changes.

This relates to https://github.com/MetaMask/controllers/issues/971

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2022-12-13 12:09:21 -03:30
Frederik Bolding
659063b335
[FLASK] Allow Snaps UI to use Markdown for text formatting (#16911)
* Allow Snaps UI to use Markdown for text formatting

* Fix yarn audit and dedupe errors

* Update LavaMoat policies

* Fix lint

* Add paragraph wrapper component

* Fix lint
2022-12-13 15:37:20 +01:00