David Walsh
1b1d039310
EIP-1559 - Ensure form always displays when there are errors ( #11787 )
2021-08-05 20:25:23 -05:00
Alex Donesky
751534e665
fix confirm transaction details to match spec ( #11779 )
2021-08-05 20:07:04 -05:00
David Walsh
a0bd496d56
Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly ( #11781 )
2021-08-05 18:59:58 -05:00
Alex Donesky
804fefcd36
Separate out non blocking gas errors ( #11783 )
2021-08-05 17:53:48 -05:00
Alex Donesky
f9378b3aa2
Add fee level education button to swaps edit gas popover ( #11785 )
2021-08-05 17:10:04 -05:00
David Walsh
d5033249a2
Fix NumericInput proptype error ( #11773 )
2021-08-05 16:52:45 -05:00
Dan J Miller
c2bfa57981
Allow max fee to be equal to max priority fee ( #11778 )
2021-08-05 14:23:50 -02:30
dependabot[bot]
ffbd8771b3
Bump tar from 4.4.11 to 4.4.15 ( #11753 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 4.4.11 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v4.4.11...v4.4.15 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-05 14:23:49 -02:30
Dan J Miller
48bfd6c7f6
Use bignumber for number comparisons in useGasFeeInput ( #11776 )
...
* Use bignumber for number comparisons in useGasFeeInput
* fix
2021-08-05 14:23:49 -02:30
Dan J Miller
e9ef3b168a
Allow max fee to be equal to max priority fee ( #11778 )
2021-08-05 14:15:02 -02:30
dependabot[bot]
24d6456aaf
Bump tar from 4.4.11 to 4.4.15 ( #11753 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 4.4.11 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v4.4.11...v4.4.15 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-05 14:12:10 -02:30
Dan J Miller
0cf5019486
Use bignumber for number comparisons in useGasFeeInput ( #11776 )
...
* Use bignumber for number comparisons in useGasFeeInput
* fix
2021-08-05 13:52:56 -02:30
Dan Miller
29a29eb877
Add temporary entry to cla bot allowlist to workaround cla-bot bug
2021-08-05 13:29:11 -02:30
Dan J Miller
825e8b7bbf
Ensure that gas fee inputs fallback to tx params values if api is down ( #11775 )
...
* Ensure that gas fee inputs fallback to tx params values if down
* ensure getGasFeeEstimate fallback is a string
2021-08-05 10:49:24 -02:30
Dan J Miller
01262d33a4
Ensure that gas fee inputs fallback to tx params values if api is down ( #11775 )
...
* Ensure that gas fee inputs fallback to tx params values if down
* ensure getGasFeeEstimate fallback is a string
2021-08-05 08:33:49 -02:30
Dan J Miller
aa0f35a8ba
Ensure that gas fee minimum errors show when api is down ( #11767 )
...
* Fix legacy unapproved tx handling
* clean up
2021-08-04 20:24:40 -02:30
Dan J Miller
7384aea541
Fix legacy unapproved tx handling ( #11766 )
2021-08-04 20:24:40 -02:30
Mark Stacey
3b8faadaad
Update eth-phishing-detect
to latest version ( #11756 )
...
This update includes just configuration updates. There are no
functional changes. The updated config is only used as a fallback in
case the config update fails for some reason.
2021-08-04 20:24:40 -02:30
Alex Donesky
ab1cd1152e
tiny lost code change from 9.8.4 RC ( #11764 )
2021-08-04 20:24:40 -02:30
David Walsh
efed7c2980
EIP-1559 - Fix mislabeled MaxPriority fee key ( #11758 )
2021-08-04 20:24:40 -02:30
Alex Donesky
02c0cbede9
Stop GasFeeController polling when pop closes ( #11746 )
...
* Stop GasFeeController polling when pop closes
* Stop estimate gas polling on window unload
* lint + comments
* Improve client closed logic
* lint
* Add back _beforeUnload on unmount in gas-modal-page-container
* Add full check and call onClientClosed method for notifcation environment
* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type
* remove unused method
* move controller manipulation logic from background.js to metamask-controller, disaggregate methods
* add beforeunload handling to reset gas polling tokens from root of send page
* cleanup, lint and address feedback
* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller
* mock new methods to fix tests
* final bit of cleanup + comments
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 20:24:40 -02:30
David Walsh
1f578fcb1b
Provide pointer cursor for radio group buttons ( #11763 )
2021-08-04 20:24:40 -02:30
Dan J Miller
e1efc7170c
Show advanced options, and hide radio buttons, for advanced gas settings users ( #11751 )
...
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on
* Improve naming and copy
* lint fix
* Lint fix
2021-08-04 20:24:40 -02:30
David Walsh
5d7eba2684
EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate ( #11759 )
2021-08-04 20:24:40 -02:30
David Walsh
179f368ae5
EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail ( #11762 )
2021-08-04 20:24:40 -02:30
David Walsh
f17514489f
EIP-1559 - Remove unncessary props from AdvancedFormControls ( #11757 )
2021-08-04 20:24:40 -02:30
Dan J Miller
b9d5c431c1
Ensure gas fees update in popover on poll for new values ( #11760 )
2021-08-04 20:24:40 -02:30
Dan J Miller
9fcd93191b
Ensure that gas fee minimum errors show when api is down ( #11767 )
...
* Fix legacy unapproved tx handling
* clean up
2021-08-04 20:14:20 -02:30
Dan J Miller
818dc13019
Fix legacy unapproved tx handling ( #11766 )
2021-08-04 19:53:15 -02:30
Mark Stacey
d01b702b23
Update eth-phishing-detect
to latest version ( #11756 )
...
This update includes just configuration updates. There are no
functional changes. The updated config is only used as a fallback in
case the config update fails for some reason.
2021-08-04 19:44:46 -02:30
Alex Donesky
4245dac8d9
tiny lost code change from 9.8.4 RC ( #11764 )
2021-08-04 17:10:29 -05:00
David Walsh
e1de6e19af
EIP-1559 - Fix mislabeled MaxPriority fee key ( #11758 )
2021-08-04 17:07:17 -05:00
Alex Donesky
d359429f04
Stop GasFeeController polling when pop closes ( #11746 )
...
* Stop GasFeeController polling when pop closes
* Stop estimate gas polling on window unload
* lint + comments
* Improve client closed logic
* lint
* Add back _beforeUnload on unmount in gas-modal-page-container
* Add full check and call onClientClosed method for notifcation environment
* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type
* remove unused method
* move controller manipulation logic from background.js to metamask-controller, disaggregate methods
* add beforeunload handling to reset gas polling tokens from root of send page
* cleanup, lint and address feedback
* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller
* mock new methods to fix tests
* final bit of cleanup + comments
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 16:53:13 -05:00
David Walsh
96a13dddb5
Provide pointer cursor for radio group buttons ( #11763 )
2021-08-04 16:37:16 -05:00
Dan J Miller
a950111a19
Show advanced options, and hide radio buttons, for advanced gas settings users ( #11751 )
...
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on
* Improve naming and copy
* lint fix
* Lint fix
2021-08-04 19:04:42 -02:30
David Walsh
aa3d1f2341
EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate ( #11759 )
2021-08-04 16:17:20 -05:00
David Walsh
f0daa28fac
EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail ( #11762 )
2021-08-04 16:16:18 -05:00
David Walsh
a3c7bae345
EIP-1559 - Remove unncessary props from AdvancedFormControls ( #11757 )
2021-08-04 16:00:46 -05:00
Dan J Miller
3f4c988018
Ensure gas fees update in popover on poll for new values ( #11760 )
2021-08-04 18:27:14 -02:30
Alex Donesky
0dcdbdd99e
remove unnecessary conversion call ( #11742 )
...
* remove unnecessary conversion call
* Pass args to GasTiming as decGwei
* lint
2021-08-04 13:54:15 -02:30
ryanml
0eef0d424d
Fixing errors in EditGasDisplay ( #11748 )
2021-08-04 13:54:15 -02:30
Dan J Miller
8f50afb0dc
Allow max priority fee to be below 1, and only require it to be greater than 0 ( #11749 )
2021-08-04 13:54:15 -02:30
Dan J Miller
8a31aaadcb
Allows users to set a max priority fee below suggested, just showing a warning in that case ( #11750 )
2021-08-04 13:54:15 -02:30
Dan J Miller
17a4b5224a
Rename effective gas price field to total gas fee ( #11754 )
2021-08-04 13:54:15 -02:30
Dan Miller
836be61cea
Fix changelog
2021-08-04 12:27:15 -02:30
Alex Donesky
4552a53724
remove unnecessary conversion call ( #11742 )
...
* remove unnecessary conversion call
* Pass args to GasTiming as decGwei
* lint
2021-08-04 10:54:40 -02:30
ryanml
7902e62d8f
Fixing errors in EditGasDisplay ( #11748 )
2021-08-04 10:54:07 -02:30
Dan J Miller
b9fb495c7b
Allow max priority fee to be below 1, and only require it to be greater than 0 ( #11749 )
2021-08-04 10:53:52 -02:30
Dan J Miller
61b965a8a2
Allows users to set a max priority fee below suggested, just showing a warning in that case ( #11750 )
2021-08-04 10:53:19 -02:30
Dan J Miller
1acbb39dff
Rename effective gas price field to total gas fee ( #11754 )
2021-08-04 10:52:54 -02:30