Ariella Vu
fa15b32fab
ConfirmAddSuggestToken: replace mapDispatchToProps & mapStateToProps; Add Tests ( #13526 )
...
* ConfirmAddSuggestedToken: component.js -> .js
* replace mapStateToProps w/ useSelector
ConfirmAddSuggestedToken
* replace mapDispatchToProps w/ useDispatch
ConfirmAddSuggestedToken
* ConfirmAddSuggestedToken: useHistory
* ConfirmAddSuggestedToken: revert scss
reuse ConfirmImportToken styles for now
* ConfirmAddSuggestToken: add tests
* ConfirmAddSuggestedToken: rm unused controls
* ConfirmAddSuggestedToken: rm snapshot
* use `metamark.svg` instead of `metamask.svg`
* ConfirmAddSuggestedToken: update useSelectors
* Revert "ConfirmAddSuggestedToken: revert scss"
This reverts commit 07aed4576caaf247cb38ad481d79a339ba3d3947.
* ConfirmAddSuggestedToken: === undefined
w/ strict mode
* ConfirmAddSuggestedToken: use useNewMetricEvent
* ConfirmAddSuggestedToken: run useEffect once
* ConfirmAddSuggestedToken: rm unused async
* ConfirmAddSuggestedToken: rm mock redux store
* ConfirmAddSuggestedToken: duplicate ConfirmImportToken styles
* ConfirmAddSuggestedToken: update metrics logic
* ConfirmAddSuggestedToken: metricEvent-> trackEvent
* ConfirmAddSuggestedToken:clean useEffect w/ new fn
- PR suggestion: https://github.com/MetaMask/metamask-extension/pull/13526#discussion_r818007393
* ConfirmAddSuggestedToken: rm unused .token-balance styles
2022-03-10 23:40:06 -03:00
Brad Decker
9cea401022
extract determineTransactionType from tx controller ( #13737 )
2022-03-07 12:54:36 -06:00
Ariella Vu
a5b114c4f9
Use ActionableMessage for ConfirmAddSuggestionToken warnings ( #13402 )
...
* ConfirmAddSuggestedToken: update duplicate logic
* ConfirmAddSuggestedToken: update duplicate fn names
* ConfirmAddSuggestedToken: add ActionableMessage
- fixes #13347
* base-styles.scss: deprecate .warning
* ConfirmAddSuggestedTokens: update @param desc
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* ConfirmAddSuggestedTokens: update @param desc
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* ConfirmAddSuggestedTokens: update @param desc
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* ConfirmAddSuggestedTokens: update @param desc
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* ConfirmAddSuggestedToken: clean JSDoc comments
- following GitHub suggestion commits
* ConfirmAddSuggestedToken: warning Learn More btn
* add zendesk-url constants
- use for ConfirmAddSuggestedToken & ImportToken pages
* storybook: add ConfirmAddSuggestedToken controls
* stories: add ConfirmAddSuggestedTokens states
* stories: rm unused args ConfirmAddSuggestedToken
* rn ZENDESK_URL -> ZENDESK_URLS
* AddSuggestedToken: check case-insensitive symbols
Co-authored-by: Alex Donesky <adonesky@gmail.com>
2022-02-01 15:30:15 +00:00
Ariella Vu
667350d15a
Convert ConfirmAddSuggestedToken to a functional component + cleanup ( #13377 )
...
* FC: ConfirmAddSuggestedToken
- change class to functional component
* clean: reorganize functions (no logic change)
* FC: ConfirmAddSuggestedToken pt. 2
- preserve trackEvent logic -> metricsEvent
* clean: rm _ prefix from fn name
- why? now, only 3 other functions remain prefixed w/ '_'
* clean: update useEffect hook
* clean: alphabetize props
* clean: functions in ConfirmAddSuggestedToken
* clean: use arrow fn for FC
2022-01-25 20:16:56 +00:00
Mark Stacey
3732c5f71e
Add JSDoc ESLint rules ( #12112 )
...
ESLint rules have been added to enforce our JSDoc conventions. These
rules were introduced by updating `@metamask/eslint-config` to v9.
Some of the rules have been disabled because the effort to fix all lint
errors was too high. It might be easiest to enable these rules one
directory at a time, or one rule at a time.
Most of the changes in this PR were a result of running
`yarn lint:fix`. There were a handful of manual changes that seemed
obvious and simple to make. Anything beyond that and the rule was left
disabled.
2022-01-07 12:27:33 -03:30
Mark Stacey
22f931e6b2
Prevent automatic rejection of confirmations ( #13194 )
...
* Prevent automatic rejection of confirmations
Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.
This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.
It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.
* Fix bug that prevented automatic closure detection
All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.
* Re-open popup when necessary
After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
George Marshall
854fc71ae7
Organizing storybook to echo app folder structure ( #12796 )
...
* Organizing storybook to echo app folder structure
* Updating new stories to follow new convention from develop
2021-12-01 11:27:57 -08:00
Niranjana Binoy
68259ee3e2
UX Papercuts Epic: Create a consistent representation of the Buttons ( #12096 )
2021-10-05 15:20:42 -04:00
ryanml
c14f46eb92
Fixing confirm-add-suggested-token storybook entry ( #12261 )
2021-10-01 09:07:29 -07:00
kumavis
f472c2615a
CI - add metamaskbot comment "highlights" section for showing relevant storybook changes ( #12095 )
...
* ci/announce/highlight - add bot announcement section for "highlights" showing off important diffs + storybook highlights
* ci/announce/highlight - fix announcement message
* Update index.js
* xxx tmp xxx
* ci/announce/highlight - fix dirty file calculation
* ci/announce/highlight - try/catch wrap highlight generation for build stability
* ui - put fox emojis in the mascot component
* ci/announce/highlight - start storybook permalinks
* ci/announce/highlight - fix storybook permalink util
* ci/announce/highlight - fix storybook permalink util
* ci/announce/highlight - small styling fix
* storybook - use any easily predictable story id
* ci/announce/highlight - revert sample commit
* ci/announce/highlight - minimal documentation
2021-09-15 08:55:48 -10:00
Niranjana Binoy
05aadb38f2
Adding fake token warning and replacing Add Token labels with Import Tokens ( #11798 )
2021-09-10 16:21:04 -04:00
Alex Donesky
490d3b8d40
Integrate TokensController ( #11552 )
...
* Integrate controllers/tokensController
* address rebase issues
* small cleanup
* addressing feedback
* more feedback
2021-09-10 12:37:19 -05:00
Etienne Dusseault
09e79f273a
fix state problems with Storybook ( #11984 )
...
* fix state problems with Storybook
* lint
* lint
* Cleanup
Co-authored-by: ryanml <ryanlanese@gmail.com>
2021-09-07 13:51:41 -10:00
Etienne Dusseault
46c4cc1966
Add confirm-add-suggested-token & confirm-add-token components to Storybook ( #11175 )
...
* add suggessted token
* lintfix
* lintfix
* silence use effect warning
* download token icons and use paths to avoid web urls
* lintifx
* Add confirm-add-token component to Storyboard (#11195 )
* create story for add token
* change code
* add confirm add token story
* lintfix
* Update confirm-add-token.component.js
* Update confirm-add-token.component.js
* different token list for confirm add token
* lintfix
* Update confirm-add-suggested-token.component.js
* remove bnb png
* remove redundant images and fix storybook image path
2021-08-17 00:33:46 -05:00
Brad Decker
09d81ac5f2
remove the ui/app and ui/lib folders ( #10911 )
2021-04-28 14:53:59 -05:00
