Etienne Dusseault
435b663f5f
awaiting signature ( #11656 )
2021-08-17 00:30:58 -05:00
Dan J Miller
ae247ea14a
Improve flashing behaviour for loading gas estimates (on confirm screen) ( #11852 )
...
* Improve flashing behaviour for loading gas estimates
* Fix typo
* renderHeartBeatIfInTest
2021-08-16 20:18:24 -02:30
Dan J Miller
b919884c6e
Allow editing custom gas while estimate is loading ( #11853 )
2021-08-16 20:15:55 -02:30
David Walsh
01fd2a609e
Gas Timing with Negative attitude should be bold with tooltip ( #11772 )
2021-08-14 17:46:55 -05:00
David Walsh
b5baa6c1d1
EIP-1559 - Update tooltip text for gas fees ( #11805 )
2021-08-13 19:13:21 -05:00
David Walsh
df84a6efa6
Keep radio group contained and equal width ( #11771 )
2021-08-13 19:13:10 -05:00
ryanml
1837397202
Fixing persisting error message from MobileSyncPage ( #11835 )
2021-08-13 12:59:06 -07:00
Alex Donesky
a073e0bb7e
Add low/medium/high gas recommendations to the speedup/cancel gas popovers ( #11818 )
2021-08-13 11:36:45 -05:00
Daniel
410c4aec9a
Fix Insufficient number of substitutions for key "swapYourTokenBalance" ( #11833 )
...
* Fix Insufficient number of substitutions for key "swapYourTokenBalance"
* Use an empty string if there is no default symbol
* Add ? after SWAPS_CHAINID_DEFAULT_TOKEN_MAP[chainId]
2021-08-13 08:26:42 -07:00
ryanml
38b581cdfa
Return an empty string when date is not provided [Date display utils] ( #11831 )
2021-08-13 08:22:12 -07:00
ryanml
428b86fcf3
Hardening clipboardData handling in EnsInput ( #11822 )
2021-08-12 15:30:07 -07:00
David Walsh
e0692db7ba
Remove unwanted console.log from codebase ( #11820 )
2021-08-12 08:13:51 -05:00
ryanml
e57a2da647
Adjusting Max Fee label in EditGasDisplay per designs ( #11796 )
2021-08-10 15:36:35 -07:00
David Walsh
00572f5910
Correct the vertical margins on the RadioGroup component ( #11769 )
2021-08-10 16:56:16 -05:00
David Walsh
da79ac382e
Autofocus the unit fiend in send screen ( #11795 )
2021-08-10 16:56:07 -05:00
ryanml
504e74fbed
Fixing EditGasDisplay console errors ( #11797 )
2021-08-10 13:45:09 -07:00
David Walsh
2bb1c1a61d
Selected radio group label should be black ( #11770 )
2021-08-10 09:25:07 -05:00
Dan J Miller
e6543a83ef
Ensure transaction activity log supports EIP-1559 ( #11794 )
...
* Ensure transaction activity log supports EIP-1559
* unit test fix
* Add estimated base fee to swaps txMeta
* fix lint and tests
* Improve activity log copy
2021-08-06 19:48:53 -02:30
Alex Donesky
1216dc95c0
Hide gasTiming on edit-gas-popover when form is in error ( #11792 )
...
* Hide gasTiming on edit-gas-popover when form is in error
* Show unknown processing error if maxFeePerGas is too low for network conditions
* remove unnecessary change
* remove unnecessary function wrapper
2021-08-06 16:37:18 -05:00
Dan J Miller
bfde5a1d77
Fixes updates on the confirm screen. ( #11788 )
...
* Fixes updates on the confirm screen.
* Better handling of internal send transactions
* maxFee -> maxFeePerGas property name fix
* Remove redundant setEstimateToUse call in onManualChange
* Fix unit tests
* rebase error fix
* Fixes to speedup loading and transaction breakdown priority fee
* Fix lint and unit tests
* Ensure gas price based transaction that have been customized (e.g. speed up and retry) are properly initialized in useGasFeeInputs
* Clean up
* Link fix
2021-08-06 14:31:30 -05:00
David Walsh
1b1d039310
EIP-1559 - Ensure form always displays when there are errors ( #11787 )
2021-08-05 20:25:23 -05:00
Alex Donesky
751534e665
fix confirm transaction details to match spec ( #11779 )
2021-08-05 20:07:04 -05:00
David Walsh
a0bd496d56
Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly ( #11781 )
2021-08-05 18:59:58 -05:00
Alex Donesky
804fefcd36
Separate out non blocking gas errors ( #11783 )
2021-08-05 17:53:48 -05:00
Alex Donesky
f9378b3aa2
Add fee level education button to swaps edit gas popover ( #11785 )
2021-08-05 17:10:04 -05:00
David Walsh
d5033249a2
Fix NumericInput proptype error ( #11773 )
2021-08-05 16:52:45 -05:00
Dan J Miller
e9ef3b168a
Allow max fee to be equal to max priority fee ( #11778 )
2021-08-05 14:15:02 -02:30
Dan J Miller
0cf5019486
Use bignumber for number comparisons in useGasFeeInput ( #11776 )
...
* Use bignumber for number comparisons in useGasFeeInput
* fix
2021-08-05 13:52:56 -02:30
Dan J Miller
01262d33a4
Ensure that gas fee inputs fallback to tx params values if api is down ( #11775 )
...
* Ensure that gas fee inputs fallback to tx params values if down
* ensure getGasFeeEstimate fallback is a string
2021-08-05 08:33:49 -02:30
Dan J Miller
9fcd93191b
Ensure that gas fee minimum errors show when api is down ( #11767 )
...
* Fix legacy unapproved tx handling
* clean up
2021-08-04 20:14:20 -02:30
Dan J Miller
818dc13019
Fix legacy unapproved tx handling ( #11766 )
2021-08-04 19:53:15 -02:30
Alex Donesky
4245dac8d9
tiny lost code change from 9.8.4 RC ( #11764 )
2021-08-04 17:10:29 -05:00
David Walsh
e1de6e19af
EIP-1559 - Fix mislabeled MaxPriority fee key ( #11758 )
2021-08-04 17:07:17 -05:00
Alex Donesky
d359429f04
Stop GasFeeController polling when pop closes ( #11746 )
...
* Stop GasFeeController polling when pop closes
* Stop estimate gas polling on window unload
* lint + comments
* Improve client closed logic
* lint
* Add back _beforeUnload on unmount in gas-modal-page-container
* Add full check and call onClientClosed method for notifcation environment
* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type
* remove unused method
* move controller manipulation logic from background.js to metamask-controller, disaggregate methods
* add beforeunload handling to reset gas polling tokens from root of send page
* cleanup, lint and address feedback
* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller
* mock new methods to fix tests
* final bit of cleanup + comments
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 16:53:13 -05:00
David Walsh
96a13dddb5
Provide pointer cursor for radio group buttons ( #11763 )
2021-08-04 16:37:16 -05:00
Dan J Miller
a950111a19
Show advanced options, and hide radio buttons, for advanced gas settings users ( #11751 )
...
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on
* Improve naming and copy
* lint fix
* Lint fix
2021-08-04 19:04:42 -02:30
David Walsh
aa3d1f2341
EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate ( #11759 )
2021-08-04 16:17:20 -05:00
David Walsh
f0daa28fac
EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail ( #11762 )
2021-08-04 16:16:18 -05:00
David Walsh
a3c7bae345
EIP-1559 - Remove unncessary props from AdvancedFormControls ( #11757 )
2021-08-04 16:00:46 -05:00
Dan J Miller
3f4c988018
Ensure gas fees update in popover on poll for new values ( #11760 )
2021-08-04 18:27:14 -02:30
Alex Donesky
4552a53724
remove unnecessary conversion call ( #11742 )
...
* remove unnecessary conversion call
* Pass args to GasTiming as decGwei
* lint
2021-08-04 10:54:40 -02:30
ryanml
7902e62d8f
Fixing errors in EditGasDisplay ( #11748 )
2021-08-04 10:54:07 -02:30
Dan J Miller
b9fb495c7b
Allow max priority fee to be below 1, and only require it to be greater than 0 ( #11749 )
2021-08-04 10:53:52 -02:30
Dan J Miller
61b965a8a2
Allows users to set a max priority fee below suggested, just showing a warning in that case ( #11750 )
2021-08-04 10:53:19 -02:30
Dan J Miller
1acbb39dff
Rename effective gas price field to total gas fee ( #11754 )
2021-08-04 10:52:54 -02:30
Alex Donesky
615380b76d
Remove estimate detail above advanced gas controls in non-1559 network ( #11744 )
...
* Remove estimate detail above advanced gas controls in non-1559 network
* lint
* remove gasEstimate localization text
2021-08-03 14:34:24 -05:00
ryanml
7f0b2a81ce
Fall back to aggregator name when icon is unavailable (Swaps Load View) ( #11718 )
2021-08-03 12:09:39 -07:00
David Walsh
24d563fc2c
EIP-1559 - Show minium native currency in banner when on testnets ( #11743 )
2021-08-03 12:51:02 -05:00
Daniel
deae2d47bf
Fix a position of a tooltip icon ( #11739 )
2021-08-03 18:10:12 +02:00
Alex Donesky
a4927a30ac
Add gasPrice to be used on non-1559 networks for transaction details on confirm screen ( #11741 )
2021-08-03 10:56:49 -05:00
