1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-25 03:20:23 +01:00
Commit Graph

17893 Commits

Author SHA1 Message Date
Mark Stacey
ec23b00fc6 Update protobufjs checksum 2023-08-30 16:21:06 -02:30
Brad Decker
e801714992 fix weird lockfile irregularities (#20333)
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-30 16:21:06 -02:30
Mark Stacey
180ac559b8 Remove snapshot update from release process (#20546)
The Sentry e2e state snapshots now mask the application version and
migration version, ensuring that the snapshots don't need a extra
update in each release candidate branch and post-release sync branch.

The values are masked rather than removed so that the test still shows
they are present in error reports, where they can be quite useful for
diagnostic purposes.
2023-08-30 16:21:06 -02:30
Pedro Figueiredo
19b6baefb4 fix: Remove obsolete network controller state properties (#20586)
* fix: remove obsolete network controller state properties

* address comments

* address comments

* address comments

* Add additional precautions for data mutation in migration tests

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-30 16:21:06 -02:30
Brad Decker
e2c4816394 split advancedGasFee by network and erase previous options (#20576)
* Split out advanced gas fees by network and delete old values

* use arrow functions in preferences test

* changes

* added back priorityFeeProperCase to en messages

* update types

* remove case change
2023-08-30 16:21:06 -02:30
Mark Stacey
b684c094cb Fix account selectors when balances are missing (#20385)
* Fix account selectors when balances are missing

Some of the account selectors we use would return an empty set of
accounts if the `AccountTracker` state was missing. This resulted in UI
crashes when trying to access the current selected account.

The selectors have been updated to use the `identities` as the source-
of-truth for the full set of accounts. This ensures that even if the
balances are missing, each account will at least be represented by an
empty object.

* Fix unit test

* Fix another unit test

* Fix another unit test

* Fix another unit test

* Fix more unit tests

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-30 16:21:06 -02:30
OGPoyraz
d5de0dd67e Fix infinite rerender on network change while active signature request (#20473) 2023-08-30 16:21:06 -02:30
cryptodev-2s
656b7878c2
Use getEncryptionPublicKey from Core KeyringController (#20646) 2023-08-30 18:10:37 +01:00
Dhruv
9d59ec5f61
fix/BannerTip to TS (#20538)
* BannerTip to TS

* removing actionButtonProps control from storybook file

* fixing console errors in storybook

* BannerTip docs fixes, prop fixes and test updates

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-30 10:07:32 -07:00
Subhajit Ghosh
8b93092e0e
Declared <IconWithFallback/> as deprecated (#20656)
* Add the deprecation JSDoc format below to the deprecated code and added deprecation notice to the icon-with-fallback.stories.js

* Declared <IconWithFallback/> as deprecated
2023-08-30 09:47:12 -07:00
weizman
982a1b2c51
Bump @metamask/post-message-stream and extension-port-stream core libs (#20659) 2023-08-30 18:32:17 +03:00
Ariella Vu
3f5bc978dd
Fix Blockaid and OpenSea BannerAlert placement for Token Allowance, Confirm Pages, SIWE, and Signature V3/V4 pages (#20530)
* refactor: add SecurityProviderBannerAlert ...props

* fix: mv security banner alerts on TokenAllowance

* fix: mv security BannerAlert in confirm page
https://github.com/MetaMask/MetaMask-planning/issues/1195

* fix: allow BlockaidBannerAlert null details

* refactor: rm SecurityProviderBannerAlert margin

* fix: SIWE security banner alert placement

* fix: rm extra banner alert padding for sig v3 & v4

* fix: update SecurityProviderBannerAlert snapshot

* fix: update BlockaidBannerAlert snapshot

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-30 07:05:53 -07:00
Michele Esposito
e2be27ed01
Use verifySeedPhrase from KeyringController (#19817)
refactor: use verifySeedPhrase from core KeyringController

---------

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
2023-08-30 14:59:22 +01:00
ftNikhil.eth
4f14178033
Update network.ts (#20617)
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-08-30 17:16:15 +05:30
Subhajit Ghosh
131321af00
Declared <TextField/> as deprecated (#20640)
* Declared <TextField/> as deprecated

* Declared <TextField/> as deprecated
2023-08-29 19:38:20 -07:00
Pedro Figueiredo
827c2fb741
feat: Add more state props from controllers to Sentry mask (#20595)
* feat: update sentry mask adding  controller props to improve error monitoring

* fix:remove changes in chrome-driver dependency

* Remove properties from mask

* Add more values to mask

* Sort the mask alphabetically

* Add termsOfUseLastAgreed to mask

* Fix test imports

* Update policy gap test to compare UI mask

* Reorganize tests under one describe block

* Update snapshots

* Mask another timestamp in state snapshots

* Mask browser environment properties

* Add missing UI field mask, and refactor field masking/removal

* Eliminate remaining policy gaps

* Simplify ganache options

* Eliminate extra mask properties

* Update mask to capture dynamic keys

The mask now supports dynamic keys. This lets set more fine-grained rules
for which data to include within dynamic data structures.

The mask has been updated to include just top-level keys for various
token-related data collections in state. This lets us see the chain IDs
that users have tokens on. This will be useful in debugging Sentry
reports of invalid keys in these data structures.

* Add additional 'expected missing state' entries

* Remove unnecessary properties from state snapshot

* Add providerConfig.chainId to state snapshot

* Update error state snapshots

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-29 20:47:58 -02:30
Dhruv
a889681e99
deprecating SiteOrigin in favour TagUrl (#20620)
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-29 14:26:44 -07:00
Monte Lai
3747bc61ef
fix: overflow of link and warnings (#20375)
* fix: overflow of link and warnings

* fix: update snapshot

* --wrapped in React.memo HOC
--changed Website to a clickable link
--slightly better overflow wrapping, but the best would be to wrap on dots and slashes

* updated snapshot

---------

Co-authored-by: Howard Braham <howrad@gmail.com>
2023-08-29 17:22:53 -04:00
Brad Decker
863362dc37
Add whats new popup for changes to advanced gas fee (#20632)
* Add whats new popup for changes to advanced gas fee

* Update shared/notifications/index.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* updated text

* verified working, changed order of init

* use first renderer for formatting issue

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-29 16:15:35 -05:00
Mark Stacey
0c9a61aabe
Merge pull request #20637 from MetaMask/master-sync
Sync `develop` with v10.35.0
2023-08-29 17:27:34 -02:30
George Marshall
e2789cbe82
Adding correct types so ButtonBase and all button variants ButtonPrimary, ButtonSecondary, ButtonLink and Button accept Text props (#20647) 2023-08-29 12:09:01 -07:00
Nidhi Kumari
6a17d76efc
UX Multichain: Added Select an action Modal (#20559)
* added select-action-modal skeleton

* added select action modal item

* replaced stake link with constant

* added route for open and close of modal

* updated lint errors

* lint fix

* updated tests

* revert unnecessary changes

* fixed lint errors

* added suggestions

* lint fix

* updated test

* nit fix

* updated select action item to use button

* removed unused fragments

* moved onClose command to bottom

* moved select action modal on footer click

* changed isDisabled to disabled

* added hover and updated test

* nit fix
2023-08-29 22:15:30 +05:30
Nidhi Kumari
215430236e
Created new route for connections (#20556)
* created new route for connections

* remove unnecessary code

* added connections component

* fixed connections route

* moved connections to pages in multichain

* moved connections route to multichain feature flag
2023-08-29 22:08:29 +05:30
Nidhi Kumari
b8b94c2c1f
UX Multichain: Added balance-overview component (#20528)
* added balance-overview component

* updated balance overview component to use Currency utility props

* added MULTICHAIN feature flag

* lint fix

* lint fix

* lint fix

* updated ternary operators
2023-08-29 22:07:23 +05:30
Frederik Bolding
ebae98d301 Bump snaps packages to 1.0.2 (#20643) 2023-08-29 15:45:41 +02:00
Frederik Bolding
6254fbb98d
Bump snaps packages to 1.0.2 (#20643) 2023-08-29 15:33:10 +02:00
Daniel
bf1c087275
Capture exceptions (#20562) 2023-08-29 15:15:33 +02:00
Daniel
4e14e179c8
Update UI for blocked tokens, use the latest dev gas api URL (#20625) 2023-08-29 14:38:46 +02:00
Mark Stacey
c065468832 Merge remote-tracking branch 'origin/develop' into master-sync
* origin/develop: (302 commits)
  Added deprecatation comment to menu.js file and Add deprecation notice to storybook (#20622)
  deprecating NetworkDisplay in favour of PickerNetwork (#20619)
  deprecating ConfirmPageContainerWarning in favour of BannerAlert (#20621)
  deprecating Dialog in favour of BannerAlert (#20623)
  Fixing linting issue caused by bad merge of HoldToRevealModal and the Button component library component TS migration (#20634)
  Feat/18890/button ts update (#20492)
  20488: Declare <Chip/> as deprecated (#20579)
  fix: Remove obsolete network controller state properties (#20586)
  Fix Sentry source maps (#20616)
  Track snap uninstalls (#20624)
  split advancedGasFee by network and erase previous options (#20576)
  Part of #20163 for file ui\components\app\detected-token\detected-token-values\detected-token-values.js (#20537)
  Fix account selectors when balances are missing (#20385)
  fix:fix error of balance fetching when add/import an account (#20612)
  fix:remove extra $ after variale in french locale (#20606)
  Multichain v1 App Footer component (#20550)
  Updating watch NFT page header (#20569)
  Always show connected accounts permissions if they exist (#20600)
  Update snaps-related copy (#20601)
  Added missing bindings (#20602)
  ...
2023-08-29 00:44:06 -02:30
Subhajit Ghosh
877e184b29
Added deprecatation comment to menu.js file and Add deprecation notice to storybook (#20622) 2023-08-28 19:31:19 -07:00
Dhruv
b6ad074b9a
deprecating NetworkDisplay in favour of PickerNetwork (#20619) 2023-08-28 16:06:56 -07:00
Dhruv
a455b6ddc1
deprecating ConfirmPageContainerWarning in favour of BannerAlert (#20621) 2023-08-28 16:06:10 -07:00
Dhruv
7e1ed4bb0b
deprecating Dialog in favour of BannerAlert (#20623) 2023-08-28 16:03:41 -07:00
George Marshall
0cbd22d0e4
Fixing linting issue caused by bad merge of HoldToRevealModal and the Button component library component TS migration (#20634) 2023-08-28 16:01:05 -07:00
Garrett Bear
66292330fe
Feat/18890/button ts update (#20492)
* button to TS migration

working demo

style props

broken mapping - need switch

working types file

working types

fix dependent imports of Button

variant mapping

working types

fix lint

fix test

fix ButtonSize issue on QuizContent

box fix

test if this works

fix button being used on QuizContent

fix button_variant import

readme fix

* fix button import

* fix primary button as anchor hover

* deprecated

* button to TS migration

fix lint

fix test

* fix rebase issue

* fix rebase issue

* lint fix
2023-08-28 14:42:00 -07:00
Jase Balderrama
c54212916b
20488: Declare <Chip/> as deprecated (#20579)
* Add @deprecated JSDoc to <Chip/>

* Add deprecated banner to <Chip/> stories

* Fix linting error

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Import 'Severity' via existing import statement

* Add propTypes for <Deprecated/> wrapper

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-08-28 14:12:28 -05:00
Pedro Figueiredo
4c88961a39
fix: Remove obsolete network controller state properties (#20586)
* fix: remove obsolete network controller state properties

* address comments

* address comments

* address comments

* Add additional precautions for data mutation in migration tests

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-28 14:25:56 -02:30
Mark Stacey
551cd3d2af
Fix Sentry source maps (#20616)
Sentry source maps were broken a few weeks back, and then fixed in the
PR #20122. The fix was to add a leading slash to our file paths in the
source maps.

This fix was accidentally undone recently in #19552, which is an
otherwise unrelated change. I suspect this was committed accidentally
due to local testing of #20122 around the same time.

This PR restores the file path change made in #20122
2023-08-28 11:21:14 -02:30
Frederik Bolding
a1ae305711 Track snap uninstalls (#20624)
* Track snap uninstalls

* Change order of execution
2023-08-28 15:29:43 +02:00
Frederik Bolding
4374e536a1
Track snap uninstalls (#20624)
* Track snap uninstalls

* Change order of execution
2023-08-28 15:27:52 +02:00
Maarten Zuidhoorn
a292158324 Always show connected accounts permissions if they exist (#20600)
* Show connected accounts permissions if they exist

* Add optional chaining
2023-08-28 09:58:18 +02:00
Maarten Zuidhoorn
8d63fabc4e Update snaps-related copy (#20601)
* Update snaps-related copy

* Update test
2023-08-28 09:58:15 +02:00
ryanml
d847272f93 Fixing Dapp link on NFT import screen (#19799) 2023-08-27 16:25:39 -02:30
ryanml
9323701f9b Fixing 'View on Opensea' link for main and testnet NFTs (#19797) 2023-08-27 16:25:30 -02:30
Dan J Miller
d0e7bfddfc Ensure chainId comparison in switchEthereumChain handler is case insensitive (#20149) 2023-08-27 16:25:21 -02:30
Nicholas Ellul
63dd03e6e7 Enforce user preferences in incoming transactions controller (#19982)
* Enforce user preferences in incoming transactions controller

* Combine various conditions to determine tx lookup

* Update tests to not use private methods
2023-08-27 16:25:13 -02:30
Brad Decker
64aef2a1c9
split advancedGasFee by network and erase previous options (#20576)
* Split out advanced gas fees by network and delete old values

* use arrow functions in preferences test

* changes

* added back priorityFeeProperCase to en messages

* update types

* remove case change
2023-08-26 17:58:26 -07:00
Harsh Shukla
a35df21b7f
Part of #20163 for file ui\components\app\detected-token\detected-token-values\detected-token-values.js (#20537)
* Part of #20163 for file ui\components\app\detected-token\detected-token-values\detected-token-values.js

* Update ui/components/app/detected-token/detected-token-values/detected-token-values.js

---------

Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-08-26 08:27:10 -07:00
Mark Stacey
3044aa0ebe
Fix account selectors when balances are missing (#20385)
* Fix account selectors when balances are missing

Some of the account selectors we use would return an empty set of
accounts if the `AccountTracker` state was missing. This resulted in UI
crashes when trying to access the current selected account.

The selectors have been updated to use the `identities` as the source-
of-truth for the full set of accounts. This ensures that even if the
balances are missing, each account will at least be represented by an
empty object.

* Fix unit test

* Fix another unit test

* Fix another unit test

* Fix another unit test

* Fix more unit tests

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-26 00:28:24 -02:30
Danica Shen
c3f907fe4f
fix:fix error of balance fetching when add/import an account (#20612) 2023-08-25 20:05:28 +01:00