Ariella Vu
3f5bc978dd
Fix Blockaid and OpenSea BannerAlert placement for Token Allowance, Confirm Pages, SIWE, and Signature V3/V4 pages ( #20530 )
...
* refactor: add SecurityProviderBannerAlert ...props
* fix: mv security banner alerts on TokenAllowance
* fix: mv security BannerAlert in confirm page
https://github.com/MetaMask/MetaMask-planning/issues/1195
* fix: allow BlockaidBannerAlert null details
* refactor: rm SecurityProviderBannerAlert margin
* fix: SIWE security banner alert placement
* fix: rm extra banner alert padding for sig v3 & v4
* fix: update SecurityProviderBannerAlert snapshot
* fix: update BlockaidBannerAlert snapshot
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-30 07:05:53 -07:00
Garrett Bear
70a13296c9
Feat/18889/update buttonlink ts ( #20372 )
...
* fix buttonlink alignment
* ButtonLink TS migration
* fix lint
* remove ButtonBase loading error feat
* move padding 0 to ButtonBase
* fix color issue
* fix test file
* fix snapshot
* Update ui/components/component-library/button-link/README.mdx
Co-authored-by: George Marshall <george.marshall@consensys.net>
* readme fix
* Update ui/components/component-library/button-link/button-link.stories.tsx
Co-authored-by: George Marshall <george.marshall@consensys.net>
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-04 14:00:05 -07:00
jainex
52c44924e3
Part #19737 - Replace deprecated FormField component with TextField, Label, HelpText ( #19859 )
...
* Replacing deprecated components for component library components
* Update
* Lint fix
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-03 15:30:41 -07:00
Monalisha Mishra
b46501cc0d
migration of button icon to use TS box version ( #20227 )
...
* migration of button icon to use TS box version
* fixed lint issues
* Some convention and linting updates
* README fixes
* Updating snapshot
* snapshot updates
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-03 12:23:47 -07:00
Alex Donesky
6594f7074e
adapt to use networksMetadata state instead of single networkStatus and networksDetails state ( #20219 )
2023-08-03 12:31:35 -05:00
Jyoti Puri
8c46f85764
Confirmation page alerts ( #20125 )
2023-08-03 16:24:54 +05:30
Dhruv
d375dc550d
Part of #18714 : Replacing deprecated constants ( #19843 )
...
* replacing constants
* updating ButtonLink component
* Updates to responsive typography
* lint fixes
* snapshot updates
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:37:16 -07:00
George Marshall
25247d0300
Updating Icon types and component to use TS Box component ( #19990 )
2023-07-25 09:05:37 -07:00
George Marshall
733391a964
Update Text import paths: /pages ( #20117 )
...
* Updating remaining Text import paths
* Updating snapshots
2023-07-20 12:49:35 -07:00
George Marshall
bf61322ee1
Update Text import paths: /app ( #20083 )
...
* Updating import paths
* Updating snapshots
* Fixing lint issues
* Updating snapshots
2023-07-19 15:32:35 -07:00
George Marshall
f9649a27f8
Update Text import paths: /ui ( #20076 )
...
* Updating Text import paths in ui folder
* Updating snapshot
2023-07-19 10:55:38 -07:00
George Marshall
5d17f86e02
Update Text import paths: component library/ ( #19987 )
...
* Updating component-librar import paths
* Updating snapshots
* Updates to AvatarBase story
* Updates to avatar and checkbox
* Updating last of the deprecated import paths
* Updating component-library snapshots from button-base
* Updating snapshots from rest of codebase to do with button-base
* Removing unneeded CSS
* Updating snapshots
2023-07-17 14:00:16 -07:00
George Marshall
74cc312cb1
Updating Text and import paths ( #19949 )
2023-07-14 10:59:30 -07:00
Vladimir Saric
36eaaa19ed
Added customize tx nonce on ERC20 approve screen when feature is enabled ( #17945 )
2023-07-12 14:32:46 -04:00
Garrett Bear
c206200918
Update ButtonBase text variant and fix font smoothing ( #19883 )
...
* Update ButtonBase text variant
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-07-12 07:37:33 -07:00
Niranjana Binoy
129f6f3f64
Token allowance flow update ( #19666 )
2023-07-11 10:57:59 -04:00
Ariella Vu
34375a57e5
Security Provider cleanup ( #19694 )
...
* security-prov: isFlaggedSecurityProviderResponse
* security-prov: create shared/modules/util
* security prov: rn isFlagged -> isSuspcious
- util fn returns true if response is not verified and flagged
* security prov: add util test
and support undefined param
* security prov: reorg util fn
- no logic changes
2023-06-23 20:08:22 +02:00
Harsh Shukla
398b0cf452
Part of #17670 & #18714 : Replace Typography with Text component: token-allowance.js ( #18742 )
...
* Update token-allowance.js
* Remove fontWeight prop in: ui/pages/token-allowance/token-allowance.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/token-allowance/token-allowance.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update token-allowance.js
* Update ui/pages/token-allowance/token-allowance.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Update ui/pages/token-allowance/token-allowance.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-05-04 22:08:43 +05:30
Mark Stacey
d1cea85f33
Rename provider to providerConfig ( #18907 )
...
* Rename `provider` to `providerConfig`
The network controller `provider` state has been renamed to
`providerConfig`. This better reflects what this state is, and makes
this controller more closely aligned with the core network controller.
All references to the provider configuration have been updated to
prefer `providerConfig` over `provider`, to make the distinction clear
between a provider and provider config.
Closes #18902
* Add migration
2023-05-02 13:23:20 -02:30
Jyoti Puri
9d794e97b3
Fix in approve header to show correct account name ( #18849 )
2023-04-28 13:29:53 +05:30
Jyoti Puri
82a64195a2
Enable editing L2 gas on optimism ( #18217 )
2023-04-26 05:43:38 +05:30
Garrett Bear
3e520214c9
update icons to ts enum version ( #18698 )
...
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-24 09:19:19 -05:00
Jyoti Puri
5892acab81
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-18 20:53:45 -02:30
Dan J Miller
39f6042e65
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-18 17:19:49 -02:30
Niranjana Binoy
fedd6d4970
New reusable gas-display component ( #17976 )
2023-04-17 10:34:26 -04:00
Jyoti Puri
a2bec15c68
Improvement on approval pages ( #18545 )
2023-04-13 22:54:33 +05:30
Filip Sekulic
54aeb1b791
Replace contract with third party within the token allowance flow ( #18101 )
2023-04-11 08:49:42 +05:30
George Marshall
739075662c
Migrating Icon to typescript and deprecating JS component ( #18431 )
...
* Migrating Icon to typescript and deprecating JS component
* gw suggestions (#18434 )
---------
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-04-04 09:48:04 -07:00
Dan J Miller
41210084dd
Allow specific origin to direct to second page of token allowance flow ( #18395 )
...
* Allow specific origin to direct to second page of token allowance flow
* Remove accidentally committed git diff text
---------
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
2023-03-31 11:34:55 -02:30
Mark Stacey
d6b49ae383
Refactor KeyringTypes constant ( #17490 )
...
The `HardwareKeyringTypes` constant has been renamed to `KeyringTypes`
and moved to a separate constants module, to reflect that it contains
more than just hardware wallet keyring types. This corrects a mistake
made recently during a TypeScript conversion.
2023-03-21 12:13:22 -02:30
Filip Sekulic
c477e29397
Fixed hardware wallet info popup on token allowance screen ( #17881 )
2023-03-14 12:29:31 -05:00
Alex Donesky
23ca4460cf
Migrate network configurations (previously frequentRpcListDetail) from PreferencesController to NetworkController ( #17421 )
2023-03-09 15:00:28 -06:00
amerkadicE
505f1f5445
Token allowance unit tests ( #17019 )
...
* Token allowance unit tests
Fix lint
Fix test
Fix token allowance unit tests
Add txData in state for token allowance unit test
Treshold bumped
Run pipeline
Treshold bumped
Treshold bumped
Treshold bumped
* Update tests
* Update tests
2023-02-23 16:57:12 +01:00
Vladimir Saric
4c598b330e
Display the address icon for the contract requesting spending cap instead of the dapp/url icon ( #17858 )
2023-02-23 15:54:04 +01:00
Niranjana Binoy
769efc9fe3
Disable fiat conversion in Approve Screen when Show balance and token price checker is OFF ( #17443 )
2023-02-03 12:13:19 -05:00
Nidhi Kumari
41d3dcc8a3
updated tag icon ( #17540 )
2023-02-02 17:13:49 -08:00
Danica Shen
794f3039f1
feature: migrate design-system.ts ( #17518 )
2023-02-02 20:15:26 +00:00
Vladimir Saric
308151cd49
Display a warning and gas fee component for token allowance and NFT flow when transaction is expected to fail ( #17437 )
...
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-02-01 17:14:09 -06:00
Nidhi Kumari
c5368c152b
Added storybook check to CI ( #17092 )
...
* added storybook test runner
* added test runner in ci
* updated test for ci and fixed lint error
* updated lavamoat policy
* updated test command
* updated playwright
* changed command to storybook;ci
* updated command
* updated instance for test-storybook
* updated playwright
* added playwright step
* replaced concurrently with start-server-and-test
* updated the static storybook directory
* replaced first with last
* updated lock file
* replaced first with last
* updated test-storybook with maxworkers
* updated .depchechrc
* updated yml
* removed id from banner base
* replaced broken stories with .stories-to-do.js extesnsion
* updated token allowance story
* removed duplicacies from yarn
* fixed lavamoat
* removed filename comment
* updated links for docs
* fixed file extension for stories
* updated path for stories.json
* updated stories.json path
* yarn updated
* updated stories
* updated yarn
* updated wait on
2023-01-21 00:57:46 +05:30
Vladimir Saric
c82c967c46
Fixing error when user input some letter in token allowance flow ( #17117 )
...
* Fixing error when user input some letter in token allowance flow
* Rename the regex variable name and added a brief comment above its definition
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-01-18 10:53:10 +01:00
Filip Sekulic
fc83a1b631
Fixed navigation through multiple unapproved transactions for ERC20 tokens ( #16822 )
2023-01-11 09:01:50 -06:00
Adnan Sahovic
fbbc1df853
Display large and small numbers as decimals instead of scientific notation on token allowance confirmation screens ( #16676 )
...
Co-authored-by: VSaric <vladimir.saric@consensys.net>
Co-authored-by: Vladimir Saric <92527393+VSaric@users.noreply.github.com>
2023-01-05 08:58:16 -06:00
Vladimir Saric
11f24deef6
Added reject transactions modal to be present in the footer of the approve screen ( #16832 )
...
* Added reject transactions modal in the footer
* Use Button component for multiple unapproved tx
2022-12-13 13:33:35 +01:00
Jyoti Puri
8125473dc5
Removing flag for EIP1559 V2 support ( #16446 )
2022-12-09 00:07:06 +05:30
Adnan Sahovic
6f21c4837d
Token allowance i18n interpolation system ( #16347 )
...
* added i18n interpolation system to token-allowance screen
* modified revokeSpendingCap
* Fixed minor type error
* resolved conflicts
2022-11-25 06:56:29 -03:30
Niranjana Binoy
5666d0a71c
Resetting spending cap value to empty when a token allowance request is rejected. ( #16659 )
2022-11-24 14:14:41 -05:00
Adnan Sahovic
f7cb1844d6
Skip the first token allowance screen if dapp proposing spending cap is 0 ( #16502 )
2022-11-17 08:12:44 -06:00
Filip Sekulic
17c1fef9be
Token allowance screen updated ( #16157 )
2022-11-07 12:21:38 -06:00
ryanml
c88efadf1e
Remove ETH badge from NetworkAccountBalanceHeader when on non-ETH net… ( #16102 )
...
* Remove ETH badge from NetworkAccountBalanceHeader when on non-ETH networks
* Network specific icons, or fallback, in the network-account-balance-header
* Update snapshots
* Code cleanup
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2022-10-25 17:03:45 +02:00
Filip Sekulic
a993509afc
Review spending cap screen ( #15919 )
2022-10-05 14:48:35 -05:00
