1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-01 21:57:06 +01:00
Commit Graph

698 Commits

Author SHA1 Message Date
MetaMask Bot
31d5c1cf22
Version v10.18.4 RC (#15643)
* Version v10.18.4

* Fix default currency symbol for `wallet_addEthereumChain` + improve warnings for data that doesn't match our validation expectations (#15201)

* set more appropriate default for ticker symbol when wallet_addEthereumChain is called

* throw error to dapp when site suggests network with same chainId but different ticker symbol from already added network, instead of showing error and disabled notification to user

* Fix Provider Tracking Metrics (#15082)

* fix filetype audit (#15334)

* Remove decentralized 4byte function signature registry since it contains incorrect signatures and we can't algorithmically check for best option when 4byte.directory is down (#15300)

* remove decentralized 4byte function signature registry since it is griefed and we can't algorithmically check for best option when 4byte is down

* add migration

* remove nock of on chain registry call in getMethodDataAsync test

* remove audit exclusion (#15346)

* Updates `eth-lattice-keyring` to v0.10.0 (#15261)

This is mainly associated with an update in GridPlus SDK and enables
better strategies for fetching calldata decoder data.
`eth-lattice-keyring` changes:
GridPlus/eth-lattice-keyring@v0.7.3...v0.10.0
`gridplus-sdk` changes (which includes a codebase rewrite):
GridPlus/gridplus-sdk@v1.2.3...v2.2.2

* Fix 'block link explorer on custom networks' (#13870)

* Created a logic for the 'Add a block explorer URL'

Removed unused message

Message logic rollback

Modified history push operation

WIP: Pushing before rebasing

Applied requested changes

Removed unintenionally added code

* Lint fix

* Metrics fixed

* Stop injecting provider on docs.google.com (#15459)

* Fix setting of gasPrice when on non-eip 1559 networks (#15628)

* Fix setting of gasPrice when on non-eip 1559 networks

* Fix unit tests

* Fix logic

* Update ui/ducks/send/send.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* [GridPlus] Bumps `eth-lattice-keyring` to v0.11.0 (#15490)

* [GridPlus] Bumps `gridplus-sdk` to v2.2.4 (#15561)

* remove exclusions for mismatched object jsdoc type casing (#15351)

* Improve `tokenId` parsing and clean up `useAssetDetails` hook (#15304)

* Fix state creation in setupSentryGetStateGlobal (#15635)

* filter breadcrumbs for improved clarity while debugging sentry errors (#15639)

* Update v10.18.4 changelog (#15645)

* Auto generated changelog

* Update 10.18.4 changelog

* Run lavamoat:auto

* Call metrics event for wallet type selection at the right time (#15591)

* Fix Sentry in LavaMoat contexts (#15672)

Our Sentry setup relies upon application state, but it wasn't able to
access it in LavaMoat builds because it's running in a separate
Compartment.

A patch has been introduced to the LavaMoat runtime to allow the root
Compartment to mutate the `rootGlobals` object, which is accessible
from outside the compartment as well. This lets us expose application
state to our Sentry integration.

* Fix Sentry deduplication of events that were never sent (#15677)

The Sentry `Dedupe` integration has been filtering out our events, even
when they were never sent due to our `beforeSend` handler. It was
wrongly identifying them as duplicates because it has no knowledge of
`beforeSend` or whether they were actually sent or not.

To resolve this, the filtering we were doing in `beforeSend` has been
moved to a Sentry integration. This integration is installed ahead of
the `Dedupe` integration, so `Dedupe` should never find out about any
events that we filter out, and thus will never consider them as sent
when they were not.

* Replace `lavamoat-runtime.js` patch (#15682)

A patch made in #15672 was found to be unnecessary. Instead of setting
a `rootGlobals` object upon construction of the root compartment, we
are now creating a `sentryHooks` object in the initial top-level
compartment. I hadn't realized at the time that the root compartment
would inherit all properties of the initial compartment `globalThis`.

This accomplishes the same goals as #15672 except without needing a
patch.

* Update v10.18.4 changelog

* Fix lint issues

* Update yarn.lock

* Update `depcheck` to latest version (#15690)

`depcheck` has been updated to the latest version. This version pins
`@babel/parser` to v7.16.4 because of unresolved bugs in v7.16.5 that
result in `depcheck` failing to parse TypeScript files correctly.

We had a Yarn resolution in place to ensure `@babel/parser@7.16.4` was
being used already. That resolution is no longer needed so it has been
removed. This should resove the issue the dev team has been seeing
lately where `yarn` and `yarn-deduplicate` disagree about the state the
lockfile should be in.

* Update yarn.lock

* Update LavaMoat policy

* deduplicate

* Update LavaMoat build policy

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Alex Miller <asmiller1989@gmail.com>
Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
Co-authored-by: seaona <mariona@gmx.es>
Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
2022-08-24 19:57:47 +01:00
Dan J Miller
a4f0944517 Ensure smart contract interactions are properly represented on the confirm screen (#15446)
* Ensure smart contract interactions are properly represented on the confirm screen

* Fix unit tests

* Code cleanup

* Cleanup

* Code cleanup

* Fix test
2022-08-03 19:51:44 -02:30
Alex Donesky
8d20c2834f Add setApprovalForAll confirmation view (#15010)
* enhance setApprovalForAll confirmation flow

* cleanup

* address feedback
2022-07-11 22:02:56 -02:30
Niranjana Binoy
bafc235928
Disable Seedphrase import button after switching seedphrase length (#15139) 2022-07-07 11:37:21 -04:00
PeterYinusa
79d0a2c8ba
Update wallet-overview.js (#15125) 2022-07-01 12:35:40 -02:30
Brad Decker
94967072f7
Remove global transaction state from send flow (#14777)
* remove global transaction state from send slice

* fixup new test
2022-07-01 08:58:35 -05:00
Dan J Miller
f4b25d7ea5
Ensure native asset icon does not display incorrectly when switching networks and balance is loading (#15116) 2022-07-01 10:38:42 -02:30
Filip Sekulic
43f7a44c25
Adding popular custom network integration (#14557)
* Initial push

* Refactored the code

* Additional code

* Removed the unused message

* Added a tooltip

* Fixed tests

* Lint fix

* Added style to a tooltip

* Fix e2e test failure

* Lint fix and code revert

* Fix e2e test

* Fixed paddings

* Fixed paddings

* CSS fix

* Minified svg files

* Applied requested changes

* Fixed theme issue

* Code revert

* Added back overridden code

* Icon problem fixed

* Lint fix

* Replaced H3 with H4

* Added unit test

* Added breadcrumbs

* Added const props for networks

* Lint fix

* Lint fix

* Added toggle button for showing the custom network list and resolved few issues

* Fixed routes

* Refactored a piece of code

* Enabled searching for the newly created option

* Fixed unit test

* Updated theme
2022-06-30 13:49:07 -02:30
Alex Donesky
3a31326199
Add fallback image/card for NFTs when image was not fetched correctly or does not exist (#15034)
* add fallback image/card for collectibles when image was not fetched correctly or does not exist

* UI and storybook updates (#15071)

* UI and storybook updates

* Adding break so token id is displayed

* subtle border fix

* Updating content

* Removing unused image

* Adding proptype descriptions

* Lint fix

Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-06-30 08:46:38 -07:00
David Walsh
6ffd0ce063
Fix 14802 - Prevent children error in page container (#14809) 2022-06-21 18:38:39 -05:00
George Marshall
051254dffd
Fixing tooltip theming by enforcing default theme (#14992)
* Fixing tooltip theming by enforcing background color

* Removing wide prop
2022-06-21 09:50:44 -07:00
daniba
085126d275
Move search icon and add to storybook (#14940)
* move search icon || update imports || add to story

* Optimized svg path, updated icon api and updating colors

* update other icons

* update snapshot

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2022-06-21 10:18:35 -05:00
Zachary Belford
5a1bc94aa4
Changed accounts fuzzy search threshhold to match all (#14914)
* Changed accounts fuzzy search threshhold to match all

* Changed account search only when there is at least 2 terms

* Fixed linting issue

* Lint fix account menu component
2022-06-20 15:35:07 -07:00
Guillaume Roux
25739a5fc1
[FLASK] Fix notifications icon color (#14941) 2022-06-20 23:23:51 +02:00
白宦成
adbd1c79be
fix EditGasDisplay (#13980)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-17 13:04:59 -05:00
George Marshall
fdf3e9d2d7
Fix/14856 network settings page (#14857)
* Removing other features code

* Improving acccessibility of check icon

* Fixing add network button footer in popover view

* Fixing unit tests
2022-06-15 13:16:53 -07:00
Ariella Vu
73488766b6
SB:EditGasDisplay: fix error (#14946) 2022-06-15 14:55:04 -05:00
Ariella Vu
1771ed4925
ErrorMessage: add @deprecated (#14945) 2022-06-15 13:45:54 -05:00
David Walsh
ea49b40d33
Make the accounts menu accessible (#14936) 2022-06-15 12:49:18 -05:00
Soralit
804db7f1dc
fix animated qr in dark mode (#14900) 2022-06-13 16:07:51 -05:00
VSaric
f9edbf50ce
Empty balance while switching network (#14354) 2022-06-13 14:39:48 -05:00
VSaric
136218893b
Fix contact address pet name (#14613)
* The contact pet name isn't replaced by the recipients address

* Create getEnsResolutionByAddress selector and use it in the codebase

* Modified the getRecipient selector such that it returns an ens resolution as the nickname if a nickname isn't present but a ens resolution is.

* Update ui/ducks/send/send.js

Co-authored-by: Brad Decker <bhdecker84@gmail.com>

* Checked if ens resolution is present in the getRecipient selector

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-06-13 11:18:33 -05:00
Zachary Belford
7dc6a5feaa
Merge pull request #14837 from MetaMask/prop-type-fixups
Prop type fixups
2022-06-10 12:36:31 -07:00
ryanml
54e83d659d
Fix padding issue in Edit Nickname screen (#14842)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-08 15:56:14 -07:00
Zachary Belford
d882835cae
Added PR feedback changes 2022-06-08 14:24:50 -07:00
Zachary Belford
8b09f84502
Linting fixups 2022-06-08 14:24:50 -07:00
Zachary Belford
5e049aabff
Remove junk from previous ticket 2022-06-08 14:24:49 -07:00
Zachary Belford
9c8b22a20b
Changed to address to optional for TransactionDecoding component 2022-06-08 14:24:36 -07:00
Zachary Belford
c2d5bd01c4
Changed networks tab to explicitly pass in false and fix implicit type casting 2022-06-08 14:24:36 -07:00
Zachary Belford
9ec652d0da
Changed transaction decoding component to put keys on data items 2022-06-08 14:24:35 -07:00
Zachary Belford
29d87343fa
Changed update nickname popover to remove proptype errors 2022-06-08 14:24:35 -07:00
Zachary Belford
5c93ca44da
Changed asset option prop type requirements 2022-06-08 14:24:34 -07:00
Thomas Huang
18e4af7690
Unit test proptype (#14868)
* Add missing props to advanced tab component test.

* Add icon size prop to site icon test

* Add hardwareWalletRequiresConnection prop to signature request test as a boolean

* Add setShowDetectedTokens prop to detect token test

* Set Setting description prop to be either object or string.
2022-06-06 19:30:07 -07:00
VSaric
914cdd5fa5
Fix switching between ETH and USD (#13827) 2022-06-06 08:11:14 -05:00
George Marshall
c18c3b078e
Updating icon color (#14835) 2022-06-03 12:45:03 -07:00
Victor Korzunin
0166575405
fix: keep lock button text inside button boundaries (#14335)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-03 12:16:44 -07:00
Ariella Vu
e60af93f2a
Storybook: add TransactionListItem component page (#14786)
* TransactionListItem: add storybook page

* SB:TransactionListItem: update retry status

* SB:TranslationListItem: exclude CANCEL & RETRY

* TransactionListItem: exclude SIGNED status

* TransactionListItem: fix mock transactions

* SB:TransactionListItem: add isEarliestNonce param

* SB:TransactionListItem: fix args

* SB:TransactionListItem: add "Speed Up" params

* SB: add nonce to mock transactions
2022-06-03 12:50:23 -05:00
$tocker
ba7a177f5c
fix design breaks on the Settings Navbar when Internationalization (#14012)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-06-03 12:33:59 -05:00
Frederik Bolding
239f5f7fa6
Include snap version in pill (#14803)
* Include snap version in pill

* snaps authorship styling

* styling

* Fix linting

* Fix linting

Co-authored-by: eriknson <eriks@mail.se>
2022-06-02 11:38:39 +02:00
Guillaume Roux
b599035a12
Snap notifications integration (#14605)
* begin controller implentation

* add NotificationController

* create selectors and actions

* update actions tu use forceUpdateMetamaskState

* Basic notification UI

* fix typo and remove console.log

* lint

* more css

* add notifications scroll

* add translations and fix some css

* Fix rebase and edit colors

* add flask tags

* add flask tag to routes component

* add missing flask tags

* add tests

* fix tests

* store notification expiration delay in constant

* address requested changes

* rename to unreadNotificationsCount

* add missing flask tag
2022-06-01 19:09:13 +02:00
Thomas Huang
db6998c66a
Fix proptype errors in network dropdown, tx list item details, and account details modal tests (#14747) 2022-05-31 09:46:38 -07:00
benlwyre
f6643e853c
Add fiat onboarding for AVAX and MATIC through Wyre (#14683) 2022-05-27 11:04:26 -05:00
Ariella Vu
b6ade44bc9
Slight cleanup of constants/transactions, useTransactionDisplayData, and TransactionIcon (#14784)
* TransactionIcon: alphabetize categories

* useTransactionDisplayData: rm repetitive comment

* useTransactionDisplayData: mv signatureTypes

* useTxDisplayData: import transactionGroup @typedef

* userTxDisplayData: just vertical line spacing
2022-05-26 16:26:45 -05:00
Frederik Bolding
5b8a69c721
Remove site origin on snap install (#14752)
* Remove site origin on snap install

* Fix linting + storybook

* Update local snap icon

* Fix storybook build
2022-05-25 18:19:02 +02:00
George Marshall
8fcbebc546
Update design tokens library from 1.5 to 1.6 WIP (#14732)
* Updating account menu icon color

* Updating design-tokens and making appropriate updates to extension styles

* Adding more deprecated tags to colors

* Adding spinner and removing todo comment

* Remove comment

* Updates

* Updating snapshots

* More color and ui updates

* reverting transition change
2022-05-25 08:35:36 -07:00
VSaric
623fd91d65
Fix currency conversion rate (#14713) 2022-05-24 15:16:11 -05:00
Frederik Bolding
c833e41eee
Restore SiteOrigin chip on permission screen (#14768)
* Restore SiteOrigin chip on permission screen

* Fix linting
2022-05-24 18:04:07 +02:00
VSaric
e7d1476522
Sign button is enabled after scrolling all the way to the bottom (#14745) 2022-05-24 10:28:40 -05:00
Ariella Vu
e06e5599bb
EditGasFeeBtn: Insufficient number of substitutions for key "dappSuggestedTooltip" (#14734)
* EditGasFeeBtn: support missing origin dappSuggest

* EditGasFeeButton: add tooltip min-width

* EditGasFeeButton: tooltip min-width needs extra px

* EditGasFeeBtb: tooltip min-width add a bit more px
2022-05-23 15:04:54 -05:00
Alex Donesky
634cf70a71
Enhance reusable SiteOrigin component (#14720)
* extend and reuse SiteOrigin component
2022-05-20 09:35:18 -05:00