Frankie
b5d6452454
Disallow loading as metamaskNetworkId ( #5924 )
...
* transactions - throw an error if a transaction is generated while the network is loading
* add tests for failing when netId is loading
2018-12-13 09:14:46 -10:00
Alexander Tseung
d8ab9cc002
Group transactions by nonce ( #5886 )
2018-12-09 12:48:06 -08:00
Dan Miller
9b9a2cc2e0
Adds createSpeedUpTransaction to txController
2018-12-04 00:06:05 -03:30
Dan Finlay
c7233e2cc7
Fixed Vivek's bug ( #5860 )
...
* Fixed Vivek's bug
Fixes #5850
What was happening:
It seems that his MetaMask had crashed while some new transactions had
been loading defaults. He probably had a network connectivity issue to
Infura (which we are working with Infura to address).
As a result of this network cutout, his three unapproved transactions
were not marked failed, and were not marked as `loadingDefaults =
false`, as their gas prices had not yet been estimated.
Normally this behavior is supposed to clean itself up when the
transaction controller starts up, via the
`TransactionController._onBootCleanUp()` function, but in this case,
during unlock, that function was unable to do its job because when it
requested the transaction list, the current network was in the `loading`
state, making it proceed as if there were no pending transactions.
To fix this, I am doing two things:
- Setting transactions to loadingDefaults = false in more catch blocks.
- Calling `onBootCleanUp()` when the network store's status changes, so
that it will re-trigger when loading completes.
* Fixed reference
* Fixed infinite loop bug
Was refreshing the tx list on every tx state change instead of just
network changes, creating an infinite loop.
* Add notes to tx updates to clarify logs
2018-11-29 16:08:03 -08:00
Frankie
a803522a92
transactions/tx-gas-utils - add the acctual response for eth_getCode for NO_CONTRACT_ERROR's && add a debug object to simulationFailed ( #5840 )
2018-11-29 10:07:05 -08:00
Frankie
8198ec9ae1
Autofill gasPrice for retry attempts with either the recommended gasprice or a %10 bump ( #5786 )
...
* transactions - autofill gasPrice for retry attempts with either the recomened gasprice or a %10 bump
* lint
2018-11-26 09:29:14 -10:00
Frankie
97c1e6bcc1
transactions - ensure err is defined when setting tx failed ( #5801 )
2018-11-26 09:00:58 -10:00
Whymarrh Whitby
1988e1e96b
ESLint fixes ( #5775 )
...
* eslint . --fix
* Upgrade all ESLint warnings to errors
2018-11-16 14:54:55 -10:00
Frankie
ce147bf6d8
Tx controller now uses safe event emitter ( #5769 )
...
* transactions - use safe-event-emitter over events
* tests - pass a platform object on init with a noop showTransactionNotification
* test - fix for tx-state-history-helper trying to reduce an empty array
* deps - safe-event-emitter
* lint
2018-11-16 10:34:08 -08:00
Dan Finlay
22ba0b0c2d
Resubmit approved transactions on new block ( #5752 )
...
* Add beginning of test
* Resubmit approved transactions on new block
May fix #4343 and related issues, where an error could leave
transactions stranded in the approved state.
* Remove unused test
* Re-approve transactions when retrying approved
* Add retry approved test
* Include approved in pending tx count
* Fix getPendingTxs()
* Linted
* Only throw hash error in submitted state
* Only check submitted txs for block inclusion
* Fix test expectations
2018-11-14 11:34:07 -10:00
kumavis
31e5cad1e3
tx-gas-util - set error message when invalidating tx based on tx data but no contract code
2018-10-21 01:01:21 -04:00
kumavis
3b46478024
Merge branch 'develop' into develop
2018-10-20 23:48:10 -04:00
Alexander Tseung
c821a8354c
Add txReceipt data to transaction details ( #5513 )
2018-10-16 06:00:47 +08:00
Whymarrh Whitby
af43b7d6c9
Ensure that new transactions added are using the selected address
2018-10-10 16:16:20 -02:30
Whymarrh Whitby
428a7cacdf
Revert "transactions - add txReceipt to the txMeta body for confirmed txs ( #5375 )"
...
This reverts commit ff67293a8e
.
2018-10-10 15:30:12 -02:30
Frankie
ff67293a8e
transactions - add txReceipt to the txMeta body for confirmed txs ( #5375 )
2018-10-10 10:26:38 -04:00
kumavis
600f755dbf
tx-gas-utils - improve format + comments
2018-10-09 23:17:05 -04:00
Howard Braham
4cc0b1ef01
ganache-core merged my PR, so I changed some comments to clarify that ganache-core v2.2.1 and below will return the non-standard '0x0'
2018-10-09 15:31:25 -07:00
Howard Braham
222e62d7f1
Bug Fix : #1789 and #4525 eth.getCode() with no contract
2018-10-09 15:31:25 -07:00
Dan Finlay
507397f6c3
Fix updating of pending transactions
...
Transaction statuses were not being properly updated when:
- MetaMask was unlocked
- The network was changed
This PR fixes both of those. Fixes #5174
2018-10-05 10:35:14 -07:00
Alexander Tseung
5a6c333506
Switch existing modals from using Notification to Modal. Remove Notification component. Add CancelTransaction modal
2018-09-19 14:31:10 -07:00
Frankie
1552fe1c3e
Merge pull request #5216 from MetaMask/tx-cancel
...
Add createCancelTransaction method
2018-09-10 13:29:29 -10:00
Alexander Tseung
43de189d06
Add createCancelTransaction method
2018-09-10 12:48:01 -07:00
Whymarrh Whitby
7c3b69e1e4
Attach the RPC error value to txMeta
2018-09-08 19:59:50 -02:30
Thomas Huang
024ebe07e0
Merge branch 'develop' into network-remove-provider-engine-tests
2018-08-01 10:40:31 -07:00
Thomas
138858647e
Merge branch 'develop' into network-remove-provider-engine
2018-07-25 22:38:44 -07:00
Jenny Pollack
00bae74475
tx-gas-utils - catch all errors from gas estimation
2018-07-24 14:16:37 -07:00
Thomas Huang
5a45df72c6
Merge pull request #4669 from MetaMask/removeNonceTrackerFunction
...
Remove unsued nonce tracker function
2018-07-12 11:48:05 -07:00
Thomas
5188b727d4
Merge branch 'develop' into removeNonceTrackerFunction
2018-07-10 11:34:00 -07:00
frankiebee
28c509914b
Merge branch 'develop' of https://github.com/MetaMask/metamask-extension into i#3896
2018-07-10 11:32:05 -07:00
kumavis
77daed5c74
Merge branch 'develop' of github.com:MetaMask/metamask-extension into network-remove-provider-engine
2018-07-03 12:42:14 -07:00
brunobar79
a8f745f9fe
eslint --fix .
2018-07-02 18:49:33 -04:00
kumavis
a89902c170
Merge branch 'develop' of github.com:MetaMask/metamask-extension into network-remove-provider-engine
2018-07-02 13:54:05 -07:00
frankiebee
9b92ba4c47
trandsactions - remove rejected transactions from history
2018-06-25 15:07:54 -07:00
tmashuang
dd18684a5d
Remove unsued nonce tracker function
2018-06-25 15:01:14 -07:00
kumavis
33cb0a8cb2
lint - fix recipient-blacklist.js
2018-06-15 11:07:56 -07:00
kumavis
83c02f90cf
blacklist - recipient blacklist as js for inline comments
2018-06-15 10:47:42 -07:00
kumavis
753743e746
Update recipient-blacklist-config.json
2018-06-15 10:32:09 -07:00
Dan Finlay
a42299aab7
Add apparent phishing address to block list
...
In [this reddit post](https://www.reddit.com/r/Metamask/comments/8r3nsu/help_me_please_somebody_stole_my_ethers/ ) a user suggests they got some ether stolen after visiting IDEX. Their ether was sent to [this address](https://etherscan.io/address/0x9bcb0a9d99d815bb87ee3191b1399b1bcc46dc77 ), which is full of comments of people telling similar stories of being phished on IDEX. I think we can safely block this, and probably safe some people some money.
2018-06-15 08:55:39 -07:00
kumavis
604289c96c
controllers - transaction - prefer log over console
2018-06-12 12:08:06 -07:00
kumavis
177cc3f280
metamask - ensure all nonce locks are released
2018-06-12 11:51:35 -07:00
kumavis
8f93e34175
nonce-tracker - wrap nonce calculations in try-catch and release lock on error
2018-06-12 11:31:26 -07:00
kumavis
c86f935889
nonce-tracker - wrap nonce calculations in try-catch and release lock on error
2018-06-12 10:55:54 -07:00
kumavis
2198276bd5
Merge branch 'develop' of github.com:MetaMask/metamask-extension into network-remove-provider-engine
2018-06-06 12:05:38 -07:00
kumavis
9d77b0a196
Merge branch 'develop' of github.com:MetaMask/metamask-extension into network-remove-provider-engine
2018-06-06 11:08:29 -07:00
Csaba Solya
1dda0c6469
remove generating blocked accounts and use a config file instead
2018-05-30 21:15:59 +02:00
Csaba Solya
3e489ea165
fix documentation
2018-05-30 17:42:41 +02:00
Csaba Solya
cf73581c0e
adding tests for recipient blacklist checker
2018-05-30 17:38:27 +02:00
Csaba Solya
6affd8f949
adding transaction controller tests
2018-05-30 16:24:40 +02:00
Csaba Solya
afb5788861
initial implementation
2018-05-30 15:53:18 +02:00
kumavis
4205d92729
Merge branch 'master' of github.com:MetaMask/metamask-extension into merge-master
2018-05-29 16:12:36 -07:00
kumavis
58de5671cc
controllers - transactions - fix tx status update on boot
2018-05-29 00:53:44 -07:00
kumavis
16d0db15e0
controllers - transactions - fix tx confirmation
2018-05-29 00:41:28 -07:00
kumavis
1b3fedd10d
controllers - transaction - pending-tx-tracker - lint fix
2018-05-28 15:54:47 -07:00
kumavis
5be154ea20
controllers - transactions - merge @frankiebee's work with mine
2018-05-28 14:29:31 -07:00
Anton
71a6e97327
cleanErrorStack moved to separate library module
...
more errors traces cleaned up
2018-05-28 22:57:08 +02:00
Anton
1d23a5c81b
error message fix
2018-05-28 18:08:33 +02:00
Anton
62dc6e20eb
Clean up user rejection error message
2018-05-28 17:57:45 +02:00
kumavis
9f8d5f0547
controllers - transactions - pending-tx-tracker - _getBlock - poll until block is truthy
2018-05-25 13:30:26 -07:00
kumavis
61ef4f1f29
tx-gas-utils - query for block without tx bodies
2018-05-25 13:21:42 -07:00
frankiebee
61caee9d94
Merge branch 'network-remove-provider-engine' of https://github.com/MetaMask/metamask-extension into transactions-use-new-block-tracker
2018-05-22 16:45:20 -07:00
frankiebee
c4b09da34e
transactions - update pending-tx-tracker to use the new block tracker
2018-05-22 16:42:06 -07:00
frankiebee
10aecf4922
remove dependance on the even tx:confirmed
2018-05-22 16:40:01 -07:00
kumavis
3a80f3dd83
Merge branch 'develop' of github.com:MetaMask/metamask-extension into network-remove-provider-engine
2018-05-22 13:20:04 -07:00
Frankie
e8b2e11c56
Reveal get filtered tx list ( #4332 )
...
* add getFilteredTxList from txController to getApi
* transactions - remove dead code (isNonceTaken)
2018-05-21 16:00:44 -07:00
kumavis
088d7930e0
network - create provider and block-tracker via json-rpc-engine
2018-05-16 20:46:34 -07:00
kumavis
8e1cad5ff6
tx-state-history-helper - use more readable Date.now method
2018-05-16 13:05:07 -07:00
Csaba Solya
2081768fc5
fix lint issues
2018-05-10 13:43:31 +02:00
Csaba Solya
3642810584
remove unnecessary lib
2018-05-10 13:34:56 +02:00
Csaba Solya
349fb9e0bc
revert unnecessary change in state manager
2018-05-10 13:33:40 +02:00
Csaba Solya
9026651224
add time stamps to transaction history log entries
2018-05-10 13:26:02 +02:00
bitpshr
6351b7bb88
Fix documentation typo
2018-05-07 15:08:43 -04:00
frankiebee
a45cb75435
transactions - add a nonce check utility for ui use
2018-05-01 13:57:43 -07:00
frankiebee
62bf76db53
fix - getTxsByMetaData check if the key is in the object not if the value is truthy
2018-05-01 13:57:14 -07:00
frankiebee
98ae853b6c
require log
2018-04-30 09:57:36 -07:00
frankiebee
706647785c
log emitter errors
2018-04-29 16:35:08 -07:00
frankiebee
7eb735651b
transactions - run event emitters outside context of _setTxStatus
2018-04-29 16:32:16 -07:00
frankiebee
8ffce8b59d
transactions - more docs and clean ups
2018-04-25 11:13:51 -07:00
Dan Finlay
621e9334bc
Cleaned up some typos and JSDocs in Transactions
...
Nonce tracker is not fully documented yet.
Have not yet touched:
- tx-state-manager
- tx-state-history-helper
- util
- tx-gas-utils
- pending-tx-tracker
2018-04-23 09:43:18 -07:00
frankiebee
e862a5091e
transactions - fix refernces
2018-04-19 12:07:45 -07:00
frankiebee
c20c97ce62
Merge branch 'master' into tx-controller-rewrite-v3
2018-04-19 11:49:11 -07:00
frankiebee
eeb9390de8
meta - transactions - docs yo!
2018-04-19 11:46:15 -07:00
frankiebee
943eea043c
fix up - more docs
2018-04-13 13:18:45 -07:00
frankiebee
88f4212363
meta - transactions - code clean up and jsDoc
2018-04-13 12:38:07 -07:00
frankiebee
3aaa28531e
transactions - code cleanup
2018-04-12 12:24:16 -07:00
frankiebee
5494aa4f9c
transactions - lint fixes
2018-04-10 14:54:30 -07:00
frankiebee
2d7c3c2b00
meta - transactions - create a transactions dir in controller and move relevant files into it
2018-04-10 14:28:05 -07:00