5 Commits

Author	SHA1	Message	Date
Whymarrh Whitby	c66449f823	Disable semicolons for class props (#7754)	2020-01-07 16:40:44 -03:30
Mark Stacey	49a525b9f8	Add react/no-unused-prop-types ESLint rule (#7655) ... * Add `react/no-unused-prop-types` rule All detected unused prop types have been removed. I have attempted to ensure these props are no longer passed in either. * Update handling of props to avoid false positive lint errors These cases were detected by `react/no-unused-prop-types` as being unused props, even though they were used. These minor adjustments prevent them from being flagged as errors. * Update unit tests Many of these tests were just checking that specific props were passed from containers or to a child component. These were deleted, as I can't imagine how they'd be useful. * Disable `react/no-unused-prop-types` in `componentWillReceiveProps The rule `react/no-unused-prop-types` doesn't seem to be detecting props used within `UNSAFE_componentWillReceiveProps`. The two cases have been disabled temporarily until we can replace these unsafe lifecycle functions.	2019-12-07 23:10:47 -04:00
Whymarrh Whitby	2e69f3233e	eslint: Enable more react/jsx-* rules (#7592)	2019-12-03 13:05:44 -03:30
Whymarrh Whitby	b0890b6b32	Enforce a single boolean attr notation in JSX (#7465) ... This changeset enables the ESLint rule enforcing a single notation for boolean attributes in JSX—explictly setting the value to `true` is no longer allowed (as it was never needed).[1] From the docs for JSX:[2] > If you pass no value for a prop, it defaults to `true`. [1]:https://github.com/yannickcr/eslint-plugin-react/blob/80935658/docs/rules/jsx-boolean-value.md [2]:https://reactjs.org/docs/jsx-in-depth.html#props-default-to-true I have chosen to use this default as it the most consistent with HTML (a la `checked` and `disabled`).	2019-11-18 19:53:41 -03:30
Chi Kei Chan	931aaeb700	Add token selection to the send screen (#6445) ... * Move send to pages/ * Fix unit tests * Finish UI * Integrate asset dropdown to send actions * Remove console.log * Hide asset change during edit * Enable switch from send token to seand eth * Enable switching from token to eth when editing * Fix linter * Fixing test * Fix unit tests * Fix linter * Fix react warning; remove console.log * fix flat test * Add metrics * Address code review comments * Consistent spacing between send screen form rows. * Reduce height of gas buttons on send screen. * Make send screen gas button height dependent on size of contents.	2019-04-17 16:45:13 -02:30