Mark Stacey
82141f1fb1
Merge pull request #11804 from MetaMask/master-sync
...
Sync `master` with `develop`
2021-08-11 13:20:56 -02:30
ryanml
e57a2da647
Adjusting Max Fee label in EditGasDisplay per designs ( #11796 )
2021-08-10 15:36:35 -07:00
ryanml
88aff9bab1
Revert "Add temporary entry to cla bot allowlist to workaround cla-bot bug"
...
This reverts commit 29a29eb877
.
2021-08-10 15:21:26 -07:00
ryanml
e34db34cda
Merge remote-tracking branch 'origin/develop' into master-sync
2021-08-10 15:21:05 -07:00
ryanml
ce3160a1f5
Fixing devDependencies package ordering ( #11806 )
2021-08-10 15:19:52 -07:00
kumavis
d75795b73f
add appropriate test timeouts ( #11667 )
...
Co-authored-by: Etienne Dusseault <etienne.dusseault@gmail.com>
2021-08-10 15:09:42 -07:00
David Walsh
00572f5910
Correct the vertical margins on the RadioGroup component ( #11769 )
2021-08-10 16:56:16 -05:00
David Walsh
da79ac382e
Autofocus the unit fiend in send screen ( #11795 )
2021-08-10 16:56:07 -05:00
ryanml
504e74fbed
Fixing EditGasDisplay console errors ( #11797 )
2021-08-10 13:45:09 -07:00
Alex Donesky
6059f997f7
bump path-parse version to address security vulnerability ( #11807 )
2021-08-10 15:11:28 -05:00
David Walsh
2bb1c1a61d
Selected radio group label should be black ( #11770 )
2021-08-10 09:25:07 -05:00
Dan J Miller
bdb66708d2
Merge pull request #11731 from MetaMask/Version-v10.0.0
...
Version v10.0.0 RC
2021-08-10 09:53:23 -02:30
Dan J Miller
de388a7b1c
Ensure transaction activity log supports EIP-1559 ( #11794 )
...
* Ensure transaction activity log supports EIP-1559
* unit test fix
* Add estimated base fee to swaps txMeta
* fix lint and tests
* Improve activity log copy
2021-08-06 19:49:33 -02:30
Dan J Miller
e6543a83ef
Ensure transaction activity log supports EIP-1559 ( #11794 )
...
* Ensure transaction activity log supports EIP-1559
* unit test fix
* Add estimated base fee to swaps txMeta
* fix lint and tests
* Improve activity log copy
2021-08-06 19:48:53 -02:30
Alex Donesky
9566cd09c0
Hide gasTiming on edit-gas-popover when form is in error ( #11792 )
...
* Hide gasTiming on edit-gas-popover when form is in error
* Show unknown processing error if maxFeePerGas is too low for network conditions
* remove unnecessary change
* remove unnecessary function wrapper
2021-08-06 19:30:11 -02:30
Dan J Miller
738d2722c5
Fixes updates on the confirm screen. ( #11788 )
...
* Fixes updates on the confirm screen.
* Better handling of internal send transactions
* maxFee -> maxFeePerGas property name fix
* Remove redundant setEstimateToUse call in onManualChange
* Fix unit tests
* rebase error fix
* Fixes to speedup loading and transaction breakdown priority fee
* Fix lint and unit tests
* Ensure gas price based transaction that have been customized (e.g. speed up and retry) are properly initialized in useGasFeeInputs
* Clean up
* Link fix
2021-08-06 19:30:10 -02:30
Daniel
29948f3c3a
Fix fee level content ( #11790 )
2021-08-06 19:30:10 -02:30
Alex Donesky
1216dc95c0
Hide gasTiming on edit-gas-popover when form is in error ( #11792 )
...
* Hide gasTiming on edit-gas-popover when form is in error
* Show unknown processing error if maxFeePerGas is too low for network conditions
* remove unnecessary change
* remove unnecessary function wrapper
2021-08-06 16:37:18 -05:00
Dan J Miller
bfde5a1d77
Fixes updates on the confirm screen. ( #11788 )
...
* Fixes updates on the confirm screen.
* Better handling of internal send transactions
* maxFee -> maxFeePerGas property name fix
* Remove redundant setEstimateToUse call in onManualChange
* Fix unit tests
* rebase error fix
* Fixes to speedup loading and transaction breakdown priority fee
* Fix lint and unit tests
* Ensure gas price based transaction that have been customized (e.g. speed up and retry) are properly initialized in useGasFeeInputs
* Clean up
* Link fix
2021-08-06 14:31:30 -05:00
Daniel
827e6a6efc
Fix fee level content ( #11790 )
2021-08-06 15:52:28 +02:00
David Walsh
39e5750981
EIP-1559 - Ensure form always displays when there are errors ( #11787 )
2021-08-06 01:45:53 -02:30
Alex Donesky
2089767d96
fix confirm transaction details to match spec ( #11779 )
2021-08-06 01:45:53 -02:30
David Walsh
0377e2c64e
Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly ( #11781 )
2021-08-06 01:45:53 -02:30
Alex Donesky
99fecbf6d2
Separate out non blocking gas errors ( #11783 )
2021-08-06 01:45:53 -02:30
Alex Donesky
f3995b72b0
Add fee level education button to swaps edit gas popover ( #11785 )
2021-08-06 01:45:53 -02:30
David Walsh
df6c05eb17
Fix NumericInput proptype error ( #11773 )
2021-08-06 01:45:53 -02:30
David Walsh
1b1d039310
EIP-1559 - Ensure form always displays when there are errors ( #11787 )
2021-08-05 20:25:23 -05:00
Alex Donesky
751534e665
fix confirm transaction details to match spec ( #11779 )
2021-08-05 20:07:04 -05:00
David Walsh
a0bd496d56
Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly ( #11781 )
2021-08-05 18:59:58 -05:00
Alex Donesky
804fefcd36
Separate out non blocking gas errors ( #11783 )
2021-08-05 17:53:48 -05:00
Alex Donesky
f9378b3aa2
Add fee level education button to swaps edit gas popover ( #11785 )
2021-08-05 17:10:04 -05:00
David Walsh
d5033249a2
Fix NumericInput proptype error ( #11773 )
2021-08-05 16:52:45 -05:00
Dan J Miller
c2bfa57981
Allow max fee to be equal to max priority fee ( #11778 )
2021-08-05 14:23:50 -02:30
dependabot[bot]
ffbd8771b3
Bump tar from 4.4.11 to 4.4.15 ( #11753 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 4.4.11 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v4.4.11...v4.4.15 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-05 14:23:49 -02:30
Dan J Miller
48bfd6c7f6
Use bignumber for number comparisons in useGasFeeInput ( #11776 )
...
* Use bignumber for number comparisons in useGasFeeInput
* fix
2021-08-05 14:23:49 -02:30
Dan J Miller
e9ef3b168a
Allow max fee to be equal to max priority fee ( #11778 )
2021-08-05 14:15:02 -02:30
dependabot[bot]
24d6456aaf
Bump tar from 4.4.11 to 4.4.15 ( #11753 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 4.4.11 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v4.4.11...v4.4.15 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-05 14:12:10 -02:30
Dan J Miller
0cf5019486
Use bignumber for number comparisons in useGasFeeInput ( #11776 )
...
* Use bignumber for number comparisons in useGasFeeInput
* fix
2021-08-05 13:52:56 -02:30
Dan Miller
29a29eb877
Add temporary entry to cla bot allowlist to workaround cla-bot bug
2021-08-05 13:29:11 -02:30
Dan J Miller
825e8b7bbf
Ensure that gas fee inputs fallback to tx params values if api is down ( #11775 )
...
* Ensure that gas fee inputs fallback to tx params values if down
* ensure getGasFeeEstimate fallback is a string
2021-08-05 10:49:24 -02:30
Dan J Miller
01262d33a4
Ensure that gas fee inputs fallback to tx params values if api is down ( #11775 )
...
* Ensure that gas fee inputs fallback to tx params values if down
* ensure getGasFeeEstimate fallback is a string
2021-08-05 08:33:49 -02:30
Dan J Miller
aa0f35a8ba
Ensure that gas fee minimum errors show when api is down ( #11767 )
...
* Fix legacy unapproved tx handling
* clean up
2021-08-04 20:24:40 -02:30
Dan J Miller
7384aea541
Fix legacy unapproved tx handling ( #11766 )
2021-08-04 20:24:40 -02:30
Mark Stacey
3b8faadaad
Update eth-phishing-detect
to latest version ( #11756 )
...
This update includes just configuration updates. There are no
functional changes. The updated config is only used as a fallback in
case the config update fails for some reason.
2021-08-04 20:24:40 -02:30
Alex Donesky
ab1cd1152e
tiny lost code change from 9.8.4 RC ( #11764 )
2021-08-04 20:24:40 -02:30
David Walsh
efed7c2980
EIP-1559 - Fix mislabeled MaxPriority fee key ( #11758 )
2021-08-04 20:24:40 -02:30
Alex Donesky
02c0cbede9
Stop GasFeeController polling when pop closes ( #11746 )
...
* Stop GasFeeController polling when pop closes
* Stop estimate gas polling on window unload
* lint + comments
* Improve client closed logic
* lint
* Add back _beforeUnload on unmount in gas-modal-page-container
* Add full check and call onClientClosed method for notifcation environment
* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type
* remove unused method
* move controller manipulation logic from background.js to metamask-controller, disaggregate methods
* add beforeunload handling to reset gas polling tokens from root of send page
* cleanup, lint and address feedback
* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller
* mock new methods to fix tests
* final bit of cleanup + comments
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 20:24:40 -02:30
David Walsh
1f578fcb1b
Provide pointer cursor for radio group buttons ( #11763 )
2021-08-04 20:24:40 -02:30
Dan J Miller
e1efc7170c
Show advanced options, and hide radio buttons, for advanced gas settings users ( #11751 )
...
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on
* Improve naming and copy
* lint fix
* Lint fix
2021-08-04 20:24:40 -02:30
David Walsh
5d7eba2684
EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate ( #11759 )
2021-08-04 20:24:40 -02:30