Whymarrh Whitby
ceb5970afd
Remove unused NotificationManager#closePopup ( #8530 )
2020-05-05 21:02:29 -02:30
Whymarrh Whitby
f5a125fe61
Move export defaults statements alongside their objects ( #8525 )
2020-05-05 19:49:38 -02:30
Brad Decker
0c7269f599
fixes firefox popup location ( #8467 )
...
Co-Authored-By: Whymarrh Whitby <whymarrh.whitby@gmail.com>
2020-04-29 17:04:03 -05:00
Brad Decker
f9989c52c5
Position notification relative to last focused window ( #8356 )
2020-04-19 19:30:17 -02:30
Mark Stacey
852277b2ae
Refactor notification manager and triggerUi to use extension platform ( #8317 )
...
The notification manager has been refactored to use the extension
platform module instead of using `extensionizer` directly. The
extension platform API presents a more ergonomic API, and it correctly
handles errors (which the old notification manager did not). Methods
that the extension platform lacked have been added.
It has been updated to use `async/await` instead of callbacks as well,
for readability.
The `triggerUI` function has also been updated to use the extension
platform instead of `extensionizer`.
2020-04-11 12:12:45 -03:00
Mark Stacey
ac01c5c89a
Consistent jsdoc syntax ( #7755 )
...
* Specify type before parameter name
Various JSDoc `@param` entries were specified as `name {type}` rather
than `{type} name`.
A couple of `@return` entries have been given types as well.
* Use JSDoc optional syntax rather than Closure syntax
* Use @returns rather than @return
* Use consistent built-in type capitalization
Primitive types are lower-case, and Object is upper-case.
* Separate param/return description with a dash
2020-01-13 14:36:36 -04:00
Whymarrh Whitby
92971d3c87
Migrate codebase to use ESM ( #7730 )
...
* Update eslint-plugin-import version
* Convert JS files to use ESM
* Update ESLint rules to check imports
* Fix test:unit:global command env
* Cleanup mock-dev script
2020-01-09 00:04:58 -03:30
Whymarrh Whitby
274a9ecf53
yarn lint --fix
2019-12-03 17:20:55 -03:30
Whymarrh Whitby
aa41057628
Update ESLint rules for curly braces style ( #7477 )
...
* eslint: Enable curly and brace-style
* yarn lint --fix
2019-11-19 20:33:20 -03:30
William Monti Souza
98699fbbc0
Fixes popups not showing when screen size is odd ( #6312 )
2019-03-17 18:30:51 -02:30
Whymarrh Whitby
ea34d3b0ff
Centre the notification in the current window ( #6307 )
2019-03-14 12:52:57 -05:00
Whymarrh Whitby
5bf8a36a87
Centre all notification popups
2019-03-12 11:37:14 -02:30
bitpshr
badf0ce314
Conditionally use Promise-based extension API when creating windows
2018-07-03 13:33:13 -04:00
vittominacori
ff3c262621
set the popup id returned by create promise
2018-06-17 19:16:30 +02:00
vittominacori
4c1b526137
set an id to the metamask notification popup
2018-06-16 18:51:01 +02:00
Dan
3ec22dc7e1
Notification manager method docs.
2018-04-20 15:48:44 -02:30
Dan
9f12c26d44
Even more documentation for various controllers and libs.
2018-04-19 13:08:56 -02:30
Jeffrey Tong
4f853bbd3c
remove console log
2018-03-11 10:18:55 -07:00
Jeffrey Tong
bda493dc9d
add comments that need clarification on naming convention
2018-03-11 10:17:08 -07:00
Jeffrey Tong
aaef2aeefd
fixed multiple notification windows when executing batch
2018-03-07 20:09:40 -08:00
Jeffrey Tong
40b1688c67
removed check for width & height on multiple popup windows
2018-03-07 14:19:27 -08:00
Chi Kei Chan
fa95303e1e
Sign Typed Request styling fixes
2017-10-25 18:05:52 -07:00
Dan
ddf11011c9
Signature request fixes.
2017-10-25 17:40:48 -07:00
kumavis
6ace0c9afb
notification-manager - remove promise listener
...
seems chrome changed their API?
MDN suggests that a Promise should be returned but getting `undefined`
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/windows/create
Chrome docs suggest its a callback API lolwut
https://developer.chrome.com/extensions/windows#method-create
2017-04-28 16:04:00 -07:00
Thomas Huang
6bdb4c8728
Fix linting warnings
2017-04-26 21:05:45 -07:00
kumavis
86e882c51a
notification-manager - rename show -> showPoup + make getPopup private
2017-03-31 18:41:51 -07:00
kumavis
5036263f88
introduce platform api and rename notifications to notification-manager
2017-03-30 18:33:19 -07:00
