1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 01:39:44 +01:00
Commit Graph

1292 Commits

Author SHA1 Message Date
Albert Olivé
3376ea4e95
[MMI] Adding missing logic to handle custodian approval in token allowance (#20662) 2023-08-31 17:45:07 +02:00
Ariella Vu
ec0a02fe40
style: fix Settings pages padding (#20674) 2023-08-31 08:15:04 -07:00
Ariella Vu
c15226325e
style: update Desktop App settings styles (#20676) 2023-08-31 06:50:21 -07:00
Ariella Vu
3f5bc978dd
Fix Blockaid and OpenSea BannerAlert placement for Token Allowance, Confirm Pages, SIWE, and Signature V3/V4 pages (#20530)
* refactor: add SecurityProviderBannerAlert ...props

* fix: mv security banner alerts on TokenAllowance

* fix: mv security BannerAlert in confirm page
https://github.com/MetaMask/MetaMask-planning/issues/1195

* fix: allow BlockaidBannerAlert null details

* refactor: rm SecurityProviderBannerAlert margin

* fix: SIWE security banner alert placement

* fix: rm extra banner alert padding for sig v3 & v4

* fix: update SecurityProviderBannerAlert snapshot

* fix: update BlockaidBannerAlert snapshot

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-30 07:05:53 -07:00
Monte Lai
3747bc61ef
fix: overflow of link and warnings (#20375)
* fix: overflow of link and warnings

* fix: update snapshot

* --wrapped in React.memo HOC
--changed Website to a clickable link
--slightly better overflow wrapping, but the best would be to wrap on dots and slashes

* updated snapshot

---------

Co-authored-by: Howard Braham <howrad@gmail.com>
2023-08-29 17:22:53 -04:00
Nidhi Kumari
6a17d76efc
UX Multichain: Added Select an action Modal (#20559)
* added select-action-modal skeleton

* added select action modal item

* replaced stake link with constant

* added route for open and close of modal

* updated lint errors

* lint fix

* updated tests

* revert unnecessary changes

* fixed lint errors

* added suggestions

* lint fix

* updated test

* nit fix

* updated select action item to use button

* removed unused fragments

* moved onClose command to bottom

* moved select action modal on footer click

* changed isDisabled to disabled

* added hover and updated test

* nit fix
2023-08-29 22:15:30 +05:30
Nidhi Kumari
215430236e
Created new route for connections (#20556)
* created new route for connections

* remove unnecessary code

* added connections component

* fixed connections route

* moved connections to pages in multichain

* moved connections route to multichain feature flag
2023-08-29 22:08:29 +05:30
Nidhi Kumari
b8b94c2c1f
UX Multichain: Added balance-overview component (#20528)
* added balance-overview component

* updated balance overview component to use Currency utility props

* added MULTICHAIN feature flag

* lint fix

* lint fix

* lint fix

* updated ternary operators
2023-08-29 22:07:23 +05:30
Daniel
4e14e179c8
Update UI for blocked tokens, use the latest dev gas api URL (#20625) 2023-08-29 14:38:46 +02:00
Garrett Bear
66292330fe
Feat/18890/button ts update (#20492)
* button to TS migration

working demo

style props

broken mapping - need switch

working types file

working types

fix dependent imports of Button

variant mapping

working types

fix lint

fix test

fix ButtonSize issue on QuizContent

box fix

test if this works

fix button being used on QuizContent

fix button_variant import

readme fix

* fix button import

* fix primary button as anchor hover

* deprecated

* button to TS migration

fix lint

fix test

* fix rebase issue

* fix rebase issue

* lint fix
2023-08-28 14:42:00 -07:00
Jyoti Puri
77c7f34062
Updating watch NFT page header (#20569) 2023-08-25 18:27:17 +05:30
Maarten Zuidhoorn
96210b9783
Always show connected accounts permissions if they exist (#20600)
* Show connected accounts permissions if they exist

* Add optional chaining
2023-08-25 12:40:28 +02:00
Maarten Zuidhoorn
f8a7a83e05
Update snaps-related copy (#20601)
* Update snaps-related copy

* Update test
2023-08-25 12:40:13 +02:00
Daniel
679d6686e3
Show a slippage notification again before submitting a swap, improve content for slippage notifications (#20364) 2023-08-25 11:44:31 +02:00
Howard Braham
d76b458235
fix(privateKey): Restore hold-to-reveal button for private key export (#20109)
* fix(privateKey): Restore hold-to-reveal button for private key export

* lint and unit test fixes

* adding e2e tests to reveal private key

* fixing lint issues

* fixed: Private key is able to be presented without tapping and holding the "Hold to reveal" CTA

* Incorrect password test and support hold to reveal

* improving unit tests

---------

Co-authored-by: Plasma Corral <32695229+plasmacorral@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
2023-08-24 17:35:26 -04:00
Danica Shen
9514b47a7e
fix(878): fix toggle align styles for eth-sign in settings (#20587) 2023-08-24 14:11:38 +01:00
Danica Shen
00d155ce2f
feat(878): implement network txn toggle and new style (#20363)
* feat(878): implement new incoming transaction toggle networks for setting and onboarding

* Update state snapshots

* feat(878): change gaps, migration types based on comment

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-24 11:27:42 +01:00
Albert Olivé
b296f48c11
Fixing iconUrl issue setting the custodianName to custodianType if custodianName is undefined (#20565) 2023-08-23 15:40:11 +02:00
Howard Braham
d3d30fd373
fix(settings): fixed two IPFS gateway issues (#19700)
* fix(settings): fixed two IPFS gateway issues

- adds back in two bugfixes that were originally in #19283
  - fixes #16871
  - fixes #18140

- achieves 100% code coverage for /ui/pages/settings/security-tab
- removes the npm package `valid-url`, which has not been updated in 10 years

* changes after #20172 was merged

* improved URL validation (specifically spaces)

* better Jest coverage

* response to legobeat review

* fixing lint and Jest
2023-08-22 22:13:13 -07:00
Dan J Miller
b8525566f2
Enable legacy HD paths for trezor users (#19552)
* Update eth-trezor-keyring to v1.1.0

* Revert "Revert "feature: Add legacy derivation path to Trezor (#19443)" (#19451)"

This reverts commit b5ef94b9f0.

* Fix trezor import

* Update lavamoat policies

* Remove accidentally committed code

* Fix type in previous commit
2023-08-22 16:11:52 -04:00
Daniel
8ca0b762ad
Don't call "toPrecisionWithoutTrailingZeros" if a destination value is not a number (#20525) 2023-08-21 18:06:12 +02:00
Dhruv
ba31f87014
fix/TagUrl to TS (#20519) 2023-08-18 17:59:02 -07:00
Dhruv
07abc53cce
fix/BannerBase to TS (#20421)
* BannerBase to TS

* snapshot updates

* more snapshot updates

* addressing type definition error

* updating eth-sign-modal snapshot

* Updates to stories, types and adding data-testid

* Updating snapshots

* updating snapshot of blockaid-banner-alert and adding unit test for childrenWrapperProps

* BannerBase updates to stories, adding locale for close button, removing static data-testid in favor of using it at the instance, updating snapshots associated with those changes

* Removing incorrect arg from storybook file

* Updating html element in security provider e2e test to match BannerBase. Also updating snapshot of ConfirmTransaction page

* Fixing e2e tests

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-18 14:52:40 -07:00
Albert Olivé
60f149178c
[MMI] Set approved status in tx controller in MMI logic (#20507)
* fix(custodial-signing): set approved status in tx controller in MMI logic

* Fixed the issue that was not showing custody-confirm-link

---------

Co-authored-by: Shane Terence Odlum <shane.odlum@consensys.net>
2023-08-18 14:38:51 +02:00
Ariella Vu
8807d06535
Security Alert Blockaid: fix propType and add instance to ConfirmApprove page (#20494)
* fix: SecurityProviderBannerAlert propTypes

* feat: add ConfirmApprove BlockaidBannerAlert
2023-08-18 14:06:46 +02:00
Albert Olivé
486ade85f3
[MMI] Fixed connect mmi button several issues (#20455)
* fixed connect mmi button several issues

* Fixed snapshot

* Improved multiple things

* running yarn dedupe

* Update LavaMoat policies

* For some reason, this.mmiConfigurationController.store.mmiConfiguration?.portfolio sometimes is undefined, added [] if null.
Moved the || {} outside the find method

* minor improvements

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-08-17 14:50:40 +02:00
Unik0rnMaggie
5cbfa82018
Fix Typo in en.json (#20429)
* Fix Typo in en.json

There is a typo in "smart contact"

* updated snapshot

---------

Co-authored-by: Howard Braham <howrad@gmail.com>
2023-08-16 15:36:33 -02:30
Pritam Dhara
6512cacec8
Replaced ActionableMessage in confirm-page-container-content (#20417)
* Replaced ActionableMessage in confirm-page-container-content

* Updated Snapshot of confirm-transaction-base

* Updated BannerAlert className

* Using component API and replacing ErrorMessage

* Update snapshot

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-15 14:59:29 -07:00
Harsh Shukla
b8475f85d4
Part of #17670 for: privacy-settings.js (#20288)
* Update privacy-settings.js

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update privacy-settings.js

* Update index.scss

* Update to html nesting and semantic fix

* lint fix

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-15 14:05:04 -07:00
Bhavya gor
b0fcb12b99
Update BannerAlert icon to match Figma Issue#20355 (#20407)
* changed warning --> danger

* snapshot updates

* Adding comment

* Updating snapshot

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-15 08:20:02 -07:00
David Walsh
712a62ed74
UX: Remove unwanted extra spacing on home screen (#20441)
Co-authored-by: Victor Thomas <10986371+vthomas13@users.noreply.github.com>
2023-08-14 11:53:11 -05:00
David Walsh
ee4bf2d264
Fix #19829: UX: Multichain: Move "Import Tokens" to Modal (#19553)
* Move Import Tokens to Modal

* Better dimensions for long token name

* Add padding above tabs
2023-08-14 11:08:59 -05:00
Garrett Bear
70a13296c9
Feat/18889/update buttonlink ts (#20372)
* fix buttonlink alignment

* ButtonLink TS migration

* fix lint

* remove ButtonBase loading error feat

* move padding 0 to ButtonBase

* fix color issue

* fix test file

* fix snapshot

* Update ui/components/component-library/button-link/README.mdx

Co-authored-by: George Marshall <george.marshall@consensys.net>

* readme fix

* Update ui/components/component-library/button-link/button-link.stories.tsx

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-04 14:00:05 -07:00
Dominik Rudzki
29ad914dc9
Fix #19882 - MetaMask support link alignment v2 (#20354)
* Fix support link alignment

* Fix lint issues

* Fix workflows

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-08-04 13:26:50 -05:00
Victor Thomas
2ff289e271
Add Opt-out Settings toggle for 4byte contract method names resolution (#20098)
* Adding 4byte toggle to settings UI and preferences

* Adding 4byte toggle to advanced settings tab

* adding use4ByteResolution privacy logic to getContractMethodData & getMethodDataAsync, removing unused useMethodData hook, adding clearKnownMethodData

* add 4byte setting to onboarding advanced option

* more test changes

* adding e2e for 4byte setting toggle

* test and copy changes, snap updates

* removing 4byte from advanced section

* adding settings constant and fixing refs

* removing clearKnownMethodData, adding flag to selector, test fixes

* e2e refactor, selectors refactor

* adding tests

* Fix jest tests, remove unwanted forceUpdateMetamaskState

* Fix jest tests

* lint:fix

* settingsRefs fixes

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-08-04 13:28:37 -04:00
Danica Shen
a85a4cf97e
feat(878): add new incomingTxn component and change styles of settings (#20374)
* feat(878): add new incomingTxn component and change styles of settings

* feat(878): relocate openSea tab from rebase regression

* feat(878): make UI and test modifications

* feat(878): transfer to ts

* feat(878): rename network-toggle.tsx
2023-08-04 12:33:47 +01:00
jainex
52c44924e3
Part #19737 - Replace deprecated FormField component with TextField, Label, HelpText (#19859)
* Replacing deprecated components for component library components

* Update

* Lint fix

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-03 15:30:41 -07:00
Daniel
066c568aca
Improvements to Swaps quote auto-selection logic, fix and edge case with zero-balance tokens (#20388)
* Add Token To into assets again (reverting commit 51f46eb65f48bdf4980f400a589bf1ac63a65222 )

* Update cleanup for an unswapped Token To from the Tokens list

* Call "setLatestAddedTokenTo" conditionally

* Update an E2E test for insufficient balance notification
2023-08-03 18:19:50 -02:30
Monalisha Mishra
b46501cc0d
migration of button icon to use TS box version (#20227)
* migration of button icon to use TS box version

* fixed lint issues

* Some convention and linting updates

* README fixes

* Updating snapshot

* snapshot updates

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-03 12:23:47 -07:00
Nidhi Kumari
6c1b71b584
Updated copy changes for display NFT Media (#20380)
* updated copy changes

* updated snapshots

* lint fix

* updated test
2023-08-03 23:49:30 +05:30
Alex Donesky
6594f7074e
adapt to use networksMetadata state instead of single networkStatus and networksDetails state (#20219) 2023-08-03 12:31:35 -05:00
David Walsh
840eb632c6
Fix #19647 - Allow importing multiple tokens (#20224) 2023-08-03 09:20:34 -05:00
Jyoti Puri
8c46f85764
Confirmation page alerts (#20125) 2023-08-03 16:24:54 +05:30
Nidhi Kumari
d4e33b0d44
close popover on backgroiund click (#20359) 2023-08-03 10:14:26 +05:30
Victor Thomas
97073e1907
Move "Enable Opensea API" and "NFT Autodetect" into Security & Privacy settings (#20278)
* move opensea api and nft settings to security tab

* DS techdebt; experimental tab

* rerouting the NFT tab enable autodetect to setting

* reverting vscode settings and preferences.js

* Rerouting NFT tab autodetect setting banner link

* resolving settingsRef collision
2023-08-02 18:46:36 -04:00
infiniteflower
1099a3763b
Feat/swaps link buy gas (#20241)
* Add link to buy more ETH if insufficient gas

* Fix lint error

* Use native currency per network

* Use localized msg for buy more gas

* Add the word "more"

* Fix smart tx not showing msg

* Pull out not enough balance into own component

* Add story for not enough balance

* Fix btn text not being aligned with rest of text

* Move inline style to class, remove empty classname

* Update ui/pages/swaps/prepare-swap-page/not-enough-balance.stories.tsx

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/swaps/prepare-swap-page/index.scss

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Remove line

* Move BannerAlert back into review-quote and use BannerAlert props

* Remove unused CSS

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-08-02 14:58:12 -04:00
Nidhi Kumari
f91d4fb858
Updated copy change for the IPFS toggle (#20358)
* updated ipfs toggle copy

* removed unused entries
2023-08-02 10:27:32 -07:00
Ariella Vu
446c7bb3fe
Security Alert Settings: update copy to match figma (#20300)
* securityAlert: fix settings copy

* securityAlert: fix settings copy - update snapshop
2023-08-02 11:29:18 +02:00
Dhruv
d375dc550d
Part of #18714: Replacing deprecated constants (#19843)
* replacing constants

* updating ButtonLink component

* Updates to responsive typography

* lint fixes

* snapshot updates

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:37:16 -07:00
Nidhi Kumari
4c37448c97
Added IPFS toggle (#20172)
* added ipfs toggle

* added placeholder valur

* fixed snapshot

* updated tests

* updated spec file

* hide input if toggle is disabled

* updated e2e tests for nft image

* fixed view-ercc-1155 spec

* updated e2e tests for nfts

* added ipfs toggle modal

* updated UI for ipfs

* updated tests

* updated classname

* added placeholder image

* lint fix

* removed prop ipfsEnabled and used with selector

* fixed ui for ipfs toggle

* updated test

* updated  test to handle cases

* nit fix

* ensure default image height match nft image
2023-08-01 23:51:51 +05:30