Elliot Winkler
a4f3a5fdd0
Widen the number of test files that TS sees ( #19403 )
...
Currently, all test files are excluded from TypeScript's purview. That
means that if any test file fails to typecheck, we won't know about it.
In fact if we were to remove all test files from the `exclude` list,
then some files would indeed fail to be typechecked.
At the moment all we care about is the unit test file for
NetworkController. Due to how the `include`/`exclude` rules work in
`tsconfig.json`, we can't "un-exclude" that file after it's excluded, so
to fix this, we simply exclude fewer things.
While we're at it, we also:
- Add `esModuleInterop: true` to address warnings we sometimes see
around imports
- Add `noEmit: true` so that we can run `tsc` to test typechecking on
its own without producing any compiled files (so that ESLint doesn't
accidentally pick them up)
- Clean up `tsconfig.json` slightly
2023-06-07 12:16:06 -06:00
Howard Braham
2647ae16d2
fix(e2e): flaky test-e2e-chrome on add-custom-network.spec.js ( #19487 )
2023-06-07 23:39:06 +05:30
Frederik Bolding
789779f4d5
[FLASK] Rework Snaps headers and footers ( #19442 )
...
* Add new snap header and footer to snap install
* Add new snap header and footer to snap result and snap update
* Fix loading state
* Fix lint
* Add required scrolling
* Adjust avatar component
* Apply new headers and footers to snaps confirmations
* Rename previous SnapAuthorship component to SnapAuthorshipExpanded
* Fix lint
* Fix font weight
* Fix fencing
* Fix a test
* Fix lint after rebase
* Fix E2E
* Fix locale lint
* Fix another E2E
* Fix test ID
* Address PR comments
* Better scroll button centering
* Address design comments
* Fix unit test
* Fix E2Es
2023-06-07 15:18:49 +02:00
Frederik Bolding
546d8349e7
Bump fast-xml-parser to fix audit issue ( #19489 )
2023-06-07 12:14:06 +02:00
David Walsh
d1dafb0bb6
Remove unwanted console.log in E2E test ( #19482 )
2023-06-07 00:13:04 -07:00
Albert Olivé
2070e5e42a
Feature/mmi 3009 confirm transaction base code fences ( #19335 )
...
* Added code fences
* Continue working on this ticket
* Fixed policies
* Added compliance-row component
* Fixed tests and css
* Fixed invalid locale
* Fixing linting
* Add optional check
* Fixing issues
* Fixed storybook
* Added missing dependency
* ran lavamoat auto
* ran dedupe and lavamoat
* lint
* Removed compliance row
* Removed unneeded package
* Removed unneeded proptyes
* updates mmi packages
* updating lavamoat
* formatting main
* Fixed conflicts
* updates lock file
* Moved code fences to have them all in the same place
* Updated yarn.lock and lavamoat
* remove linebreak
* Improved logic in order to not have many code fences and improve readability
* Fixing proptypes issues with eslint
* runs lavamoat auto
* Testing fixes issue e2e tests
* Testing issues
* Reverting code fences container
* Fixing issue with binding
* Added code fences in proptypes
* Reverting code fences
* Removed institutional from main lavamoat
* Added code fences in confirm transaction base component
* Adding tests for handleMainSubmit
* Improving code
* Added test for handleMainSubmit
* Removed waitFor
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-06-07 08:43:28 +02:00
Mark Stacey
5f57ad159b
Fix capitalization of MetaMask ( #19466 )
...
The name MetaMask was incorrectly capitalized in a few messages.
2023-06-06 17:56:29 -02:30
Elliot Winkler
db45a0aef4
setActiveNetwork captures network config ID ( #19404 )
...
In the core version of NetworkController, when the `setActiveNetwork`
method updates the provider configuration object, it will capture the ID
of the network configuration used to do so within the provider config
itself. In the same way, `setProviderType` clears any ID that was
previously set from the provider config.
This commit updates this version of NetworkController to be consistent
and updates tests to match.
2023-06-06 14:10:45 -06:00
Dhruv
2b95d7b242
Creating story for asset-list ( #19450 )
...
* Creating story for asset-list component
* lint fix
* lint-fix
2023-06-06 11:31:18 -07:00
David Walsh
7d7d09e469
UX: Multichain: Restore Flask support link and text ( #19198 )
...
* UX: Multichain: Restore Flask support link and text
* Update test
2023-06-06 11:02:00 -05:00
António Regadas
51f6a29461
Have mmi build being generated ( #19441 )
...
* have mmi build being generated
* not needed right now
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-06-06 16:43:31 +01:00
Niranjana Binoy
b5b3f67b4b
Using NetworkAccountBalanceHeader component on SIWE screen ( #19361 )
2023-06-06 09:53:28 -04:00
David Drazic
354788510e
[FLASK] Update UI (for audit) (UI facelift) ( #19388 )
...
* Update UI (for audit)
Revert yarn.lock change
Update e2e tests with new copy for a button
Make UI changes to custom Snap UI
Update UI on snap installation success page
Fix icon on installation success
Fix snap name font weight in installation page
Add UI changes for Snap installation failed page
Add new copy for snap installation screen
Update e2e tests OK button name
Update OK button names in e2e tests
Return previous functionality of update flow
Add error message handling for update screens
* Fix after rebase
* Fix messages.json update message
* Revert SCSS changes
* Refactor failed and success screen rendering
2023-06-06 12:15:20 +02:00
Frederik Bolding
c66d65921c
[FLASK] Limit notification count display to 99+ ( #19449 )
2023-06-06 11:00:42 +02:00
rohit kerkar
15bdb32bb6
replacing depricated constants ( #19448 )
...
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-06-06 14:21:27 +05:30
rohit kerkar
b40b4c6239
replacing depricated constants ( #19447 )
2023-06-06 14:20:45 +05:30
Nidhi Kumari
b64aa7f958
UX Multichain: Update settings title ( #19414 )
...
* update settings title
* fixed add contact button
2023-06-05 21:34:17 -07:00
Bernardo Garces Chapero
5355000202
Handle watch asset accept and reject using ApprovalController only ( #18829 )
2023-06-05 21:13:22 +01:00
Brad Decker
b5ef94b9f0
Revert "feature: Add legacy derivation path to Trezor ( #19443 )" ( #19451 )
...
This reverts commit 36de02ff69
2023-06-05 14:20:38 -04:00
Simon Males
36de02ff69
feature: Add legacy derivation path to Trezor ( #19443 )
2023-06-05 11:34:08 -05:00
Dhruv
61e952bad0
Replacing deprecated constants with enums ( #19242 )
2023-06-05 21:25:20 +05:30
Dhruv
5c5de03846
Updating component-library readme storybook render ( #19359 )
...
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-06-05 21:23:25 +05:30
rohit kerkar
3ec2c189b0
Part of #18714 : Replacing deprecated constants in Avatar-Base folder ( #19408 )
...
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-06-05 10:43:23 -05:00
Danica Shen
16e07b5d79
feature(17901): fix import UI error ( #19372 )
2023-06-05 14:15:47 +01:00
Frederik Bolding
3b9e2eb5e5
[FLASK] Update snap tweaks ( #19410 )
...
* Sort revoked permissions before existing permissions
* Simplify update screen logic and update copy
* Remove approve and update copy
* Reduce nesting
2023-06-05 14:31:11 +02:00
Frederik Bolding
f03f2d3f79
[FLASK] snaps@0.34.0-flask.1 ( #19377 )
...
* snaps@0.34.0-flask.1
* Update LavaMoat policies
* Replace instances of targetKey with targetName
* Replace use of PermissionKeys with PermissionNames
* Use Flask packages in tests for now
* Bump execution env
* Add another mock
* Fix lint
2023-06-05 13:51:19 +02:00
vthomas13
1726fb3fd0
Remove MULTICHAIN flag for NFT badges ( #19416 )
2023-06-04 12:28:48 -04:00
Elliot Winkler
a5c370cdfa
Sync NetworkController initializeProvider tests w/ core ( #19297 )
...
This makes it easier to visually compare differences in the
NetworkController unit tests between core and this repo.
2023-06-02 20:41:57 -06:00
Elliot Winkler
63c402155d
Sync default value of networkDetails w/ core ( #19407 )
...
In the core version of NetworkController, the `networkDetails` property
is initialized to `{ EIPS: {} }`. It is also reset to this
representation when `refreshNetwork` is called.
In this version of NetworkController, however, the default
representation of `networkDetails` is `{ EIPS: { 1559: undefined } }`.
From a consumer's perspective this doesn't make a difference — it's
practically the same. It does make a slight difference in tests,
however.
With that in mind, this commit changes the default representation to `{
EIPS: {} }`. This makes it easier to visually compare differences in the
NetworkController unit tests between core and this repo.
2023-06-02 14:35:08 -06:00
David Walsh
931b126831
UX: Multichain: Make MetaFox logo more accessible ( #19395 )
...
* UX: Multichain: Make MetaFox logo more accessible
* Fix jest snapshots
2023-06-02 11:43:20 -05:00
Albert Olivé
9195057136
[MMI] Added code fencing in libs folder ( #17929 )
2023-06-02 18:40:58 +02:00
vthomas13
4f8c4820d2
Multichain NFT network badges ( #19029 )
...
* adding badges for nfts
* fixing default nft styling issue
* adding multichain flag, making borderRadius inline
* Apply suggestions from code review
Co-authored-by: George Marshall <george.marshall@consensys.net>
* fixing imports
* removing nullcheck for guaranteed fields
* moving badgewrapper UI into multichain component
* using Box for button, removing inline style, border-radius for NFT default image
* adding nft badges to NFT Details page
* nits, snap update
* fixing/refactoring nftdefaultimage display, adding clickable, removing handleimageclick, refactor NFTItem, required props
* editing nft-default-image story, test, and snap
* Updating to fix positioning, use Box props to reduce CSS and BEM naming conventions
* moving minor styling to Box props, adding comment
* display block typo
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-06-02 11:01:51 -04:00
Dan J Miller
1cea94c8eb
Merge pull request #19384 from MetaMask/Version-v10.31.1
...
Version v10.31.1 RC
2023-06-02 11:17:15 -02:30
Jyoti Puri
f1de905be7
Fix details when transferring NFT not added to wallet ( #19045 )
2023-06-02 18:33:10 +05:30
Pedro Pablo Aste Kompen
37af04374a
feature(on-ramp): update supported networks ( #19268 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-06-02 08:19:03 -04:00
Danica Shen
3596edd180
feature(17901): fix flaky tests in send-eth e2e ( #19397 )
2023-06-02 12:54:54 +01:00
Bernardo Garces Chapero
67555fc879
accept approval request first ( #19409 )
2023-06-02 11:07:08 +01:00
Suryansh Anand
20fe6fcad4
Fix/storybook console cleanup ( #19244 )
...
* Fix: Fix storybook console error of networkList not being found when passed to createStore
* Fix: Remove unused testData imports
2023-06-01 14:40:39 -07:00
David Walsh
b89630fdd2
Release MultiChain 0.5 ( #18903 )
...
* Show portfolio icon in ETH overview
* Show new copy button in QR code modal
* Show address copy button in wallet overview
* Update connected status component
* Remove legacy MenuBar
* Remove legacy ImportTokenLink
* Remove AssetListItem
* Remove DetectedTokensLink
* Remove legacy AppHeader
* Remove MULTICHAIN flag from builds.yml
* Remove legacy AccountMenu
* FIX: Token cell snapshot
* Add data-testid for Account Picker
* Remove multichain check in LoadingNetworkScreen
* Remove MULTICHAIN check for AccountDetailsModal
* Remove MULTICHAIN check for AssetList
* Update QR dimensions
* Remove MULTICHAIN declaration from metamaskrc.dist
* Implement PickerNetwork and NetworkListMenu in onboarding
* Remove legacy NetworkDropdown and Dropdown
* Remove documentation about legacy account menu
* FIX: Fixes route tests for missing data-testid=network-display
* Fix account-menu-icon data-testid
* Fix TokenCell test
* FIX Onboarding Flow tests
* Remove unused locales from AccountMenu removal
* E2E: Fix Import Secret Recovery Phrase: logs out of the vault
* E2E: Fix Show account details: should show the QR code for the account
* E2E: Fix add-account.spec.js
* E2E: Fix state-logs.spec.js
* E2E: Fix lock-account.spec.js
* E2E: Fix settings-general.spec.js
* E2E: Fix advanced-settings.spec.js
* E2E: Fix auto-lock.spec.js
* E2E: Fix backup-restore.spec.js
* E2E: Fix clear-activity.spec.js
* E2E: Fix settings-search.spec.js
* E2E: Fix encrypt-decrypt.spec.js
* E2E: Fix dapp-interactions.spec.js
* E2E: Fix test-snap-management.spec.js
* E2E: Fix add-custom-network.spec.js
* E2E: Fix from-import-ui.spec.js
* E2E: Fix provider-api.spec.js
* E2E: Fix chain-interactions.spec.js
* E2E: Fix custom-rpc-history.spec.js
* Remove network icon from overview components
* E2E: Fix user-actions-benchmark.js
* E2E: Fix benchmark.js
* E2E: Fix add-hide-token.spec.js
* E2E: Fix address-book.spec.js
* E2E: Fix custom-token-add-approve.spec.js
* E2E: Fix incremental-security.spec.js
* E2E: Fix metamask-responsive-ui.spec.js
* E2E: Onboarding.spec.js
* E2E: Fix permissions.spec.js
* E2E: Fix send-hex-address.spec.js
* E2E: Fix send-to-contract.spec.js
* Remove dead AccountOptionsMenu test
* E2E: Fix token-details.spec.js
* E2E: Fix switch-custom-network.spec.js
* E2E: Fix metamask-ui.spec.js
* Revert "UX Multichain: updated border top for activity list (#19176 )"
This reverts commit 15598f2a23
2023-06-01 16:14:38 -05:00
rohit kerkar
2a227c4646
Part of #18714 : Replacing deprecated constants in Avatar-Favicon folder ( #19332 )
...
* sda
* sad
* replacing depricated constants
---------
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-06-01 10:09:08 -07:00
Ariella Vu
d5dd4fa881
ConfirmTxPage: rm redundant unapprovedTxs const ( #19275 )
...
* fix typo: uncofirmedTransactions -> unconfirmedTransactions
* txHelper: reorganize lines and improve test
* ConfirmTx: rn unconfirmedTxs->unconfirmedTxsSorted
* ConfirmTx: rn unconfirmedMessages-> unconfirmedTxs
* ConfirmTxPage: rm redundant unapprovedTxs const
* lint: rm unused getUnapprovedTransactions
2023-06-01 18:42:19 +02:00
rohit kerkar
ee9f7949f9
Replacing Deprecated Constants ( #19333 )
2023-06-01 09:33:11 -07:00
Binij Shrestha
33cd2c7c18
added deprecation message above SiteIcon ( #19256 )
...
* added deprecation message above SiteIcon
* fix eslint
* Some small updates to show correct code formatting and removing params
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-06-01 09:32:10 -07:00
Brad Decker
c146023598
ci: temporarily disable codecov status checks ( #19354 )
2023-06-01 10:11:22 -05:00
Dan J Miller
37536646d4
Update changelog for v10.31.1
2023-06-01 12:23:33 -02:30
Soralit
14f1ac7a66
fix: keystone sign request break ( #19349 )
2023-06-01 12:22:54 -02:30
Ariella Vu
ea4270babf
ConfirmApprove: fix space occurring after footer ( #19276 )
2023-06-01 16:12:09 +02:00
Ariella Vu
8d79e28560
Clean ConfirmTransaction page related code ( #19208 )
...
* fix typo: uncofirmedTransactions -> unconfirmedTransactions
* txHelper: reorganize lines and improve test
* ConfirmTx: rn unconfirmedTxs->unconfirmedTxsSorted
* ConfirmTx: rn unconfirmedMessages-> unconfirmedTxs
2023-06-01 16:10:26 +02:00
MetaMask Bot
a1050095d4
Version v10.31.1
2023-06-01 13:30:13 +00:00
OGPoyraz
d99aecc164
deep clone signature tx in order to avoid state mutation bug on development ( #19179 )
2023-06-01 11:48:07 +02:00
