Elliot Winkler
84cb4a7b62
NetworkController tests: Remove commented line ( #19315 )
...
This line was accidentally left in a previous PR that swapped Nock in
the NetworkController tests for a fake provider. It does not show up in
the core version of these tests.
2023-05-31 11:16:48 -06:00
rohit kerkar
80de5ceed4
Part of #18714 : Replacing deprecated constants in Modal-Header folder ( #19339 )
...
* replacing deprecated
* replacing deprecated
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-31 10:12:21 -07:00
Mark Stacey
d09c8bd492
Update @metamask/announcement-controller to v4 ( #19348 )
...
The `@metamask/announcement-controller` has been updated to v4, which
is the version released in the core monorepo v53 release. The remaining
packages released as part of v53 will be updated in later PRs.
The only breaking change is that the minimum Node.js version was
updated to v16.
Relates to #19271
2023-05-31 13:19:34 -02:30
Erik Nilsson
d7301fb811
Update README.md ( #19350 )
...
Clarify that `.metamaskrc` doesn't exist before you create it
2023-05-31 10:49:17 -05:00
Elliot Winkler
3e0d717b97
NetworkController: Improve test for destroy ( #19314 )
...
This test for the `destroy` method in NetworkController uses `toBe` on
the core side because the use of `toBeTruthy` produces a lint warning
there. It doesn't here, but it's good to be consistent anyway so that
comparing the differences in NetworkController tests between this
extension and core is easier.
2023-05-31 09:30:17 -06:00
Elliot Winkler
cc2e18b16a
Add getProviderConfig action to NetworkController ( #19317 )
...
This controller action exists within the core version of
NetworkController. Although there are no plans to make use of this
action within the extension, it has accompanying tests. So ultimately,
the goal of this commit (like others) is to make it easier to compare
differences in the NetworkController tests between this repo and core
by adding a test for the `getProviderConfig` action.
2023-05-31 09:29:59 -06:00
Elliot Winkler
84d22e122c
Sync NetworkController constructor tests with core ( #19311 )
...
This makes it easier to compare the NetworkController unit tests between
extension and core.
2023-05-31 09:29:29 -06:00
Dan J Miller
3d4cca4d9a
Version v10.32.0-beta.0
2023-05-31 12:52:55 -02:30
Dan J Miller
ce22514914
Run yarn lavamoat:auto for v10.32.0
2023-05-31 12:52:27 -02:30
Dan J Miller
efa0d2872a
Update changelog
2023-05-31 12:52:11 -02:30
Mark Stacey
7f82ea231c
Update @metamask/base-controller to v3 ( #19343 )
...
The `@metamask/base-controller` has been updated to v3, which is the
version released in the core monorepo v53 release. The other packages
released as part of v53 will be updated in later PRs.
Relates to #19271
2023-05-31 12:38:07 -02:30
David Drazic
f788121c3b
[FLASK] Add Snaps privacy warning on snap install ( #18835 )
...
* Add Snaps privacy warning on snap install
Add snap install warning status to storage
Add storybook
Add test for snap-privacy-warning
Resolve button type issue
Fix popup display logic
Update fixture
Update popup information and read more handling
Replace deprecated button
Update unit test
* Update buttons and add cancel flow
* Refactoring (review 1)
* Add more unit tests
2023-05-31 14:43:39 +02:00
Danica Shen
49f8052b15
feature(17901): fix failing network error and remove duplicated e2e for mv3 ( #19292 )
...
* feature(17901): fix failing network error e2e for mv3
* feature(17901): remove dapp interaction for duplication
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-30 14:48:43 +01:00
Danica Shen
8dc6bf1111
feature(17901): fix address-book Sends to an address book entry e2e against MV3 build ( #19330 )
...
* feature(17901): fix address-book `Sends to an address book entry` e2e against MV3 build
* feature(17901): add balance guide for send-eth e2e as well
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-30 13:44:56 +01:00
legobeat
dfafdbb6bd
Revert "[MMI] Add confirm-transaction-base code fences ( #18795 )" ( #19328 )
...
This reverts commit 97a9834182
2023-05-30 21:39:38 +09:00
António Regadas
f2356b29a5
updates values ( #19336 )
2023-05-30 13:08:07 +01:00
Dhruv
cdaa21b3cb
Changes to Popover folder ( #19245 )
2023-05-29 16:16:11 -07:00
Albert Olivé
97a9834182
[MMI] Add confirm-transaction-base code fences ( #18795 )
...
* Added code fences
* Continue working on this ticket
* Fixed policies
* Added compliance-row component
* Fixed tests and css
* Fixed invalid locale
* Fixing linting
* Add optional check
* Fixing issues
* Fixed storybook
* Added missing dependency
* ran lavamoat auto
* ran dedupe and lavamoat
* lint
* Removed compliance row
* Removed unneeded package
* Removed unneeded proptyes
* updates mmi packages
* updating lavamoat
* formatting main
* Fixed conflicts
* updates lock file
* Moved code fences to have them all in the same place
* Updated yarn.lock and lavamoat
* remove linebreak
* Improved logic in order to not have many code fences and improve readability
* Fixing proptypes issues with eslint
* runs lavamoat auto
* Testing fixes issue e2e tests
* Testing issues
* Reverting code fences container
* Fixing issue with binding
* Added code fences in proptypes
* Reverting code fences
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-29 16:50:56 +01:00
António Regadas
edf2cc41cb
[MMI] adds mmi code fences to mm controller ( #18279 )
...
* adds code fencing
* MMI adds mmi-controller
* MMI prettier
* chore: create keyring builder for CustodyKeyrings
* updates code fence to build-mmi
* adds dependencies
* fix import and prettier
* lint
* clean up
* clean up
* removes old methods and adds new
* comment for now
* adds two missing methods
* runs yarn dedupe
* adds missing import
* bump target values
* lavamoat policy update
* bump values in coverage targets
* prettier import order
* coverage report update
* clean up
* yarn update
* yarn dedupe
* ran lavamoat:auto
* adds zlib entry to storybook/main.js
* adds browserify-zlib
* clean up
* clean up
* prettier
* prettier
* eslint fix
* fix paths
* fix prettier
* fix file name for mocha
* adds to config
* rename
* adds file to configs
* test lavamoat clean up
* run dedupe
* sets value in storybook main.js as false
* runs lavamoat auto
* updates mmi packages to lighter versions
* updates mmi packages
* lavamoat auto
* adds finalized tx status
* lavamoat auto
* yarn dedupe
* clean up
* moving stuff into mmi controller
* clean up
* updates tresholds
* yarn lock review
* updates the mmi controller
---------
Co-authored-by: Shane Terence Odlum <shane.odlum@consensys.net>
2023-05-29 16:38:28 +01:00
MetaMask Bot
b667fde2e3
Version v10.32.0
2023-05-26 20:01:59 +00:00
Mark Stacey
d9c48cc4c0
Merge pull request #19309 from MetaMask/master-sync
...
Master sync follow v10.31.0
2023-05-26 15:44:28 -02:30
Dan J Miller
e5a9dc8dcf
Merge remote-tracking branch 'origin/develop' into master-sync
2023-05-26 15:08:25 -02:30
Elliot Winkler
c2bbbb1dbc
NetworkController: Simplify event types ( #19252 )
...
In the `core` version of this controller, event types are not held in an
enum but are specified directly as strings instead.
Simplifying the event types will make it easier to compare the
NetworkController unit tests between extension and core.
2023-05-26 10:35:52 -06:00
Elliot Winkler
b387a6e795
Reset all Jest mocks in NetworkController tests ( #19295 )
...
This makes it possible to test that mock functions are called the
correct amount of times (otherwise Jest will think that a mock function
has been called for as many tests as exist in the NetworkController unit
test suite).
2023-05-26 09:55:19 -06:00
Mark Stacey
edf3307f6e
Merge pull request #19032 from MetaMask/Version-v10.31.0
...
Version v10.31.0 RC
2023-05-26 11:29:36 -02:30
Danica Shen
7753364958
feature(17901): disable hardware wallet test with trezor in mv3 ( #19287 )
2023-05-26 14:05:34 +01:00
Thomas Huang
00db93763b
Update Changelog
2023-05-25 16:00:56 -07:00
Dhruv
744dfc9e38
Part of #18714 : Replacing deprecated constants in Icon folder ( #19250 )
...
* Replacing deprecated constants in Icon folder
* Requested changes
---------
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-05-25 13:53:31 -07:00
Daniel
a62de72aaa
Styling fix and content update for Swaps ( #19284 )
2023-05-25 11:43:21 -07:00
Daniel
c42d3920f8
Show the right "balance needed" value if we fallback from STX to regular Swaps ( #19230 )
...
* Show the right balance needed value if we fallback from STX to regular Swaps
* Fix usage of StxErrorTypes
2023-05-25 11:43:21 -07:00
Elliot Winkler
b7ef99847a
Refactor NC initializeProvider tests ( #19253 )
...
On the `core` side, the tests for `NetworkController.initializeProvider`
use the `lookupNetworkTests` to automatically test the `lookupNetwork`
behavior that `initializeProvider` initiates. This commit makes use of
the helper to bring the tests closer to the `core` version.
2023-05-25 11:47:36 -06:00
Elliot Winkler
5b85e9b73b
Refactor tests for refreshNetwork behavior ( #19238 )
...
The NetworkController tests in the `core` repo use a `refreshNetwork`
test helper to exercise the behavior performed by various methods
when switching the network. This commit brings over this test helper and
refactors tests for those methods to use it.
2023-05-25 11:36:38 -06:00
Dhruv
26bd689b44
Fixed Text Docs not rendering issue in Storybook ( #19248 )
2023-05-25 10:35:38 -07:00
Daniel
e1b12279ab
Show the right "balance needed" value if we fallback from STX to regular Swaps ( #19230 )
...
* Show the right balance needed value if we fallback from STX to regular Swaps
* Fix usage of StxErrorTypes
2023-05-25 19:30:10 +02:00
Daniel
af018efcb6
Styling fix and content update for Swaps ( #19284 )
2023-05-25 18:48:11 +02:00
Nicholas Ellul
ea321c964f
Revert "limit connections ( #18355 )" ( #19272 )
...
This reverts commit 8d2803c179
2023-05-25 11:32:05 -02:30
Nidhi Kumari
f0be1c3dba
added tooltip ( #19269 )
2023-05-25 08:30:01 -05:00
OGPoyraz
9375e3810f
fix cancel reason event for signatures ( #19286 )
2023-05-25 15:10:45 +02:00
Danica Shen
9ea6f8ee12
feature(17901): fix test/e2e/tests/add-account.spec.js ( #19280 )
2023-05-24 12:50:31 -05:00
Nicholas Ellul
ba4f56fbf7
Revert "limit connections ( #18355 )" ( #19272 )
...
This reverts commit 8d2803c179
2023-05-24 11:17:00 -04:00
Nidhi Kumari
6a7688b0d3
removed mmi fencing from copy icon in header ( #19087 )
...
* removed mmi fencing from copy icon
* updated snapshot
2023-05-24 09:51:37 -02:30
David Walsh
8e3b705fc1
Fix #19139 - Allow user to switch network when loading networking fails ( #19175 )
2023-05-24 09:51:37 -02:30
Nidhi Kumari
d2dba07eeb
UX Multichain: updated border top for activity list ( #19176 )
...
* updated border top for activity list
* updated border css via prop
* fixed symbol
* fixed lint errors
* fix conditions
* updated snapshot
2023-05-24 09:51:37 -02:30
David Walsh
68e1958005
Fix #19139 - Allow user to switch network when loading networking fails ( #19175 )
2023-05-24 09:40:12 -02:30
Albert Olivé
057188d155
[MMI] Add code fences in signature-request ( #18770 )
...
* Started adding code fences in signature-request
* Finished code fencing
* Improving code
* Fixed storybook and code fences bundle
* Added missing dependency
* Fixed yarn.lock
* Fixing policies
* Updated package.json
* updating lavamoat
* lavamoat fix
* adds missing package
* runs yarn dedupe
* updates method name
* run lavamoat:auto again
* Added more code fences
* updates snapshot
* snapshot updates
* updates mmi packages to lighter versions
* updates mmi packages
* runs lavamoat auto
* updates yarn lock and runs lavamoat auto
* updates yarn lock
* updates targets file
* Removed console log and added tests
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
2023-05-24 13:41:21 +02:00
Albert Olivé
00bad7b8a8
[MMI] Added code fencing in transaction list ( #18071 )
...
* Added code fencing in transaction list
* Fixed import
* Fixed tests
* Fixed indentation
* Fixed code fences
* Removed custody icon in favor of svg
* Fix prettier
* lint
* Fixed prettier issue
* adds check before set state with variable _mounted
* lint
* check for address in selectedIdentity
* review fix
* lint
* updates test
* lint
* clean up
* prettier
* adds missing locale
* Added tests and improved code
* Fixed code
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
2023-05-24 13:40:58 +02:00
Monte Lai
832ce634fd
feat(accounts): import account without password ( #19132 )
...
import account without password
---------
Co-authored-by: Mike B <32695229+plasmacorral@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Howard Braham <howrad@gmail.com>
2023-05-23 15:54:30 -07:00
Garrett Bear
53acfe271d
TEXT_ALIGN to TextAlign in UI folder ( #19235 )
2023-05-23 13:57:07 -07:00
David Walsh
c5a35b70c7
UX: Multichain: Only show the account picker with a selected identity ( #19236 )
2023-05-23 14:44:24 -05:00
David Walsh
627ff3c0ad
Multichain: UX: Snaps: Add Notifications to Global Menu ( #19204 )
...
* Multichain: UX: Snaps: Add Notifications to Global Menu
* Fix lint
* Move notification count after text
2023-05-23 14:44:05 -05:00
