Frankie
f6d25357db
transactions:tx-state-manager - optionally take a function as a search param ( #7078 )
2019-08-29 14:57:28 +02:00
Whymarrh Whitby
4d88e1cf86
Enable indent linting via ESLint ( #6936 )
...
* Enable indent linting via ESLint
* yarn run lint:fix
2019-07-31 10:17:11 -10:00
Akshit Kr Nagpal
d16d6f483c
Validate txParams in TransactionStateManager.addTx ( #6713 )
...
* Normalize and Validate txParams in TransactionStateManager.addTx too
* Added Tests
* Updated normalizeAndValidateParams to return the new txParams
2019-06-29 00:51:51 +02:00
frankiebee
5cf5359e78
transactions - always hexprefix txParams on update; fixes #6724
2019-06-19 14:36:24 +02:00
Whymarrh Whitby
094e4cf555
Check for unused function arguments ( #6583 )
...
* eslint: Check for unused function arguments
* eslint: Ignore unused '_' in argument list
Also allow any number of '_' e.g., '__' or '___' which is to be used sparingly
* Remove and rename unused arguments
2019-05-08 15:51:33 -04:00
Frankie
b5d6452454
Disallow loading as metamaskNetworkId ( #5924 )
...
* transactions - throw an error if a transaction is generated while the network is loading
* add tests for failing when netId is loading
2018-12-13 09:14:46 -10:00
Frankie
97c1e6bcc1
transactions - ensure err is defined when setting tx failed ( #5801 )
2018-11-26 09:00:58 -10:00
Whymarrh Whitby
1988e1e96b
ESLint fixes ( #5775 )
...
* eslint . --fix
* Upgrade all ESLint warnings to errors
2018-11-16 14:54:55 -10:00
Frankie
ce147bf6d8
Tx controller now uses safe event emitter ( #5769 )
...
* transactions - use safe-event-emitter over events
* tests - pass a platform object on init with a noop showTransactionNotification
* test - fix for tx-state-history-helper trying to reduce an empty array
* deps - safe-event-emitter
* lint
2018-11-16 10:34:08 -08:00
Dan Finlay
22ba0b0c2d
Resubmit approved transactions on new block ( #5752 )
...
* Add beginning of test
* Resubmit approved transactions on new block
May fix #4343 and related issues, where an error could leave
transactions stranded in the approved state.
* Remove unused test
* Re-approve transactions when retrying approved
* Add retry approved test
* Include approved in pending tx count
* Fix getPendingTxs()
* Linted
* Only throw hash error in submitted state
* Only check submitted txs for block inclusion
* Fix test expectations
2018-11-14 11:34:07 -10:00
Alexander Tseung
c821a8354c
Add txReceipt data to transaction details ( #5513 )
2018-10-16 06:00:47 +08:00
Whymarrh Whitby
7c3b69e1e4
Attach the RPC error value to txMeta
2018-09-08 19:59:50 -02:30
frankiebee
9b92ba4c47
trandsactions - remove rejected transactions from history
2018-06-25 15:07:54 -07:00
kumavis
4205d92729
Merge branch 'master' of github.com:MetaMask/metamask-extension into merge-master
2018-05-29 16:12:36 -07:00
Csaba Solya
2081768fc5
fix lint issues
2018-05-10 13:43:31 +02:00
Csaba Solya
3642810584
remove unnecessary lib
2018-05-10 13:34:56 +02:00
Csaba Solya
349fb9e0bc
revert unnecessary change in state manager
2018-05-10 13:33:40 +02:00
Csaba Solya
9026651224
add time stamps to transaction history log entries
2018-05-10 13:26:02 +02:00
frankiebee
62bf76db53
fix - getTxsByMetaData check if the key is in the object not if the value is truthy
2018-05-01 13:57:14 -07:00
frankiebee
98ae853b6c
require log
2018-04-30 09:57:36 -07:00
frankiebee
706647785c
log emitter errors
2018-04-29 16:35:08 -07:00
frankiebee
7eb735651b
transactions - run event emitters outside context of _setTxStatus
2018-04-29 16:32:16 -07:00
frankiebee
8ffce8b59d
transactions - more docs and clean ups
2018-04-25 11:13:51 -07:00
frankiebee
eeb9390de8
meta - transactions - docs yo!
2018-04-19 11:46:15 -07:00
frankiebee
5494aa4f9c
transactions - lint fixes
2018-04-10 14:54:30 -07:00
frankiebee
2d7c3c2b00
meta - transactions - create a transactions dir in controller and move relevant files into it
2018-04-10 14:28:05 -07:00