m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix Sentry sourcemaps (#11051)

Browse Source 
The method used for uploading release artifacts to Sentry has been
updated to allow `sentry-cli` to associate our minified bundles with
the corresponding source map file. This should help Sentry display rich
stack traces.

Previously Sentry had used the `sourceMappingURL` to associate source
maps with bundles, but we recently removed this in #10695. The hope is
that this change to the upload process will ensure the mapping works
correctly without the `sourceMappingURL` comment.

The `upload_bundles` function was removed because the later
`upload_sourcemaps` function actually uploaded both the bundles and
source maps.

The `--rewrite` flag was added to enable a newer "rewrite" feature of
the Sentry CLI that they recommend using [1]. This rewrite is where
they associate source maps with bundles.

The `url-prefix` has been updated to be `metamask` rather than
`sourcemaps`. I don't think `sourcemaps` was ever the correct prefix.
We normalize our errors to have the path `metamask/` before sending any
reports to Sentry.

[1]: https://docs.sentry.io/product/cli/releases/#sentry-cli-sourcemaps
This commit is contained in:
Mark Stacey 2021-05-11 18:36:01 -02:30 committed by GitHub
parent d62329fd0a
commit ff8c960ab6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
development/sentry-upload-artifacts.sh
View File

@ -27,33 +27,10 @@ Options:
EOF EOF
} }
function upload_bundles {
local release="${1}"; shift
for filepath in ./dist/chrome/*.js
do
if [[ -f $filepath ]]
then
upload_bundle "${release}" "${filepath}"
fi
done
}
function upload_bundle {
local release="${1}"; shift
local filepath="${1}"; shift
local filename
filename="$( basename "${filepath}" )"
printf 'Uploading %s\n' "${filename}"
sentry-cli releases --org 'metamask' --project 'metamask' files "${release}" upload "${filepath}" "metamask/${filename}"
}
function upload_sourcemaps { function upload_sourcemaps {
local release="${1}"; shift local release="${1}"; shift
sentry-cli releases --org 'metamask' --project 'metamask' files "${release}" upload-sourcemaps ./dist/sourcemaps/ --url-prefix 'sourcemaps' sentry-cli releases --org 'metamask' --project 'metamask' files "${release}" upload-sourcemaps ./dist/chrome/*.js ./dist/sourcemaps/ --rewrite --url-prefix 'metamask'
} }
function main { function main {
@ -87,9 +64,7 @@ function main {
die 'Required parameter "release" missing; either include parameter or set VERSION environment variable' die 'Required parameter "release" missing; either include parameter or set VERSION environment variable'
fi fi
printf 'uploading source files Sentry release "%s"...\n' "${release}" printf 'uploading source files and sourcemaps for Sentry release "%s"...\n' "${release}"
upload_bundles "${release}"
printf 'uploading sourcemaps Sentry release "%s"...\n' "${release}"
upload_sourcemaps "${release}" upload_sourcemaps "${release}"
printf 'all done!\n' printf 'all done!\n'
} }