m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

set the popup id returned by create promise

Browse Source
This commit is contained in:
vittominacori 2018-06-17 19:16:30 +02:00
parent 4c1b526137
commit ff3c262621
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/scripts/lib/notification-manager.js
View File

@ -28,11 +28,12 @@ class NotificationManager {
} else { } else {
// create new notification popup // create new notification popup
extension.windows.create({ extension.windows.create({
id: 'metamask-popup',
url: 'notification.html', url: 'notification.html',
type: 'popup', type: 'popup',
width, width,
height, height,
}).then((currentPopup) => {
this._popupId = currentPopup.id
}) })
} }
}) })
@ -85,7 +86,7 @@ class NotificationManager {
} }
/** /**
* Given an array of windows, returns the first that has a 'popup' type, or null if no such window exists. * Given an array of windows, returns the 'popup' that has been opened by MetaMask, or null if no such window exists.
* *
* @private * @private
* @param {array} windows An array of objects containing data about the open MetaMask extension windows. * @param {array} windows An array of objects containing data about the open MetaMask extension windows.
@ -94,7 +95,7 @@ class NotificationManager {
_getPopupIn (windows) { _getPopupIn (windows) {
return windows ? windows.find((win) => { return windows ? windows.find((win) => {
// Returns notification popup // Returns notification popup
return (win && win.type === 'popup' && win.id === 'metamask-popup') return (win && win.type === 'popup' && win.id === this._popupId)
}) : null }) : null
} }