From fbea2f7c5323678f0e4e972c0e80ede846f2c1ed Mon Sep 17 00:00:00 2001 From: PeterYinusa Date: Wed, 18 Jan 2023 17:48:07 +0000 Subject: [PATCH] update more snaps tests --- test/e2e/snaps/test-snap-confirm.spec.js | 4 ++++ test/e2e/snaps/test-snap-error.spec.js | 5 ++++- test/e2e/snaps/test-snap-installed.spec.js | 8 ++++++++ test/e2e/snaps/test-snap-managestate.spec.js | 12 ++++++++++-- test/e2e/snaps/test-snap-update.spec.js | 16 ++++++++++++---- 5 files changed, 38 insertions(+), 7 deletions(-) diff --git a/test/e2e/snaps/test-snap-confirm.spec.js b/test/e2e/snaps/test-snap-confirm.spec.js index 3b87cb4a2..42f0e8c25 100644 --- a/test/e2e/snaps/test-snap-confirm.spec.js +++ b/test/e2e/snaps/test-snap-confirm.spec.js @@ -71,6 +71,10 @@ describe('Test Snap Confirm', function () { await driver.switchToWindowWithTitle('Test Snaps', windowHandles); // click send inputs on test snap page + await driver.waitForSelector({ + css: '#connectConfirmSnap', + text: 'Reconnect to Confirm Snap', + }); const snapButton2 = await driver.findElement('#sendConfirmButton'); await driver.scrollToElement(snapButton2); await driver.delay(1000); diff --git a/test/e2e/snaps/test-snap-error.spec.js b/test/e2e/snaps/test-snap-error.spec.js index 949c69316..5290b0a46 100644 --- a/test/e2e/snaps/test-snap-error.spec.js +++ b/test/e2e/snaps/test-snap-error.spec.js @@ -70,7 +70,10 @@ describe('Test Snap Error', function () { // click send inputs on test snap page windowHandles = await driver.waitUntilXWindowHandles(2, 1000, 10000); await driver.switchToWindowWithTitle('Test Snaps', windowHandles); - await driver.delay(1000); + await driver.waitForSelector({ + css: '#connectErrorSnap', + text: 'Reconnect to Error Snap', + }); // find and click on send error await driver.clickElement('#sendError'); diff --git a/test/e2e/snaps/test-snap-installed.spec.js b/test/e2e/snaps/test-snap-installed.spec.js index 67a61df2b..96aae9084 100644 --- a/test/e2e/snaps/test-snap-installed.spec.js +++ b/test/e2e/snaps/test-snap-installed.spec.js @@ -69,6 +69,10 @@ describe('Test Snap Installed', function () { // click send inputs on test snap page windowHandles = await driver.waitUntilXWindowHandles(2, 1000, 10000); await driver.switchToWindowWithTitle('Test Snaps', windowHandles); + await driver.waitForSelector({ + css: '#connectConfirmSnap', + text: 'Reconnect to Confirm Snap', + }); const errorButton = await driver.findElement('#connectErrorSnap'); await driver.scrollToElement(errorButton); @@ -104,6 +108,10 @@ describe('Test Snap Installed', function () { windowHandles = await driver.waitUntilXWindowHandles(2, 1000, 10000); await driver.switchToWindowWithTitle('Test Snaps', windowHandles); + await driver.waitForSelector({ + css: '#connectErrorSnap', + text: 'Reconnect to Error Snap', + }); const result = await driver.findElement('#installedSnapsResult'); await driver.scrollToElement(result); diff --git a/test/e2e/snaps/test-snap-managestate.spec.js b/test/e2e/snaps/test-snap-managestate.spec.js index 3bd925a77..f338f0f6d 100644 --- a/test/e2e/snaps/test-snap-managestate.spec.js +++ b/test/e2e/snaps/test-snap-managestate.spec.js @@ -72,9 +72,15 @@ describe('Test Snap manageState', function () { // fill and click send inputs on test snap page windowHandles = await driver.waitUntilXWindowHandles(2, 1000, 10000); await driver.switchToWindowWithTitle('Test Snaps', windowHandles); + await driver.waitForSelector({ + css: '#connectManageState', + text: 'Reconnect to Manage State Snap', + }); await driver.fill('#dataManageState', '23'); await driver.delay(1000); - await driver.clickElement('#sendManageState'); + const sendButton = await driver.findElement('#sendManageState'); + await driver.scrollToElement(sendButton); + await sendButton.click(); // check the results of the public key test await driver.delay(1000); @@ -94,7 +100,9 @@ describe('Test Snap manageState', function () { ); // click clear results - await driver.clickElement('#clearManageState'); + const clearButton = await driver.findElement('#clearManageState'); + await driver.scrollToElement(clearButton); + await clearButton.click(); // check if true await driver.delay(1000); diff --git a/test/e2e/snaps/test-snap-update.spec.js b/test/e2e/snaps/test-snap-update.spec.js index 332aac1e0..2c46a7429 100644 --- a/test/e2e/snaps/test-snap-update.spec.js +++ b/test/e2e/snaps/test-snap-update.spec.js @@ -70,7 +70,10 @@ describe('Test Snap update', function () { }); // wait for permissions popover, click checkboxes and confirm - await driver.delay(1000); + await driver.waitForSelector({ + css: '.popover-header', + text: 'Are you sure?', + }); await driver.clickElement('#key-access-bip32-m-44h-0h-secp256k1-0'); await driver.clickElement('#key-access-bip32-m-44h-0h-ed25519-0'); await driver.clickElement({ @@ -81,7 +84,10 @@ describe('Test Snap update', function () { // navigate to test snap page windowHandles = await driver.waitUntilXWindowHandles(1, 1000, 10000); await driver.switchToWindowWithTitle('Test Snaps', windowHandles); - await driver.delay(1000); + await driver.waitForSelector({ + css: '#connectUpdate', + text: 'Reconnect to Update Snap', + }); // find and scroll to the correct card and click first const snapButton2 = await driver.findElement('#connectUpdateNew'); @@ -109,8 +115,10 @@ describe('Test Snap update', function () { await driver.switchToWindowWithTitle('Test Snaps', windowHandles); // look for the correct version text - const versionResult = await driver.findElement('#updateSnapVersion'); - await driver.delay(1000); + const versionResult = await driver.waitForSelector({ + css: '#updateSnapVersion', + text: '"4.0.2"', + }); assert.equal(await versionResult.getText(), '"4.0.2"'); }, );