Merge pull request #805 from MetaMask/i804

detect tx error - show warning and fix gasLimit

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## Current Master
+- Show a warning when a transaction fails during simulation.
 - Fix bug where 20% of gas estimate was not being added properly.
 
 ## 2.13.7 2016-11-8

app/scripts/lib/idStore.js

@@ -259,10 +259,24 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone
   }
 
   function estimateGas(cb){
-    query.estimateGas(txParams, function(err, result){
+    var estimationParams = extend(txParams)
+    // 1 billion gas for estimation
+    var gasLimit = '0x3b9aca00'
+    estimationParams.gas = gasLimit
+    query.estimateGas(estimationParams, function(err, result){
       if (err) return cb(err)
+      if (result === estimationParams.gas) {
+        txData.simulationFails = true
+        query.getBlockByNumber('latest', true, function(err, block){
+          if (err) return cb(err)
+          txData.estimatedGas = block.gasLimit
+          txData.txParams.gas = block.gasLimit
+          cb()
+        })
+        return
+      }
       txData.estimatedGas = self.addGasBuffer(result)
-      txData.txParams.gasLimit = txData.estimatedGas
+      txData.txParams.gas = txData.estimatedGas
       cb()
     })
   }

ui/app/components/pending-tx.js

@@ -30,6 +30,15 @@ PendingTx.prototype.render = function () {
         }
       `),
 
+      txData.simulationFails ?
+        h('span.error', {
+          style: {
+            marginLeft: 50,
+            fontSize: '0.9em',
+          },
+        }, 'Transaction Error. Exception thrown in contract code.')
+      : null,
+
       state.insufficientBalance ?
         h('span.error', {
           style: {