From f4e5eeca181389f9b08038f9eaac29af3f391afc Mon Sep 17 00:00:00 2001 From: David Walsh Date: Fri, 23 Oct 2020 16:08:46 -0500 Subject: [PATCH] Prevent React error for close --- .../swaps/dropdown-search-list/dropdown-search-list.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/app/pages/swaps/dropdown-search-list/dropdown-search-list.js b/ui/app/pages/swaps/dropdown-search-list/dropdown-search-list.js index bcaef3731..0f6606109 100644 --- a/ui/app/pages/swaps/dropdown-search-list/dropdown-search-list.js +++ b/ui/app/pages/swaps/dropdown-search-list/dropdown-search-list.js @@ -29,15 +29,16 @@ export default function DropdownSearchList ({ const t = useContext(I18nContext) const [isOpen, setIsOpen] = useState(false) const [selectedItem, setSelectedItem] = useState(startingItem) - const close = () => { + const close = useCallback(() => { setIsOpen(false) onClose && onClose() - } + }, [onClose]) + const onClickItem = useCallback((item) => { onSelect && onSelect(item) setSelectedItem(item) close() - }, [onSelect]) + }, [onSelect, close]) const onClickSelector = useCallback(() => { if (!isOpen) {