m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Skip adding history entry for empty txMeta diffs (#8379)

Browse Source
This commit is contained in:
Whymarrh Whitby 2020-04-22 00:39:16 -02:30 committed by GitHub
parent d908102636
commit f2f70342e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/scripts/controllers/transactions/tx-state-manager.js
View File

@ -202,7 +202,9 @@ class TransactionStateManager extends EventEmitter {
const previousState = replayHistory(txMeta.history) const previousState = replayHistory(txMeta.history)
// generate history entry and add to history // generate history entry and add to history
const entry = generateHistoryEntry(previousState, currentState, note) const entry = generateHistoryEntry(previousState, currentState, note)
txMeta.history.push(entry) if (entry.length) {
txMeta.history.push(entry)
}
// commit txMeta to state // commit txMeta to state
const txId = txMeta.id const txId = txMeta.id

17
test/unit/app/controllers/transactions/tx-state-manager-test.js
View File

@ -256,6 +256,23 @@ describe('TransactionStateManager', function () {
assert.deepEqual(result.history[1][0].value, expectedEntry.value, 'two history items (initial + diff) value') assert.deepEqual(result.history[1][0].value, expectedEntry.value, 'two history items (initial + diff) value')
assert.ok(result.history[1][0].timestamp >= before && result.history[1][0].timestamp <= after) assert.ok(result.history[1][0].timestamp >= before && result.history[1][0].timestamp <= after)
}) })
it('does NOT add empty history items', function () {
const txMeta = {
id: '1',
status: 'unapproved',
metamaskNetworkId: currentNetworkId,
txParams: {
gasPrice: '0x01',
},
}
txStateManager.addTx(txMeta)
txStateManager.updateTx(txMeta)
const { history } = txStateManager.getTx('1')
assert.equal(history.length, 1, 'two history items (initial + diff)')
})
}) })
describe('#getUnapprovedTxList', function () { describe('#getUnapprovedTxList', function () {