m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Never disable save button if props chain ID is invalid (#9808)

Browse Source
This commit is contained in:
Erik Marks 2020-11-05 14:57:11 -08:00 committed by GitHub
parent 6426816411
commit efd36adaac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ui/app/pages/settings/networks-tab/network-form/network-form.component.js
View File

@ -198,7 +198,13 @@ export default class NetworkForm extends PureComponent {
}
stateIsUnchanged() {
const { rpcUrl, ticker, networkName, blockExplorerUrl } = this.props
const {
rpcUrl,
chainId: propsChainId,
ticker,
networkName,
blockExplorerUrl,
} = this.props
const {
rpcUrl: stateRpcUrl,
@ -208,9 +214,17 @@ export default class NetworkForm extends PureComponent {
blockExplorerUrl: stateBlockExplorerUrl,
} = this.state
// These added conditions are in case the saved chainId is invalid, which
// was possible in versions <8.1 of the extension.
// Basically, we always want to be able to overwrite an invalid chain ID.
const chainIdIsUnchanged =
typeof propsChainId === 'string' &&
propsChainId.toLowerCase().startsWith('0x') &&
stateChainId === this.getDisplayChainIdFromProps()
return (
stateRpcUrl === rpcUrl &&
stateChainId === this.getDisplayChainIdFromProps() &&
chainIdIsUnchanged &&
stateTicker === ticker &&
stateNetworkName === networkName &&
stateBlockExplorerUrl === blockExplorerUrl