m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-26 12:29:06 +01:00
Code

Fix no-useless-concat issues (#9200)

Browse Source 
See [`no-useless-concat`](https://eslint.org/docs/rules/no-useless-concat) for more information.

This change enables `no-useless-concat` and fixes the issues raised by the rule.
This commit is contained in:
Whymarrh Whitby 2020-08-12 17:07:44 -02:30 committed by GitHub
parent 9842b2f1ce
commit ef88d79fac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -49,6 +49,7 @@ module.exports = {
'guard-for-in': 'error', 'guard-for-in': 'error',
'no-case-declarations': 'error', 'no-case-declarations': 'error',
'no-useless-catch': 'error', 'no-useless-catch': 'error',
'no-useless-concat': 'error',
/* End v2 rules */ /* End v2 rules */
'arrow-parens': 'error', 'arrow-parens': 'error',
'no-tabs': 'error', 'no-tabs': 'error',

4
ui/app/components/app/gas-customization/gas-price-chart/gas-price-chart.utils.js
View File

@ -263,10 +263,10 @@ export function generateChart (gasPrices, estimatedTimes, gasPricesMax, estimate
let text let text
d.forEach((el) => { d.forEach((el) => {
if (el && (el.value || el.value === 0) && !text) { if (el && (el.value || el.value === 0) && !text) {
text = "<table class='" + 'custom-tooltip' + "'>" + "<tr><th colspan='2'>" + titleFormat(el.x) + '</th></tr>' text = `<table class='custom-tooltip'><tr><th colspan='2'>${titleFormat(el.x)}</th></tr>`
} }
}) })
return text + '</table>' + "<div class='tooltip-arrow'></div>" return `${text}</table><div class='tooltip-arrow'></div>`
}, },
position: function () { position: function () {
if (d3.select('#overlayed-circle').empty()) { if (d3.select('#overlayed-circle').empty()) {

2
ui/app/components/app/modals/fade-modal.js
View File

@ -23,7 +23,7 @@ const insertRule = (css) => {
const insertKeyframesRule = (keyframes) => { const insertKeyframesRule = (keyframes) => {
// random name // random name
const name = 'anim_' + (++index) + (+new Date()) const name = 'anim_' + (++index) + (+new Date())
let css = '@' + 'keyframes ' + name + ' {' let css = `@keyframes ${name} {`
Object.keys(keyframes).forEach((key) => { Object.keys(keyframes).forEach((key) => {
css += key + ' {' css += key + ' {'