m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 01:47:00 +01:00
Code

NFTs: Use Unknown Collection instead of first NFT name (#18388)

Browse Source 
* NFTs: Use Unknown Collection instead of first NFT name

* Use localization in hook

* Get localization for previously owned

* Fix tests

---------

Co-authored-by: Dan Miller <danjm.com@gmail.com>
This commit is contained in:
David Walsh 2023-03-31 04:11:07 -05:00 committed by GitHub
parent 26fed9e8da
commit e895ff33f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/_locales/en/messages.json generated
View File

@ -2309,6 +2309,9 @@
"nfts": { "nfts": {
"message": "NFTs" "message": "NFTs"
}, },
"nftsPreviouslyOwned": {
"message": "Previously Owned"
},
"nickname": { "nickname": {
"message": "Nickname" "message": "Nickname"
}, },

2
test/e2e/nft/import-erc1155.spec.js
View File

@ -51,7 +51,7 @@ describe('Import ERC1155 NFT', function () {
// Check the imported ERC1155 and its image are displayed in the ERC1155 tab // Check the imported ERC1155 and its image are displayed in the ERC1155 tab
const importedERC1155 = await driver.waitForSelector({ const importedERC1155 = await driver.waitForSelector({
css: 'h5', css: 'h5',
text: 'Rocks', text: 'Unnamed collection',
}); });
assert.equal(await importedERC1155.isDisplayed(), true); assert.equal(await importedERC1155.isDisplayed(), true);

12
ui/hooks/useNftsCollections.js
View File

@ -4,11 +4,16 @@ import { isEqual } from 'lodash';
import { getNfts, getNftContracts } from '../ducks/metamask/metamask'; import { getNfts, getNftContracts } from '../ducks/metamask/metamask';
import { getCurrentChainId, getSelectedAddress } from '../selectors'; import { getCurrentChainId, getSelectedAddress } from '../selectors';
import { usePrevious } from './usePrevious'; import { usePrevious } from './usePrevious';
import { useI18nContext } from './useI18nContext';
export function useNftsCollections() { export function useNftsCollections() {
const t = useI18nContext();
const previouslyOwnedText = t('nftsPreviouslyOwned');
const unknownCollectionText = t('unknownCollection');
const [collections, setCollections] = useState({}); const [collections, setCollections] = useState({});
const [previouslyOwnedCollection, setPreviouslyOwnedCollection] = useState({ const [previouslyOwnedCollection, setPreviouslyOwnedCollection] = useState({
collectionName: 'Previously Owned', collectionName: previouslyOwnedText,
nfts: [], nfts: [],
}); });
const nfts = useSelector(getNfts); const nfts = useSelector(getNfts);
@ -19,6 +24,7 @@ export function useNftsCollections() {
const prevNfts = usePrevious(nfts); const prevNfts = usePrevious(nfts);
const prevChainId = usePrevious(chainId); const prevChainId = usePrevious(chainId);
const prevSelectedAddress = usePrevious(selectedAddress); const prevSelectedAddress = usePrevious(selectedAddress);
useEffect(() => { useEffect(() => {
const getCollections = () => { const getCollections = () => {
setNftsLoading(true); setNftsLoading(true);
@ -27,7 +33,7 @@ export function useNftsCollections() {
} }
const newCollections = {}; const newCollections = {};
const newPreviouslyOwnedCollections = { const newPreviouslyOwnedCollections = {
collectionName: 'Previously Owned', collectionName: previouslyOwnedText,
nfts: [], nfts: [],
}; };
@ -41,7 +47,7 @@ export function useNftsCollections() {
({ address }) => address === nft.address, ({ address }) => address === nft.address,
); );
newCollections[nft.address] = { newCollections[nft.address] = {
collectionName: collectionContract?.name || nft.name, collectionName: collectionContract?.name || unknownCollectionText,
collectionImage: collectionContract?.logo || nft.image, collectionImage: collectionContract?.logo || nft.image,
nfts: [nft], nfts: [nft],
}; };