From e720843517ccfca0ecb0fd9ce2452736654935b3 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Thu, 9 Apr 2020 20:43:32 -0300 Subject: [PATCH] Fix popup not opening (#8314) MetaMask would sometimes get into a state where the notification popup would never open. This could happen if the notification window was closed shortly after being opened. After this happened, no popups would show up until after the extension was reset. This was happening because the background thought the popup was already open. The variable it uses to track whether the popup was open or not was being set to `true` immediately after the background asked the browser to open a new window, before a handler was attached that could respond to the window being closed. Removing this line seems to solve the problem. This line was added originally in #5437, which dealt with batch transactions. Batches of transactions seem to work just fine without this line though (from local testing), and I can't think of why this would be required. Closes #7051 --- app/scripts/background.js | 1 - 1 file changed, 1 deletion(-) diff --git a/app/scripts/background.js b/app/scripts/background.js index 58e446e8b..5da6d0774 100644 --- a/app/scripts/background.js +++ b/app/scripts/background.js @@ -460,7 +460,6 @@ function triggerUi () { const currentlyActiveMetamaskTab = Boolean(tabs.find((tab) => openMetamaskTabsIDs[tab.id])) if (!popupIsOpen && !currentlyActiveMetamaskTab && !notificationIsOpen) { notificationManager.showPopup() - notificationIsOpen = true } }) }