m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Drop origin key from requests for Parity compatibility

Browse Source
This commit is contained in:
Dan Finlay 2016-09-19 10:15:19 +08:00
parent ae2f0f585f
commit e197e3808f
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -5,6 +5,7 @@
- Add a link to the transaction in history that goes to https://metamask.github.io/eth-tx-viz - Add a link to the transaction in history that goes to https://metamask.github.io/eth-tx-viz
too help visualize transactions and to where they are going. too help visualize transactions and to where they are going.
- Show "Buy Ether" button and warning on tx confirmation when sender balance is insufficient - Show "Buy Ether" button and warning on tx confirmation when sender balance is insufficient
- Change behavior that prevented Parity client compatibility, where we included a request site origin on rpc calls.
## 2.12.1 2016-09-14 ## 2.12.1 2016-09-14

5
app/scripts/metamask-controller.js
View File

@ -75,6 +75,10 @@ module.exports = class MetamaskController {
} }
onRpcRequest (stream, originDomain, request) { onRpcRequest (stream, originDomain, request) {
/* Commented out for Parity compliance
* Parity does not permit additional keys, like `origin`,
* and Infura is not currently filtering this key out.
var payloads = Array.isArray(request) ? request : [request] var payloads = Array.isArray(request) ? request : [request]
payloads.forEach(function (payload) { payloads.forEach(function (payload) {
// Append origin to rpc payload // Append origin to rpc payload
@ -86,6 +90,7 @@ module.exports = class MetamaskController {
payload.params.push({ origin: originDomain }) payload.params.push({ origin: originDomain })
} }
}) })
*/
// handle rpc request // handle rpc request
this.provider.sendAsync(request, function onPayloadHandled (err, response) { this.provider.sendAsync(request, function onPayloadHandled (err, response) {