m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 01:47:00 +01:00
Code

Add edge case handling for tx utilities (#19907)

Browse Source
This commit is contained in:
Nicholas Ellul 2023-07-06 19:48:38 -04:00 committed by GitHub
parent f829f0069d
commit e0f99600a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
shared/modules/transaction.utils.js
View File

@ -176,7 +176,7 @@ export async function determineTransactionType(txParams, query) {
contractCode = resultCode; contractCode = resultCode;
if (isContractAddress) { if (isContractAddress) {
const hasValue = txParams.value && txParams.value !== '0x0'; const hasValue = txParams.value && Number(txParams.value) !== 0;
const tokenMethodName = [ const tokenMethodName = [
TransactionType.tokenMethodApprove, TransactionType.tokenMethodApprove,

14
shared/modules/transaction.utils.test.js
View File

@ -186,6 +186,20 @@ describe('Transaction.utils', function () {
getCodeResponse: '0xab', getCodeResponse: '0xab',
}); });
const resultWithEmptyValue2 = await determineTransactionType(
{
value: '0x0000',
to: '0x9e673399f795D01116e9A8B2dD2F156705131ee9',
data: '0xa9059cbb0000000000000000000000002f318C334780961FB129D2a6c30D0763d9a5C970000000000000000000000000000000000000000000000000000000000000000a',
},
new EthQuery(_provider),
);
expect(resultWithEmptyValue2).toMatchObject({
type: TransactionType.tokenMethodTransfer,
getCodeResponse: '0xab',
});
const resultWithValue = await determineTransactionType( const resultWithValue = await determineTransactionType(
{ {
value: '0x12345', value: '0x12345',