m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 11:22:43 +02:00
Code

removed portfolio link from wallet view (#19716)

Browse Source 
* removed portfolio link from wallet view

* removed unused code

* updated test

* updated spec file

* updated test
This commit is contained in:
Nidhi Kumari 2023-06-23 17:28:41 +05:30 committed by GitHub
parent 80bfb5b501
commit dfb830e862
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/tests/portfolio-site.spec.js
View File

@ -26,7 +26,7 @@ describe('Portfolio site', function () {
await driver.press('#password', driver.Key.ENTER); await driver.press('#password', driver.Key.ENTER);
// Click Portfolio site // Click Portfolio site
await driver.clickElement('[data-testid="home__portfolio-site"]'); await driver.clickElement('[data-testid="eth-overview-portfolio"]');
await driver.waitUntilXWindowHandles(2); await driver.waitUntilXWindowHandles(2);
const windowHandles = await driver.getAllWindowHandles(); const windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles); await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles);
@ -34,7 +34,7 @@ describe('Portfolio site', function () {
// Verify site // Verify site
assert.equal( assert.equal(
await driver.getCurrentUrl(), await driver.getCurrentUrl(),
'http://127.0.0.1:8080/?metamaskEntry=ext&metametricsId=null', 'http://127.0.0.1:8080/?metamaskEntry=ext_portfolio_button&metametricsId=null',
); );
}, },
); );

44
ui/components/app/wallet-overview/eth-overview.js
View File

@ -36,7 +36,6 @@ import IconButton from '../../ui/icon-button';
import { isHardwareKeyring } from '../../../helpers/utils/hardware'; import { isHardwareKeyring } from '../../../helpers/utils/hardware';
import { MetaMetricsContext } from '../../../contexts/metametrics'; import { MetaMetricsContext } from '../../../contexts/metametrics';
import { import {
MetaMetricsContextProp,
MetaMetricsEventCategory, MetaMetricsEventCategory,
MetaMetricsEventName, MetaMetricsEventName,
MetaMetricsSwapsEventSource, MetaMetricsSwapsEventSource,
@ -44,12 +43,7 @@ import {
import Spinner from '../../ui/spinner'; import Spinner from '../../ui/spinner';
import { startNewDraftTransaction } from '../../../ducks/send'; import { startNewDraftTransaction } from '../../../ducks/send';
import { AssetType } from '../../../../shared/constants/transaction'; import { AssetType } from '../../../../shared/constants/transaction';
import { import { Icon, IconName } from '../../component-library';
ButtonIcon,
ButtonIconSize,
Icon,
IconName,
} from '../../component-library';
import { IconColor } from '../../../helpers/constants/design-system'; import { IconColor } from '../../../helpers/constants/design-system';
import useRamps from '../../../hooks/experiences/useRamps'; import useRamps from '../../../hooks/experiences/useRamps';
import { getPortfolioUrl } from '../../../helpers/utils/portfolio'; import { getPortfolioUrl } from '../../../helpers/utils/portfolio';
@ -156,42 +150,6 @@ const EthOverview = ({ className }) => {
{balanceIsCached ? ( {balanceIsCached ? (
<span className="eth-overview__cached-star">*</span> <span className="eth-overview__cached-star">*</span>
) : null} ) : null}
{
///: BEGIN:ONLY_INCLUDE_IN(build-main,build-beta,build-flask)
<ButtonIcon
className="eth-overview__portfolio-button"
data-testid="home__portfolio-site"
color={IconColor.primaryDefault}
iconName={IconName.Diagram}
ariaLabel={t('portfolio')}
size={ButtonIconSize.Lg}
onClick={() => {
const portfolioUrl = getPortfolioUrl(
'',
'ext',
metaMetricsId,
);
global.platform.openTab({
url: portfolioUrl,
});
trackEvent(
{
category: MetaMetricsEventCategory.Home,
event: MetaMetricsEventName.PortfolioLinkClicked,
properties: {
url: portfolioUrl,
},
},
{
contextPropsIntoEventProperties: [
MetaMetricsContextProp.PageTitle,
],
},
);
}}
/>
///: END:ONLY_INCLUDE_IN
}
</div> </div>
{showFiat && balance && ( {showFiat && balance && (
<UserPreferencedCurrencyDisplay <UserPreferencedCurrencyDisplay

2
ui/components/app/wallet-overview/eth-overview.test.js
View File

@ -71,7 +71,7 @@ describe('EthOverview', () => {
const store = configureMockStore([thunk])(mockStore); const store = configureMockStore([thunk])(mockStore);
const ETH_OVERVIEW_BUY = 'eth-overview-buy'; const ETH_OVERVIEW_BUY = 'eth-overview-buy';
const ETH_OVERVIEW_BRIDGE = 'eth-overview-bridge'; const ETH_OVERVIEW_BRIDGE = 'eth-overview-bridge';
const ETH_OVERVIEW_PORTFOLIO = 'home__portfolio-site'; const ETH_OVERVIEW_PORTFOLIO = 'eth-overview-portfolio';
const ETH_OVERVIEW_PRIMARY_CURRENCY = 'eth-overview__primary-currency'; const ETH_OVERVIEW_PRIMARY_CURRENCY = 'eth-overview__primary-currency';
const ETH_OVERVIEW_SECONDARY_CURRENCY = 'eth-overview__secondary-currency'; const ETH_OVERVIEW_SECONDARY_CURRENCY = 'eth-overview__secondary-currency';