m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Show Failed transaction in the browser notification for on-chain failures (#5904)

Browse Source
This commit is contained in:
Alexander Tseung 2018-12-10 18:02:26 -08:00 committed by GitHub
parent 1fbdce8916
commit dde239797b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/scripts/platforms/extension.js
View File

@ -48,10 +48,13 @@ class ExtensionPlatform {
} }
showTransactionNotification (txMeta) { showTransactionNotification (txMeta) {
const { status, txReceipt: { status: receiptStatus } = {} } = txMeta
const status = txMeta.status
if (status === 'confirmed') { if (status === 'confirmed') {
this._showConfirmedTransaction(txMeta) // There was an on-chain failure
receiptStatus === '0x0'
? this._showFailedTransaction(txMeta, 'Transaction encountered an error.')
: this._showConfirmedTransaction(txMeta)
} else if (status === 'failed') { } else if (status === 'failed') {
this._showFailedTransaction(txMeta) this._showFailedTransaction(txMeta)
} }
@ -81,11 +84,11 @@ class ExtensionPlatform {
this._showNotification(title, message, url) this._showNotification(title, message, url)
} }
_showFailedTransaction (txMeta) { _showFailedTransaction (txMeta, errorMessage) {
const nonce = parseInt(txMeta.txParams.nonce, 16) const nonce = parseInt(txMeta.txParams.nonce, 16)
const title = 'Failed transaction' const title = 'Failed transaction'
const message = `Transaction ${nonce} failed! ${txMeta.err.message}` const message = `Transaction ${nonce} failed! ${errorMessage || txMeta.err.message}`
this._showNotification(title, message) this._showNotification(title, message)
} }