From da1aae772b64cd900bb411fe83d229b16cb3ef2a Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Fri, 11 Dec 2020 16:20:45 -0330 Subject: [PATCH] Remove coveralls (#10063) We don't look at coveralls very much. We might occasionally consult it to see a report on our code coverage, but that report is already generated entirely locally, and has been added to the MetaMask bot comment in #10061. --- .circleci/config.yml | 13 ------------- .gitignore | 1 - package.json | 2 -- yarn.lock | 23 +---------------------- 4 files changed, 1 insertion(+), 38 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index da1dbb654..37d10381a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -106,9 +106,6 @@ workflows: only: develop requires: - prep-build-storybook - - coveralls-upload: - requires: - - test-unit jobs: create_release_pull_request: @@ -496,13 +493,3 @@ jobs: - run: name: All Tests Passed command: echo 'weew - everything passed!' - - coveralls-upload: - executor: node-browsers - steps: - - checkout - - attach_workspace: - at: . - - run: - name: Coveralls upload - command: yarn test:coveralls-upload diff --git a/.gitignore b/.gitignore index 6d11965cb..46064a64b 100644 --- a/.gitignore +++ b/.gitignore @@ -41,7 +41,6 @@ ui/app/css/output/ notes.txt -.coveralls.yml .nyc_output .metamaskrc diff --git a/package.json b/package.json index 9f6b5a56a..540e0d262 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,6 @@ "test:coverage": "nyc --silent --check-coverage yarn test:unit:strict && nyc --silent --no-clean yarn test:unit:lax && nyc report --reporter=text --reporter=html", "test:coverage:strict": "nyc --check-coverage yarn test:unit:strict", "test:coverage:path": "nyc --check-coverage yarn test:unit:path", - "test:coveralls-upload": "if [ \"$COVERALLS_REPO_TOKEN\" ]; then nyc report --reporter=text-lcov | coveralls; fi", "ganache:start": "./development/run-ganache", "sentry:publish": "node ./development/sentry-publish.js", "lint": "prettier --check ./**/*.json && eslint . --ext js && yarn lint:styles", @@ -215,7 +214,6 @@ "chromedriver": "^79.0.0", "concurrently": "^5.2.0", "copy-webpack-plugin": "^6.0.3", - "coveralls": "^3.0.0", "cross-spawn": "^7.0.3", "css-loader": "^2.1.1", "del": "^3.0.0", diff --git a/yarn.lock b/yarn.lock index 81d6dbe6b..06950d7c6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7486,17 +7486,6 @@ cosmiconfig@^6.0.0: path-type "^4.0.0" yaml "^1.7.2" -coveralls@^3.0.0: - version "3.0.0" - resolved "https://registry.yarnpkg.com/coveralls/-/coveralls-3.0.0.tgz#22ef730330538080d29b8c151dc9146afde88a99" - integrity sha512-ZppXR9y5PraUOrf/DzHJY6gzNUhXYE3b9D43xEXs4QYZ7/Oe0Gy0CS+IPKWFfvQFXB3RG9QduaQUFehzSpGAFw== - dependencies: - js-yaml "^3.6.1" - lcov-parse "^0.0.10" - log-driver "^1.2.5" - minimist "^1.2.0" - request "^2.79.0" - cp-file@^7.0.0: version "7.0.0" resolved "https://registry.yarnpkg.com/cp-file/-/cp-file-7.0.0.tgz#b9454cfd07fe3b974ab9ea0e5f29655791a9b8cd" @@ -15111,7 +15100,7 @@ js-tokens@^3.0.2: resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b" integrity sha1-mGbfOVECEw449/mWvOtlRDIJwls= -js-yaml@3.13.1, js-yaml@^3.13.0, js-yaml@^3.13.1, js-yaml@^3.5.1, js-yaml@^3.6.1, js-yaml@^3.9.0: +js-yaml@3.13.1, js-yaml@^3.13.0, js-yaml@^3.13.1, js-yaml@^3.5.1, js-yaml@^3.9.0: version "3.13.1" resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.13.1.tgz#aff151b30bfdfa8e49e05da22e7415e9dfa37847" integrity sha512-YfbcO7jXDdyj0DGxYVSlSeQNHbD7XPWvrVWeVUujrQEoZzWJIRrCPoyk6kL6IAjAG2IolMK4T0hNUe0HOUs5Jw== @@ -15797,11 +15786,6 @@ lcid@^3.0.0: dependencies: invert-kv "^3.0.0" -lcov-parse@^0.0.10: - version "0.0.10" - resolved "https://registry.yarnpkg.com/lcov-parse/-/lcov-parse-0.0.10.tgz#1b0b8ff9ac9c7889250582b70b71315d9da6d9a3" - integrity sha1-GwuP+ayceIklBYK3C3ExXZ2m2aM= - lead@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/lead/-/lead-1.0.0.tgz#6f14f99a37be3a9dd784f5495690e5903466ee42" @@ -16759,11 +16743,6 @@ lodash@4.17.20, lodash@=3.10.1, lodash@^4.0.0, lodash@^4.0.1, lodash@^4.13.1, lo resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.20.tgz#b44a9b6297bcb698f1c51a3545a2b3b368d59c52" integrity sha512-PlhdFcillOINfeV7Ni6oF1TAEayyZBoZ8bcshTHqOYJYlrqzRK5hagpagky5o4HfCzzd1TRkXPMFq6cKk9rGmA== -log-driver@^1.2.5: - version "1.2.5" - resolved "https://registry.yarnpkg.com/log-driver/-/log-driver-1.2.5.tgz#7ae4ec257302fd790d557cb10c97100d857b0056" - integrity sha1-euTsJXMC/XkNVXyxDJcQDYV7AFY= - log-symbols@3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/log-symbols/-/log-symbols-3.0.0.tgz#f3a08516a5dea893336a7dee14d18a1cfdab77c4"