From d8a4b7fc9b6cdb2aacfab4f5f0d4a591611ef780 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Fri, 8 May 2020 21:49:41 -0300 Subject: [PATCH] Fix alert disabling type error (#8561) When disabling an alert, the background `alertEnabledness` state of the alert was being set to `undefined` instead of `false`. This didn't have any user-facing effect, since `undefined` is falsey, but it did result in a PropType error on the Alert settings page. This mistake was made in #8550. The `alertEnabledness` state is now correctly set to `false` instead of `undefined`. --- ui/app/ducks/alerts/unconnected-account.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/app/ducks/alerts/unconnected-account.js b/ui/app/ducks/alerts/unconnected-account.js index 8963c7160..9610d5080 100644 --- a/ui/app/ducks/alerts/unconnected-account.js +++ b/ui/app/ducks/alerts/unconnected-account.js @@ -94,7 +94,7 @@ export const dismissAndDisableAlert = () => { return async (dispatch) => { try { await dispatch(disableAlertRequested()) - await dispatch(setAlertEnabledness(name), false) + await dispatch(setAlertEnabledness(name, false)) await dispatch(disableAlertSucceeded()) } catch (error) { console.error(error)