From d882835cae5afeba2b72dea66ffb166a389c8229 Mon Sep 17 00:00:00 2001 From: Zachary Belford Date: Wed, 8 Jun 2022 14:21:53 -0700 Subject: [PATCH] Added PR feedback changes --- .../ui/update-nickname-popover/update-nickname-popover.js | 4 ++-- ui/pages/asset/components/asset-options.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/components/ui/update-nickname-popover/update-nickname-popover.js b/ui/components/ui/update-nickname-popover/update-nickname-popover.js index e63bc41fe..dc9804635 100644 --- a/ui/components/ui/update-nickname-popover/update-nickname-popover.js +++ b/ui/components/ui/update-nickname-popover/update-nickname-popover.js @@ -12,10 +12,10 @@ import Identicon from '../identicon/identicon.component'; import { getUseTokenDetection, getTokenList } from '../../../selectors'; export default function UpdateNicknamePopover({ - nickname, address, + nickname = '', + memo = '', onAdd, - memo, onClose, }) { const t = useContext(I18nContext); diff --git a/ui/pages/asset/components/asset-options.js b/ui/pages/asset/components/asset-options.js index f1ae4ec2f..4d7aef44f 100644 --- a/ui/pages/asset/components/asset-options.js +++ b/ui/pages/asset/components/asset-options.js @@ -85,7 +85,7 @@ const AssetOptions = ({ ); }; -const isntFunc = (p) => { +const isNotFunc = (p) => { return typeof p !== 'function'; }; @@ -95,14 +95,14 @@ AssetOptions.propTypes = { onClickBlockExplorer: PropTypes.func.isRequired, onViewAccountDetails: PropTypes.func.isRequired, onRemove: (props) => { - if (props.isNativeAsset === false && isntFunc(props.onRemove)) { + if (props.isNativeAsset === false && isNotFunc(props.onRemove)) { throw new Error( 'When isNativeAsset is true, onRemove is a required prop', ); } }, onViewTokenDetails: (props) => { - if (props.isNativeAsset === false && isntFunc(props.onViewTokenDetails)) { + if (props.isNativeAsset === false && isNotFunc(props.onViewTokenDetails)) { throw new Error( 'When isNativeAsset is true, onViewTokenDetails is a required prop', );