m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

ConfirmTxPage: rm redundant unapprovedTxs const (#19275)

Browse Source 
* fix typo: uncofirmedTransactions -> unconfirmedTransactions

* txHelper: reorganize lines and improve test

* ConfirmTx: rn unconfirmedTxs->unconfirmedTxsSorted

* ConfirmTx: rn unconfirmedMessages-> unconfirmedTxs

* ConfirmTxPage: rm redundant unapprovedTxs const

* lint: rm unused getUnapprovedTransactions
This commit is contained in:
Ariella Vu 2023-06-01 18:42:19 +02:00 committed by GitHub
parent ee9f7949f9
commit d5dd4fa881
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ui/pages/confirm-transaction/confirm-transaction.component.js
View File

@ -31,7 +31,6 @@ import {
import { isTokenMethodAction } from '../../helpers/utils/transactions.util'; import { isTokenMethodAction } from '../../helpers/utils/transactions.util';
import { usePrevious } from '../../hooks/usePrevious'; import { usePrevious } from '../../hooks/usePrevious';
import { import {
getUnapprovedTransactions,
unconfirmedTransactionsListSelector, unconfirmedTransactionsListSelector,
unconfirmedTransactionsHashSelector, unconfirmedTransactionsHashSelector,
} from '../../selectors'; } from '../../selectors';
@ -56,21 +55,18 @@ const ConfirmTransaction = () => {
const mostRecentOverviewPage = useSelector(getMostRecentOverviewPage); const mostRecentOverviewPage = useSelector(getMostRecentOverviewPage);
const sendTo = useSelector(getSendTo); const sendTo = useSelector(getSendTo);
const unapprovedTxs = useSelector(getUnapprovedTransactions);
const unconfirmedTxsSorted = useSelector(unconfirmedTransactionsListSelector); const unconfirmedTxsSorted = useSelector(unconfirmedTransactionsListSelector);
const unconfirmedTxs = useSelector(unconfirmedTransactionsHashSelector); const unconfirmedTxs = useSelector(unconfirmedTransactionsHashSelector);
const totalUnapproved = unconfirmedTxsSorted.length || 0; const totalUnapproved = unconfirmedTxsSorted.length || 0;
const getTransaction = useCallback(() => { const getTransaction = useCallback(() => {
return totalUnapproved return totalUnapproved
? unapprovedTxs[paramsTransactionId] || ? unconfirmedTxs[paramsTransactionId] || unconfirmedTxsSorted[0]
unconfirmedTxs[paramsTransactionId] ||
unconfirmedTxsSorted[0]
: {}; : {};
}, [ }, [
paramsTransactionId, paramsTransactionId,
totalUnapproved, totalUnapproved,
unapprovedTxs,
unconfirmedTxs, unconfirmedTxs,
unconfirmedTxsSorted, unconfirmedTxsSorted,
]); ]);
@ -87,7 +83,6 @@ const ConfirmTransaction = () => {
getTransaction, getTransaction,
paramsTransactionId, paramsTransactionId,
totalUnapproved, totalUnapproved,
unapprovedTxs,
unconfirmedTxs, unconfirmedTxs,
unconfirmedTxsSorted, unconfirmedTxsSorted,
]); ]);