m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix intermittent e2e test failure (#7873)

Browse Source 
The 'can retype the seed phrase' test would fail sometimes when one of
the words in the seed phrase was a subset of another word (e.g. 'issue'
and 'tissue'). This is because the selector used to find the word
looked for the first element that contained the text, rather than an
exact match.

To simplify the selector and make it more reliable, test ids were added
to each seed phrase word. The selector now uses CSS instead of XPath,
and it only finds exact matches.

A test id was also added to the div containing the shuffled seed words
to select from, so that the chosen seed words wouldn't be selected
in place of the real target when the same word appears twice.
This commit is contained in:
Mark Stacey 2020-01-21 11:31:56 -04:00 committed by GitHub
parent 6e49d0b5b5
commit d27f2ee7d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/e2e/address-book.spec.js
View File

@ -98,8 +98,7 @@ describe('MetaMask', function () {
})
async function clickWordAndWait (word) {
const xpath = `//div[contains(@class, 'confirm-seed-phrase__seed-word--shuffled') and not(contains(@class, 'confirm-seed-phrase__seed-word--selected')) and contains(text(), '${word}')]`
await driver.clickElement(By.xpath(xpath))
await driver.clickElement(By.css(`[data-testid="seed-phrase-shuffled"] [data-testid="draggable-seed-${word}"]`))
await driver.delay(tinyDelayMs)
}

3
test/e2e/incremental-security.spec.js
View File

@ -171,8 +171,7 @@ describe('MetaMask', function () {
})
async function clickWordAndWait (word) {
const xpath = `//div[contains(@class, 'confirm-seed-phrase__seed-word--shuffled') and not(contains(@class, 'confirm-seed-phrase__seed-word--selected')) and contains(text(), '${word}')]`
await driver.clickElement(By.xpath(xpath))
await driver.clickElement(By.css(`[data-testid="seed-phrase-shuffled"] [data-testid="draggable-seed-${word}"]`))
await driver.delay(tinyDelayMs)
}

3
test/e2e/metamask-responsive-ui.spec.js
View File

@ -93,8 +93,7 @@ describe('MetaMask', function () {
})
async function clickWordAndWait (word) {
const xpath = `//div[contains(@class, 'confirm-seed-phrase__seed-word--shuffled') and not(contains(@class, 'confirm-seed-phrase__seed-word--selected')) and contains(text(), '${word}')]`
await driver.clickElement(By.xpath(xpath))
await driver.clickElement(By.css(`[data-testid="seed-phrase-shuffled"] [data-testid="draggable-seed-${word}"]`))
await driver.delay(tinyDelayMs)
}

3
test/e2e/metamask-ui.spec.js
View File

@ -95,8 +95,7 @@ describe('MetaMask', function () {
})
async function clickWordAndWait (word) {
const xpath = `//div[contains(@class, 'confirm-seed-phrase__seed-word--shuffled') and not(contains(@class, 'confirm-seed-phrase__seed-word--selected')) and contains(text(), '${word}')]`
await driver.clickElement(By.xpath(xpath))
await driver.clickElement(By.css(`[data-testid="seed-phrase-shuffled"] [data-testid="draggable-seed-${word}"]`))
await driver.delay(tinyDelayMs)
}

2
ui/app/pages/first-time-flow/seed-phrase/confirm-seed-phrase/confirm-seed-phrase.component.js
View File

@ -163,7 +163,7 @@ export default class ConfirmSeedPhrase extends PureComponent {
{ this.renderPendingSeeds() }
{ this.renderSelectedSeeds() }
</div>
<div className="confirm-seed-phrase__shuffled-seed-words">
<div className="confirm-seed-phrase__shuffled-seed-words" data-testid="seed-phrase-shuffled">
{
shuffledSeedWords.map((word, index) => {
const isSelected = selectedSeedIndices.includes(index)

1
ui/app/pages/first-time-flow/seed-phrase/confirm-seed-phrase/draggable-seed.component.js
View File

@ -58,6 +58,7 @@ class DraggableSeed extends Component {
'confirm-seed-phrase__seed-word--drop-hover': isOver && canDrop,
})}
onClick={onClick}
data-testid={`draggable-seed-${selected ? 'selected-' : ''}${word}`}
>
{ word }
</div>