m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

transactions - insure if a to field in tx params has a truthy valu that it is a valid addres and if it is falsy that it is not null to fix issue #3509

Browse Source
This commit is contained in:
frankiebee 2018-03-13 15:13:05 -07:00
parent 303801d276
commit d195cfab50
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/scripts/lib/tx-gas-utils.js
View File

@ -4,7 +4,7 @@ const {
BnMultiplyByFraction, BnMultiplyByFraction,
bnToHex, bnToHex,
} = require('./util') } = require('./util')
const addHexPrefix = require('ethereumjs-util').addHexPrefix const {addHexPrefix, isValidAddress} = require('ethereumjs-util')
const SIMPLE_GAS_COST = '0x5208' // Hex for 21000, cost of a simple send. const SIMPLE_GAS_COST = '0x5208' // Hex for 21000, cost of a simple send.
/* /*
@ -101,6 +101,12 @@ module.exports = class TxGasUtil {
async validateTxParams (txParams) { async validateTxParams (txParams) {
this.validateRecipient(txParams) this.validateRecipient(txParams)
if ('to' in txParams) {
if ( txParams.to === null ) delete txParams.to
else if ( txParams.to !== undefined && !isValidAddress(txParams.to) ) {
throw new Error(`Invalid transaction value of ${txParams.to} not a valid to address.`)
}
}
if ('value' in txParams) { if ('value' in txParams) {
const value = txParams.value.toString() const value = txParams.value.toString()
if (value.includes('-')) { if (value.includes('-')) {